71783 2011-11-08 01:36:30 -0800 Web Inspector: Avoid automatic Console suggestions with empty expression 2011-11-08 04:22:39 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 497852 0 apavlov 2011-11-08 01:36:30 -0800 Enter ";" in the console - entire global scope suggestions will be displayed. 497854 1 114012 apavlov 2011-11-08 01:39:34 -0800 Created attachment 114012 Patch 497855 2 114012 pfeldman 2011-11-08 01:40:56 -0800 Comment on attachment 114012 Patch We should call the callback. 497858 3 114013 apavlov 2011-11-08 01:45:41 -0800 Created attachment 114013 Patch 497886 4 114013 yurys 2011-11-08 02:59:57 -0800 Comment on attachment 114013 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114013&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:368 > + completionsReadyCallback([]); Prefer early return. 497936 5 apavlov 2011-11-08 04:22:39 -0800 Committed r99548: <http://trac.webkit.org/changeset/99548> 114012 2011-11-08 01:39:34 -0800 2011-11-08 01:45:33 -0800 Patch bug-71783-20111108133932.patch text/plain 1627 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogOTk1MjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYjlmMjc3NjJiODIwYjU0 MTFlN2U0ZDMxYjk2NTkyNDc0OWViNTE5Li5jMDk3MWVmZDViMWIzYzMwMDRlNzMxYzYxYTE3OWUy NjNjMDY0YWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTEtMDggIEFsZXhh bmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBBdm9pZCBhdXRvbWF0aWMgQ29uc29sZSBzdWdnZXN0aW9ucyB3aXRoIGVtcHR5IGV4cHJl c3Npb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcx NzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorCiAyMDExLTExLTA3ICBEYW5pZWwg QmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBBZGQgQ3JlZGVudGlhbFN0b3JhZ2Uu Y3BwIHRvIFdlYkNvcmUvQ01ha2VMaXN0cy50eHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCmluZGV4IDc2YTY3ZGY0ZGU4M2ZiZTBlMzlk NjE2MzNlYjE4NTgzMWUxZTQ0YTUuLjZiNGI2NzNkZDM2NjQwNmRmMzRiN2Y5NzEwMmQxMzQxYjgy ZWVmYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29u c29sZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25z b2xlVmlldy5qcwpAQCAtMzYxLDggKzM2MSwxMCBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcu cHJvdG90eXBlID0gewogCiAgICAgICAgIGlmICghZXhwcmVzc2lvblN0cmluZyAmJiBXZWJJbnNw ZWN0b3IuZGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5wYXVzZWQpCiAgICAgICAgICAgICBXZWJJ bnNwZWN0b3IuZGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbC5nZXRTZWxlY3RlZENhbGxGcmFtZVZh cmlhYmxlcyhyZWNlaXZlZFByb3BlcnR5TmFtZXMuYmluZCh0aGlzKSk7Ci0gICAgICAgIGVsc2UK LSAgICAgICAgICAgIHRoaXMuZXZhbEluSW5zcGVjdGVkV2luZG93KGV4cHJlc3Npb25TdHJpbmcs ICJjb21wbGV0aW9uIiwgdHJ1ZSwgdHJ1ZSwgZmFsc2UsIGV2YWx1YXRlZC5iaW5kKHRoaXMpKTsK KyAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBpZiAocHJlZml4IHx8IGV4cHJlc3Npb25TdHJp bmcgfHwgZm9yY2UpCisgICAgICAgICAgICAgICAgdGhpcy5ldmFsSW5JbnNwZWN0ZWRXaW5kb3co ZXhwcmVzc2lvblN0cmluZywgImNvbXBsZXRpb24iLCB0cnVlLCB0cnVlLCBmYWxzZSwgZXZhbHVh dGVkLmJpbmQodGhpcykpOworICAgICAgICB9CiAKICAgICAgICAgZnVuY3Rpb24gZXZhbHVhdGVk KHJlc3VsdCwgd2FzVGhyb3duKQogICAgICAgICB7Cg== 114013 2011-11-08 01:45:41 -0800 2011-11-08 02:59:57 -0800 Patch bug-71783-20111108134539.patch text/plain 1948 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogOTk1MjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzYjlmMjc3NjJiODIwYjU0 MTFlN2U0ZDMxYjk2NTkyNDc0OWViNTE5Li5jMDk3MWVmZDViMWIzYzMwMDRlNzMxYzYxYTE3OWUy NjNjMDY0YWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTEtMDggIEFsZXhh bmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBBdm9pZCBhdXRvbWF0aWMgQ29uc29sZSBzdWdnZXN0aW9ucyB3aXRoIGVtcHR5IGV4cHJl c3Npb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcx NzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorCiAyMDExLTExLTA3ICBEYW5pZWwg QmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBBZGQgQ3JlZGVudGlhbFN0b3JhZ2Uu Y3BwIHRvIFdlYkNvcmUvQ01ha2VMaXN0cy50eHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCmluZGV4IDc2YTY3ZGY0ZGU4M2ZiZTBlMzlk NjE2MzNlYjE4NTgzMWUxZTQ0YTUuLjk3OTQ4ZmM0YTllMDdmZmM0Y2IxMmQ1M2YwZThiMjI1OWM5 OTYyZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29u c29sZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25z b2xlVmlldy5qcwpAQCAtMzU5LDEwICszNTksMTUgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCi0gICAgICAg IGlmICghZXhwcmVzc2lvblN0cmluZyAmJiBXZWJJbnNwZWN0b3IuZGVidWdnZXJQcmVzZW50YXRp b25Nb2RlbC5wYXVzZWQpCi0gICAgICAgICAgICBXZWJJbnNwZWN0b3IuZGVidWdnZXJQcmVzZW50 YXRpb25Nb2RlbC5nZXRTZWxlY3RlZENhbGxGcmFtZVZhcmlhYmxlcyhyZWNlaXZlZFByb3BlcnR5 TmFtZXMuYmluZCh0aGlzKSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIHRoaXMuZXZhbElu SW5zcGVjdGVkV2luZG93KGV4cHJlc3Npb25TdHJpbmcsICJjb21wbGV0aW9uIiwgdHJ1ZSwgdHJ1 ZSwgZmFsc2UsIGV2YWx1YXRlZC5iaW5kKHRoaXMpKTsKKyAgICAgICAgaWYgKHByZWZpeCB8fCBl eHByZXNzaW9uU3RyaW5nIHx8IGZvcmNlKSB7CisgICAgICAgICAgICBpZiAoIWV4cHJlc3Npb25T dHJpbmcgJiYgV2ViSW5zcGVjdG9yLmRlYnVnZ2VyUHJlc2VudGF0aW9uTW9kZWwucGF1c2VkKQor ICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsLmdl dFNlbGVjdGVkQ2FsbEZyYW1lVmFyaWFibGVzKHJlY2VpdmVkUHJvcGVydHlOYW1lcy5iaW5kKHRo aXMpKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICB0aGlzLmV2YWxJbkluc3Bl Y3RlZFdpbmRvdyhleHByZXNzaW9uU3RyaW5nLCAiY29tcGxldGlvbiIsIHRydWUsIHRydWUsIGZh bHNlLCBldmFsdWF0ZWQuYmluZCh0aGlzKSk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAg ICBjb21wbGV0aW9uc1JlYWR5Q2FsbGJhY2soW10pOworICAgICAgICAgICAgcmV0dXJuOworICAg ICAgICB9CiAKICAgICAgICAgZnVuY3Rpb24gZXZhbHVhdGVkKHJlc3VsdCwgd2FzVGhyb3duKQog ICAgICAgICB7Cg==