<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>71778</bug_id>
          
          <creation_ts>2011-11-08 00:50:25 -0800</creation_ts>
          <short_desc>[Qt] Incremental build is flakey on Windows</short_desc>
          <delta_ts>2011-11-14 04:50:54 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>71222</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Tor Arne Vestbø">vestbo</assigned_to>
          <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>497816</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-11-08 00:50:25 -0800</bug_when>
    <thetext>It seems fails are absolutely unrelated to commits. 

I think the dependency tree is broken in the Makefile, and 
we get flakey fails because of we build with make -j4.

fail1: (r99437-r99438)
make[3]: *** No rule to make target `compiler_cssvalues_make_all&apos;, needed by `first&apos;.  Stop.
make[2]: *** [sub-DerivedSources-pri] Error 2

fail2: (r99455)
make[3]: *** No rule to make target `compiler_inspectorValidate_make_all&apos;, needed by `first&apos;.  Stop.
make[2]: *** [sub-DerivedSources-pri] Error 2

fail3: (r99463)
make[3]: *** No rule to make target `compiler_cssvalues_make_all&apos;, needed by `first&apos;.  Stop.
make[3]: Entering directory `/ramdisk/qt-windows-32bit-release/build/WebKitBuild/Release/Source/WebCore&apos;
make[3]: Leaving directory `/ramdisk/qt-windows-32bit-release/build/WebKitBuild/Release/Source/WebCore&apos;
make[2]: *** [sub-DerivedSources-pri] Error 2

fail4: (r99465)
make[3]: *** No rule to make target `compiler_keywordlut_make_all&apos;, needed by `first&apos;.  Stop.
make[2]: *** [sub-DerivedSources-pri] Error 2

make[3]: *** No rule to make target `compiler_inspectorValidate_make_all&apos;, needed by `first&apos;.  Stop.
make[2]: *** [sub-DerivedSources-pri] Error 2

fail4: (r99515)
make[3]: *** No rule to make target `compiler_keywordlut_make_all&apos;, needed by `first&apos;.  Stop.
make[2]: *** [sub-DerivedSources-pri] Error 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497857</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-11-08 01:43:48 -0800</bug_when>
    <thetext>One more fail because of this bug: (r99540)

make[3]: *** No rule to make target `compiler_keywordlut_make_all&apos;, needed by make[2]: *** [sub-DerivedSources-pri] Error 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>499124</commentid>
    <comment_count>2</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2011-11-09 10:37:26 -0800</bug_when>
    <thetext>What&apos;s likely happening is that make qmake triggers qmake foo.pro -o Makefile.foo, and somehow make does not understand that it needs to wait for that to finish before parallelizing running make -f Makefile.foo

Clear case:

http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Debug/builds/29880/steps/compile-webkit/logs/stdio

In theory the makefile rules are set up so that make should be able to realize this, and it seems to work everywhere else, except on the mingw bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>500216</commentid>
    <comment_count>3</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2011-11-10 13:32:25 -0800</bug_when>
    <thetext>I know what the issue is now. The rules that were supposed to make &quot;qmake derived, make derived, qmake traget&quot; sequential was under an unix ifdef, as it depends on gnumake, but this obviously failed for mingw. I&apos;ll make a patch tomorrow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>501806</commentid>
    <comment_count>4</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2011-11-14 04:50:54 -0800</bug_when>
    <thetext>Fixed in r99949</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>