71769 2011-11-07 23:09:24 -0800 [WK][GTK] Application cache directory is incorrectly set 2011-11-08 09:36:24 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 zan webkit-unassigned mrobinson webkit.review.bot oldest_to_newest 497764 0 zan 2011-11-07 23:09:24 -0800 As discussed in bug #70680, the appcache directory should be located in user's local cache directory and not in WebKit's database directory. 497771 1 113998 zan 2011-11-07 23:27:09 -0800 Created attachment 113998 Patch Uses the same directory as in bug #70680 497798 2 zan 2011-11-08 00:17:16 -0800 (In reply to comment #1) > Created an attachment (id=113998) [details] > Patch > > Uses the same directory as in bug #70680 Just noted that with this change, documentation for webkit_application_cache_get_database_directory_path becomes invalid. That should be addressed as well. 497933 3 114037 zan 2011-11-08 04:14:46 -0800 Created attachment 114037 Patch Updated patch 498145 4 114037 webkit.review.bot 2011-11-08 09:36:19 -0800 Comment on attachment 114037 Patch Clearing flags on attachment: 114037 Committed r99578: <http://trac.webkit.org/changeset/99578> 498146 5 webkit.review.bot 2011-11-08 09:36:24 -0800 All reviewed patches have been landed. Closing bug. 113998 2011-11-07 23:27:09 -0800 2011-11-08 04:14:08 -0800 Patch bug-71769-20111108082706.patch text/plain 1943 zan U3VidmVyc2lvbiBSZXZpc2lvbjogOTk1MjMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBkNzZkMmYxNWU5 ZGU3MGU2NTFmZDBkYjUxMTliOGE5YzA1ZGMyNjQ4Li5lODIwMGI2OTc1YTNiOGVlYmFlYzNkZjBm YTc2MmZjNWYxY2RkMTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MTEtMDcgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBb V0tdW0dUS10gQXBwbGljYXRpb24gY2FjaGUgZGlyZWN0b3J5IGlzIGluY29ycmVjdGx5IHNldAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE3NjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgdGhlIGFw cGxpY2F0aW9uIGNhY2hlIGRpcmVjdG9yeSB0byBiZSBwbGFjZWQgaW4gY3VycmVudCB1c2VyJ3MK KyAgICAgICAgY2FjaGUgZGlyZWN0b3J5LgorCisgICAgICAgICogd2Via2l0L3dlYmtpdGdsb2Jh bHMuY3BwOgorICAgICAgICAod2Via2l0SW5pdCk6IEFsc28gc3dpdGNoIG9uZSBzdHJpbmcgZm9y bWF0aW9uIHRvIHVzZSBHT3duUHRyPGdjaGFyPi4KKwogMjAxMS0xMS0wMyAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIHJlbWFpbmluZyBjYWxsZXJzIG9m IHJlbGVhc2VSZWYgdG8gY2FsbCBsZWFrUmVmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay93ZWJraXQvd2Via2l0Z2xvYmFscy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0Z2xvYmFscy5jcHAKaW5kZXggNDM5YzIzY2Q5MmNhMjg2ODBmYmU5NWQ1MmZhOGU4OTdmN2I0 MzAwMi4uM2M4MWI0NWI0ODYwMzRmNzc5Mzc4YTcwOGQ2OTNjZDcxM2Q3MjNjOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGdsb2JhbHMuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRnbG9iYWxzLmNwcApAQCAtMzE2LDExICszMTYsMTEg QEAgdm9pZCB3ZWJraXRJbml0KCkKICAgICAvLyB0aGF0IG1heSBvbmx5IGJlIGRvbmUgYnkgdGhl IG1haW4gdGhyZWFkLgogICAgIGF0b21pY0Nhbm9uaWNhbFRleHRFbmNvZGluZ05hbWUoIlVURi04 Iik7CiAKLSAgICBnY2hhciogZGF0YWJhc2VEaXJlY3RvcnkgPSBnX2J1aWxkX2ZpbGVuYW1lKGdf Z2V0X3VzZXJfZGF0YV9kaXIoKSwgIndlYmtpdCIsICJkYXRhYmFzZXMiLCBOVUxMKTsKLSAgICB3 ZWJraXRfc2V0X3dlYl9kYXRhYmFzZV9kaXJlY3RvcnlfcGF0aChkYXRhYmFzZURpcmVjdG9yeSk7 Ci0gICAgV2ViQ29yZTo6Y2FjaGVTdG9yYWdlKCkuc2V0Q2FjaGVEaXJlY3RvcnkoZGF0YWJhc2VE aXJlY3RvcnkpOworICAgIEdPd25QdHI8Z2NoYXI+IGRhdGFiYXNlRGlyZWN0b3J5KGdfYnVpbGRf ZmlsZW5hbWUoZ19nZXRfdXNlcl9kYXRhX2RpcigpLCAid2Via2l0IiwgImRhdGFiYXNlcyIsIE5V TEwpKTsKKyAgICB3ZWJraXRfc2V0X3dlYl9kYXRhYmFzZV9kaXJlY3RvcnlfcGF0aChkYXRhYmFz ZURpcmVjdG9yeS5nZXQoKSk7CiAKLSAgICBnX2ZyZWUoZGF0YWJhc2VEaXJlY3RvcnkpOworICAg IEdPd25QdHI8Z2NoYXI+IGNhY2hlRGlyZWN0b3J5KGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfdXNl cl9jYWNoZV9kaXIoKSwgIndlYmtpdGd0ayIsICJhcHBsaWNhdGlvbnMiLCBOVUxMKSk7CisgICAg V2ViQ29yZTo6Y2FjaGVTdG9yYWdlKCkuc2V0Q2FjaGVEaXJlY3RvcnkoY2FjaGVEaXJlY3Rvcnku Z2V0KCkpOwogCiAgICAgUGFnZUdyb3VwOjpzZXRTaG91bGRUcmFja1Zpc2l0ZWRMaW5rcyh0cnVl KTsKIAo= 114037 2011-11-08 04:14:46 -0800 2011-11-08 09:36:19 -0800 Patch bug-71769-20111108131438.patch text/plain 3257 zan U3VidmVyc2lvbiBSZXZpc2lvbjogOTk1NDYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3Rr L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwppbmRleCBkNzZkMmYxNWU5 ZGU3MGU2NTFmZDBkYjUxMTliOGE5YzA1ZGMyNjQ4Li5lMGIzN2Y1ODFmNDU5YjAwZTU1ZmIyZmRj ZjAzMDllOWJhYzBkMTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEt MTEtMDggIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBb V0tdW0dUS10gQXBwbGljYXRpb24gY2FjaGUgZGlyZWN0b3J5IGlzIGluY29ycmVjdGx5IHNldAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE3NjkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgdGhlIGFw cGxpY2F0aW9uIGNhY2hlIGRpcmVjdG9yeSB0byBiZSBwbGFjZWQgaW4gY3VycmVudCB1c2VyJ3MK KyAgICAgICAgY2FjaGUgZGlyZWN0b3J5IGFuZCB1cGRhdGUgZG9jdW1lbnRhdGlvbiBmb3IKKyAg ICAgICAgd2Via2l0X2FwcGxpY2F0aW9uX2NhY2hlX2dldF9kYXRhYmFzZV9kaXJlY3RvcnlfcGF0 aCBhZnRlciB0aGVzZQorICAgICAgICBjaGFuZ2VzIGFuZCBjaGFuZ2VzIGluIHI4MDcxNTsKKwor ICAgICAgICAqIHdlYmtpdC93ZWJraXRhcHBsaWNhdGlvbmNhY2hlLmNwcDoKKyAgICAgICAgKiB3 ZWJraXQvd2Via2l0Z2xvYmFscy5jcHA6CisgICAgICAgICh3ZWJraXRJbml0KTogU3dpdGNoIG9u ZSBzdHJpbmcgZm9ybWF0aW9uIHRvIHVzZSBHT3duUHRyPGdjaGFyPi4KKwogMjAxMS0xMS0wMyAg RGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIHJlbWFpbmlu ZyBjYWxsZXJzIG9mIHJlbGVhc2VSZWYgdG8gY2FsbCBsZWFrUmVmCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0YXBwbGljYXRpb25jYWNoZS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0YXBwbGljYXRpb25jYWNoZS5jcHAKaW5kZXggYzIyZjdk ZDRhZmE5MmE3NmE5ODUxOTZlMDc1YzM2Mzc5NmM4NzMwMS4uNzAwMDk0NGMwMjc3ZWM3ZWI0N2Vm YTlkNzYxMDlmODIzYWFjZmYxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdGFwcGxpY2F0aW9uY2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXRhcHBsaWNhdGlvbmNhY2hlLmNwcApAQCAtNjUsMTMgKzY1LDEzIEBAIHZvaWQgd2Vi a2l0X2FwcGxpY2F0aW9uX2NhY2hlX3NldF9tYXhpbXVtX3NpemUodW5zaWduZWQgbG9uZyBsb25n IHNpemUpCiB9CiAKIC8qKgotICogd2Via2l0X3NwcGxpY2F0aW9uX2NhY2hlX2dldF9kYXRhYmFz ZV9kaXJlY3RvcnlfcGF0aDoKKyAqIHdlYmtpdF9hcHBsaWNhdGlvbl9jYWNoZV9nZXRfZGF0YWJh c2VfZGlyZWN0b3J5X3BhdGg6CiAgKgotICogUmV0dXJucyB0aGUgY3VycmVudCBwYXRoIHRvIHRo ZSBkaXJlY3RvcnkgV2ViS2l0IHdpbGwgd3JpdGUgd2ViIGFwcGxpY2F0aW9uCi0gKiBjYWNoZSBk YXRhYmFzZXMuIEJ5IGRlZmF1bHQgdGhpcyBwYXRoIGlzIHNldCB0byAkWERHX0RBVEFfSE9NRS93 ZWJraXQvZGF0YWJhc2VzCi0gKiB3aXRoIHdlYmtpdF9hcHBsaWNhdGlvbl9jYWNoZV9zZXRfZGF0 YWJhc2VfZGlyZWN0b3J5X3BhdGgKKyAqIFJldHVybnMgdGhlIHBhdGggdG8gdGhlIGRpcmVjdG9y eSBXZWJLaXQgd2lsbCB3cml0ZSB3ZWIgYXBwbGljYXRpb24KKyAqIGNhY2hlIGRhdGFiYXNlcyB0 by4gQnkgZGVmYXVsdCB0aGlzIHBhdGggaXMgc2V0IHRvCisgKiAkWERHX0NBQ0hFX0hPTUUvd2Vi a2l0Z3RrL2FwcGxpY2F0aW9ucyBhbmQgY2Fubm90IGJlIG1vZGlmaWVkLgogICoKLSAqIFJldHVy bnM6IHRoZSBjdXJyZW50IGFwcGxpY2F0aW9uIGNhY2hlIGRhdGFiYXNlIGRpcmVjdG9yeSBwYXRo CisgKiBSZXR1cm5zOiB0aGUgYXBwbGljYXRpb24gY2FjaGUgZGF0YWJhc2UgZGlyZWN0b3J5IHBh dGgKICAqCiAgKiBTaW5jZTogMS4zLjEzCiAgKiovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0Z2xvYmFscy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0Z2xvYmFscy5jcHAKaW5kZXggNDM5YzIzY2Q5MmNhMjg2ODBmYmU5NWQ1MmZhOGU4OTdm N2I0MzAwMi4uM2M4MWI0NWI0ODYwMzRmNzc5Mzc4YTcwOGQ2OTNjZDcxM2Q3MjNjOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdGdsb2JhbHMuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXRnbG9iYWxzLmNwcApAQCAtMzE2LDExICszMTYs MTEgQEAgdm9pZCB3ZWJraXRJbml0KCkKICAgICAvLyB0aGF0IG1heSBvbmx5IGJlIGRvbmUgYnkg dGhlIG1haW4gdGhyZWFkLgogICAgIGF0b21pY0Nhbm9uaWNhbFRleHRFbmNvZGluZ05hbWUoIlVU Ri04Iik7CiAKLSAgICBnY2hhciogZGF0YWJhc2VEaXJlY3RvcnkgPSBnX2J1aWxkX2ZpbGVuYW1l KGdfZ2V0X3VzZXJfZGF0YV9kaXIoKSwgIndlYmtpdCIsICJkYXRhYmFzZXMiLCBOVUxMKTsKLSAg ICB3ZWJraXRfc2V0X3dlYl9kYXRhYmFzZV9kaXJlY3RvcnlfcGF0aChkYXRhYmFzZURpcmVjdG9y eSk7Ci0gICAgV2ViQ29yZTo6Y2FjaGVTdG9yYWdlKCkuc2V0Q2FjaGVEaXJlY3RvcnkoZGF0YWJh c2VEaXJlY3RvcnkpOworICAgIEdPd25QdHI8Z2NoYXI+IGRhdGFiYXNlRGlyZWN0b3J5KGdfYnVp bGRfZmlsZW5hbWUoZ19nZXRfdXNlcl9kYXRhX2RpcigpLCAid2Via2l0IiwgImRhdGFiYXNlcyIs IE5VTEwpKTsKKyAgICB3ZWJraXRfc2V0X3dlYl9kYXRhYmFzZV9kaXJlY3RvcnlfcGF0aChkYXRh YmFzZURpcmVjdG9yeS5nZXQoKSk7CiAKLSAgICBnX2ZyZWUoZGF0YWJhc2VEaXJlY3RvcnkpOwor ICAgIEdPd25QdHI8Z2NoYXI+IGNhY2hlRGlyZWN0b3J5KGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRf dXNlcl9jYWNoZV9kaXIoKSwgIndlYmtpdGd0ayIsICJhcHBsaWNhdGlvbnMiLCBOVUxMKSk7Cisg ICAgV2ViQ29yZTo6Y2FjaGVTdG9yYWdlKCkuc2V0Q2FjaGVEaXJlY3RvcnkoY2FjaGVEaXJlY3Rv cnkuZ2V0KCkpOwogCiAgICAgUGFnZUdyb3VwOjpzZXRTaG91bGRUcmFja1Zpc2l0ZWRMaW5rcyh0 cnVlKTsKIAo=