71767 2011-11-07 22:34:13 -0800 [GTK][EFL] NWRT should check that Xvfb is installed 2013-01-17 02:00:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED NRWT P2 Normal --- 0 vanuan zan abarth dpranke eric mrobinson rakuco webkit.review.bot zan oldest_to_newest 497749 0 vanuan 2011-11-07 22:34:13 -0800 NRWT is crashing when xvfb is not installed: AttributeError: GtkDriver instance has no attribute '_server_process' worker/0 raised OSError('[Errno 2] No such file or directory'): Full traceback: http://pastebin.com/B5pE8AJg Giving a warning to check if all dependencies is installed instead of crashing with exception would be great. 684851 1 dpranke 2012-08-01 18:30:50 -0700 This is the point of the Port.check_sys_deps() method. Sounds like Gtk and EFL should be overriding this to look for Xvfb? Updating subject accordingly ... 694179 2 rakuco 2012-08-13 15:45:12 -0700 The EFL port doesn't use Xvfb, rewording the title to make it GTK-only. 808220 3 zan 2013-01-16 03:01:47 -0800 (In reply to comment #2) > The EFL port doesn't use Xvfb, rewording the title to make it GTK-only. It does now. 808227 4 182951 zan 2013-01-16 03:09:38 -0800 Created attachment 182951 Patch 809199 5 182951 zan 2013-01-17 02:00:13 -0800 Comment on attachment 182951 Patch Clearing flags on attachment: 182951 Committed r139973: <http://trac.webkit.org/changeset/139973> 809200 6 zan 2013-01-17 02:00:19 -0800 All reviewed patches have been landed. Closing bug. 182951 2013-01-16 03:09:38 -0800 2013-01-17 02:00:13 -0800 Patch bug-71767-20130116120640.patch text/plain 3640 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM5ODUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzU5OGM1MWM4Y2IyMTk4ZmI1M2RjYWMxODVlYWUzMmJh YzQ2YjllMi4uNmUyYTY4ZGYxMGI2ZTkxNGZmNzQ2YjU2NGUyZWYxM2IwYTA2NTkxZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDEzLTAxLTE2ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbR1RLXVtFRkxdIE5XUlQgc2hvdWxkIGNoZWNrIHRoYXQgWHZmYiBpcyBpbnN0YWxs ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNzY3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRUZMIGFu ZCBHVEsgcG9ydHMgbm93IGNoZWNrIHRoYXQgWHZmYiBpcyBpbnN0YWxsZWQgYmVmb3JlIHJ1bm5p bmcKKyAgICAgICAgbGF5b3V0IHRlc3RzLiBUaGUgY29tbWFuZCBsaW5lIHVzZWQgdG8gY2hlY2sg d2hldGhlciBYdmZiIGlzIHByZXNlbnQKKyAgICAgICAgaXMgYSBzaW1wbGUgYHdoaWNoIFh2ZmJg IHRoYXQgc2hvdWxkIHJldHVybiAwIGFzIHRoZSBleGl0IGNvZGUgdXBvbgorICAgICAgICBzdWNj ZXNzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9lZmwu cHk6CisgICAgICAgIChFZmxQb3J0LnNob3dfcmVzdWx0c19odG1sX2ZpbGUpOgorICAgICAgICAo RWZsUG9ydCk6CisgICAgICAgIChFZmxQb3J0LmNoZWNrX3N5c19kZXBzKToKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2d0ay5weToKKyAgICAgICAgKEd0a1Bv cnQuY2hlY2tfc3lzX2RlcHMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQveHZmYmRyaXZlci5weToKKyAgICAgICAgKFh2ZmJEcml2ZXIpOgorICAgICAgICAo WHZmYkRyaXZlci5jaGVja194dmZiKToKKwogMjAxMy0wMS0xNiAgSm9jaGVuIEVpc2luZ2VyICA8 am9jaGVuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIGFkZCB0aXRsZSB0ZXh0 IGRpcmVjdGlvbiBhdHRyaWJ1dGUgdG8gVGVzdFJ1bm5lcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9lZmwucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weQppbmRleCBkZjU2Mzg0NDY2ODRlOGFmMWUy YjIzZTRkODc0NzZiZjExNmU0YzgxLi5mODY3M2NhNGUxZTAxMTlmM2NjYzE2M2Q2ZjJhY2IyOTRl MmFlOTkyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2VmbC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2VmbC5weQpAQCAtMTI1LDMgKzEyNSw2IEBAIGNsYXNzIEVmbFBvcnQoUG9ydCk6CiAgICAgICAg ICMgRklYTUU6IG9sZC1ydW4td2Via2l0LXRlc3RzIGFsc28gYWRkZWQgWyItZ3JhcGhpY3NzeXN0 ZW0iLCAicmFzdGVyIiwgIi1zdHlsZSIsICJ3aW5kb3dzIl0KICAgICAgICAgIyBGSVhNRTogb2xk LXJ1bi13ZWJraXQtdGVzdHMgY29udmVydGVkIHJlc3VsdHNfZmlsZW5hbWUgcGF0aCBmb3IgY3ln d2luLgogICAgICAgICBzZWxmLl9ydW5fc2NyaXB0KCJydW4tbGF1bmNoZXIiLCBydW5fbGF1bmNo ZXJfYXJncykKKworICAgIGRlZiBjaGVja19zeXNfZGVwcyhzZWxmLCBuZWVkc19odHRwKToKKyAg ICAgICAgcmV0dXJuIHN1cGVyKEVmbFBvcnQsIHNlbGYpLmNoZWNrX3N5c19kZXBzKG5lZWRzX2h0 dHApIGFuZCBYdmZiRHJpdmVyLmNoZWNrX3h2ZmIoc2VsZikKZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKaW5kZXggMGRhNWUyZGQyNTU5ZTg3ODQy NjA1NWZjZTk3Y2QxMGIxYWUxZjU3OS4uZGU2YmVkNTY4ZTcxMzFkY2U2YzhiN2RiNTZlOGVhOWM2 NTI2MTZhZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9ndGsucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9ndGsucHkKQEAgLTEyNCw2ICsxMjQsOSBAQCBjbGFzcyBHdGtQb3J0KFBvcnQpOgogICAgICAg ICAjIEZJWE1FOiBvbGQtcnVuLXdlYmtpdC10ZXN0cyBjb252ZXJ0ZWQgcmVzdWx0c19maWxlbmFt ZSBwYXRoIGZvciBjeWd3aW4uCiAgICAgICAgIHNlbGYuX3J1bl9zY3JpcHQoInJ1bi1sYXVuY2hl ciIsIHJ1bl9sYXVuY2hlcl9hcmdzKQogCisgICAgZGVmIGNoZWNrX3N5c19kZXBzKHNlbGYsIG5l ZWRzX2h0dHApOgorICAgICAgICByZXR1cm4gc3VwZXIoR3RrUG9ydCwgc2VsZikuY2hlY2tfc3lz X2RlcHMobmVlZHNfaHR0cCkgYW5kIFh2ZmJEcml2ZXIuY2hlY2tfeHZmYihzZWxmKQorCiAgICAg ZGVmIF9nZXRfZ2RiX291dHB1dChzZWxmLCBjb3JlZHVtcF9wYXRoKToKICAgICAgICAgY21kID0g WydnZGInLCAnLWV4JywgJ3RocmVhZCBhcHBseSBhbGwgYnQgMTAyNCcsICctLWJhdGNoJywgc3Ry KHNlbGYuX3BhdGhfdG9fZHJpdmVyKCkpLCBjb3JlZHVtcF9wYXRoXQogICAgICAgICBwcm9jID0g c3VicHJvY2Vzcy5Qb3BlbihjbWQsIHN0ZGluPU5vbmUsIHN0ZG91dD1zdWJwcm9jZXNzLlBJUEUs IHN0ZGVycj1zdWJwcm9jZXNzLlBJUEUpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3h2ZmJkcml2ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L3h2ZmJkcml2ZXIucHkKaW5kZXggYjFhNzQ1MDE0ZGMzZTQz NzJhZTUwY2IzYmYzY2NkNzZlYzk1NDMwOC4uNzFlYThkZGI4NjI2YzI3NDUzODhlNWQ5MDAxNjM3 YjUwMGVmMjI0NSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC94dmZiZHJpdmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQveHZmYmRyaXZlci5weQpAQCAtMzksNiArMzksMTMgQEAgX2xvZyA9IGxvZ2dp bmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQogCiAKIGNsYXNzIFh2ZmJEcml2ZXIoRHJpdmVyKToKKyAg ICBAc3RhdGljbWV0aG9kCisgICAgZGVmIGNoZWNrX3h2ZmIocG9ydCk6CisgICAgICAgIHh2ZmJf Zm91bmQgPSBwb3J0Lmhvc3QuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsnd2hpY2gnLCAnWHZmYidd LCByZXR1cm5fZXhpdF9jb2RlPVRydWUpIGlzIDAKKyAgICAgICAgaWYgbm90IHh2ZmJfZm91bmQ6 CisgICAgICAgICAgICBfbG9nLmVycm9yKCJObyBYdmZiIGZvdW5kLiBDYW5ub3QgcnVuIGxheW91 dCB0ZXN0cy4iKQorICAgICAgICByZXR1cm4geHZmYl9mb3VuZAorCiAgICAgZGVmIF9faW5pdF9f KHNlbGYsICphcmdzLCAqKmt3YXJncyk6CiAgICAgICAgIERyaXZlci5fX2luaXRfXyhzZWxmLCAq YXJncywgKiprd2FyZ3MpCiAgICAgICAgIHNlbGYuX2d1YXJkX2xvY2sgPSBOb25lCg==