71762 2011-11-07 21:29:49 -0800 Fix gcc 4.4 compilation warnings in DFG 32_64 2011-11-07 22:52:04 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71686 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 497716 0 yuqiang.xian 2011-11-07 21:29:49 -0800 gcc 4.4 on Linux will complain "comparison always false due to limited range of data type" for a function (registersMatched) in DFG, as in one file the call to this function always has the second parameter as "InvalidGPRReg". Patch forthcoming. 497719 1 113984 yuqiang.xian 2011-11-07 21:33:28 -0800 Created attachment 113984 the patch 497758 2 113984 webkit.review.bot 2011-11-07 22:52:00 -0800 Comment on attachment 113984 the patch Clearing flags on attachment: 113984 Committed r99525: <http://trac.webkit.org/changeset/99525> 497759 3 webkit.review.bot 2011-11-07 22:52:04 -0800 All reviewed patches have been landed. Closing bug. 113984 2011-11-07 21:33:28 -0800 2011-11-07 22:52:00 -0800 the patch 71762.patch text/plain 2195 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTk1MTgpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMTEtMDcgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgRml4IGdjYyA0LjQgY29tcGlsYXRpb24gd2FybmluZ3MgaW4gREZHIDMyXzY0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTc2MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0pJVENv ZGVHZW5lcmF0b3IuaDoKKyAgICAgICAgKEpTQzo6REZHOjpKSVRDb2RlR2VuZXJhdG9yOjpyZWdp c3RlcnNNYXRjaGVkKToKKwogMjAxMS0xMS0wNyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUu Y29tPgogCiAgICAgICAgIFN3aXRjaCBiYWNrIHRvIDErMSB2YWx1ZSBwcm9maWxpbmcgYnVja2V0 cywgc2luY2UgaXQgZGlkbid0IGhlbHAgb24gYXJld2VmYXN0eWV0LApJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9yLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9yLmgJKHJldmlzaW9uIDk5 NTE4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb2RlR2VuZXJhdG9yLmgJ KHdvcmtpbmcgY29weSkKQEAgLTI2OCw3ICsyNjgsMTggQEAgcHJvdGVjdGVkOgogICAgICAgICBB U1NFUlQoaW5mby5yZWdpc3RlckZvcm1hdCgpICE9IERhdGFGb3JtYXROb25lKTsKICAgICAgICAg QVNTRVJUKGluZm8ucmVnaXN0ZXJGb3JtYXQoKSAhPSBEYXRhRm9ybWF0RG91YmxlKTsKICAgICAg ICAgQVNTRVJUKGluZm8ucmVnaXN0ZXJGb3JtYXQoKSAhPSBEYXRhRm9ybWF0SlNEb3VibGUpOwot ICAgICAgICByZXR1cm4gIShpbmZvLnJlZ2lzdGVyRm9ybWF0KCkgJiBEYXRhRm9ybWF0SlMpID8g KGluZm8uZ3ByKCkgPT0gZXhjbHVkZSB8fCBpbmZvLmdwcigpID09IGV4Y2x1ZGUyKSA6ICAoaW5m by50YWdHUFIoKSA9PSBleGNsdWRlIHx8IGluZm8udGFnR1BSKCkgPT0gZXhjbHVkZTIgfHwgaW5m by5wYXlsb2FkR1BSKCkgPT0gZXhjbHVkZSB8fCBpbmZvLnBheWxvYWRHUFIoKSA9PSBleGNsdWRl Mik7CisKKyAgICAgICAgaWYgKGV4Y2x1ZGUgPT0gSW52YWxpZEdQUlJlZyAmJiBleGNsdWRlMiA9 PSBJbnZhbGlkR1BSUmVnKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgIGJv b2wgbWF0Y2hlZCA9IGZhbHNlOworICAgICAgICBpZiAoZXhjbHVkZTIgPT0gSW52YWxpZEdQUlJl ZykKKyAgICAgICAgICAgIG1hdGNoZWQgPSAoIShpbmZvLnJlZ2lzdGVyRm9ybWF0KCkgJiBEYXRh Rm9ybWF0SlMpKSA/IChpbmZvLmdwcigpID09IGV4Y2x1ZGUpIDogIChpbmZvLnRhZ0dQUigpID09 IGV4Y2x1ZGUgfHwgaW5mby5wYXlsb2FkR1BSKCkgPT0gZXhjbHVkZSk7CisgICAgICAgIGVsc2Ug aWYgKGV4Y2x1ZGUgPT0gSW52YWxpZEdQUlJlZykKKyAgICAgICAgICAgIG1hdGNoZWQgPSAoIShp bmZvLnJlZ2lzdGVyRm9ybWF0KCkgJiBEYXRhRm9ybWF0SlMpKSA/IChpbmZvLmdwcigpID09IGV4 Y2x1ZGUyKSA6ICAoaW5mby50YWdHUFIoKSA9PSBleGNsdWRlMiB8fCBpbmZvLnBheWxvYWRHUFIo KSA9PSBleGNsdWRlMik7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIG1hdGNoZWQgPSAoIShp bmZvLnJlZ2lzdGVyRm9ybWF0KCkgJiBEYXRhRm9ybWF0SlMpKSA/IChpbmZvLmdwcigpID09IGV4 Y2x1ZGUgfHwgaW5mby5ncHIoKSA9PSBleGNsdWRlMikgOiAgKGluZm8udGFnR1BSKCkgPT0gZXhj bHVkZSB8fCBpbmZvLnRhZ0dQUigpID09IGV4Y2x1ZGUyIHx8IGluZm8ucGF5bG9hZEdQUigpID09 IGV4Y2x1ZGUgfHwgaW5mby5wYXlsb2FkR1BSKCkgPT0gZXhjbHVkZTIpOworICAgICAgICByZXR1 cm4gbWF0Y2hlZDsKICAgICB9CiAjZW5kaWYKIAo=