71759 2011-11-07 18:57:38 -0800 [Qt] Removing qwebkitglobal.h inclusion from qwebkitplatformplugin.h 2011-11-08 01:01:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 1 luiz luiz hausmann webkit.review.bot oldest_to_newest 497673 0 luiz 2011-11-07 18:57:38 -0800 This inclusion is wrong because it forces the plugins to depend on qwebkitglobal.h. The inclusion does not seem to be needed anyway. The of qwebkitplatformplugin.h copy that is inside the examples directory is pretty old and will be updated as well. 497680 1 113977 luiz 2011-11-07 19:05:53 -0800 Created attachment 113977 patch 497792 2 113977 hausmann 2011-11-07 23:52:40 -0800 Comment on attachment 113977 patch Thanks :) 497828 3 113977 webkit.review.bot 2011-11-08 01:01:54 -0800 Comment on attachment 113977 patch Clearing flags on attachment: 113977 Committed r99535: <http://trac.webkit.org/changeset/99535> 497829 4 webkit.review.bot 2011-11-08 01:01:59 -0800 All reviewed patches have been landed. Closing bug. 113977 2011-11-07 19:05:53 -0800 2011-11-08 01:01:54 -0800 patch 0001-Qt-Removing-qwebkitglobal.h-inclusion-from-qwebkitpl.patch text/plain 6254 luiz RnJvbSBjMDVhNjc0NTZlNTliODI2MWUzYTJiZmRiMWQyMGM5ODE4MDkwZTliIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQHBhbG0uY29t PgpEYXRlOiBNb24sIDcgTm92IDIwMTEgMTk6MDQ6MjcgLTA4MDAKU3ViamVjdDogW1BBVENIXSBb UXRdIFJlbW92aW5nIHF3ZWJraXRnbG9iYWwuaCBpbmNsdXNpb24gZnJvbQogcXdlYmtpdHBsYXRm b3JtcGx1Z2luLmgKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTc1 OQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpxd2Via2l0cGxhdGZvcm1wbHVnaW4uaCBt dXN0IG5vdCBkZXBlbmQgb24gcXdlYmtpdGdsb2JhbC5oLgoKKiBBcGkvcXdlYmtpdHBsYXRmb3Jt cGx1Z2luLmg6CgpVcGRhdGluZyB0aGUgY29weSBvZiBxd2Via2l0cGxhdGZvcm1wbHVnaW4uaCB0 aGF0IGlzIHVzZWQgYnkgdGhlIGV4YW1wbGUgcGx1Z2luLiBUaGUgcHJldmlvdXMKb25lIHdhcyB2 ZXJ5IG91dGRhdGVkLgoKKiBleGFtcGxlcy9wbGF0Zm9ybXBsdWdpbi9xd2Via2l0cGxhdGZvcm1w bHVnaW4uaDoKLS0tCiBTb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4u aCAgICAgICB8ICAgIDQgKy0KIFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxNiArKysrKwogLi4uL3BsYXRmb3JtcGx1Z2luL3F3ZWJraXRwbGF0 Zm9ybXBsdWdpbi5oICAgICAgICAgfCAgIDYxICsrKysrKysrKysrKystLS0tLS0KIDMgZmlsZXMg Y2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9xdC9BcGkvcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmggYi9Tb3VyY2UvV2Vi S2l0L3F0L0FwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaAppbmRleCBjZjJlYzRhLi41MzdmNWMw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4u aAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaApAQCAt MjEsOCArMjEsNiBAQAogI2lmbmRlZiBRV0VCS0lUUExBVEZPUk1QTFVHSU5fSAogI2RlZmluZSBR V0VCS0lUUExBVEZPUk1QTFVHSU5fSAogCi0jaW5jbHVkZSAicXdlYmtpdGdsb2JhbC5oIgotCiAv KgogICogIFdhcm5pbmc6IFRoZSBjb250ZW50cyBvZiB0aGlzIGZpbGUgaXMgbm90ICBwYXJ0IG9m IHRoZSBwdWJsaWMgUXRXZWJLaXQgQVBJCiAgKiAgYW5kIG1heSBiZSBjaGFuZ2VkIGZyb20gdmVy c2lvbiB0byB2ZXJzaW9uIG9yIGV2ZW4gYmUgY29tcGxldGVseSByZW1vdmVkLgpAQCAtMTM2LDcg KzEzNCw3IEBAIHB1YmxpYyBRX1NMT1RTOgogfTsKICNlbmRpZgogCi1jbGFzcyBRV0VCS0lUX0VY UE9SVCBRV2ViU3BlbGxDaGVja2VyIDogcHVibGljIFFPYmplY3QgeworY2xhc3MgUVdlYlNwZWxs Q2hlY2tlciA6IHB1YmxpYyBRT2JqZWN0IHsKICAgICBRX09CSkVDVAogcHVibGljOgogICAgIHN0 cnVjdCBHcmFtbWFyRGV0YWlsIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggNzMyMTA0Ni4uNWY0MzllZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0xMS0wNyAgTHVpeiBBZ29zdGlu aSAgPGx1aXouYWdvc3RpbmlAcGFsbS5jb20+CisKKyAgICAgICAgW1F0XSBSZW1vdmluZyBxd2Vi a2l0Z2xvYmFsLmggaW5jbHVzaW9uIGZyb20gcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNzU5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcXdlYmtpdHBsYXRmb3Jt cGx1Z2luLmggbXVzdCBub3QgZGVwZW5kIG9uIHF3ZWJraXRnbG9iYWwuaC4KKworICAgICAgICAq IEFwaS9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaDoKKworICAgICAgICBVcGRhdGluZyB0aGUgY29w eSBvZiBxd2Via2l0cGxhdGZvcm1wbHVnaW4uaCB0aGF0IGlzIHVzZWQgYnkgdGhlIGV4YW1wbGUg cGx1Z2luLiBUaGUgcHJldmlvdXMKKyAgICAgICAgb25lIHdhcyB2ZXJ5IG91dGRhdGVkLgorCisg ICAgICAgICogZXhhbXBsZXMvcGxhdGZvcm1wbHVnaW4vcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmg6 CisKIDIwMTEtMTEtMDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBNb3ZlIERvbWFpblJlbGF4YXRpb25Gb3JiaWRkZW4gc2NoZW1lIHJlZ2lzdHJ5IHRvIFNjaGVt ZVJlZ2lzdHJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L2V4YW1wbGVzL3BsYXRmb3Jt cGx1Z2luL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5oIGIvU291cmNlL1dlYktpdC9xdC9leGFtcGxl cy9wbGF0Zm9ybXBsdWdpbi9xd2Via2l0cGxhdGZvcm1wbHVnaW4uaAppbmRleCA3YTc2ZmU3Li41 MzdmNWMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L2V4YW1wbGVzL3BsYXRmb3JtcGx1 Z2luL3F3ZWJraXRwbGF0Zm9ybXBsdWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvZXhhbXBs ZXMvcGxhdGZvcm1wbHVnaW4vcXdlYmtpdHBsYXRmb3JtcGx1Z2luLmgKQEAgLTI2LDE0ICsyNiwx NCBAQAogICogIGFuZCBtYXkgYmUgY2hhbmdlZCBmcm9tIHZlcnNpb24gdG8gdmVyc2lvbiBvciBl dmVuIGJlIGNvbXBsZXRlbHkgcmVtb3ZlZC4KICovCiAKLSNpbmNsdWRlIDxRT2JqZWN0PgotI2lu Y2x1ZGUgPFFVcmw+CiAjaWYgZGVmaW5lZChXVEZfVVNFX1FUX01VTFRJTUVESUEpICYmIFdURl9V U0VfUVRfTVVMVElNRURJQQogI2luY2x1ZGUgPFFNZWRpYVBsYXllcj4KICNlbmRpZgorI2luY2x1 ZGUgPFF0Q29yZS9RT2JqZWN0PgorI2luY2x1ZGUgPFF0Q29yZS9RVXJsPgorI2luY2x1ZGUgPFF0 R3VpL1FDb2xvcj4KIAotY2xhc3MgUVdlYlNlbGVjdERhdGEKLXsKK2NsYXNzIFFXZWJTZWxlY3RE YXRhIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5RV2ViU2VsZWN0RGF0YSgpIHt9CiAKQEAgLTQ2 LDEwICs0NiwxMyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGl0ZW1Jc1NlbGVjdGVkKGlu dCBpbmRleCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgaW50IGl0ZW1Db3VudCgpIGNvbnN0ID0g MDsKICAgICB2aXJ0dWFsIGJvb2wgbXVsdGlwbGUoKSBjb25zdCA9IDA7CisgICAgdmlydHVhbCBR Q29sb3IgYmFja2dyb3VuZENvbG9yKCkgY29uc3QgPSAwOworICAgIHZpcnR1YWwgUUNvbG9yIGZv cmVncm91bmRDb2xvcigpIGNvbnN0ID0gMDsKKyAgICB2aXJ0dWFsIFFDb2xvciBpdGVtQmFja2dy b3VuZENvbG9yKGludCBpbmRleCkgY29uc3QgPSAwOworICAgIHZpcnR1YWwgUUNvbG9yIGl0ZW1G b3JlZ3JvdW5kQ29sb3IoaW50IGluZGV4KSBjb25zdCA9IDA7CiB9OwogCi1jbGFzcyBRV2ViU2Vs ZWN0TWV0aG9kIDogcHVibGljIFFPYmplY3QKLXsKK2NsYXNzIFFXZWJTZWxlY3RNZXRob2QgOiBw dWJsaWMgUU9iamVjdCB7CiAgICAgUV9PQkpFQ1QKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5RV2Vi U2VsZWN0TWV0aG9kKCkge30KQEAgLTYyLDggKzY1LDcgQEAgUV9TSUdOQUxTOgogICAgIHZvaWQg ZGlkSGlkZSgpOwogfTsKIAotY2xhc3MgUVdlYk5vdGlmaWNhdGlvbkRhdGEKLXsKK2NsYXNzIFFX ZWJOb3RpZmljYXRpb25EYXRhIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5RV2ViTm90aWZpY2F0 aW9uRGF0YSgpIHt9CiAKQEAgLTczLDggKzc1LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgY29u c3QgUVVybCBvcGVuZXJQYWdlVXJsKCkgY29uc3QgPSAwOwogfTsKIAotY2xhc3MgUVdlYk5vdGlm aWNhdGlvblByZXNlbnRlciA6IHB1YmxpYyBRT2JqZWN0Ci17CitjbGFzcyBRV2ViTm90aWZpY2F0 aW9uUHJlc2VudGVyIDogcHVibGljIFFPYmplY3QgewogICAgIFFfT0JKRUNUCiBwdWJsaWM6CiAg ICAgUVdlYk5vdGlmaWNhdGlvblByZXNlbnRlcigpIHt9CkBAIC04Nyw4ICs4OCw3IEBAIFFfU0lH TkFMUzoKICAgICB2b2lkIG5vdGlmaWNhdGlvbkNsaWNrZWQoKTsKIH07CiAKLWNsYXNzIFFXZWJI YXB0aWNGZWVkYmFja1BsYXllcjogcHVibGljIFFPYmplY3QKLXsKK2NsYXNzIFFXZWJIYXB0aWNG ZWVkYmFja1BsYXllcjogcHVibGljIFFPYmplY3QgewogICAgIFFfT0JKRUNUCiBwdWJsaWM6CiAg ICAgUVdlYkhhcHRpY0ZlZWRiYWNrUGxheWVyKCkge30KQEAgLTEwNSw4ICsxMDUsNyBAQCBwdWJs aWM6CiAgICAgdmlydHVhbCB2b2lkIHBsYXlIYXB0aWNGZWVkYmFjayhjb25zdCBIYXB0aWNFdmVu dCwgY29uc3QgUVN0cmluZyYgaGFwdGljVHlwZSwgY29uc3QgSGFwdGljU3RyZW5ndGgpID0gMDsK IH07CiAKLWNsYXNzIFFXZWJUb3VjaE1vZGlmaWVyIDogcHVibGljIFFPYmplY3QKLXsKK2NsYXNz IFFXZWJUb3VjaE1vZGlmaWVyIDogcHVibGljIFFPYmplY3QgewogICAgIFFfT0JKRUNUCiBwdWJs aWM6CiAgICAgdmlydHVhbCB+UVdlYlRvdWNoTW9kaWZpZXIoKSB7fQpAQCAtMTM1LDggKzEzNCwz MSBAQCBwdWJsaWMgUV9TTE9UUzoKIH07CiAjZW5kaWYKIAotY2xhc3MgUVdlYktpdFBsYXRmb3Jt UGx1Z2luCi17CitjbGFzcyBRV2ViU3BlbGxDaGVja2VyIDogcHVibGljIFFPYmplY3QgeworICAg IFFfT0JKRUNUCitwdWJsaWM6CisgICAgc3RydWN0IEdyYW1tYXJEZXRhaWwgeworICAgICAgICBp bnQgbG9jYXRpb247CisgICAgICAgIGludCBsZW5ndGg7CisgICAgICAgIFFTdHJpbmdMaXN0IGd1 ZXNzZXM7CisgICAgICAgIFFTdHJpbmcgdXNlckRlc2NyaXB0aW9uOworICAgIH07CisKKyAgICB2 aXJ0dWFsIGJvb2wgaXNDb250aW5vdXNTcGVsbENoZWNraW5nRW5hYmxlZCgpIGNvbnN0ID0gMDsK KyAgICB2aXJ0dWFsIHZvaWQgdG9nZ2xlQ29udGlub3VzU3BlbGxDaGVja2luZygpID0gMDsKKwor ICAgIHZpcnR1YWwgdm9pZCBsZWFybldvcmQoY29uc3QgUVN0cmluZyYgd29yZCkgPSAwOworICAg IHZpcnR1YWwgdm9pZCBpZ25vcmVXb3JkSW5TcGVsbERvY3VtZW50KGNvbnN0IFFTdHJpbmcmIHdv cmQpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgY2hlY2tTcGVsbGluZ09mU3RyaW5nKGNvbnN0IFFT dHJpbmcmIHdvcmQsIGludCogbWlzc3BlbGxpbmdMb2NhdGlvbiwgaW50KiBtaXNzcGVsbGluZ0xl bmd0aCkgPSAwOworICAgIHZpcnR1YWwgUVN0cmluZyBhdXRvQ29ycmVjdFN1Z2dlc3Rpb25Gb3JN aXNzcGVsbGVkV29yZChjb25zdCBRU3RyaW5nJiB3b3JkKSA9IDA7CisgICAgdmlydHVhbCB2b2lk IGd1ZXNzZXNGb3JXb3JkKGNvbnN0IFFTdHJpbmcmIHdvcmQsIGNvbnN0IFFTdHJpbmcmIGNvbnRl eHQsIFFTdHJpbmdMaXN0JiBndWVzc2VzKSA9IDA7CisKKyAgICB2aXJ0dWFsIGJvb2wgaXNHcmFt bWFyQ2hlY2tpbmdFbmFibGVkKCkgPSAwOworICAgIHZpcnR1YWwgdm9pZCB0b2dnbGVHcmFtbWFy Q2hlY2tpbmcoKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIGNoZWNrR3JhbW1hck9mU3RyaW5nKGNv bnN0IFFTdHJpbmcmLCBRTGlzdDxHcmFtbWFyRGV0YWlsPiYsIGludCogYmFkR3JhbW1hckxvY2F0 aW9uLCBpbnQqIGJhZEdyYW1tYXJMZW5ndGgpID0gMDsKK307CisKK2NsYXNzIFFXZWJLaXRQbGF0 Zm9ybVBsdWdpbiB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+UVdlYktpdFBsYXRmb3JtUGx1Z2lu KCkge30KIApAQCAtMTQ1LDExICsxNjcsMTIgQEAgcHVibGljOgogICAgICAgICBOb3RpZmljYXRp b25zLAogICAgICAgICBIYXB0aWNzLAogICAgICAgICBUb3VjaEludGVyYWN0aW9uLAotICAgICAg ICBGdWxsU2NyZWVuVmlkZW9QbGF5ZXIKKyAgICAgICAgRnVsbFNjcmVlblZpZGVvUGxheWVyLAor ICAgICAgICBTcGVsbENoZWNrZXIKICAgICB9OwogCi0gICAgdmlydHVhbCBib29sIHN1cHBvcnRz RXh0ZW5zaW9uKEV4dGVuc2lvbiBleHRlbnNpb24pIGNvbnN0ID0gMDsKLSAgICB2aXJ0dWFsIFFP YmplY3QqIGNyZWF0ZUV4dGVuc2lvbihFeHRlbnNpb24gZXh0ZW5zaW9uKSBjb25zdCA9IDA7Cisg ICAgdmlydHVhbCBib29sIHN1cHBvcnRzRXh0ZW5zaW9uKEV4dGVuc2lvbikgY29uc3QgPSAwOwor ICAgIHZpcnR1YWwgUU9iamVjdCogY3JlYXRlRXh0ZW5zaW9uKEV4dGVuc2lvbikgY29uc3QgPSAw OwogfTsKIAogUVRfQkVHSU5fTkFNRVNQQUNFCi0tIAoxLjcuNy4xCgo=