71748 2011-11-07 16:31:15 -0800 Add CredentialStorage.cpp to WebCore/CMakeLists.txt 2011-11-08 10:12:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates gyuyoung.kim leandro paroga rakuco ryuan.choi tonikitoo oldest_to_newest 497583 0 dbates 2011-11-07 16:31:15 -0800 We should add CredentialStorage.cpp to the list of source files in WebCore/CMakeLists.txt. Notice, CredentialStorage.cpp provides a base implementation. A port-specific file is needed to implement CredentialStorage::getFromPersistentStorage(). 497595 1 113958 dbates 2011-11-07 16:48:43 -0800 Created attachment 113958 Patch This patch adds a stub implementation of CredentialStorage::getFromPersistentStorage() for the WinCE port. It also adds the source file CredentialStorageCurl.cpp to the list of WebCore source files when building the EFL port with the Curl backend. Notice that EFL uses the implementation of CredentialStorage::getFromPersistentStorage() from either CredentialStorageSoup.cpp or CredentialStorageCurl.cpp depending on which networking backend is used when building it. 497692 2 113958 gyuyoung.kim 2011-11-07 20:08:31 -0800 Comment on attachment 113958 Patch LGTM. 497753 3 113958 dbates 2011-11-07 22:40:31 -0800 Comment on attachment 113958 Patch Clearing flags on attachment: 113958 Committed r99523: <http://trac.webkit.org/changeset/99523> 497754 4 dbates 2011-11-07 22:40:38 -0800 All reviewed patches have been landed. Closing bug. 498023 5 rakuco 2011-11-08 07:01:07 -0800 This commit has broken the EFL build when the soup backend is used: Linking CXX shared library libwebcore_efl.so CMakeFiles/webcore_efl.dir/platform/network/soup/CredentialStorageSoup.cpp.o: In function `WebCore::CredentialStorage: :get(WebCore::ProtectionSpace const&)': /home/rakuco/dev/webkit/WebKit/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp:39: multiple definition of `WebCore::CredentialStorage::get(WebCore::ProtectionSpace const&)' CMakeFiles/webcore_efl.dir/platform/network/CredentialStorage.cpp.o:/home/rakuco/dev/webkit/WebKit/Source/WebCore/plat form/network/CredentialStorage.cpp:104: first defined here 498139 6 dbates 2011-11-08 09:30:52 -0800 (In reply to comment #5) > This commit has broken the EFL build when the soup backend is used: > > Linking CXX shared library libwebcore_efl.so > CMakeFiles/webcore_efl.dir/platform/network/soup/CredentialStorageSoup.cpp.o: In function `WebCore::CredentialStorage: > :get(WebCore::ProtectionSpace const&)': > /home/rakuco/dev/webkit/WebKit/Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp:39: multiple definition > of `WebCore::CredentialStorage::get(WebCore::ProtectionSpace const&)' > CMakeFiles/webcore_efl.dir/platform/network/CredentialStorage.cpp.o:/home/rakuco/dev/webkit/WebKit/Source/WebCore/plat > form/network/CredentialStorage.cpp:104: first defined here As the error message indicates, both CredentialStorage.cpp and CredentialStorageSoup.cpp define CredentialStorage::get(). I don't understand why CredentialStorageSoup.cpp defines get() given that it does't override all the other CredentialStorage methods that use CredentialStorage::protectionSpaceToCredentialMap(). I noticed that CredentialStorageQt.cpp also defines a get() as well. I think we should remove the get() method from CredentialStorageSoup.cpp. 498197 7 dbates 2011-11-08 10:12:34 -0800 Filed <https://bugs.webkit.org/show_bug.cgi?id=71825> and <https://bugs.webkit.org/show_bug.cgi?id=71829> to remove CredentialStorage::get() from CredentialStorageSoup.cpp and CredentialStorageQt.cpp, respectively. 113958 2011-11-07 16:48:43 -0800 2011-11-07 22:40:30 -0800 Patch Bug71748.patch text/plain 4212 dbates SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5NDk5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMTEtMDcgIERhbmllbCBC YXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIEFkZCBDcmVkZW50aWFsU3RvcmFnZS5j cHAgdG8gV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE3NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRzIENyZWRlbnRpYWxTdG9yYWdlLmNwcCB0byBXZWJDb3Jl L0NNYWtlTGlzdHMudHh0IHNpbmNlIGl0cyBwcm92aWRlcyBhCisgICAgICAgIGJhc2UgaW1wbGVt ZW50YXRpb24gb2YgdGhpcyBmZWF0dXJlLgorCisgICAgICAgIEFsc28gYWRkcyBhIHN0dWIgaW1w bGVtZW50YXRpb24gb2YgQ3JlZGVudGlhbFN0b3JhZ2UgdG8gdGhlIFdpbkNFIHBvcnQuCisKKyAg ICAgICAgKiBDTWFrZUxpc3RzLnR4dDogQWRkZWQgc291cmNlIGZpbGUgQ3JlZGVudGlhbFN0b3Jh Z2UuY3BwLgorICAgICAgICAqIENNYWtlTGlzdHNFZmwudHh0OiBBZGRlZCBzb3VyY2UgZmlsZSBD cmVkZW50aWFsU3RvcmFnZUN1cmwuY3BwIHdoZW4gYnVpbGRpbmcKKyAgICAgICAgICB3aXRoIHRo ZSBDdXJsIG5ldHdvcmtpbmcgYmFja2VuZC4KKyAgICAgICAgKiBDTWFrZUxpc3RzV2luQ0UudHh0 OiBBZGRlZCBzb3VyY2UgZmlsZSBDcmVkZW50aWFsU3RvcmFnZVdpbi5jcHAuCisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay93aW4vQ3JlZGVudGlhbFN0b3JhZ2VXaW4uY3BwOiBBZGRlZC4KKyAg ICAgICAgKFdlYkNvcmU6OkNyZWRlbnRpYWw6OmdldEZyb21QZXJzaXN0ZW50U3RvcmFnZSk6IFN0 dWIgaW1wbGVtZW50YXRpb24uCisKIDIwMTEtMTEtMDcgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSBbQ3VzdG9tR2V0dGVyXSBJREwgZm9yIHdp bmRvdy5PcHRpb24gb2YgVjgKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CShyZXZpc2lvbiA5OTQ5 NikKKysrIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0x MTU0LDYgKzExNTQsNyBAQCBTRVQoV2ViQ29yZV9TT1VSQ0VTCiAgICAgcGxhdGZvcm0vbmV0d29y ay9CbG9iUmVnaXN0cnlJbXBsLmNwcAogICAgIHBsYXRmb3JtL25ldHdvcmsvQmxvYlJlc291cmNl SGFuZGxlLmNwcAogICAgIHBsYXRmb3JtL25ldHdvcmsvQ3JlZGVudGlhbC5jcHAKKyAgICBwbGF0 Zm9ybS9uZXR3b3JrL0NyZWRlbnRpYWxTdG9yYWdlLmNwcAogICAgIHBsYXRmb3JtL25ldHdvcmsv Q29udGVudFR5cGVQYXJzZXIuY3BwCiAgICAgcGxhdGZvcm0vbmV0d29yay9EYXRhVVJMLmNwcAog ICAgIHBsYXRmb3JtL25ldHdvcmsvRm9ybURhdGFCdWlsZGVyLmNwcApJbmRleDogU291cmNlL1dl YkNvcmUvQ01ha2VMaXN0c0VmbC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvQ01h a2VMaXN0c0VmbC50eHQJKHJldmlzaW9uIDk5NDk2KQorKysgU291cmNlL1dlYkNvcmUvQ01ha2VM aXN0c0VmbC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTE2NCw2ICsxNjQsNyBAQCBJRiAoV1RGX1VT RV9DVVJMKQogICApCiAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogICAgIHBsYXRmb3Jt L25ldHdvcmsvY3VybC9Db29raWVKYXJDdXJsLmNwcAorICAgIHBsYXRmb3JtL25ldHdvcmsvY3Vy bC9DcmVkZW50aWFsU3RvcmFnZUN1cmwuY3BwCiAgICAgcGxhdGZvcm0vbmV0d29yay9jdXJsL0RO U0N1cmwuY3BwCiAgICAgcGxhdGZvcm0vbmV0d29yay9jdXJsL0Zvcm1EYXRhU3RyZWFtQ3VybC5j cHAKICAgICBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsLmNwcApJbmRl eDogU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0c1dpbkNFLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9DTWFrZUxpc3RzV2luQ0UudHh0CShyZXZpc2lvbiA5OTQ5NikKKysrIFNvdXJj ZS9XZWJDb3JlL0NNYWtlTGlzdHNXaW5DRS50eHQJKHdvcmtpbmcgY29weSkKQEAgLTgwLDYgKzgw LDcgQEAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgcGxhdGZvcm0vd2luY2UvTUlN RVR5cGVSZWdpc3RyeVdpbmNlLmNwcAogICAgIHBsYXRmb3JtL3dpbmNlL1NoYXJlZFRpbWVyV2lu Y2UuY3BwCiAKKyAgICBwbGF0Zm9ybS9uZXR3b3JrL3dpbi9DcmVkZW50aWFsU3RvcmFnZVdpbi5j cHAKICAgICBwbGF0Zm9ybS9uZXR3b3JrL3dpbi9Db29raWVKYXJXaW4uY3BwCiAgICAgcGxhdGZv cm0vbmV0d29yay93aW4vQ29va2llU3RvcmFnZVdpbi5jcHAKICAgICBwbGF0Zm9ybS9uZXR3b3Jr L3dpbi9OZXR3b3JrU3RhdGVOb3RpZmllcldpbi5jcHAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvd2luL0NyZWRlbnRpYWxTdG9yYWdlV2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3dpbi9DcmVkZW50aWFsU3RvcmFnZVdp bi5jcHAJKHJldmlzaW9uIDApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3dp bi9DcmVkZW50aWFsU3RvcmFnZVdpbi5jcHAJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzMgQEAK Ky8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQuIEFs bCByaWdodHMgcmVzZXJ2ZWQuCisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7 IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0 ZXJtcyBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICogTGljZW5zZSBhcyBwdWJs aXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisgKiB2ZXJzaW9u IDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24u CisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQg d2lsbCBiZSB1c2VmdWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZl biB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1Mg Rk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAqIExlc3NlciBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBoYXZl IHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICogTGlj ZW5zZSBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgaWYgbm90LCB3cml0ZSB0byB0aGUgRnJlZSBT b2Z0d2FyZQorICogRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBG bG9vciwgQm9zdG9uLCBNQSAgMDIxMTAtMTMwMSAgVVNBCisgKi8KKworI2luY2x1ZGUgImNvbmZp Zy5oIgorI2luY2x1ZGUgIkNyZWRlbnRpYWxTdG9yYWdlLmgiCisKKyNpbmNsdWRlICJDcmVkZW50 aWFsLmgiCisjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUg eworCitDcmVkZW50aWFsIENyZWRlbnRpYWxTdG9yYWdlOjpnZXRGcm9tUGVyc2lzdGVudFN0b3Jh Z2UoY29uc3QgUHJvdGVjdGlvblNwYWNlJikKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IHJldHVybiBDcmVkZW50aWFsKCk7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUK