<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>71736</bug_id>
          
          <creation_ts>2011-11-07 14:57:49 -0800</creation_ts>
          <short_desc>Allow gamepad to be enabled at runtime</short_desc>
          <delta_ts>2011-11-07 16:28:04 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Scott Graham">scottmg</reporter>
          <assigned_to name="Scott Graham">scottmg</assigned_to>
          <cc>abarth</cc>
    
    <cc>fishd</cc>
    
    <cc>jamesr</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>497494</commentid>
    <comment_count>0</comment_count>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2011-11-07 14:57:49 -0800</bug_when>
    <thetext>Add runtime enable for gamepad functionality.

Full patch here https://bugs.webkit.org/show_bug.cgi?id=69451</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497497</commentid>
    <comment_count>1</comment_count>
      <attachid>113933</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2011-11-07 14:59:47 -0800</bug_when>
    <thetext>Created attachment 113933
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497511</commentid>
    <comment_count>2</comment_count>
      <attachid>113937</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2011-11-07 15:07:11 -0800</bug_when>
    <thetext>Created attachment 113937
consistently plural</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497522</commentid>
    <comment_count>3</comment_count>
      <attachid>113937</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-11-07 15:24:32 -0800</bug_when>
    <thetext>Comment on attachment 113937
consistently plural

View in context: https://bugs.webkit.org/attachment.cgi?id=113937&amp;action=review

&gt; Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:64
&gt; +bool RuntimeEnabledFeatures::isGamepadsEnabled = false;

&quot;is gamepads&quot; ?  :(

Can we change this to isGamepadEnabled ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497524</commentid>
    <comment_count>4</comment_count>
      <attachid>113937</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2011-11-07 15:27:53 -0800</bug_when>
    <thetext>Comment on attachment 113937
consistently plural

View in context: https://bugs.webkit.org/attachment.cgi?id=113937&amp;action=review

&gt;&gt; Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:64
&gt;&gt; +bool RuntimeEnabledFeatures::isGamepadsEnabled = false;
&gt; 
&gt; &quot;is gamepads&quot; ?  :(
&gt; 
&gt; Can we change this to isGamepadEnabled ?

Yes, it&apos;s ugly and ungrammatical. :(

gamepadsEnabled() has to be plural because of the binding generation code. So I waffled for a while and went full-plural. Would you like to see just the bool singular? Or both the bool and the setGamepad[s]Enabled function as singular (but not matching the get)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497531</commentid>
    <comment_count>5</comment_count>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2011-11-07 15:32:31 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 113937 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=113937&amp;action=review
&gt; 
&gt; &gt;&gt; Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:64
&gt; &gt;&gt; +bool RuntimeEnabledFeatures::isGamepadsEnabled = false;
&gt; &gt; 
&gt; &gt; &quot;is gamepads&quot; ?  :(
&gt; &gt; 
&gt; &gt; Can we change this to isGamepadEnabled ?
&gt; 
&gt; Yes, it&apos;s ugly and ungrammatical. :(
&gt; 
&gt; gamepadsEnabled() has to be plural because of the binding generation code. So I waffled for a while and went full-plural. Would you like to see just the bool singular? Or both the bool and the setGamepad[s]Enabled function as singular (but not matching the get)?

Hmm, actually I guess setGamepadsEnabled sounds OK. It just seemed awkward to have that modify a bool that was singular. I&apos;ll do that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497537</commentid>
    <comment_count>6</comment_count>
      <attachid>113942</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2011-11-07 15:33:42 -0800</bug_when>
    <thetext>Created attachment 113942
less ungrammatical</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497538</commentid>
    <comment_count>7</comment_count>
      <attachid>113942</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-11-07 15:35:42 -0800</bug_when>
    <thetext>Comment on attachment 113942
less ungrammatical

Ok.  We really should just autogenerate this file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497578</commentid>
    <comment_count>8</comment_count>
      <attachid>113942</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-07 16:27:59 -0800</bug_when>
    <thetext>Comment on attachment 113942
less ungrammatical

Clearing flags on attachment: 113942

Committed r99500: &lt;http://trac.webkit.org/changeset/99500&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497579</commentid>
    <comment_count>9</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-07 16:28:04 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>113933</attachid>
            <date>2011-11-07 14:59:47 -0800</date>
            <delta_ts>2011-11-07 15:07:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-71736-20111107145946.patch</filename>
            <type>text/plain</type>
            <size>2675</size>
            <attacher name="Scott Graham">scottmg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTkyMjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MWM4MWE2NTc1ZjkyMzlj
MjUyMzJiNThlOTAwZWYxNmI3MTViMmVjLi5kZWEwMTU3MWY5YjZiNTQzZDIxMjhiZDk4ODc3ZDk2
NWI2NGY3NDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTEtMDcgIFNjb3R0
IEdyYWhhbSAgPHNjb3R0bWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFsbG93IGdhbWVwYWQg
QVBJIHRvIGJlIGVuYWJsZWQgYXQgcnVudGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE3MzYKKworICAgICAgICBQYXJ0IG9mIGZ1bGwgcGF0Y2gs
IGZvdW5kIGF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02OTQ1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IE5vIG5ldyB0ZXN0cy4gTm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBiaW5kaW5n
cy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwOgorICAgICAgICAqIGJpbmRpbmdz
L2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oOgorICAgICAgICAoV2ViQ29yZTo6UnVu
dGltZUVuYWJsZWRGZWF0dXJlczo6c2V0R2FtZXBhZEVuYWJsZWQpOgorICAgICAgICAoV2ViQ29y
ZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6Z2FtZXBhZHNFbmFibGVkKToKKwogMjAxMS0xMS0w
MyAgSm9zaHVhIEJlbGwgIDxqc2JlbGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluZGV4ZWRE
QiByZXN1bHQgb2YgZGVsZXRpbmcgYSByZWNvcmQgc2hvdWxkIGJlIHRydWUgb3IgZmFsc2UKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRG
ZWF0dXJlcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFi
bGVkRmVhdHVyZXMuY3BwCmluZGV4IDRhYmVhMDVlOGIxYmQyZmY2MzY3NTEwODUxYmM4YjA3M2Ux
NGVkN2IuLjFhMzUzN2QxMzhiNjYzMTA2NWJhODcwZjJiZDFmNDY2N2RiMWU0YmUgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJl
cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxl
ZEZlYXR1cmVzLmNwcApAQCAtNjAsNiArNjAsMTAgQEAgYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1
cmVzOjppc1NwZWVjaElucHV0RW5hYmxlZCA9IHRydWU7CiBib29sIFJ1bnRpbWVFbmFibGVkRmVh
dHVyZXM6OmlzTWVkaWFTdHJlYW1FbmFibGVkID0gdHJ1ZTsKICNlbmRpZgogCisjaWYgRU5BQkxF
KEdBTUVQQUQpCitib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzR2FtZXBhZEVuYWJsZWQg
PSBmYWxzZTsKKyNlbmRpZgorCiAjaWYgRU5BQkxFKFhIUl9SRVNQT05TRV9CTE9CKQogYm9vbCBS
dW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc1hIUlJlc3BvbnNlQmxvYkVuYWJsZWQgPSBmYWxzZTsK
ICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50
aW1lRW5hYmxlZEZlYXR1cmVzLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1
bnRpbWVFbmFibGVkRmVhdHVyZXMuaAppbmRleCA2NjI0YzdhYzAyMzhlZjRkNmI1ZmMzNGE0ZWM1
NmE5Y2MxYmFmNWVhLi5hZWNmNzMyNTVlZDAyYjJhMjgxNDBhNGVjNjFlYjY0YTM2MDU2OGIyIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVk
RmVhdHVyZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVF
bmFibGVkRmVhdHVyZXMuaApAQCAtMTcwLDYgKzE3MCwxMSBAQCBwdWJsaWM6CiAgICAgc3RhdGlj
IGJvb2wgd2Via2l0UGVlckNvbm5lY3Rpb25FbmFibGVkKCkgeyByZXR1cm4gaXNNZWRpYVN0cmVh
bUVuYWJsZWQ7IH0KICNlbmRpZgogCisjaWYgRU5BQkxFKEdBTUVQQUQpCisgICAgc3RhdGljIHZv
aWQgc2V0R2FtZXBhZEVuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsgaXNHYW1lcGFkRW5hYmxlZCA9
IGlzRW5hYmxlZDsgfQorICAgIHN0YXRpYyBib29sIGdhbWVwYWRzRW5hYmxlZCgpIHsgcmV0dXJu
IGlzR2FtZXBhZEVuYWJsZWQ7IH0KKyNlbmRpZgorCiAjaWYgRU5BQkxFKFFVT1RBKQogICAgIHN0
YXRpYyBib29sIHF1b3RhRW5hYmxlZCgpIHsgcmV0dXJuIGlzUXVvdGFFbmFibGVkOyB9CiAgICAg
c3RhdGljIHZvaWQgc2V0UXVvdGFFbmFibGVkKGJvb2wgaXNFbmFibGVkKSB7IGlzUXVvdGFFbmFi
bGVkID0gaXNFbmFibGVkOyB9CkBAIC0yMTgsNiArMjIzLDEwIEBAIHByaXZhdGU6CiAgICAgc3Rh
dGljIGJvb2wgaXNNZWRpYVN0cmVhbUVuYWJsZWQ7CiAjZW5kaWYKIAorI2lmIEVOQUJMRShHQU1F
UEFEKQorICAgIHN0YXRpYyBib29sIGlzR2FtZXBhZEVuYWJsZWQ7CisjZW5kaWYKKwogI2lmIEVO
QUJMRShRVU9UQSkKICAgICBzdGF0aWMgYm9vbCBpc1F1b3RhRW5hYmxlZDsKICNlbmRpZgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>113937</attachid>
            <date>2011-11-07 15:07:11 -0800</date>
            <delta_ts>2011-11-07 15:33:39 -0800</delta_ts>
            <desc>consistently plural</desc>
            <filename>bug-71736-20111107150710.patch</filename>
            <type>text/plain</type>
            <size>2681</size>
            <attacher name="Scott Graham">scottmg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTkyMjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MWM4MWE2NTc1ZjkyMzlj
MjUyMzJiNThlOTAwZWYxNmI3MTViMmVjLi45YThiZWQzODFmZTE1NWQwNzVhMDc2NGRkZWNlMjY2
MTEyZGFlYzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTEtMDcgIFNjb3R0
IEdyYWhhbSAgPHNjb3R0bWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFsbG93IGdhbWVwYWQg
QVBJIHRvIGJlIGVuYWJsZWQgYXQgcnVudGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE3MzYKKworICAgICAgICBQYXJ0IG9mIGZ1bGwgcGF0Y2gs
IGZvdW5kIGF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02OTQ1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IE5vIG5ldyB0ZXN0cy4gTm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBiaW5kaW5n
cy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwOgorICAgICAgICAqIGJpbmRpbmdz
L2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oOgorICAgICAgICAoV2ViQ29yZTo6UnVu
dGltZUVuYWJsZWRGZWF0dXJlczo6c2V0R2FtZXBhZHNFbmFibGVkKToKKyAgICAgICAgKFdlYkNv
cmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmdhbWVwYWRzRW5hYmxlZCk6CisKIDIwMTEtMTEt
MDMgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVk
REIgcmVzdWx0IG9mIGRlbGV0aW5nIGEgcmVjb3JkIHNob3VsZCBiZSB0cnVlIG9yIGZhbHNlCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVk
RmVhdHVyZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5h
YmxlZEZlYXR1cmVzLmNwcAppbmRleCA0YWJlYTA1ZThiMWJkMmZmNjM2NzUxMDg1MWJjOGIwNzNl
MTRlZDdiLi5lYWMxMmRiZTFkY2VmMmFkMzZjODc1YWFhYWY3ZDdjYzYyN2Y2MGIxIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVy
ZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJs
ZWRGZWF0dXJlcy5jcHAKQEAgLTYwLDYgKzYwLDEwIEBAIGJvb2wgUnVudGltZUVuYWJsZWRGZWF0
dXJlczo6aXNTcGVlY2hJbnB1dEVuYWJsZWQgPSB0cnVlOwogYm9vbCBSdW50aW1lRW5hYmxlZEZl
YXR1cmVzOjppc01lZGlhU3RyZWFtRW5hYmxlZCA9IHRydWU7CiAjZW5kaWYKIAorI2lmIEVOQUJM
RShHQU1FUEFEKQorYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0dhbWVwYWRzRW5hYmxl
ZCA9IGZhbHNlOworI2VuZGlmCisKICNpZiBFTkFCTEUoWEhSX1JFU1BPTlNFX0JMT0IpCiBib29s
IFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzWEhSUmVzcG9uc2VCbG9iRW5hYmxlZCA9IGZhbHNl
OwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1
bnRpbWVFbmFibGVkRmVhdHVyZXMuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMv
UnVudGltZUVuYWJsZWRGZWF0dXJlcy5oCmluZGV4IDY2MjRjN2FjMDIzOGVmNGQ2YjVmYzM0YTRl
YzU2YTljYzFiYWY1ZWEuLjk4YzgwN2RjYmY1ZjkzNWY0YjcxMzlhMjI2N2U3YjJjMzJiMmRiOWEg
MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJs
ZWRGZWF0dXJlcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGlt
ZUVuYWJsZWRGZWF0dXJlcy5oCkBAIC0xNzAsNiArMTcwLDExIEBAIHB1YmxpYzoKICAgICBzdGF0
aWMgYm9vbCB3ZWJraXRQZWVyQ29ubmVjdGlvbkVuYWJsZWQoKSB7IHJldHVybiBpc01lZGlhU3Ry
ZWFtRW5hYmxlZDsgfQogI2VuZGlmCiAKKyNpZiBFTkFCTEUoR0FNRVBBRCkKKyAgICBzdGF0aWMg
dm9pZCBzZXRHYW1lcGFkc0VuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsgaXNHYW1lcGFkc0VuYWJs
ZWQgPSBpc0VuYWJsZWQ7IH0KKyAgICBzdGF0aWMgYm9vbCBnYW1lcGFkc0VuYWJsZWQoKSB7IHJl
dHVybiBpc0dhbWVwYWRzRW5hYmxlZDsgfQorI2VuZGlmCisKICNpZiBFTkFCTEUoUVVPVEEpCiAg
ICAgc3RhdGljIGJvb2wgcXVvdGFFbmFibGVkKCkgeyByZXR1cm4gaXNRdW90YUVuYWJsZWQ7IH0K
ICAgICBzdGF0aWMgdm9pZCBzZXRRdW90YUVuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsgaXNRdW90
YUVuYWJsZWQgPSBpc0VuYWJsZWQ7IH0KQEAgLTIxOCw2ICsyMjMsMTAgQEAgcHJpdmF0ZToKICAg
ICBzdGF0aWMgYm9vbCBpc01lZGlhU3RyZWFtRW5hYmxlZDsKICNlbmRpZgogCisjaWYgRU5BQkxF
KEdBTUVQQUQpCisgICAgc3RhdGljIGJvb2wgaXNHYW1lcGFkc0VuYWJsZWQ7CisjZW5kaWYKKwog
I2lmIEVOQUJMRShRVU9UQSkKICAgICBzdGF0aWMgYm9vbCBpc1F1b3RhRW5hYmxlZDsKICNlbmRp
Zgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>113942</attachid>
            <date>2011-11-07 15:33:42 -0800</date>
            <delta_ts>2011-11-07 16:27:59 -0800</delta_ts>
            <desc>less ungrammatical</desc>
            <filename>bug-71736-20111107153341.patch</filename>
            <type>text/plain</type>
            <size>2677</size>
            <attacher name="Scott Graham">scottmg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTkyMjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MWM4MWE2NTc1ZjkyMzlj
MjUyMzJiNThlOTAwZWYxNmI3MTViMmVjLi45YThiZWQzODFmZTE1NWQwNzVhMDc2NGRkZWNlMjY2
MTEyZGFlYzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTEtMDcgIFNjb3R0
IEdyYWhhbSAgPHNjb3R0bWdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFsbG93IGdhbWVwYWQg
QVBJIHRvIGJlIGVuYWJsZWQgYXQgcnVudGltZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE3MzYKKworICAgICAgICBQYXJ0IG9mIGZ1bGwgcGF0Y2gs
IGZvdW5kIGF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD02OTQ1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IE5vIG5ldyB0ZXN0cy4gTm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBiaW5kaW5n
cy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwOgorICAgICAgICAqIGJpbmRpbmdz
L2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oOgorICAgICAgICAoV2ViQ29yZTo6UnVu
dGltZUVuYWJsZWRGZWF0dXJlczo6c2V0R2FtZXBhZHNFbmFibGVkKToKKyAgICAgICAgKFdlYkNv
cmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmdhbWVwYWRzRW5hYmxlZCk6CisKIDIwMTEtMTEt
MDMgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVk
REIgcmVzdWx0IG9mIGRlbGV0aW5nIGEgcmVjb3JkIHNob3VsZCBiZSB0cnVlIG9yIGZhbHNlCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVk
RmVhdHVyZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5h
YmxlZEZlYXR1cmVzLmNwcAppbmRleCA0YWJlYTA1ZThiMWJkMmZmNjM2NzUxMDg1MWJjOGIwNzNl
MTRlZDdiLi4xYTM1MzdkMTM4YjY2MzEwNjViYTg3MGYyYmQxZjQ2NjdkYjFlNGJlIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVy
ZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJs
ZWRGZWF0dXJlcy5jcHAKQEAgLTYwLDYgKzYwLDEwIEBAIGJvb2wgUnVudGltZUVuYWJsZWRGZWF0
dXJlczo6aXNTcGVlY2hJbnB1dEVuYWJsZWQgPSB0cnVlOwogYm9vbCBSdW50aW1lRW5hYmxlZEZl
YXR1cmVzOjppc01lZGlhU3RyZWFtRW5hYmxlZCA9IHRydWU7CiAjZW5kaWYKIAorI2lmIEVOQUJM
RShHQU1FUEFEKQorYm9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc0dhbWVwYWRFbmFibGVk
ID0gZmFsc2U7CisjZW5kaWYKKwogI2lmIEVOQUJMRShYSFJfUkVTUE9OU0VfQkxPQikKIGJvb2wg
UnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNYSFJSZXNwb25zZUJsb2JFbmFibGVkID0gZmFsc2U7
CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVu
dGltZUVuYWJsZWRGZWF0dXJlcy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9S
dW50aW1lRW5hYmxlZEZlYXR1cmVzLmgKaW5kZXggNjYyNGM3YWMwMjM4ZWY0ZDZiNWZjMzRhNGVj
NTZhOWNjMWJhZjVlYS4uODAwMWI3YTcwZjM5MWE1NTVmZWNjNjA2MzRmMGRkN2EwZjc2YTNkNiAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1lRW5hYmxl
ZEZlYXR1cmVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ2VuZXJpYy9SdW50aW1l
RW5hYmxlZEZlYXR1cmVzLmgKQEAgLTE3MCw2ICsxNzAsMTEgQEAgcHVibGljOgogICAgIHN0YXRp
YyBib29sIHdlYmtpdFBlZXJDb25uZWN0aW9uRW5hYmxlZCgpIHsgcmV0dXJuIGlzTWVkaWFTdHJl
YW1FbmFibGVkOyB9CiAjZW5kaWYKIAorI2lmIEVOQUJMRShHQU1FUEFEKQorICAgIHN0YXRpYyB2
b2lkIHNldEdhbWVwYWRzRW5hYmxlZChib29sIGlzRW5hYmxlZCkgeyBpc0dhbWVwYWRFbmFibGVk
ID0gaXNFbmFibGVkOyB9CisgICAgc3RhdGljIGJvb2wgZ2FtZXBhZHNFbmFibGVkKCkgeyByZXR1
cm4gaXNHYW1lcGFkRW5hYmxlZDsgfQorI2VuZGlmCisKICNpZiBFTkFCTEUoUVVPVEEpCiAgICAg
c3RhdGljIGJvb2wgcXVvdGFFbmFibGVkKCkgeyByZXR1cm4gaXNRdW90YUVuYWJsZWQ7IH0KICAg
ICBzdGF0aWMgdm9pZCBzZXRRdW90YUVuYWJsZWQoYm9vbCBpc0VuYWJsZWQpIHsgaXNRdW90YUVu
YWJsZWQgPSBpc0VuYWJsZWQ7IH0KQEAgLTIxOCw2ICsyMjMsMTAgQEAgcHJpdmF0ZToKICAgICBz
dGF0aWMgYm9vbCBpc01lZGlhU3RyZWFtRW5hYmxlZDsKICNlbmRpZgogCisjaWYgRU5BQkxFKEdB
TUVQQUQpCisgICAgc3RhdGljIGJvb2wgaXNHYW1lcGFkRW5hYmxlZDsKKyNlbmRpZgorCiAjaWYg
RU5BQkxFKFFVT1RBKQogICAgIHN0YXRpYyBib29sIGlzUXVvdGFFbmFibGVkOwogI2VuZGlmCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>