71735 2011-11-07 14:54:30 -0800 Remove [CustomGetter] IDL for window.Option of V8 2011-11-07 16:11:03 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71093 1 haraken haraken abarth dominicc japhet ojan webkit.review.bot oldest_to_newest 497490 0 haraken 2011-11-07 14:54:30 -0800 The getter for window.Option of V8 does not need to be a custom getter. It can use a default getter DOMWindowInternal::DOMWindowConstructorGetter. 497518 1 113939 haraken 2011-11-07 15:22:00 -0800 Created attachment 113939 Patch 497561 2 113939 webkit.review.bot 2011-11-07 16:10:59 -0800 Comment on attachment 113939 Patch Clearing flags on attachment: 113939 Committed r99498: <http://trac.webkit.org/changeset/99498> 497562 3 webkit.review.bot 2011-11-07 16:11:03 -0800 All reviewed patches have been landed. Closing bug. 113939 2011-11-07 15:22:00 -0800 2011-11-07 16:10:59 -0800 Patch bug-71735-20111107152159.patch text/plain 3563 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogOTk0ODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNmZkY2MzNzBmMDRiYTlj N2Y3M2Y3NDk5MDRmYTNiMGRhM2ZiYTEzLi44MzNlOWJmNmZmNjNlYjU1Yjc5YzBhOTkwYjVlM2Y1 ZWIyN2IyNzRmIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIwMTEtMTEtMDcgIEtlbnRh cm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJlbW92ZSBbQ3VzdG9t R2V0dGVyXSBJREwgZm9yIHdpbmRvdy5PcHRpb24gb2YgVjgKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCB3aW5kb3cuT3B0aW9uIHVzZXMg YSBjdXN0b20gZ2V0dGVyIHRvIGdldCB0aGUgdGVtcGxhdGUKKyAgICAgICAgb2YgJ0hUTUxPcHRp b25FbGVtZW50Q29uc3RydWN0b3InLiBIb3dldmVyLCB0aGlzIGdldHRlciBkb2VzIG5vdCBuZWVk IHRvCisgICAgICAgIGJlIGN1c3RvbSBhbmQgY2FuIHVzZSBhIGRlZmF1bHQgZ2V0dGVyCisgICAg ICAgICdET01XaW5kb3dJbnRlcm5hbDo6RE9NV2luZG93Q29uc3RydWN0b3JHZXR0ZXInLgorCisg ICAgICAgIFRlc3RzOiBmYXN0L2pzL2N1c3RvbS1jb25zdHJ1Y3RvcnMuaHRtbAorICAgICAgICAg ICAgICAgZmFzdC9mb3Jtcy9vcHRpb24taW5kZXguaHRtbAorICAgICAgICAgICAgICAgZmFzdC9m b3Jtcy9hZGQtYW5kLXJlbW92ZS1vcHRpb24uaHRtbAorICAgICAgICAgICAgICAgZmFzdC9kb20v ZG9tLWFkZC1vcHRpb25lbGVtZW50Lmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3Rv bS9WOERPTVdpbmRvd0N1c3RvbS5jcHA6IFJlbW92ZWQgYSBjdXN0b20gZ2V0dGVyLgorICAgICAg ICAqIHBhZ2UvRE9NV2luZG93LmlkbDogUmVtb3ZlZCBbQ3VzdG9tR2V0dGVyXSBJREwgZnJvbSB3 aW5kb3cuT3B0aW9uIG9mIFY4LiBSZW5hbWVkICdIVE1MT3B0aW9uRWxlbWVudENvbnN0cnVjdG9y JyB0byAnSFRNTE9wdGlvbkVsZW1lbnRDb25zdHJ1Y3RvckNvbnN0cnVjdG9yJyBpbiBvcmRlciB0 byBtYWtlIHdpbmRvdy5PcHRpb24gdXNlIHRoZSB0ZW1wbGF0ZSBvZiAobm90ICdIVE1MT3B0aW9u RWxlbWVudCcgYnV0KSAnSFRNTE9wdGlvbkVsZW1lbnRDb25zdHJ1Y3RvcicuIE5vdGUgdGhhdCBD b2RlR2VuZXJhdG9yKi5wbSBzdHJpcHMgL0NvbnN0cnVjdG9yJC8gZnJvbSB0aGUgSURMIHR5cGUu CisKKzIwMTEtMTEtMDcgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCiAg ICAgICAgIFJlbW92ZSBbQ3VzdG9tR2V0dGVyXSBJREwgZnJvbSAnSFRNTEF1ZGlvRWxlbWVudENv bnN0cnVjdG9yJyBvZiBWOAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzE2NjAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKaW5kZXggZTVmYWYwYjAyNmFkNDlhZjJlODM4 ZDIwYmEwZDMwMjdhMjQ5OGY4OS4uOGI4Njc2N2Q3ZDFhNjdiZDNmZDI1YzdkYzc0NTkzNTZhOWNi ZWUzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9N V2luZG93Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20v VjhET01XaW5kb3dDdXN0b20uY3BwCkBAIC01OCw3ICs1OCw2IEBACiAjaW5jbHVkZSAiVjhIaWRk ZW5Qcm9wZXJ0eU5hbWUuaCIKICNpbmNsdWRlICJWOEhUTUxDb2xsZWN0aW9uLmgiCiAjaW5jbHVk ZSAiVjhIVE1MSW1hZ2VFbGVtZW50Q29uc3RydWN0b3IuaCIKLSNpbmNsdWRlICJWOEhUTUxPcHRp b25FbGVtZW50Q29uc3RydWN0b3IuaCIKICNpbmNsdWRlICJWOE1lc3NhZ2VQb3J0Q3VzdG9tLmgi CiAjaW5jbHVkZSAiVjhOb2RlLmgiCiAjaW5jbHVkZSAiVjhQcm94eS5oIgpAQCAtMjMyLDEyICsy MzEsNiBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhET01XaW5kb3c6OkltYWdlQWNjZXNzb3JH ZXR0ZXIodjg6OkxvY2FsPHY4OjpTdHJpbmc+IG5hbQogICAgIHJldHVybiBWOERPTVdyYXBwZXI6 OmdldENvbnN0cnVjdG9yKCZWOEhUTUxJbWFnZUVsZW1lbnRDb25zdHJ1Y3Rvcjo6aW5mbywgd2lu ZG93KTsKIH0KIAotdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4RE9NV2luZG93OjpPcHRpb25BY2Nl c3NvckdldHRlcih2ODo6TG9jYWw8djg6OlN0cmluZz4gbmFtZSwgY29uc3Qgdjg6OkFjY2Vzc29y SW5mbyYgaW5mbykKLXsKLSAgICBET01XaW5kb3cqIHdpbmRvdyA9IFY4RE9NV2luZG93Ojp0b05h dGl2ZShpbmZvLkhvbGRlcigpKTsKLSAgICByZXR1cm4gVjhET01XcmFwcGVyOjpnZXRDb25zdHJ1 Y3RvcigmVjhIVE1MT3B0aW9uRWxlbWVudENvbnN0cnVjdG9yOjppbmZvLCB3aW5kb3cpOwotfQot CiB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhET01XaW5kb3c6OmFkZEV2ZW50TGlzdGVuZXJDYWxs YmFjayhjb25zdCB2ODo6QXJndW1lbnRzJiBhcmdzKQogewogICAgIElOQ19TVEFUUygiRE9NLkRP TVdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCkiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRE9NV2luZG93LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbApp bmRleCBlODg0N2RmZDg3Mzc3YzFkYTcwZTBhNmI3OTJkMTUyZDU5ZTc3NzM5Li4zN2Q2MzkxZmU3 NDYyODc5YjIxNGNjOWY4YjdkY2U4NGNjZGJmMTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RPTVdpbmRvdy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cu aWRsCkBAIC00OTEsNyArNDkxLDcgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIGF0dHJpYnV0 ZSBIVE1MVW5rbm93bkVsZW1lbnRDb25zdHJ1Y3RvciBIVE1MVW5rbm93bkVsZW1lbnQ7CiAKICAg ICAgICAgYXR0cmlidXRlIFtDdXN0b21HZXR0ZXJdIEhUTUxJbWFnZUVsZW1lbnRDb25zdHJ1Y3Rv ciBJbWFnZTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCi0gICAgICAgIGF0dHJpYnV0ZSBb Q3VzdG9tR2V0dGVyXSBIVE1MT3B0aW9uRWxlbWVudENvbnN0cnVjdG9yIE9wdGlvbjsgLy8gVXNh YmxlIHdpdGggbmV3IG9wZXJhdG9yCisgICAgICAgIGF0dHJpYnV0ZSBbSlNDQ3VzdG9tR2V0dGVy XSBIVE1MT3B0aW9uRWxlbWVudENvbnN0cnVjdG9yQ29uc3RydWN0b3IgT3B0aW9uOyAvLyBVc2Fi bGUgd2l0aCBuZXcgb3BlcmF0b3IKIAogICAgICAgICBhdHRyaWJ1dGUgQ2FudmFzUGF0dGVybkNv bnN0cnVjdG9yIENhbnZhc1BhdHRlcm47CiAgICAgICAgIGF0dHJpYnV0ZSBDYW52YXNHcmFkaWVu dENvbnN0cnVjdG9yIENhbnZhc0dyYWRpZW50Owo=