71722 2011-11-07 12:45:20 -0800 Uninitialized Heap member var 2011-11-07 14:20:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rectalogic webkit-unassigned fpizlo kling oliver webkit.review.bot oldest_to_newest 497387 0 rectalogic 2011-11-07 12:45:20 -0800 m_blockFreeingThreadShouldQuit is uninitialized in Source/JavaScriptCore/heap/Heap.cpp valgrind complains: ==24728== Thread 3: ==24728== Conditional jump or move depends on uninitialised value(s) ==24728== at 0x6923EF7: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:411) ==24728== by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405) ==24728== by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67) ==24728== by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67) ==24728== by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331) ==24728== by 0x96A19C9: start_thread (pthread_create.c:300) ==24728== by 0xA14C70C: clone (clone.S:112) ==24728== ==24728== Conditional jump or move depends on uninitialised value(s) ==24728== at 0x6923CBE: JSC::Heap::waitForRelativeTimeWhileHoldingLock(double) (Heap.cpp:388) ==24728== by 0x6923D2E: JSC::Heap::waitForRelativeTime(double) (Heap.cpp:400) ==24728== by 0x6923DAB: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:414) ==24728== by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405) ==24728== by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67) ==24728== by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67) ==24728== by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331) ==24728== by 0x96A19C9: start_thread (pthread_create.c:300) ==24728== by 0xA14C70C: clone (clone.S:112) ==24728== ==24728== Conditional jump or move depends on uninitialised value(s) ==24728== at 0x6923DB9: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:415) ==24728== by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405) ==24728== by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67) ==24728== by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67) ==24728== by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331) ==24728== by 0x96A19C9: start_thread (pthread_create.c:300) ==24728== by 0xA14C70C: clone (clone.S:112) 497397 1 113915 rectalogic 2011-11-07 12:56:10 -0800 Created attachment 113915 initialize m_blockFreeingThreadShouldQuit 497422 2 113915 fpizlo 2011-11-07 13:21:19 -0800 Comment on attachment 113915 initialize m_blockFreeingThreadShouldQuit Ooops! It's a wonder that this code has "worked" for so long. Thanks for the fix! r=me 497425 3 oliver 2011-11-07 13:26:51 -0800 <rdar://problem/10407863> 497467 4 113915 webkit.review.bot 2011-11-07 14:20:34 -0800 Comment on attachment 113915 initialize m_blockFreeingThreadShouldQuit Clearing flags on attachment: 113915 Committed r99477: <http://trac.webkit.org/changeset/99477> 497468 5 webkit.review.bot 2011-11-07 14:20:39 -0800 All reviewed patches have been landed. Closing bug. 113915 2011-11-07 12:56:10 -0800 2011-11-07 14:20:34 -0800 initialize m_blockFreeingThreadShouldQuit heapinit.diff text/plain 1118 rectalogic ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk3NzFmNGMuLmNlNTFhMGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTExLTA3ICBBbmRyZXcgV2Fzb24g IDxyZWN0YWxvZ2ljQHJlY3RhbG9naWMuY29tPgorCisgICAgICAgIFVuaW5pdGlhbGl6ZWQgSGVh cCBtZW1iZXIgdmFyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MTcyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6SGVhcCk6IEluaXRpYWxp emUgbV9ibG9ja0ZyZWVpbmdUaHJlYWRTaG91bGRRdWl0CisKIDIwMTEtMTEtMDQgIFl1cWlhbmcg WGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CiAKICAgICAgICAgTW9yZSBjb2RlIGNsZWFu LXVwIGluIERGRyAzMl82NApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv SGVhcC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAppbmRleCBlODA0 Y2ViLi5lOTc1ODc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFw LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcApAQCAtMzEyLDYg KzMxMiw3IEBAIEhlYXA6OkhlYXAoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhLCBIZWFwU2l6ZSBo ZWFwU2l6ZSkKICAgICAsIG1fbGFzdEZ1bGxHQ1NpemUoMCkKICAgICAsIG1fb3BlcmF0aW9uSW5Q cm9ncmVzcyhOb09wZXJhdGlvbikKICAgICAsIG1fb2JqZWN0U3BhY2UodGhpcykKKyAgICAsIG1f YmxvY2tGcmVlaW5nVGhyZWFkU2hvdWxkUXVpdChmYWxzZSkKICAgICAsIG1fZXh0cmFDb3N0KDAp CiAgICAgLCBtX21hcmtMaXN0U2V0KDApCiAgICAgLCBtX2FjdGl2aXR5Q2FsbGJhY2soRGVmYXVs dEdDQWN0aXZpdHlDYWxsYmFjazo6Y3JlYXRlKHRoaXMpKQo=