71720 2011-11-07 12:23:41 -0800 WebGLContextEvent.initEvent should be removed 2011-11-09 16:12:13 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dominicc dominicc abarth cmarrin dominicc kbr ojan sam webkit.review.bot zmo oldest_to_newest 497367 0 dominicc 2011-11-07 12:23:41 -0800 Per the spec here: <http://www.khronos.org/registry/webgl/specs/latest/#5.14> 497510 1 sam 2011-11-07 15:06:08 -0800 It would probably make more sense to just remove it, and get the spec updated. 498605 2 kbr 2011-11-08 19:08:33 -0800 (In reply to comment #1) > It would probably make more sense to just remove it, and get the spec updated. Agreed; however, the WebGL spec is being snapshotted, and this update may need to wait for the next version. It may make sense to update the WebKit implementation to track the current one while this is happening. Either way, applications shouldn't be accessing this constructor so any change is unlikely to affect real world apps. 498636 3 abarth 2011-11-08 21:24:45 -0800 We should delete it now so folks don't end up relying upon it. 499071 4 sam 2011-11-09 09:36:05 -0800 (In reply to comment #3) > We should delete it now so folks don't end up relying upon it. I agree. 499386 5 dominicc 2011-11-09 15:07:54 -0800 I will remove initEvent for now. The bug against the WebGL spec to use a constructor instead of initWebGLContextEvent is <http://www.khronos.org/bugzilla/show_bug.cgi?id=550>. Based on the outcome of this bug we can add a constructor or reinstitute this method with the correct name. 499399 6 114375 dominicc 2011-11-09 15:21:29 -0800 Created attachment 114375 Patch 499405 7 114375 abarth 2011-11-09 15:26:43 -0800 Comment on attachment 114375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114375&action=review > Source/WebCore/ChangeLog:13 > + No new tests--removing untested code. I see. 499421 8 114375 webkit.review.bot 2011-11-09 15:42:39 -0800 Comment on attachment 114375 Patch Rejecting attachment 114375 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 Source/WebKit/chromium: Fix crash by handling case when AccessibilityObject::lineForPosition When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 157. Full output: http://queues.webkit.org/results/10399126 499445 9 114375 webkit.review.bot 2011-11-09 16:12:08 -0800 Comment on attachment 114375 Patch Clearing flags on attachment: 114375 Committed r99780: <http://trac.webkit.org/changeset/99780> 499446 10 webkit.review.bot 2011-11-09 16:12:13 -0800 All reviewed patches have been landed. Closing bug. 114375 2011-11-09 15:21:29 -0800 2011-11-09 16:12:08 -0800 Patch bug-71720-20111109152128.patch text/plain 3307 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogOTk3NjQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZDZmZGNlOWE3MTY0N2Jh MDc1ZGE1ODc0YzA5MDU2MmE0ZDg2M2JjLi4yNzBiZTQ3Y2M1MzcyOWNlYzc0NmEwMmY3ODU0MDU5 OWExOWEzZTZiIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMTEtMDkgIERvbWlu aWMgQ29vbmV5ICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBXZWJH TENvbnRleHRFdmVudC5pbml0RXZlbnQgbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTcyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBXZWJHTCBzcGVjIGNhbGxzIHRoaXMgbWV0aG9kIGlu aXRXZWJHTENvbnRleHRFdmVudCwgYnV0IGl0IG1heQorICAgICAgICBhZG9wdCBhIGNvbnN0cnVj dG9yIGluc3RlYWQuIERlbGV0aW5nIHRoZSBpbml0RXZlbnQgbWV0aG9kIGZvciBub3cKKyAgICAg ICAgc2luY2UgaXQgaXMgZGVmaW5pdGVseSB3cm9uZyBhbmQgd2UgZG9uJ3Qgd2FudCBwZW9wbGUg dG8gY29tZSB0bworICAgICAgICBkZXBlbmQgb24gaXQuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LS1yZW1vdmluZyB1bnRlc3RlZCBjb2RlLgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xD b250ZXh0RXZlbnQuY3BwOgorICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMQ29udGV4dEV2ZW50 Lmg6CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xDb250ZXh0RXZlbnQuaWRsOgorCiAyMDEx LTExLTA5ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXBsYWNlIFtDYW5CZUNvbnN0cnVjdGVkXSBJREwgd2l0aCBbQ29uc3RydWN0b3JdIElETApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xDb250ZXh0RXZlbnQuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xDb250ZXh0RXZlbnQuY3BwCmluZGV4 IDYyMTE3MzhjMjE0M2Q5ZmQ0ZjBjZjkzYmJhZjM3NjdkZjQ5YzEwYWEuLmViZDNlNmExNmM0YmZl MTIzNDlmMTdlNmUyY2M2MDE2MzI3MTg1ZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMQ29udGV4dEV2ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTENvbnRleHRFdmVudC5jcHAKQEAgLTQ0LDE1ICs0NCw2IEBAIFdlYkdMQ29u dGV4dEV2ZW50Ojp+V2ViR0xDb250ZXh0RXZlbnQoKQogewogfQogCi12b2lkIFdlYkdMQ29udGV4 dEV2ZW50Ojppbml0RXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBib29sIGNhbkJ1YmJs ZSwgYm9vbCBjYW5jZWxhYmxlLCBjb25zdCBTdHJpbmcmIHN0YXR1c01lc3NhZ2UpCi17Ci0gICAg aWYgKGRpc3BhdGNoZWQoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgRXZlbnQ6OmluaXRFdmVu dCh0eXBlLCBjYW5CdWJibGUsIGNhbmNlbGFibGUpOwotICAgIG1fc3RhdHVzTWVzc2FnZSA9IHN0 YXR1c01lc3NhZ2U7Ci19Ci0KIGNvbnN0IEF0b21pY1N0cmluZyYgV2ViR0xDb250ZXh0RXZlbnQ6 OmludGVyZmFjZU5hbWUoKSBjb25zdAogewogICAgIHJldHVybiBldmVudE5hbWVzKCkuaW50ZXJm YWNlRm9yV2ViR0xDb250ZXh0RXZlbnQ7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1s L2NhbnZhcy9XZWJHTENvbnRleHRFdmVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xDb250ZXh0RXZlbnQuaAppbmRleCBiZGYzMjI1MzRhNGFkMDA5MGJmZGVlNjFlZWYzZmQ2 ZWU4MzJlYjM1Li5kNDZjMjIzNjMxODUzMGUyNTI2ZWIyNDIzYmI1NDFiN2JiODU4Mzc2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTENvbnRleHRFdmVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMQ29udGV4dEV2ZW50LmgKQEAgLTQy LDggKzQyLDYgQEAgcHVibGljOgogICAgIH0KICAgICB2aXJ0dWFsIH5XZWJHTENvbnRleHRFdmVu dCgpOwogCi0gICAgdm9pZCBpbml0RXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBib29s IGNhbkJ1YmJsZSwgYm9vbCBjYW5jZWxhYmxlLCBjb25zdCBTdHJpbmcmIHN0YXR1c01lc3NhZ2Up OwotCiAgICAgY29uc3QgU3RyaW5nJiBzdGF0dXNNZXNzYWdlKCkgY29uc3QgeyByZXR1cm4gbV9z dGF0dXNNZXNzYWdlOyB9CiAKICAgICB2aXJ0dWFsIGNvbnN0IEF0b21pY1N0cmluZyYgaW50ZXJm YWNlTmFtZSgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xDb250ZXh0RXZlbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xD b250ZXh0RXZlbnQuaWRsCmluZGV4IDhlNDY1OWMzNGIyMDM1NmZlMjRjZTMwNzhjNGZmZjAwZDIw NThmNmQuLmZkNmQ1M2QwNTVkYmE4OGMxYWQ5NTZiY2M2MjhjNGFhZDlkZDk2NWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMQ29udGV4dEV2ZW50LmlkbAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTENvbnRleHRFdmVudC5pZGwKQEAgLTI4 LDkgKzI4LDUgQEAgbW9kdWxlIGh0bWwgewogICAgICAgICBDb25kaXRpb25hbD1XRUJHTCwKICAg ICBdIFdlYkdMQ29udGV4dEV2ZW50IDogRXZlbnQgewogICAgICAgICByZWFkb25seSBhdHRyaWJ1 dGUgRE9NU3RyaW5nIHN0YXR1c01lc3NhZ2U7Ci0gICAgICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmdd IHZvaWQgaW5pdEV2ZW50KGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gRE9NU3Ry aW5nIGV2ZW50VHlwZUFyZywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBib29sZWFuIGNhbkJ1YmJs ZUFyZywKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09w dGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBib29sZWFuIGNhbmNlbGFibGVBcmcsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25hbD1DYWxs V2l0aERlZmF1bHRWYWx1ZV0gRE9NU3RyaW5nIHN0YXR1c01lc3NhZ2VBcmcpOwogICAgIH07CiB9 Cg==