71710 2011-11-07 11:11:40 -0800 Web Inspector: Suggest box should be open immediately if forced by Ctrl+Space. 2011-11-07 12:37:21 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 497309 0 vsevik 2011-11-07 11:11:40 -0800 Suggest box should be open immediately if forced by Ctrl+Space. 497312 1 113896 vsevik 2011-11-07 11:13:05 -0800 Created attachment 113896 Patch 497321 2 113896 pfeldman 2011-11-07 11:23:27 -0800 Comment on attachment 113896 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113896&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:297 > + if (this._completeImmediately) { There is no need for the additional timer. setTimeout(0) is likely to dispatch before the subsequent keyboard event. 497346 3 113903 vsevik 2011-11-07 11:47:06 -0800 Created attachment 113903 Patch 497381 4 vsevik 2011-11-07 12:37:21 -0800 Committed r99459: <http://trac.webkit.org/changeset/99459> 113896 2011-11-07 11:13:05 -0800 2011-11-07 11:46:57 -0800 Patch bug-71710-20111107231303.patch text/plain 2889 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTk0MzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNmYxZTdhZmEyZTQ3NjQw MWRlNTUzYTlmOGEzNWJhOWU2ZDcyNDAyLi44MmI1NDhmYzMwMTFkYWYyNGYwM2E3M2VkMmIzZTQy NmU1ZWMyZTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTEtMTEtMDcgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU3VnZ2VzdCBib3ggc2hvdWxkIGJlIG9wZW4gaW1tZWRpYXRlbHkgaWYgZm9yY2VkIGJ5IEN0 cmwrU3BhY2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MTcxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlRleHRQcm9tcHQucHJvdG90eXBlLmNsZWFyQ29tcGxldGVUaW1lb3V0cyk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUuY2xlYXJBdXRvQ29tcGxldGUpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlLmF1dG9Db21wbGV0ZVNv b24pOgorCisyMDExLTExLTA3ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3Jn PgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN1Z2dlc3QgYm94IHNob3VsZCBjb25zdW1lIGVu dGVyIGtleSBwcmVzc2VkIGV2ZW50LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzE3MDAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9UZXh0UHJvbXB0LmpzCmluZGV4IDAyY2NlYmVlZmVkOGU0MDVkYTY1MzhjMDc2MzU3 ODgzZWUwMDYyZmMuLjgwNmZhM2YwZjM2Mjg5MjVkNDc1MmI3OTQxMjIwNzU5N2NlNWFkZmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMK QEAgLTI5MiwxNSArMjkyLDI1IEBAIFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZSA9 IHsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAorICAgIGNsZWFyQ29tcGxldGVUaW1l b3V0czogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX2NvbXBsZXRlSW1tZWRp YXRlbHkpIHsKKyAgICAgICAgICAgIGNsZWFyVGltZW91dCh0aGlzLl9jb21wbGV0ZUltbWVkaWF0 ZWx5KTsKKyAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9jb21wbGV0ZUltbWVkaWF0ZWx5OworICAg ICAgICB9CisgICAgICAgIGlmICh0aGlzLl9jb21wbGV0ZVRpbWVvdXQpIHsKKyAgICAgICAgICAg IGNsZWFyVGltZW91dCh0aGlzLl9jb21wbGV0ZVRpbWVvdXQpOworICAgICAgICAgICAgZGVsZXRl IHRoaXMuX2NvbXBsZXRlVGltZW91dDsKKyAgICAgICAgfQorICAgIH0sCisgICAgICAgIAogICAg IC8qKgogICAgICAqIEBwYXJhbSB7Ym9vbGVhbj19IGluY2x1ZGVUaW1lb3V0CiAgICAgICovCiAg ICAgY2xlYXJBdXRvQ29tcGxldGU6IGZ1bmN0aW9uKGluY2x1ZGVUaW1lb3V0KQogICAgIHsKLSAg ICAgICAgaWYgKGluY2x1ZGVUaW1lb3V0ICYmICJfY29tcGxldGVUaW1lb3V0IiBpbiB0aGlzKSB7 Ci0gICAgICAgICAgICBjbGVhclRpbWVvdXQodGhpcy5fY29tcGxldGVUaW1lb3V0KTsKLSAgICAg ICAgICAgIGRlbGV0ZSB0aGlzLl9jb21wbGV0ZVRpbWVvdXQ7Ci0gICAgICAgIH0KKyAgICAgICAg aWYgKGluY2x1ZGVUaW1lb3V0KQorICAgICAgICAgICAgdGhpcy5jbGVhckNvbXBsZXRlVGltZW91 dHMoKTsKIAogICAgICAgICBpZiAoIXRoaXMuYXV0b0NvbXBsZXRlRWxlbWVudCkKICAgICAgICAg ICAgIHJldHVybjsKQEAgLTMzNSw4ICszNDUsMTggQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQu cHJvdG90eXBlID0gewogICAgICAqLwogICAgIGF1dG9Db21wbGV0ZVNvb246IGZ1bmN0aW9uKGZv cmNlKQogICAgIHsKLSAgICAgICAgaWYgKCEoIl9jb21wbGV0ZVRpbWVvdXQiIGluIHRoaXMpKQot ICAgICAgICAgICAgdGhpcy5fY29tcGxldGVUaW1lb3V0ID0gc2V0VGltZW91dCh0aGlzLmNvbXBs ZXRlLmJpbmQodGhpcywgdHJ1ZSwgZm9yY2UpLCB0aGlzLmlzU3VnZ2VzdEJveFZpc2libGUoKSA/ IDAgOiAyNTApOworICAgICAgICBpZiAodGhpcy5fY29tcGxldGVJbW1lZGlhdGVseSkKKyAgICAg ICAgICAgIHJldHVybjsKKworICAgICAgICB2YXIgaW1tZWRpYXRlbHkgPSB0aGlzLmlzU3VnZ2Vz dEJveFZpc2libGUoKSB8fCBmb3JjZTsKKyAgICAgICAgaWYgKGltbWVkaWF0ZWx5KSB7CisgICAg ICAgICAgICB0aGlzLmNsZWFyQ29tcGxldGVUaW1lb3V0cygpOworICAgICAgICAgICAgdGhpcy5f Y29tcGxldGVJbW1lZGlhdGVseSA9IHNldFRpbWVvdXQodGhpcy5jb21wbGV0ZS5iaW5kKHRoaXMs IHRydWUsIGZvcmNlKSwgMCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICAg ICAgCisgICAgICAgIGlmICghdGhpcy5fY29tcGxldGVUaW1lb3V0KQorICAgICAgICAgICAgdGhp cy5fY29tcGxldGVUaW1lb3V0ID0gc2V0VGltZW91dCh0aGlzLmNvbXBsZXRlLmJpbmQodGhpcywg dHJ1ZSwgZmFsc2UpLCAyNTApOwogICAgIH0sCiAKICAgICAvKioK 113903 2011-11-07 11:47:06 -0800 2011-11-07 12:32:07 -0800 Patch bug-71710-20111107234704.patch text/plain 2044 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTk0MzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNmYxZTdhZmEyZTQ3NjQw MWRlNTUzYTlmOGEzNWJhOWU2ZDcyNDAyLi5kY2FmNWYyNWFkNGFlMzE5NTYwZDJiYWViNGVjYzBl YTQxMWJiMmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTEtMTEtMDcgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU3VnZ2VzdCBib3ggc2hvdWxkIGJlIG9wZW4gaW1tZWRpYXRlbHkgaWYgZm9yY2VkIGJ5IEN0 cmwrU3BhY2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MTcxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLlRleHRQcm9tcHQucHJvdG90eXBlLmNsZWFyQXV0b0NvbXBsZXRlKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZS5hdXRvQ29tcGxldGVTb29uKToKKworMjAx MS0xMS0wNyAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KKwogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBTdWdnZXN0IGJveCBzaG91bGQgY29uc3VtZSBlbnRlciBrZXkgcHJl c3NlZCBldmVudC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcxNzAwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvVGV4dFByb21wdC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4 dFByb21wdC5qcwppbmRleCAwMmNjZWJlZWZlZDhlNDA1ZGE2NTM4YzA3NjM1Nzg4M2VlMDA2MmZj Li4yZjA3ZjA5MzUxNTNmNTIyMjBkNTZjNjQ1ZWIzZGIzYzQ0ZmRmNTY4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzCkBAIC0yOTcsNyAr Mjk3LDcgQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQucHJvdG90eXBlID0gewogICAgICAqLwog ICAgIGNsZWFyQXV0b0NvbXBsZXRlOiBmdW5jdGlvbihpbmNsdWRlVGltZW91dCkKICAgICB7Ci0g ICAgICAgIGlmIChpbmNsdWRlVGltZW91dCAmJiAiX2NvbXBsZXRlVGltZW91dCIgaW4gdGhpcykg eworICAgICAgICBpZiAoaW5jbHVkZVRpbWVvdXQgJiYgdGhpcy5fY29tcGxldGVUaW1lb3V0KSB7 CiAgICAgICAgICAgICBjbGVhclRpbWVvdXQodGhpcy5fY29tcGxldGVUaW1lb3V0KTsKICAgICAg ICAgICAgIGRlbGV0ZSB0aGlzLl9jb21wbGV0ZVRpbWVvdXQ7CiAgICAgICAgIH0KQEAgLTMzNSw4 ICszMzUsOSBAQCBXZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUgPSB7CiAgICAgICov CiAgICAgYXV0b0NvbXBsZXRlU29vbjogZnVuY3Rpb24oZm9yY2UpCiAgICAgewotICAgICAgICBp ZiAoISgiX2NvbXBsZXRlVGltZW91dCIgaW4gdGhpcykpCi0gICAgICAgICAgICB0aGlzLl9jb21w bGV0ZVRpbWVvdXQgPSBzZXRUaW1lb3V0KHRoaXMuY29tcGxldGUuYmluZCh0aGlzLCB0cnVlLCBm b3JjZSksIHRoaXMuaXNTdWdnZXN0Qm94VmlzaWJsZSgpID8gMCA6IDI1MCk7CisgICAgICAgIHZh ciBpbW1lZGlhdGVseSA9IHRoaXMuaXNTdWdnZXN0Qm94VmlzaWJsZSgpIHx8IGZvcmNlOworICAg ICAgICBpZiAoIXRoaXMuX2NvbXBsZXRlVGltZW91dCkKKyAgICAgICAgICAgIHRoaXMuX2NvbXBs ZXRlVGltZW91dCA9IHNldFRpbWVvdXQodGhpcy5jb21wbGV0ZS5iaW5kKHRoaXMsIHRydWUsIGZv cmNlKSwgaW1tZWRpYXRlbHkgPyAwIDogMjUwKTsKICAgICB9LAogCiAgICAgLyoqCg==