7171 2006-02-09 21:51:55 -0800 No description in WebKitErrors.m for WebKitErrorPlugInWillHandleLoad 2006-02-25 05:32:47 -0800 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 1 ddkilzer ddkilzer jordan.breeding justin.garcia oldest_to_newest 32003 0 ddkilzer 2006-02-09 21:51:55 -0800 While fixing Bug 7145, I noticed that there was no description in WebKitErrors.m for WebKitErrorPlugInWillHandleLoad (as defined in WebKitErrorsPrivate.h). Per discussion with xenon on IRC, this should have been added. WebKitErrorPlugInWillHandleLoad was added to WebkitErrorsPrivate.h in r10537 from the anonsvn repository. 32004 1 6380 ddkilzer 2006-02-09 22:17:47 -0800 Created attachment 6380 Patch v1 Trivial patch to add the description and dictionary entry to WebKitErrors.m. I'm assuming there may be a different description that you want to use. :) 32031 2 6380 darin 2006-02-10 08:45:32 -0800 Comment on attachment 6380 Patch v1 I think John Sullivan should look this one over. Is this really the string we want? When is it displayed? We may want to improve the descriptive messages for localizers for all of those errors to help make it clear how to see them in, say, the Safari UI. 32043 3 6380 sullivan 2006-02-10 09:54:51 -0800 Comment on attachment 6380 Patch v1 This particular error code is an unusual one in that it doesn't really signify an error, but the rest of the code behaves as if an error occurred. Currently Safari goes out of its way to show no error text at all for this case. But this still isn't quite right, because the status bar and Activity window still count the error, so you see "1 error" when the load is actually successful. This broader problem was in Radar, and I've just added it to Bugzilla as bug 7176. These descriptions generally appear in Safari in the Activity window (but this one is special-cased to not appear, as I said). They also appear in Safari in the page that's displayed when a URL can't be reached, if Safari has not supplied a specific message for that error number. In this particular case, I believe that WebKitErrorDescriptionPlugInWillHandleLoad doesn't occur for main pages, so the error description would never appear in the latter context. So the new error description here would never appear in Safari. However, it might appear in other WebKit clients. Depending on whether and how 7176 is eventually addressed, this error code might be eliminated. However, in the meantime I see no harm in providing a string here, for the benefit of clients other than Safari. Brevity really pays off for these messages since they might be displayed in a context (e.g. Activity window) where space is tight, so I'd suggest "Plug-in handled load" rather than "Plug-in will handle load". I'm not that excited about using "load" here as a noun, but I can't think of anything obviously better. I see Darin's point that the localizer comments could be improved. Currently they are all of the form "WebKitErrorXXX description". They would be better if they clarified when this type of error occurred, but only if this can be done briefly and without just repeating the words that are already part of the error name. I don't think doing that is necessary for committing this bug fix. Also, since this modifies localized strings, you need to run update-webkit-localizable-strings and patch Localizable.strings as well as this file. So review- for now just to get the shorter string and to run update-webkit-localizable-strings. 32065 4 sullivan 2006-02-10 12:51:33 -0800 Ignore the part about update-webkit-localizable-strings. Until that procedure is documented, the person checking in the fix will have to worry about this step. So as long as you're happy with the shorter string I suggest here, I'll change this to review+ and check it in. Let me know. 32116 5 6412 ddkilzer 2006-02-11 07:54:42 -0800 Created attachment 6412 Patch v2 Updates from Patch v1: - Shortened UI_String for WebKitErrorDescriptionPlugInWillHandleLoad. - Ran update-webkit-localizable-strings before preparing ChangeLog (although because the file is considered binary, it's not included in the patch). Don't forget to run update-webkit-localizable-strings before committing! :) 32117 6 6412 sullivan 2006-02-11 08:00:25 -0800 Comment on attachment 6412 Patch v2 I'll check this in (and update localizable strings). 33956 7 ddkilzer 2006-02-25 05:32:47 -0800 Verified by visual inspection of the code. 6380 2006-02-09 22:17:47 -0800 2006-02-11 07:54:42 -0800 Patch v1 bug-7171-v1.diff text/plain 2098 ddkilzer SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTI3MjcpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTMgQEAKKzIwMDYtMDItMTAgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtpbHplci5u ZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBG aXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD03MTcxCisg ICAgICAgIE5vIGRlc2NyaXB0aW9uIGluIFdlYktpdEVycm9ycy5tIGZvciBXZWJLaXRFcnJvclBs dWdJbldpbGxIYW5kbGVMb2FkCisKKyAgICAgICAgKiBNaXNjL1dlYktpdEVycm9ycy5tOiBBZGRl ZCAjZGVmaW5lIGZvciBkZXNjcmlwdGlvbi4KKyAgICAgICAgKHJlZ2lzdGVyRXJyb3JzKTogQWRk ZWQgZGljdGlvbmFyeSBlbnRyeS4KKwogMjAwNi0wMi0wOSAgVGltIE9tZXJuaWNrICA8dGltb0Bh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhhdGNoZXIuCkluZGV4OiBXZWJL aXQvTWlzYy9XZWJLaXRFcnJvcnMubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvTWlzYy9XZWJLaXRF cnJvcnMubQkocmV2aXNpb24gMTI3MjcpCisrKyBXZWJLaXQvTWlzYy9XZWJLaXRFcnJvcnMubQko d29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsNyBAQCBOU1N0cmluZyAqIGNvbnN0IFdlYktpdEVy cm9yUGx1Z0luUGFnZVVSCiAjZGVmaW5lIFdlYktpdEVycm9yRGVzY3JpcHRpb25DYW5ub3RMb2Fk UGx1Z2luIFVJX1NUUklORygiQ2Fubm90IGxvYWQgcGx1Zy1pbiIsICJXZWJLaXRFcnJvckNhbm5v dExvYWRQbHVnaW4gZGVzY3JpcHRpb24iKQogI2RlZmluZSBXZWJLaXRFcnJvckRlc2NyaXB0aW9u SmF2YVVuYXZhaWxhYmxlIFVJX1NUUklORygiSmF2YSBpcyB1bmF2YWlsYWJsZSIsICJXZWJLaXRF cnJvckphdmFVbmF2YWlsYWJsZSBkZXNjcmlwdGlvbiIpCiAjZGVmaW5lIFdlYktpdEVycm9yRGVz Y3JpcHRpb25QbHVnSW5DYW5jZWxsZWRDb25uZWN0aW9uIFVJX1NUUklORygiUGx1Zy1pbiBjYW5j ZWxsZWQiLCAiV2ViS2l0RXJyb3JQbHVnSW5DYW5jZWxsZWRDb25uZWN0aW9uIGRlc2NyaXB0aW9u IikKKyNkZWZpbmUgV2ViS2l0RXJyb3JEZXNjcmlwdGlvblBsdWdJbldpbGxIYW5kbGVMb2FkIFVJ X1NUUklORygiUGx1Zy1pbiB3aWxsIGhhbmRsZSBsb2FkIiwgIldlYktpdEVycm9yUGx1Z0luV2ls bEhhbmRsZUxvYWQgZGVzY3JpcHRpb24iKQogCiBzdGF0aWMgcHRocmVhZF9vbmNlX3QgcmVnaXN0 ZXJFcnJvcnNDb250cm9sID0gUFRIUkVBRF9PTkNFX0lOSVQ7CiBzdGF0aWMgdm9pZCByZWdpc3Rl ckVycm9ycyh2b2lkKTsKQEAgLTE1MSw2ICsxNTIsNyBAQCBzdGF0aWMgdm9pZCByZWdpc3RlckVy cm9ycygpCiAgICAgICAgIFdlYktpdEVycm9yRGVzY3JpcHRpb25DYW5ub3RMb2FkUGx1Z2luLAkJ W05TTnVtYmVyIG51bWJlcldpdGhJbnQ6IFdlYktpdEVycm9yQ2Fubm90TG9hZFBsdWdJbl0sCiAg ICAgICAgIFdlYktpdEVycm9yRGVzY3JpcHRpb25KYXZhVW5hdmFpbGFibGUsCQlbTlNOdW1iZXIg bnVtYmVyV2l0aEludDogV2ViS2l0RXJyb3JKYXZhVW5hdmFpbGFibGVdLAogICAgICAgICBXZWJL aXRFcnJvckRlc2NyaXB0aW9uUGx1Z0luQ2FuY2VsbGVkQ29ubmVjdGlvbixbTlNOdW1iZXIgbnVt YmVyV2l0aEludDogV2ViS2l0RXJyb3JQbHVnSW5DYW5jZWxsZWRDb25uZWN0aW9uXSwKKyAgICAg ICAgV2ViS2l0RXJyb3JEZXNjcmlwdGlvblBsdWdJbldpbGxIYW5kbGVMb2FkLCAgICAgW05TTnVt YmVyIG51bWJlcldpdGhJbnQ6IFdlYktpdEVycm9yUGx1Z0luV2lsbEhhbmRsZUxvYWRdLAogICAg ICAgICBuaWxdOwogCiAgICAgW05TRXJyb3IgX3dlYmtpdF9hZGRFcnJvcnNXaXRoQ29kZXNBbmRE ZXNjcmlwdGlvbnM6ZGljdCBpbkRvbWFpbjpXZWJLaXRFcnJvckRvbWFpbl07Cg== 6412 2006-02-11 07:54:42 -0800 2006-02-11 08:00:25 -0800 Patch v2 bug-7171-v2.diff text/plain 2163 ddkilzer SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTI3NTMpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMDYtMDItMTEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtpbHplci5u ZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLSBG aXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD03MTcxCisg ICAgICAgIE5vIGRlc2NyaXB0aW9uIGluIFdlYktpdEVycm9ycy5tIGZvciBXZWJLaXRFcnJvclBs dWdJbldpbGxIYW5kbGVMb2FkCisKKyAgICAgICAgKiBFbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxl LnN0cmluZ3M6IEFkZGVkIG5ldyBVSV9TVFJJTkcoKS4KKyAgICAgICAgKiBNaXNjL1dlYktpdEVy cm9ycy5tOiBBZGRlZCAjZGVmaW5lIGZvciBkZXNjcmlwdGlvbi4KKyAgICAgICAgKHJlZ2lzdGVy RXJyb3JzKTogQWRkZWQgZGljdGlvbmFyeSBlbnRyeS4KKwogMjAwNi0wMi0wOSAgVGltIE9tZXJu aWNrICA8dGltb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhhdGNoZXIu CkluZGV4OiBXZWJLaXQvTWlzYy9XZWJLaXRFcnJvcnMubQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv TWlzYy9XZWJLaXRFcnJvcnMubQkocmV2aXNpb24gMTI3NTMpCisrKyBXZWJLaXQvTWlzYy9XZWJL aXRFcnJvcnMubQkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsNyBAQCBOU1N0cmluZyAqIGNv bnN0IFdlYktpdEVycm9yUGx1Z0luUGFnZVVSCiAjZGVmaW5lIFdlYktpdEVycm9yRGVzY3JpcHRp b25DYW5ub3RMb2FkUGx1Z2luIFVJX1NUUklORygiQ2Fubm90IGxvYWQgcGx1Zy1pbiIsICJXZWJL aXRFcnJvckNhbm5vdExvYWRQbHVnaW4gZGVzY3JpcHRpb24iKQogI2RlZmluZSBXZWJLaXRFcnJv ckRlc2NyaXB0aW9uSmF2YVVuYXZhaWxhYmxlIFVJX1NUUklORygiSmF2YSBpcyB1bmF2YWlsYWJs ZSIsICJXZWJLaXRFcnJvckphdmFVbmF2YWlsYWJsZSBkZXNjcmlwdGlvbiIpCiAjZGVmaW5lIFdl YktpdEVycm9yRGVzY3JpcHRpb25QbHVnSW5DYW5jZWxsZWRDb25uZWN0aW9uIFVJX1NUUklORygi UGx1Zy1pbiBjYW5jZWxsZWQiLCAiV2ViS2l0RXJyb3JQbHVnSW5DYW5jZWxsZWRDb25uZWN0aW9u IGRlc2NyaXB0aW9uIikKKyNkZWZpbmUgV2ViS2l0RXJyb3JEZXNjcmlwdGlvblBsdWdJbldpbGxI YW5kbGVMb2FkIFVJX1NUUklORygiUGx1Zy1pbiBoYW5kbGVkIGxvYWQiLCAiV2ViS2l0RXJyb3JQ bHVnSW5XaWxsSGFuZGxlTG9hZCBkZXNjcmlwdGlvbiIpCiAKIHN0YXRpYyBwdGhyZWFkX29uY2Vf dCByZWdpc3RlckVycm9yc0NvbnRyb2wgPSBQVEhSRUFEX09OQ0VfSU5JVDsKIHN0YXRpYyB2b2lk IHJlZ2lzdGVyRXJyb3JzKHZvaWQpOwpAQCAtMTUxLDYgKzE1Miw3IEBAIHN0YXRpYyB2b2lkIHJl Z2lzdGVyRXJyb3JzKCkKICAgICAgICAgV2ViS2l0RXJyb3JEZXNjcmlwdGlvbkNhbm5vdExvYWRQ bHVnaW4sCQlbTlNOdW1iZXIgbnVtYmVyV2l0aEludDogV2ViS2l0RXJyb3JDYW5ub3RMb2FkUGx1 Z0luXSwKICAgICAgICAgV2ViS2l0RXJyb3JEZXNjcmlwdGlvbkphdmFVbmF2YWlsYWJsZSwJCVtO U051bWJlciBudW1iZXJXaXRoSW50OiBXZWJLaXRFcnJvckphdmFVbmF2YWlsYWJsZV0sCiAgICAg ICAgIFdlYktpdEVycm9yRGVzY3JpcHRpb25QbHVnSW5DYW5jZWxsZWRDb25uZWN0aW9uLFtOU051 bWJlciBudW1iZXJXaXRoSW50OiBXZWJLaXRFcnJvclBsdWdJbkNhbmNlbGxlZENvbm5lY3Rpb25d LAorICAgICAgICBXZWJLaXRFcnJvckRlc2NyaXB0aW9uUGx1Z0luV2lsbEhhbmRsZUxvYWQsICAg ICBbTlNOdW1iZXIgbnVtYmVyV2l0aEludDogV2ViS2l0RXJyb3JQbHVnSW5XaWxsSGFuZGxlTG9h ZF0sCiAgICAgICAgIG5pbF07CiAKICAgICBbTlNFcnJvciBfd2Via2l0X2FkZEVycm9yc1dpdGhD b2Rlc0FuZERlc2NyaXB0aW9uczpkaWN0IGluRG9tYWluOldlYktpdEVycm9yRG9tYWluXTsK