71706 2011-11-07 10:46:44 -0800 Web Inspector: Suggest box should not accept suggestion on space key pressed. 2011-11-07 12:09:58 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 497290 0 vsevik 2011-11-07 10:46:44 -0800 Suggest box should not accept suggestion on space key pressed. Space is not a typical way to commit auto-complete suggestion and more importantly this interferes with "just typing commands in console". When I type space I usually just mean space. 497293 1 113891 vsevik 2011-11-07 10:50:33 -0800 Created attachment 113891 Patch 497353 2 vsevik 2011-11-07 12:09:58 -0800 Committed r99453: <http://trac.webkit.org/changeset/99453> 113891 2011-11-07 10:50:33 -0800 2011-11-07 10:57:50 -0800 Patch bug-71706-20111107225030.patch text/plain 1983 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTk0MzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNmYxZTdhZmEyZTQ3NjQw MWRlNTUzYTlmOGEzNWJhOWU2ZDcyNDAyLi5mYmQwMGFhMDM3MzY2MzI5ODBlNzlmMmU1NWI5ZGJk MjQ2MDQwMjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTEtMTEtMDcgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU3VnZ2VzdCBib3ggc2hvdWxkIG5vdCBhY2NlcHQgc3VnZ2VzdGlvbiBvbiBzcGFjZSBrZXkg cHJlc3NlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTcxNzA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGV4dFByb21wdC5wcm90b3R5cGUub25LZXlEb3duKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UZXh0UHJvbXB0LlN1Z2dlc3RCb3gucHJvdG90eXBlLnRhYktleVByZXNzZWQpOgorCisyMDEx LTExLTA3ICBWc2V2b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IFN1Z2dlc3QgYm94IHNob3VsZCBjb25zdW1lIGVudGVyIGtleSBwcmVz c2VkIGV2ZW50LgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzE3MDAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9UZXh0UHJvbXB0LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0 UHJvbXB0LmpzCmluZGV4IDAyY2NlYmVlZmVkOGU0MDVkYTY1MzhjMDc2MzU3ODgzZWUwMDYyZmMu LjM0MDAyNDVjMzA4YjI3ZTlmODUzNWEyNDhmMjViZGY3MTM4ZWI5NWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKQEAgLTI0Niw4ICsy NDYsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAg ICBpZiAodGhpcy5fc3VnZ2VzdEZvcmNlYWJsZSAmJiBldmVudC5jdHJsS2V5ICYmICFldmVudC5t ZXRhS2V5ICYmICFldmVudC5hbHRLZXkgJiYgIWV2ZW50LnNoaWZ0S2V5KSB7CiAgICAgICAgICAg ICAgICAgdGhpcy5kZWZhdWx0S2V5SGFuZGxlcihldmVudCwgdHJ1ZSk7CiAgICAgICAgICAgICAg ICAgaGFuZGxlZCA9IHRydWU7Ci0gICAgICAgICAgICB9IGVsc2UgaWYgKHRoaXMuaXNTdWdnZXN0 Qm94VmlzaWJsZSgpKQotICAgICAgICAgICAgICAgIGhhbmRsZWQgPSB0aGlzLl9zdWdnZXN0Qm94 LnNwYWNlS2V5UHJlc3NlZChldmVudCk7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBicmVh azsKICAgICAgICAgY2FzZSAiQWx0IjoKICAgICAgICAgY2FzZSAiTWV0YSI6CkBAIC0xMDg1LDEx ICsxMDg0LDUgQEAgV2ViSW5zcGVjdG9yLlRleHRQcm9tcHQuU3VnZ2VzdEJveC5wcm90b3R5cGUg PSB7CiAgICAgdGFiS2V5UHJlc3NlZDogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAgICAgICBy ZXR1cm4gdGhpcy5lbnRlcktleVByZXNzZWQoZXZlbnQpOwotICAgIH0sCi0KLSAgICBzcGFjZUtl eVByZXNzZWQ6IGZ1bmN0aW9uKGV2ZW50KQotICAgIHsKLSAgICAgICAgdGhpcy5hY2NlcHRTdWdn ZXN0aW9uKCk7Ci0gICAgICAgIHJldHVybiBmYWxzZTsgLy8gRG8gbm90IGluaGliaXQgYSB3aGl0 ZXNwYWNlIGVudHJ5IGFmdGVyIHRoZSBzdWdnZXN0aW9uLgogICAgIH0KIH0K