<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>71697</bug_id>
          
          <creation_ts>2011-11-07 09:01:39 -0800</creation_ts>
          <short_desc>build-webkit --install-headers no longer installs QtWebKit headers</short_desc>
          <delta_ts>2011-11-10 03:42:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>71222</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Andrew Wason">rectalogic</reporter>
          <assigned_to name="Tor Arne Vestbø">vestbo</assigned_to>
          <cc>vestbo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>497213</commentid>
    <comment_count>0</comment_count>
    <who name="Andrew Wason">rectalogic</who>
    <bug_when>2011-11-07 09:01:39 -0800</bug_when>
    <thetext>Building webkit with:

cd /home/aw/Projects/foundation/webkit
Tools/Scripts/build-webkit --qt --debug --makeargs=-j20 --3d-canvas --3d-rendering --no-video --no-geolocation --no-netscape-plugin --install-headers=/home/aw/Projects/foundation/qt480/include --install-libs=/home/aw/Projects/foundation/qt480/lib
cd WebKitBuild/Debug
make &amp;&amp; make install

no longer installs QtWebKit headers.

The relevant section of &quot;make install&quot; output seems to be:

[...]
make -f Makefile.QtWebKit.api install
make[2]: Entering directory `/home/aw/Projects/foundation/webkit/WebKitBuild/Debug/Source&apos;
perl /home/aw/Projects/foundation/webkit/Tools/qmake/syncqt-4.8 -outdir /home/aw/Projects/foundation/webkit/WebKitBuild/Debug -separate-module QtWebKit:/home/aw/Projects/foundation/webkit:Source/WebKit/qt/Api
install -m 644 -p /home/aw/Projects/foundation/webkit/Tools/qmake/qt_webkit.pri /home/aw/Projects/foundation/qt480/mkspecs/modules/
install -m 755 -p &quot;../lib/libQtWebKit.so.4.10.0&quot; &quot;/home/aw/Projects/foundation/qt480/lib/libQtWebKit.so.4.10.0&quot;
ln -f -s &quot;libQtWebKit.so.4.10.0&quot; &quot;/home/aw/Projects/foundation/qt480/lib/libQtWebKit.so&quot;
ln -f -s &quot;libQtWebKit.so.4.10.0&quot; &quot;/home/aw/Projects/foundation/qt480/lib/libQtWebKit.so.4&quot;
ln -f -s &quot;libQtWebKit.so.4.10.0&quot; &quot;/home/aw/Projects/foundation/qt480/lib/libQtWebKit.so.4.10&quot;
install -m 644 -p &quot;../lib/libQtWebKit.prl&quot; &quot;/home/aw/Projects/foundation/qt480/lib/libQtWebKit.prl&quot;
sed -e &quot;s,/home/aw/Projects/foundation/webkit/WebKitBuild/Debug/lib,/home/aw/Projects/foundation/qt480/lib,g&quot; &quot;../lib/pkgconfig/QtWebKit.pc&quot; &gt;&quot;/home/aw/Projects/foundation/qt480/lib/pkgconfig/QtWebKit.pc&quot;
make[2]: Leaving directory `/home/aw/Projects/foundation/webkit/WebKitBuild/Debug/Source&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497908</commentid>
    <comment_count>1</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2011-11-08 03:32:25 -0800</bug_when>
    <thetext>Fixed in r99542</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>498184</commentid>
    <comment_count>2</comment_count>
    <who name="Andrew Wason">rectalogic</who>
    <bug_when>2011-11-08 10:06:27 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; Fixed in r99542

The header files are installed now, but they are incorrect relative references.

e.g. in my case /home/aw/Projects/foundation/qt480/include/QtWebKit/QWebPage contains:

#include &quot;qwebpage.h&quot;

and /home/aw/Projects/foundation/qt480/include/QtWebKit/qwebpage.h contains:

#include &quot;../../../../Source/WebKit/qt/Api/qwebpage.h&quot;

which appears to be a broken reference to a file within my webkit source directory.


In file included from ../../../qt480/include/QtWebKit/QWebView:1,
                 from threadcrash.h:2,
                 from main.cpp:3:
../../../qt480/include/QtWebKit/qwebview.h:1:55: error: ../../../../Source/WebKit/qt/Api/qwebview.h: No such file or directory</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>498260</commentid>
    <comment_count>3</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2011-11-08 11:02:08 -0800</bug_when>
    <thetext>Reopening</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>499113</commentid>
    <comment_count>4</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2011-11-09 10:12:37 -0800</bug_when>
    <thetext>This prospective patch should fix it

https://gist.github.com/1352315

I&apos;ll land it tomorrow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>499123</commentid>
    <comment_count>5</comment_count>
    <who name="Andrew Wason">rectalogic</who>
    <bug_when>2011-11-09 10:36:59 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; This prospective patch should fix it
&gt; 
&gt; https://gist.github.com/1352315

Thanks, that fixes it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>499768</commentid>
    <comment_count>6</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2011-11-10 03:42:16 -0800</bug_when>
    <thetext>Landed in r99832</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>