71688 2011-11-07 07:53:13 -0800 nrwt pixeltests crash while test in WK2 2012-06-18 15:12:41 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 79668 88680 1 rtakacs rafael.lobo abecsi dpranke feherzs kbalazs loki ossy rafael.lobo tony webkit-sed zoltan oldest_to_newest 497168 0 rtakacs 2011-11-07 07:53:13 -0800 I tried run nrwt but it crashed with the -p switch. Crash log the following: worker/0 raised TypeError('must be string or buffer, not bool'): layout_tests/controllers/worker.py:91 (in run) self._worker_connection.run_message_loop() layout_tests/controllers/message_broker.py:191 (in run_message_loop) self._broker.run_message_loop(self._run_topic, self._client, delay_secs) layout_tests/controllers/message_broker.py:127 (in run_message_loop) self._run_loop(topic_name, client, block=True, delay_secs=delay_secs) layout_tests/controllers/message_broker.py:141 (in _run_loop) self._dispatch_message(msg, client) layout_tests/controllers/message_broker.py:150 (in _dispatch_message) message_handler(message.src, *optargs) layout_tests/controllers/worker.py:111 (in handle_test_list) self._run_test(test_input) layout_tests/controllers/worker.py:126 (in _run_test) result = self.run_test_with_timeout(test_input, test_timeout_sec) layout_tests/controllers/worker.py:165 (in run_test_with_timeout) return self._run_test_in_this_thread(test_input) layout_tests/controllers/worker.py:250 (in _run_test_in_this_thread) return self.run_single_test(self._driver, test_input) layout_tests/controllers/worker.py:254 (in run_single_test) test_input, driver, self._name) layout_tests/controllers/single_test_runner.py:46 (in run_single_test) return runner.run() layout_tests/controllers/single_test_runner.py:121 (in run) return self._run_reftest() layout_tests/controllers/single_test_runner.py:290 (in _run_reftest) test_result_writer.write_test_result(self._port, self._test_name, driver_output1, driver_output2, test_result.failures) layout_tests/layout_package/test_result_writer.py:75 (in write_test_result) writer.write_image_diff_files(image_diff) layout_tests/layout_package/test_result_writer.py:208 (in write_image_diff_files) fs.write_binary_file(diff_filename, image_diff) common/system/filesystem.py:205 (in write_binary_file) f.write(contents) In my opinion with the --tolerance switch doesn't run the pixel tests on WK2. 497984 1 rtakacs 2011-11-08 05:39:27 -0800 General specification: CPU: Intel(R) Core(TM) i5-2320 CPU @ 3.00GHz RAM: 4 GB GPU: GeForce GT 440, 1 GB memory OS: Linux Ubuntu ----- My WebKit revision is 99400 (hash: 09a4c196f864ce8ca268cc1565cb408a55af0045) WK2 is built with Qt5. My Qt 5 hash code: 90f7cf110710bb59c2993d6d1848223baeb9642b ----- Experiences: When I want to run the WK2 pixel test [command: run-webkit-tests -2 -p], it starts at 43% and it runs to 60%, when it crashes with the wrote errors. When I use --tolerace switch [ command: run-webkit-tests -2 -p --tolerance 1 ], it doesn't run the pixel tests on WK2, but with this switch, it crashes as well... (it breaks at 60% as well...) 497999 2 abecsi 2011-11-08 06:05:26 -0800 (In reply to comment #1) > When I want to run the WK2 pixel test [command: run-webkit-tests -2 -p], it starts at 43% and it runs to 60%, when it crashes with the wrote errors. > Try using the --verbose switch, which might give you more information (than the percentage) on which tests crash. 498024 3 rtakacs 2011-11-08 07:02:43 -0800 This test caused the crash: editing/pasteboard/data-transfer-items-image-png.html If I skipped that, the pixel test works! 498705 4 loki 2011-11-09 00:47:02 -0800 (In reply to comment #3) > This test caused the crash: editing/pasteboard/data-transfer-items-image-png.html > If I skipped that, the pixel test works! I can confirm that behaviour! We should skip this test until a NRWT expert fix this issue! 498726 5 114226 rtakacs 2011-11-09 01:32:13 -0800 Created attachment 114226 skipped one test to solve the problem 498734 6 114226 abecsi 2011-11-09 01:47:35 -0800 Comment on attachment 114226 skipped one test to solve the problem View in context: https://bugs.webkit.org/attachment.cgi?id=114226&action=review > LayoutTests/platform/qt-5.0/Skipped:1556 > +editing/pasteboard/data-transfer-items-image-png.html Would be good to have a comment for this entry refering to the bug URL, so we do not lose this information between all the skipped editing tests. 498735 7 114226 loki 2011-11-09 01:52:43 -0800 Comment on attachment 114226 skipped one test to solve the problem View in context: https://bugs.webkit.org/attachment.cgi?id=114226&action=review > LayoutTests/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + * platform/qt-5.0/Skipped: add to skipped: editing/pasteboard/data-transfer-items-image-png.html You should mention the reason in the ChangeLog file why you are putting this test to the Skipped list. 498756 8 114229 rtakacs 2011-11-09 02:41:57 -0800 Created attachment 114229 it solves the nrwt pixel test crash 498810 9 114244 rtakacs 2011-11-09 04:08:43 -0800 Created attachment 114244 nrwt pixeltest crash in WK2 resolved 498820 10 114244 zherczeg 2011-11-09 04:32:25 -0800 Comment on attachment 114244 nrwt pixeltest crash in WK2 resolved r=me 498828 11 114244 loki 2011-11-09 04:44:47 -0800 Comment on attachment 114244 nrwt pixeltest crash in WK2 resolved The skip patch is landed: http://trac.webkit.org/changeset/99687 645609 12 ossy 2012-06-10 12:54:19 -0700 Reopen, because the test is still in skipped list. 648638 13 dpranke 2012-06-13 18:01:34 -0700 Can someone confirm whether or not there is an actual problem in NRWT and we still get python crashes? 651563 14 rafael.lobo 2012-06-18 11:26:13 -0700 I'll take a look. 651781 15 rafael.lobo 2012-06-18 15:12:41 -0700 No longer crashing. The test editing/pasteboard/data-transfer-items-image-png.html still fails on qt, but for a different reason (different results). I'm closing this bug and reporting another one to keep track of that failure. 114226 2011-11-09 01:32:13 -0800 2011-11-09 04:08:43 -0800 skipped one test to solve the problem 20111109.patch text/plain 1182 rtakacs ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MzYxOTU1Li43ZGM4NzNhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTEt MDkgIFJvbGFuZCBUYWthY3MgIDx0YWthY3Mucm9sYW5kQHN0dWQudS1zemVnZWQuaHU+CisKKyAg ICAgICAgbnJ3dCBwaXhlbHRlc3RzIGNyYXNoIHdoaWxlIHRlc3QgaW4gV0syCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTY4OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vcXQtNS4wL1Nr aXBwZWQ6IGFkZCB0byBza2lwcGVkOiBlZGl0aW5nL3Bhc3RlYm9hcmQvZGF0YS10cmFuc2Zlci1p dGVtcy1pbWFnZS1wbmcuaHRtbAorCiAyMDExLTExLTA3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCB1bmtpcCBhIHdvcmtpbmcg dGVzdCBhbmQgcmVjbGFzc2lmeSB0aGUgd2hlZWxldmVudCBtaXNzaW5nIERSVCBmZWF0dXJlcy4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC9Ta2lwcGVkIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQKaW5kZXggZDBkYTc0NS4uMDQ4M2NjNSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQKQEAgLTE1NTMsNiArMTU1Myw3IEBAIGVkaXRp bmcvcGFzdGVib2FyZC81NzgwNjk3LTIuaHRtbAogZWRpdGluZy9wYXN0ZWJvYXJkLzc5NTUuaHRt bAogZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktY3Jhc2guaHRtbAogZWRpdGluZy9wYXN0ZWJvYXJk L2NvcHktaW4tcGFzc3dvcmQtZmllbGQuaHRtbAorZWRpdGluZy9wYXN0ZWJvYXJkL2RhdGEtdHJh bnNmZXItaXRlbXMtaW1hZ2UtcG5nLmh0bWwKIGVkaXRpbmcvcGFzdGVib2FyZC9kaXNwbGF5LWJs b2NrLW9uLXNwYW5zLmh0bWwKIGVkaXRpbmcvcGFzdGVib2FyZC9pbnB1dC1maWVsZC0xLmh0bWwK IGVkaXRpbmcvcGFzdGVib2FyZC9tZXJnZS1lbmQtbGlzdC0yLmh0bWwK 114229 2011-11-09 02:41:57 -0800 2011-11-09 04:08:43 -0800 it solves the nrwt pixel test crash 20111109.patch text/plain 1233 rtakacs ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MzYxOTU1Li41ZTUxZGRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEt MDkgIFJvbGFuZCBUYWthY3MgIDx0YWthY3Mucm9sYW5kQHN0dWQudS1zemVnZWQuaHU+CisKKyAg ICAgICAgbnJ3dCBwaXhlbHRlc3RzIGNyYXNoIHdoaWxlIHRlc3QgaW4gV0syCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTY4OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vcXQtNS4wL1Nr aXBwZWQ6CisgICAgICAgICdlZGl0aW5nL3Bhc3RlYm9hcmQvZGF0YS10cmFuc2Zlci1pdGVtcy1p bWFnZS1wbmcuaHRtbCcgaXMgc2tpcHBlZCwgYmVjYXVzZSBpdCBjYXVzZWQgYW4gbnJ3dCBwaXhl bCB0ZXN0IGNyYXNoLgorCiAyMDExLTExLTA3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRA aWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCB1bmtpcCBhIHdvcmtpbmcgdGVzdCBh bmQgcmVjbGFzc2lmeSB0aGUgd2hlZWxldmVudCBtaXNzaW5nIERSVCBmZWF0dXJlcy4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQtNS4wL1NraXBwZWQKaW5kZXggZDBkYTc0NS4uMDQ4M2NjNSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vcXQtNS4wL1NraXBwZWQKQEAgLTE1NTMsNiArMTU1Myw3IEBAIGVkaXRpbmcvcGFz dGVib2FyZC81NzgwNjk3LTIuaHRtbAogZWRpdGluZy9wYXN0ZWJvYXJkLzc5NTUuaHRtbAogZWRp dGluZy9wYXN0ZWJvYXJkL2NvcHktY3Jhc2guaHRtbAogZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHkt aW4tcGFzc3dvcmQtZmllbGQuaHRtbAorZWRpdGluZy9wYXN0ZWJvYXJkL2RhdGEtdHJhbnNmZXIt aXRlbXMtaW1hZ2UtcG5nLmh0bWwKIGVkaXRpbmcvcGFzdGVib2FyZC9kaXNwbGF5LWJsb2NrLW9u LXNwYW5zLmh0bWwKIGVkaXRpbmcvcGFzdGVib2FyZC9pbnB1dC1maWVsZC0xLmh0bWwKIGVkaXRp bmcvcGFzdGVib2FyZC9tZXJnZS1lbmQtbGlzdC0yLmh0bWwK 114244 2011-11-09 04:08:43 -0800 2011-11-09 04:44:47 -0800 nrwt pixeltest crash in WK2 resolved 20111109.patch text/plain 1242 rtakacs ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MzYxOTU1Li45MWU4MzY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEt MDkgIFJvbGFuZCBUYWthY3MgIDx0YWthY3Mucm9sYW5kQHN0dWQudS1zemVnZWQuaHU+CisKKyAg ICAgICAgW1dLMl0gbnJ3dCBwaXhlbHRlc3RzIGNyYXNoIHdoaWxlIHRlc3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNjg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC01LjAvU2tp cHBlZDoKKyAgICAgICAgJ2VkaXRpbmcvcGFzdGVib2FyZC9kYXRhLXRyYW5zZmVyLWl0ZW1zLWlt YWdlLXBuZy5odG1sJyBpcyBza2lwcGVkLCBiZWNhdXNlIGl0IGNhdXNlZCBhbiBucnd0IHBpeGVs IHRlc3QgY3Jhc2guCisKIDIwMTEtMTEtMDcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVua2lwIGEgd29ya2luZyB0ZXN0IGFu ZCByZWNsYXNzaWZ5IHRoZSB3aGVlbGV2ZW50IG1pc3NpbmcgRFJUIGZlYXR1cmVzLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC01LjAvU2tpcHBlZAppbmRleCBkMGRhNzQ1Li45MmRiYTUxIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC01LjAvU2tpcHBlZApAQCAtNjk2NCwzICs2OTY0LDcgQEAgZmFzdC9zcGF0aWFs LW5hdmlnYXRpb24vc25hdi1vZmZzY3JlZW4tY29udGVudC5odG1sCiAjIFtRdF0gZmFzdC9tdWx0 aWNvbC9mbGlwcGVkLWJsb2Nrcy1oaXQtdGVzdC5odG1sIGZhaWxzIHdpdGggUXQ1CiAjIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTExOAogZmFzdC9tdWx0aWNvbC9m bGlwcGVkLWJsb2Nrcy1oaXQtdGVzdC5odG1sCisKKyMgbnJ3dCBwaXhlbCB0ZXN0IGNyYXNoCisj IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTY4OAorZWRpdGluZy9w YXN0ZWJvYXJkL2RhdGEtdHJhbnNmZXItaXRlbXMtaW1hZ2UtcG5nLmh0bWwK