71687 2011-11-07 07:34:51 -0800 Remove initOverflowEvent method from JavaScript bindings 2011-11-07 09:51:27 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 68791 1 dominicc dominicc abarth ojan sam webkit.review.bot oldest_to_newest 497164 0 dominicc 2011-11-07 07:34:51 -0800 It appears from Code Search that nobody uses initOverflowEvent. It should be removed from the JavaScript bindings. Because it is part of the public Objective C, it should only be removed from the JavaScript bindings, not removed altogether. 497166 1 113866 dominicc 2011-11-07 07:47:53 -0800 Created attachment 113866 Patch 497220 2 113866 ojan 2011-11-07 09:04:16 -0800 Comment on attachment 113866 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113866&action=review > Source/WebCore/ChangeLog:7 > + This could use more description of why we're changing this. Just something short to the effect of it being removed from the new DOM spec. 497257 3 dominicc 2011-11-07 09:51:27 -0800 Committed r99435: <http://trac.webkit.org/changeset/99435> 113866 2011-11-07 07:47:53 -0800 2011-11-07 09:04:16 -0800 Patch bug-71687-20111107074752.patch text/plain 5717 dominicc U3VidmVyc2lvbiBSZXZpc2lvbjogOTk0MjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNzc0OWYxNDUyZDc5MjNh ZmM4NTBjMWIwMjIzNTM0ZjExZTI1N2IyLi5jZDA3MzBhZjdlYjAyZDQ3YjdkMTk3ODQ4ODBmNmVh NDVjYWY4ZmEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTEtMDcgIERvbWlu aWMgQ29vbmV5ICA8ZG9taW5pY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBpbml0 T3ZlcmZsb3dFdmVudCBmcm9tIEphdmFTY3JpcHQgYmluZGluZ3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNjg3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vT3ZlcmZsb3dFdmVudC5pZGw6CisK IDIwMTEtMTEtMDcgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW0Nocm9taXVtXSBXZWIgSW5zcGVjdG9yOiB1c2UgbmF0aXZlIHdvcmtlciBpbnNwZWN0 b3IgaW5zdGVhZCBvZiBmYWtlIHdvcmtlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9PdmVyZmxvd0V2ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9PdmVyZmxvd0V2ZW50Lmlk bAppbmRleCBmYjljNTUzOWUyYjZmOGRkM2FlYzcxOGEwYTJkZGI4YmU3MDUxM2RhLi5mZmMxYzJh MzJiYWNiOGRiNmE3ZGQ5ZTdlYTQzYzkwNzBlZmE4NWY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vT3ZlcmZsb3dFdmVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL092ZXJm bG93RXZlbnQuaWRsCkBAIC0zNyw5ICszNywxMSBAQCBtb2R1bGUgZXZlbnRzIHsKICAgICAgICAg cmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gaG9yaXpvbnRhbE92ZXJmbG93OwogICAgICAgICBy ZWFkb25seSBhdHRyaWJ1dGUgYm9vbGVhbiB2ZXJ0aWNhbE92ZXJmbG93OyAgICAgICAgCiAKKyNp ZiBkZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQwog ICAgICAgICB2b2lkIGluaXRPdmVyZmxvd0V2ZW50KGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1 bHRWYWx1ZV0gdW5zaWduZWQgc2hvcnQgb3JpZW50LAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gYm9vbGVhbiBob3Jpem9u dGFsT3ZlcmZsb3csCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFs PUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBib29sZWFuIHZlcnRpY2FsT3ZlcmZsb3cpOworI2VuZGlm CiAgICAgfTsKIAogfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDk3Njc0YWQwMDgwMGE5ZTAyNjcyN2I5MmU1ZTA0M2IxZGI0 YzBhZDUuLjMyODFlYzBhYzFjOWM1NzUzOTM2ZjkyNGFiM2FkODFjODcyMTRiZjYgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNiBAQAorMjAxMS0xMS0wNyAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0BjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIGluaXRPdmVyZmxvd0V2ZW50IGZyb20gSmF2YVNj cmlwdCBiaW5kaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzE2ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBPdmVyZmxvd0V2ZW50IGluaXRpYWxpemF0aW9uIGlzIHRlc3RlZCBpbgorICAgICAgICBm YXN0L2V2ZW50cy9jb25zdHJ1Y3RvcnMvb3ZlcmZsb3ctZXZlbnQtY29uc3RydWN0b3IuaHRtbAor CisgICAgICAgICogZmFzdC9ldmVudHMvaW5pdC1ldmVudHMtZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIGZhc3QvZXZlbnRzL3NjcmlwdC10ZXN0cy9pbml0LWV2ZW50cy5qczoKKwogMjAxMS0xMS0w NyAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAg W1F0XSBGaXggZmFpbGluZyBpbnNwZWN0b3IgdGVzdHMgYWZ0ZXIgYnVpbGQgc3lzdGVtIGNoYW5n ZXMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2luaXQtZXZlbnRzLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2luaXQtZXZlbnRzLWV4cGVjdGVkLnR4 dAppbmRleCA5ZmUyM2Y0NTEwOWMwZDU5NDA2MmQ0Y2ViMzc4ZjllNmJiY2Q5ZTY1Li40MzM1NGUx M2NhOGI5YTEzNjBmN2MyNDMwZWJlOTZkMDg0NTIzYmI1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9pbml0LWV2ZW50cy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvaW5pdC1ldmVudHMtZXhwZWN0ZWQudHh0CkBAIC0xMTYsMTUgKzExNiw2IEBA IFBBU1MgdGVzdEluaXRFdmVudCgnTXV0YXRpb24nLCAnImEiLCBmYWxzZSwgZmFsc2UsIG51bGws ICJiIiwgbnVsbCwgImQiLCAxMDAxJykuCiBQQVNTIHRlc3RJbml0RXZlbnQoJ011dGF0aW9uJywg JyJhIiwgZmFsc2UsIGZhbHNlLCBudWxsLCAiYiIsICJjIiwgImQiLCAxMDAxJykuYXR0ck5hbWUg aXMgJ2QnCiBQQVNTIHRlc3RJbml0RXZlbnQoJ011dGF0aW9uJywgJyJhIiwgZmFsc2UsIGZhbHNl LCBudWxsLCAiYiIsICJjIiwgbnVsbCwgMTAwMScpLmF0dHJOYW1lIGlzICdudWxsJwogUEFTUyB0 ZXN0SW5pdEV2ZW50KCdNdXRhdGlvbicsICciYSIsIGZhbHNlLCBmYWxzZSwgbnVsbCwgImIiLCAi YyIsICJkIiwgMTAwMScpLmF0dHJDaGFuZ2UgaXMgMTAwMQotUEFTUyB0ZXN0SW5pdEV2ZW50KCdP dmVyZmxvdycsICcxMDAxLCBmYWxzZSwgZmFsc2UnKS50eXBlIGlzICdvdmVyZmxvd2NoYW5nZWQn Ci1QQVNTIHRlc3RJbml0RXZlbnQoJ092ZXJmbG93JywgJzEwMDEsIGZhbHNlLCBmYWxzZScpLmJ1 YmJsZXMgaXMgZmFsc2UKLVBBU1MgdGVzdEluaXRFdmVudCgnT3ZlcmZsb3cnLCAnMTAwMSwgZmFs c2UsIGZhbHNlJykuY2FuY2VsYWJsZSBpcyBmYWxzZQotUEFTUyB0ZXN0SW5pdEV2ZW50KCdPdmVy ZmxvdycsICcxMDAxLCBmYWxzZSwgZmFsc2UnKS5vcmllbnQgaXMgMTAwMQotUEFTUyB0ZXN0SW5p dEV2ZW50KCdPdmVyZmxvdycsICcxMDAxLCBmYWxzZSwgZmFsc2UnKS5ob3Jpem9udGFsT3ZlcmZs b3cgaXMgZmFsc2UKLVBBU1MgdGVzdEluaXRFdmVudCgnT3ZlcmZsb3cnLCAnMTAwMSwgdHJ1ZSwg ZmFsc2UnKS5ob3Jpem9udGFsT3ZlcmZsb3cgaXMgdHJ1ZQotUEFTUyB0ZXN0SW5pdEV2ZW50KCdP dmVyZmxvdycsICcxMDAxLCBmYWxzZSwgZmFsc2UnKS52ZXJ0aWNhbE92ZXJmbG93IGlzIGZhbHNl Ci1QQVNTIHRlc3RJbml0RXZlbnQoJ092ZXJmbG93JywgJzEwMDEsIGZhbHNlLCB0cnVlJykudmVy dGljYWxPdmVyZmxvdyBpcyB0cnVlCi1QQVNTIGNyZWF0ZUV2ZW50SGVscGVyKCdPdmVyZmxvdycp Lm9yaWVudCBpcyBPdmVyZmxvd0V2ZW50LlZFUlRJQ0FMCiBQQVNTIHRlc3RJbml0RXZlbnQoJ1By b2dyZXNzJywgJyJhIiwgZmFsc2UsIGZhbHNlLCBmYWxzZSwgMTAwMSwgMTAwMicpLnR5cGUgaXMg J2EnCiBQQVNTIHRlc3RJbml0RXZlbnQoJ1Byb2dyZXNzJywgJ251bGwsIGZhbHNlLCBmYWxzZSwg ZmFsc2UsIDEwMDEsIDEwMDInKS50eXBlIGlzICdudWxsJwogUEFTUyB0ZXN0SW5pdEV2ZW50KCdQ cm9ncmVzcycsICciYSIsIGZhbHNlLCBmYWxzZSwgZmFsc2UsIDEwMDEsIDEwMDInKS5idWJibGVz IGlzIGZhbHNlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JpcHQtdGVz dHMvaW5pdC1ldmVudHMuanMgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zY3JpcHQtdGVzdHMv aW5pdC1ldmVudHMuanMKaW5kZXggNGJjYTY0NGM3ZDk5OTNhYjg4YmJhMzc5MGFlNmZhODQzYTRl NzlkYS4uMjQxMTBiZTBhYmI0YWU4ZDg5NTI4YzFiNTc2ZTdmYWRiYzA3YmZhMCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc2NyaXB0LXRlc3RzL2luaXQtZXZlbnRzLmpzCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL3NjcmlwdC10ZXN0cy9pbml0LWV2ZW50cy5qcwpA QCAtMTMwLDE3ICsxMzAsNiBAQCBzaG91bGRCZSgidGVzdEluaXRFdmVudCgnTXV0YXRpb24nLCAn XCJhXCIsIGZhbHNlLCBmYWxzZSwgbnVsbCwgXCJiXCIsIFwiY1wiLCBcIgogc2hvdWxkQmUoInRl c3RJbml0RXZlbnQoJ011dGF0aW9uJywgJ1wiYVwiLCBmYWxzZSwgZmFsc2UsIG51bGwsIFwiYlwi LCBcImNcIiwgbnVsbCwgMTAwMScpLmF0dHJOYW1lIiwgIidudWxsJyIpOwogc2hvdWxkQmUoInRl c3RJbml0RXZlbnQoJ011dGF0aW9uJywgJ1wiYVwiLCBmYWxzZSwgZmFsc2UsIG51bGwsIFwiYlwi LCBcImNcIiwgXCJkXCIsIDEwMDEnKS5hdHRyQ2hhbmdlIiwgIjEwMDEiKTsKIAotLy8gaW5pdE92 ZXJmbG93RXZlbnQgaGFzIGFuIGludGVyZmFjZSB0aGF0IGhhcyBhbiBkZXNpZ24gdGhhdCdzIGlu Y29uc2lzdGVudCB3aXRoIHRoZSBpbml0IGZ1bmN0aW9ucyBmcm9tIG90aGVyIGV2ZW50cy4KLXNo b3VsZEJlKCJ0ZXN0SW5pdEV2ZW50KCdPdmVyZmxvdycsICcxMDAxLCBmYWxzZSwgZmFsc2UnKS50 eXBlIiwgIidvdmVyZmxvd2NoYW5nZWQnIik7Ci1zaG91bGRCZSgidGVzdEluaXRFdmVudCgnT3Zl cmZsb3cnLCAnMTAwMSwgZmFsc2UsIGZhbHNlJykuYnViYmxlcyIsICJmYWxzZSIpOwotc2hvdWxk QmUoInRlc3RJbml0RXZlbnQoJ092ZXJmbG93JywgJzEwMDEsIGZhbHNlLCBmYWxzZScpLmNhbmNl bGFibGUiLCAiZmFsc2UiKTsKLXNob3VsZEJlKCJ0ZXN0SW5pdEV2ZW50KCdPdmVyZmxvdycsICcx MDAxLCBmYWxzZSwgZmFsc2UnKS5vcmllbnQiLCAiMTAwMSIpOwotc2hvdWxkQmUoInRlc3RJbml0 RXZlbnQoJ092ZXJmbG93JywgJzEwMDEsIGZhbHNlLCBmYWxzZScpLmhvcml6b250YWxPdmVyZmxv dyIsICJmYWxzZSIpOwotc2hvdWxkQmUoInRlc3RJbml0RXZlbnQoJ092ZXJmbG93JywgJzEwMDEs IHRydWUsIGZhbHNlJykuaG9yaXpvbnRhbE92ZXJmbG93IiwgInRydWUiKTsKLXNob3VsZEJlKCJ0 ZXN0SW5pdEV2ZW50KCdPdmVyZmxvdycsICcxMDAxLCBmYWxzZSwgZmFsc2UnKS52ZXJ0aWNhbE92 ZXJmbG93IiwgImZhbHNlIik7Ci1zaG91bGRCZSgidGVzdEluaXRFdmVudCgnT3ZlcmZsb3cnLCAn MTAwMSwgZmFsc2UsIHRydWUnKS52ZXJ0aWNhbE92ZXJmbG93IiwgInRydWUiKTsKLXNob3VsZEJl KCJjcmVhdGVFdmVudEhlbHBlcignT3ZlcmZsb3cnKS5vcmllbnQiLCAiT3ZlcmZsb3dFdmVudC5W RVJUSUNBTCIpOwotCiBzaG91bGRCZSgidGVzdEluaXRFdmVudCgnUHJvZ3Jlc3MnLCAnXCJhXCIs IGZhbHNlLCBmYWxzZSwgZmFsc2UsIDEwMDEsIDEwMDInKS50eXBlIiwgIidhJyIpOwogc2hvdWxk QmUoInRlc3RJbml0RXZlbnQoJ1Byb2dyZXNzJywgJ251bGwsIGZhbHNlLCBmYWxzZSwgZmFsc2Us IDEwMDEsIDEwMDInKS50eXBlIiwgIidudWxsJyIpOwogc2hvdWxkQmUoInRlc3RJbml0RXZlbnQo J1Byb2dyZXNzJywgJ1wiYVwiLCBmYWxzZSwgZmFsc2UsIGZhbHNlLCAxMDAxLCAxMDAyJykuYnVi YmxlcyIsICJmYWxzZSIpOwo=