71684 2011-11-07 06:59:34 -0800 DFG 32_64 - registers cannot be reused arbitrarily if speculation failures are possible 2011-11-07 14:14:10 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 71686 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 497148 0 yuqiang.xian 2011-11-07 06:59:34 -0800 Currently in DFG JIT, we try to reuse the physical register of an operand for temporary usage if the current use of the operand is the last use. But sometimes this can be wrong, for example if there are possible speculation failures and we need to fallback to baseline JIT, the value of the operand which is supposed to be hold in the physical register can be modified by register reusing. The fixes the last inspector failures in layout test on Mac 32-bit if switching on DFG. (BTW, I didn't observe the failure in Gtk+ port on Linux ia32 as the inspector tests are skipped in Gtk layout test, and only w/ a 32-bit Mac environment setup today can I notice this failure...) 497152 1 113863 yuqiang.xian 2011-11-07 07:02:49 -0800 Created attachment 113863 the patch 497461 2 113863 webkit.review.bot 2011-11-07 14:14:06 -0800 Comment on attachment 113863 the patch Clearing flags on attachment: 113863 Committed r99476: <http://trac.webkit.org/changeset/99476> 497462 3 webkit.review.bot 2011-11-07 14:14:10 -0800 All reviewed patches have been landed. Closing bug. 113863 2011-11-07 07:02:49 -0800 2011-11-07 14:14:06 -0800 the patch 71684.patch text/plain 3277 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTk0MTYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTEtMTEtMDcgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgREZHIDMyXzY0IC0gcmVnaXN0ZXJzIGNhbm5vdCBiZSByZXVzZWQgYXJiaXRyYXJpbHkg aWYgc3BlY3VsYXRpb24gZmFpbHVyZXMgYXJlIHBvc3NpYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTY4NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSBpbiBERkcgSklULCB3ZSB0cnkg dG8gcmV1c2UgdGhlIHBoeXNpY2FsIHJlZ2lzdGVyIG9mIGFuCisgICAgICAgIG9wZXJhbmQgZm9y IHRlbXBvcmFyeSB1c2FnZSBpZiB0aGUgY3VycmVudCB1c2Ugb2YgdGhlIG9wZXJhbmQgaXMgdGhl CisgICAgICAgIGxhc3QgdXNlLiBCdXQgc29tZXRpbWVzIHRoaXMgY2FuIGJlIHdyb25nLCBmb3Ig ZXhhbXBsZSBpZiB0aGVyZSBhcmUKKyAgICAgICAgcG9zc2libGUgc3BlY3VsYXRpb24gZmFpbHVy ZXMgYW5kIHdlIG5lZWQgdG8gZmFsbGJhY2sgdG8gYmFzZWxpbmUgSklULAorICAgICAgICB0aGUg dmFsdWUgb2YgdGhlIG9wZXJhbmQgd2hpY2ggaXMgc3VwcG9zZWQgdG8gYmUgaG9sZCBpbiB0aGUg cGh5c2ljYWwKKyAgICAgICAgcmVnaXN0ZXIgY2FuIGJlIG1vZGlmaWVkIGJ5IHJlZ2lzdGVyIHJl dXNpbmcuIFRoZSBmaXhlcyB0aGUgbGFzdAorICAgICAgICBpbnNwZWN0b3IgZmFpbHVyZXMgaW4g bGF5b3V0IHRlc3Qgb24gTWFjIDMyLWJpdCBpZiBzd2l0Y2hpbmcgb24gREZHLgorCisgICAgICAg ICogZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNw ZWN1bGF0aXZlSklUOjplbWl0T2JqZWN0T3JPdGhlckJyYW5jaCk6CisgICAgICAgIChKU0M6OkRG Rzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorCiAyMDExLTExLTA2ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyOTkzNzQpOiBHVEsrIGJ1 aWxkIG9mIHRoZSBqc2MgYmluYXJ5IGRvZXNuJ3QgbGlrZSB0aGUgY2FsbApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3Bw CShyZXZpc2lvbiA5OTQxNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3Vs YXRpdmVKSVQzMl82NC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYyNyw3ICs2MjcsNyBAQCB2b2lk IFNwZWN1bGF0aXZlSklUOjpjb21waWxlTG9naWNhbE5vdChOCiB2b2lkIFNwZWN1bGF0aXZlSklU OjplbWl0T2JqZWN0T3JPdGhlckJyYW5jaChOb2RlSW5kZXggbm9kZUluZGV4LCBCbG9ja0luZGV4 IHRha2VuLCBCbG9ja0luZGV4IG5vdFRha2VuLCB2b2lkICp2cHRyLCBib29sIG5lZWRTcGVjdWxh dGlvbkNoZWNrKQogewogICAgIEpTVmFsdWVPcGVyYW5kIHZhbHVlKHRoaXMsIG5vZGVJbmRleCk7 Ci0gICAgR1BSVGVtcG9yYXJ5IHNjcmF0Y2godGhpcywgdmFsdWUpOworICAgIEdQUlRlbXBvcmFy eSBzY3JhdGNoKHRoaXMpOwogICAgIEdQUlJlZyB2YWx1ZVRhZ0dQUiA9IHZhbHVlLnRhZ0dQUigp OwogICAgIEdQUlJlZyB2YWx1ZVBheWxvYWRHUFIgPSB2YWx1ZS5wYXlsb2FkR1BSKCk7CiAgICAg R1BSUmVnIHNjcmF0Y2hHUFIgPSBzY3JhdGNoLmdwcigpOwpAQCAtMTI0Myw3ICsxMjQzLDcgQEAg dm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlJiBub2RlKQogICAgIGNhc2UgQXJpdGhB YnM6IHsKICAgICAgICAgaWYgKGF0KG5vZGUuY2hpbGQxKCkpLnNob3VsZFNwZWN1bGF0ZUludGVn ZXIoKSAmJiBub2RlLmNhblNwZWN1bGF0ZUludGVnZXIoKSkgewogICAgICAgICAgICAgU3BlY3Vs YXRlSW50ZWdlck9wZXJhbmQgb3AxKHRoaXMsIG5vZGUuY2hpbGQxKCkpOwotICAgICAgICAgICAg R1BSVGVtcG9yYXJ5IHJlc3VsdCh0aGlzLCBvcDEpOworICAgICAgICAgICAgR1BSVGVtcG9yYXJ5 IHJlc3VsdCh0aGlzKTsKICAgICAgICAgICAgIEdQUlRlbXBvcmFyeSBzY3JhdGNoKHRoaXMpOwog ICAgICAgICAgICAgCiAgICAgICAgICAgICBtX2ppdC56ZXJvRXh0ZW5kMzJUb1B0cihvcDEuZ3By KCksIHJlc3VsdC5ncHIoKSk7CkBAIC0xNDIxLDcgKzE0MjEsNyBAQCB2b2lkIFNwZWN1bGF0aXZl SklUOjpjb21waWxlKE5vZGUmIG5vZGUpCiAgICAgICAgIFNwZWN1bGF0ZUNlbGxPcGVyYW5kIGJh c2UodGhpcywgbm9kZS5jaGlsZDEoKSk7CiAgICAgICAgIFNwZWN1bGF0ZVN0cmljdEludDMyT3Bl cmFuZCBwcm9wZXJ0eSh0aGlzLCBub2RlLmNoaWxkMigpKTsKICAgICAgICAgR1BSVGVtcG9yYXJ5 IHN0b3JhZ2UodGhpcyk7Ci0gICAgICAgIEdQUlRlbXBvcmFyeSByZXN1bHRUYWcodGhpcywgYmFz ZSk7CisgICAgICAgIEdQUlRlbXBvcmFyeSByZXN1bHRUYWcodGhpcyk7CiAKICAgICAgICAgR1BS UmVnIGJhc2VSZWcgPSBiYXNlLmdwcigpOwogICAgICAgICBHUFJSZWcgcHJvcGVydHlSZWcgPSBw cm9wZXJ0eS5ncHIoKTsKQEAgLTE4ODgsNyArMTg4OCw3IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6 OmNvbXBpbGUoTm9kZSYgbm9kZSkKICAgICAgICAgCiAgICAgICAgIGlmIChpc090aGVyUHJlZGlj dGlvbihhdChub2RlLmNoaWxkMSgpKS5wcmVkaWN0aW9uKCkpKSB7CiAgICAgICAgICAgICBKU1Zh bHVlT3BlcmFuZCB0aGlzVmFsdWUodGhpcywgbm9kZS5jaGlsZDEoKSk7Ci0gICAgICAgICAgICBH UFJUZW1wb3Jhcnkgc2NyYXRjaCh0aGlzLCB0aGlzVmFsdWUpOworICAgICAgICAgICAgR1BSVGVt cG9yYXJ5IHNjcmF0Y2godGhpcyk7CiAgICAgICAgICAgICAKICAgICAgICAgICAgIEdQUlJlZyB0 aGlzVmFsdWVUYWdHUFIgPSB0aGlzVmFsdWUudGFnR1BSKCk7CiAgICAgICAgICAgICBHUFJSZWcg c2NyYXRjaEdQUiA9IHNjcmF0Y2guZ3ByKCk7Cg==