71680 2011-11-07 06:46:51 -0800 [Qt][WK2] MiniBrowser should use urlFromUserInput() 2011-11-08 01:04:03 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zeno zeno eric hausmann ossy webkit.review.bot oldest_to_newest 497138 0 zeno 2011-11-07 06:46:51 -0800 Currently MiniBrowser does nothing when an address with a missing http:// prefix is entered. Using the urlFromUserInput() method this could be automatically completed. 497147 1 113861 zeno 2011-11-07 06:55:50 -0800 Created attachment 113861 patch for review. 497176 2 113861 webkit.review.bot 2011-11-07 08:06:43 -0800 Comment on attachment 113861 patch for review. Rejecting attachment 113861 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/10332661 497182 3 113861 vestbo 2011-11-07 08:18:34 -0800 Comment on attachment 113861 patch for review. let's try this again 497185 4 113861 webkit.review.bot 2011-11-07 08:26:12 -0800 Comment on attachment 113861 patch for review. Rejecting attachment 113861 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/10333719 497211 5 vestbo 2011-11-07 08:58:57 -0800 Is it barfing on my name? Or something else? 497746 6 ossy 2011-11-07 22:29:57 -0800 (In reply to comment #5) > Is it barfing on my name? Or something else? Yes, CQ doesn't like our name: https://bugs.webkit.org/show_bug.cgi?id=63452 , so it can't land patches reviewed by you or me. :( 497789 7 113861 hausmann 2011-11-07 23:50:04 -0800 Comment on attachment 113861 patch for review. Clearing flags on attachment: 113861 Committed r99527: <http://trac.webkit.org/changeset/99527> 497790 8 hausmann 2011-11-07 23:50:12 -0800 All reviewed patches have been landed. Closing bug. 497791 9 hausmann 2011-11-07 23:50:42 -0800 (In reply to comment #6) > (In reply to comment #5) > > Is it barfing on my name? Or something else? > > Yes, CQ doesn't like our name: https://bugs.webkit.org/show_bug.cgi?id=63452 , > so it can't land patches reviewed by you or me. :( Weirdly enough webkit-patch land-from-bug <1234> works just fine (and worked for this bug, too :) 497796 10 ossy 2011-11-08 00:02:29 -0800 It broke WK2 build: /usr/bin/gold: obj/release/BrowserWindow.o: in function BrowserWindow::BrowserWindow(WindowOptions*):BrowserWindow.cpp(.text+0x58d): error: undefined reference to 'vtable for Utils' /usr/bin/gold: obj/release/BrowserWindow.o: in function BrowserWindow::BrowserWindow(WindowOptions*):BrowserWindow.cpp(.text+0x95d): error: undefined reference to 'vtable for Utils' It might be an icremental build issue because of new build system. 497827 11 hausmann 2011-11-08 01:01:28 -0800 (In reply to comment #10) > It broke WK2 build: > > /usr/bin/gold: obj/release/BrowserWindow.o: in function BrowserWindow::BrowserWindow(WindowOptions*):BrowserWindow.cpp(.text+0x58d): error: undefined reference to 'vtable for Utils' > /usr/bin/gold: obj/release/BrowserWindow.o: in function BrowserWindow::BrowserWindow(WindowOptions*):BrowserWindow.cpp(.text+0x95d): error: undefined reference to 'vtable for Utils' > > > It might be an icremental build issue because of new build system. Yeah, it is an incremental build issue. I touched the .pro file and then it all went fine on the bot. 497831 12 ossy 2011-11-08 01:04:03 -0800 I triggered a clean build on the bot and it works, so it is an incremental build bug. I filed a new bug report: https://bugs.webkit.org/show_bug.cgi?id=71775 113861 2011-11-07 06:55:50 -0800 2011-11-07 23:50:04 -0800 patch for review. 71680_20111107-155421.patch text/plain 3723 zeno ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0ZjZh MTBhLi44OTcxMmQ2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMTEtMDcgIFplbm8gQWxiaXNzZXIgIDx6ZW5v LmFsYmlzc2VyQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdW1dLMl0gTWluaUJyb3dzZXIgc2hv dWxkIHVzZSB1cmxGcm9tVXNlcklucHV0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTcxNjgwCisKKyAgICAgICAgVXNlIHVybEZyb21Vc2VySW5wdXQo KSAvIFFVcmw6OmZyb21Vc2VySW5wdXQoKSB0byBhdXRvbWF0aWNhbGx5CisgICAgICAgIGNvbXBs ZXRlIHVybHMgaW4gTWluaUJyb3dzZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcDoKKyAg ICAgICAgKEJyb3dzZXJXaW5kb3c6OkJyb3dzZXJXaW5kb3cpOgorICAgICAgICAoQnJvd3Nlcldp bmRvdzo6bG9hZCk6CisgICAgICAgICogTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cu cW1sOgorICAgICAgICAqIE1pbmlCcm93c2VyL3F0L3V0aWxzLmNwcDoKKyAgICAgICAgKFV0aWxz Ojp1cmxGcm9tVXNlcklucHV0KToKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC91dGlscy5oOgor ICAgICAgICAoVXRpbHM6OlV0aWxzKToKKwogMjAxMS0xMS0wNiAgQ3NhYmEgT3N6dHJvZ29uw6Fj ICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCB0cml2aWFsIGZp eCBhZnRlciBidWlsZCBzeXN0ZW0gcmVmYWN0b3JpbmcuCmRpZmYgLS1naXQgYS9Ub29scy9NaW5p QnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dz ZXJXaW5kb3cuY3BwCmluZGV4IGUyMDMxNGEuLjE0MTVmNGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01p bmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL3F0 L0Jyb3dzZXJXaW5kb3cuY3BwCkBAIC00Nyw2ICs0Nyw4IEBAIEJyb3dzZXJXaW5kb3c6OkJyb3dz ZXJXaW5kb3coV2luZG93T3B0aW9ucyogb3B0aW9ucykKICAgICBxbWxJbXBvcnREaXIuY2QoIi4u L2ltcG9ydHMiKTsKICAgICBlbmdpbmUoKS0+YWRkSW1wb3J0UGF0aChxbWxJbXBvcnREaXIuY2Fu b25pY2FsUGF0aCgpKTsKIAorICAgIFV0aWxzKiB1dGlscyA9IG5ldyBVdGlscyh0aGlzKTsKKyAg ICBlbmdpbmUoKS0+cm9vdENvbnRleHQoKS0+c2V0Q29udGV4dFByb3BlcnR5KCJ1dGlscyIsIHV0 aWxzKTsKICAgICBlbmdpbmUoKS0+cm9vdENvbnRleHQoKS0+c2V0Q29udGV4dFByb3BlcnR5KCJv cHRpb25zIiwgb3B0aW9ucyk7CiAgICAgc2V0U291cmNlKFFVcmwoInFyYzovcW1sL0Jyb3dzZXJX aW5kb3cucW1sIikpOwogICAgIGNvbm5lY3Qocm9vdE9iamVjdCgpLCBTSUdOQUwocGFnZVRpdGxl Q2hhbmdlZChRU3RyaW5nKSksIHRoaXMsIFNMT1Qoc2V0V2luZG93VGl0bGUoUVN0cmluZykpKTsK QEAgLTY4LDcgKzcwLDcgQEAgUU9iamVjdCogQnJvd3NlcldpbmRvdzo6d2ViVmlldygpIGNvbnN0 CiAKIHZvaWQgQnJvd3NlcldpbmRvdzo6bG9hZChjb25zdCBRU3RyaW5nJiB1cmwpCiB7Ci0gICAg UVVybCBjb21wbGV0ZWRVcmwgPSB1cmxGcm9tVXNlcklucHV0KHVybCk7CisgICAgUVVybCBjb21w bGV0ZWRVcmwgPSBVdGlsczo6dXJsRnJvbVVzZXJJbnB1dCh1cmwpOwogICAgIFFNZXRhT2JqZWN0 OjppbnZva2VNZXRob2Qocm9vdE9iamVjdCgpLCAibG9hZCIsIFF0OjpEaXJlY3RDb25uZWN0aW9u LCBRX0FSRyhRVmFyaWFudCwgY29tcGxldGVkVXJsKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xz L01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbCBiL1Rvb2xzL01pbmlCcm93c2Vy L3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbAppbmRleCAwYTFkNTE0Li4zOGNiYTBmIDEwMDY0NAot LS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvQnJvd3NlcldpbmRvdy5xbWwKKysrIGIvVG9v bHMvTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cucW1sCkBAIC0xNzgsNyArMTc4LDcg QEAgUmVjdGFuZ2xlIHsKIAogICAgICAgICAgICAgICAgIEtleXMub25SZXR1cm5QcmVzc2VkOnsK ICAgICAgICAgICAgICAgICAgICAgY29uc29sZS5sb2coImdvaW5nIHRvOiAiLCBhZGRyZXNzTGlu ZS50ZXh0KQotICAgICAgICAgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoYWRkcmVzc0xpbmUudGV4 dCkKKyAgICAgICAgICAgICAgICAgICAgd2ViVmlldy5sb2FkKHV0aWxzLnVybEZyb21Vc2VySW5w dXQoYWRkcmVzc0xpbmUudGV4dCkpCiAgICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAg ICAgS2V5cy5vblByZXNzZWQ6IHsKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L3V0 aWxzLmNwcCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L3V0aWxzLmNwcAppbmRleCA0OWRiNzNkLi5k NjQ5MWNjIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9xdC91dGlscy5jcHAKKysrIGIv VG9vbHMvTWluaUJyb3dzZXIvcXQvdXRpbHMuY3BwCkBAIC04Nyw3ICs4Nyw3IEBAIHZvaWQgYXBw UXVpdChpbnQgZXhpdENvZGUsIGNvbnN0IFFTdHJpbmcmIG1zZykKICAgICBleGl0KGV4aXRDb2Rl KTsKIH0KIAotUVVybCB1cmxGcm9tVXNlcklucHV0KGNvbnN0IFFTdHJpbmcmIHN0cmluZykKK1FV cmwgVXRpbHM6OnVybEZyb21Vc2VySW5wdXQoY29uc3QgUVN0cmluZyYgc3RyaW5nKQogewogICAg IFFTdHJpbmcgaW5wdXQoc3RyaW5nKTsKICAgICBRRmlsZUluZm8gZmkoaW5wdXQpOwpkaWZmIC0t Z2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvdXRpbHMuaCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0 L3V0aWxzLmgKaW5kZXggMmFjM2RkYi4uMTU0YWZiZSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJy b3dzZXIvcXQvdXRpbHMuaAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC91dGlscy5oCkBAIC00 Miw2ICs0MiwxNSBAQAogI2VuZGlmCiAKIC8vIG9wdGlvbnMgaGFuZGxpbmcKK2NsYXNzIFV0aWxz IDogcHVibGljIFFPYmplY3QgeworICAgIFFfT0JKRUNUCitwdWJsaWM6CisgICAgVXRpbHMoUU9i amVjdCogcGFyZW50ID0gMCkKKyAgICAgICAgOiBRT2JqZWN0KHBhcmVudCkgeyB9CisKKyAgICBR X0lOVk9LQUJMRSBzdGF0aWMgUVVybCB1cmxGcm9tVXNlcklucHV0KGNvbnN0IFFTdHJpbmcmIGlu cHV0KTsKK307CisKIGJvb2wgdGFrZU9wdGlvbkZsYWcoUVN0cmluZ0xpc3QqIGFyZ3VtZW50cywg Y29uc3QgUVN0cmluZyYgbmFtZSk7CiBRU3RyaW5nIHRha2VPcHRpb25WYWx1ZShRU3RyaW5nTGlz dCogYXJndW1lbnRzLCBjb25zdCBRU3RyaW5nJiBuYW1lKTsKIFFTdHJpbmcgZm9ybWF0S2V5cyhR TGlzdDxRU3RyaW5nPiBrZXlzKTsKQEAgLTQ5LDYgKzU4LDQgQEAgUUxpc3Q8UVN0cmluZz4gZW51 bVRvS2V5cyhjb25zdCBRTWV0YU9iamVjdCwgY29uc3QgUVN0cmluZyYsIGNvbnN0IFFTdHJpbmcm KTsKIAogTk9fUkVUVVJOIHZvaWQgYXBwUXVpdChpbnQgc3RhdHVzLCBjb25zdCBRU3RyaW5nJiBt c2cgPSBRU3RyaW5nKCkpOwogCi1RVXJsIHVybEZyb21Vc2VySW5wdXQoY29uc3QgUVN0cmluZyYg aW5wdXQpOwotCiAjZW5kaWYK