71665 2011-11-07 04:39:27 -0800 [GTK] platform/gtk/accessibility/name-from-label.html fails 2011-11-22 00:30:57 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand mario mario pnormand xan.lopez oldest_to_newest 497070 0 pnormand 2011-11-07 04:39:27 -0800 Currently skipped in GTK as anonymous flaky but failure looks consistent here: --- /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/name-from-label-expected.txt +++ /home/phil/gst/jhbuild/build/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/accessibility/name-from-label-actual.txt @@ -4,8 +4,8 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS child.role is 'AXRole: entry' -PASS child.title is 'AXTitle: Full Name:' +FAIL child.role should be AXRole: entry. Was AXRole: paragraph. +FAIL child.title should be AXTitle: Full Name:. Was AXTitle: . PASS successfullyParsed is true TEST COMPLETE 506903 1 116073 mario 2011-11-21 06:15:31 -0800 Created attachment 116073 Patch 506906 2 mario 2011-11-21 06:19:51 -0800 (In reply to comment #1) > Created an attachment (id=116073) [details] > Patch It seems this has been a problem even before November the 7th (tried with a commit from Nov 1st, and was failing as well there). I have been trying to find out the exact point where it start failing but couldn't find it. However, as per visual inspection in the code, I now wonder how it could be working fine before, since its obvious that the form object in the middle was not being taking into account when it should, so either form objects were explicitly not being exposed before (which is not the case I think) or there was a bug somewhere else (e.g. determining when the webArea is focusable, determining if a form is visible or not...) that was fixed at some point recently, unleashing the problem with this wrongly implemented layout test (that I wrote btw, so assuming my fault on that :(). My guessing is that the reason why it started failing recently was the later one (a bug somewhere else that got fixed, unveiling the problem with this test), so that's why I propose now this patch, which is basically a rewrite of the layout test that properly considers the a11y hierarchy. 506908 3 pnormand 2011-11-21 06:23:00 -0800 It was skipped *before* I opened this bug, which I did when I moved the flaky tests in tests_expectations.txt 506936 4 116073 pnormand 2011-11-21 07:15:53 -0800 Comment on attachment 116073 Patch Looks sane to me! 507439 5 mario 2011-11-22 00:30:57 -0800 Committed r100979: <http://trac.webkit.org/changeset/100979> 116073 2011-11-21 06:15:31 -0800 2011-11-21 07:15:53 -0800 Patch bug-71665-20111121151529.patch text/plain 2707 mario U3VidmVyc2lvbiBSZXZpc2lvbjogMTAwODg4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjlhODYwYjEzYmM5ODg5NThlNzU5 YzJmODg2MGY1MjczYzMxYmY0NC4uMmE3NjYzNTNkMjQ3ODRkNTlhNmU0Y2U0YmZlYTg1ODUzZmQ0 YjZmMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTExLTIxICBNYXJpbyBTYW5jaGV6IFBy YWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBwbGF0Zm9ybS9ndGsv YWNjZXNzaWJpbGl0eS9uYW1lLWZyb20tbGFiZWwuaHRtbCBmYWlscworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE2NjUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggbGF5b3V0IHRlc3QgdG8gcHJvcGVy bHkgY29uc2lkZXIgJ2Zvcm0nIGFjY2Vzc2liaWxpdHkgb2JqZWN0cy4KKworICAgICAgICAqIHBs YXRmb3JtL2d0ay9Ta2lwcGVkOiBVbnNraXAgbmFtZS1mcm9tLWxhYmVsLmh0bWwuCisgICAgICAg ICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbmFtZS1mcm9tLWxhYmVsLmh0bWw6IFJlLXdy aXRlIGxheW91dAorICAgICAgICAgIHRlc3QgdG8gcHJvcGVybHkgdGFrZSBpbnRvIGFjY291bnQg dGhlIGFjY2Vzc2liaWxpdHkgaGllcmFyY2h5LgorCiAyMDExLTExLTIwICBTaGlueWEgS2F3YW5h a2EgIDxzaGlueWFrQGdvb2dsZS5jb20+CiAKICAgICAgICAgW0Nocm9taXVtXSBMYXlvdXQgdGVz dCBkb2VzIG5vdCByZXR1cm4gY29ycmVjdCBtaXNzcGVsbGluZyBwb3NpdGlvbnMgaWYgdGhlcmUg YXJlIG11bHRpcGxlIG1pc3NwZWxsZWQgd29yZHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCmlu ZGV4IDhlMzM5OWRlOWYzYjJiMmI0MzUyNDczNzgwN2RlOGYwZDMyNzg1ZDguLjEzZDFhZmQwOGM2 YTU1YTU4ZDE2NGRhZjY1MjU4MTg1N2M1NTA2NGMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVk CkBAIC0xNDk5LDkgKzE0OTksNiBAQCBmYXN0L2xvYWRlci9mb3JtLXN1Ym1pc3Npb24tYWZ0ZXIt YmVmb3JldW5sb2FkLWNhbmNlbC5odG1sCiBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9jb21i by1ib3gtY29sbGFwc2VkLXNlbGVjdGlvbi1jaGFuZ2VkLmh0bWwKIHBsYXRmb3JtL2d0ay9hY2Nl c3NpYmlsaXR5L2RvY3VtZW50LXJlbG9hZC1ldmVudHMuaHRtbAogCi0jIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTY2NQotcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxp dHkvbmFtZS1mcm9tLWxhYmVsLmh0bWwKLQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Njc3MTMKIGFjY2Vzc2liaWxpdHkvdGV4dGJveC1yb2xlLXJlcG9ydHMtc2Vs ZWN0aW9uLmh0bWwKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vz c2liaWxpdHkvbmFtZS1mcm9tLWxhYmVsLmh0bWwgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv YWNjZXNzaWJpbGl0eS9uYW1lLWZyb20tbGFiZWwuaHRtbAppbmRleCBlODIwZjc1OWIwNmFkNWVh NGI3MDQzYmQ4YjE5YjExMTcyNWEwNzQ4Li41N2Y2NmE3MzU2MzkwYzNjZWFkYzczMGMzNTFiY2Uz NWYxMDhmMThiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJp bGl0eS9uYW1lLWZyb20tbGFiZWwuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv YWNjZXNzaWJpbGl0eS9uYW1lLWZyb20tbGFiZWwuaHRtbApAQCAtMTIsMTIgKzEyLDEzIEBACiA8 ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KIDxzY3JpcHQ+CiAgIHZhciB3ZWJBcmVhOwotICB2YXIg Y2hpbGQ7CisgIHZhciBmb3JtOwogCiAgIGZ1bmN0aW9uIGNoZWNrUmVzdWx0cygpIHsKICAgICAv LyBBY3R1YWxseSBjaGVjayB0aGUgcmVzdWx0cwotICAgIHNob3VsZEJlKCJjaGlsZC5yb2xlIiwg IidBWFJvbGU6IGVudHJ5JyIpOwotICAgIHNob3VsZEJlKCJjaGlsZC50aXRsZSIsICInQVhUaXRs ZTogRnVsbCBOYW1lOiciKTsKKyAgICBlbnRyeSA9IGZvcm0uY2hpbGRBdEluZGV4KDEpOworICAg IHNob3VsZEJlKCJlbnRyeS5yb2xlIiwgIidBWFJvbGU6IGVudHJ5JyIpOworICAgIHNob3VsZEJl KCJlbnRyeS50aXRsZSIsICInQVhUaXRsZTogRnVsbCBOYW1lOiciKTsKICAgICBmaW5pc2hKU1Rl c3QoKTsKICAgfQogCkBAIC0zMCw3ICszMSw3IEBACiAKICAgICBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgiYm9keSIpLmZvY3VzKCk7CiAgICAgd2ViQXJlYSA9IGFjY2Vzc2liaWxpdHlDb250cm9s bGVyLmZvY3VzZWRFbGVtZW50OwotICAgIGNoaWxkID0gd2ViQXJlYS5jaGlsZEF0SW5kZXgoMSk7 CisgICAgZm9ybSA9IHdlYkFyZWEuY2hpbGRBdEluZGV4KDApOwogCiAgICAgLy8gQ2hlY2sgcmVz dWx0cyBvbiBpZGxlIHRvIGVuc3VyZSBsYXlvdXQoKSBpcyBkb25lCiAgICAgd2luZG93LnNldFRp bWVvdXQoImNoZWNrUmVzdWx0cygpIiwgMCk7Cg==