71655 2011-11-07 01:21:23 -0800 [GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky 2025-07-01 16:13:53 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=183129 Gtk, LayoutTestFailure P2 Normal --- 1 pnormand webkit-unassigned ahmad.saleem792 bugs-noreply fred.wang mcatanzaro pnormand zan oldest_to_newest 497015 0 pnormand 2011-11-07 01:21:23 -0800 Attaching simple patch. 497018 1 113833 pnormand 2011-11-07 01:27:20 -0800 Created attachment 113833 proposed patch 497251 2 pnormand 2011-11-07 09:45:13 -0800 Committed r99433: <http://trac.webkit.org/changeset/99433> 502036 3 pnormand 2011-11-14 10:01:01 -0800 It's still flaky :( --- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/frames/flattening/frameset-flattening-simple-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/frames/flattening/frameset-flattening-simple-actual.txt @@ -1,14 +1,14 @@ -layer at (0,0) size 1000x600 - RenderView at (0,0) size 800x584 -layer at (0,0) size 800x600 - RenderBlock {HTML} at (0,0) size 800x600 - RenderFrameSet {FRAMESET} at (0,0) size 1000x600 - RenderFrame {FRAME} at (0,0) size 800x600 - layer at (0,0) size 800x600 - RenderView at (0,0) size 800x600 - layer at (0,0) size 800x600 - RenderBlock {HTML} at (0,0) size 800x600 - RenderBody {BODY} at (8,8) size 784x576 [bgcolor=#008000] +layer at (0,0) size 1000x584 + RenderView at (0,0) size 784x584 +layer at (0,0) size 784x584 + RenderBlock {HTML} at (0,0) size 784x584 + RenderFrameSet {FRAMESET} at (0,0) size 1000x584 + RenderFrame {FRAME} at (0,0) size 800x584 + layer at (0,0) size 800x584 + RenderView at (0,0) size 800x584 + layer at (0,0) size 800x584 + RenderBlock {HTML} at (0,0) size 800x584 + RenderBody {BODY} at (8,8) size 784x560 [bgcolor=#008000] RenderBlock {P} at (0,0) size 784x19 RenderText {#text} at (0,0) size 445x19 text run at (0,0) width 445: "Test for frameset flattening. The flattening only works inside the DRT." @@ -17,9 +17,9 @@ text run at (0,0) width 458: "This frame should be 800px wide and not be scrollable (have scrollbars)." layer at (0,100) size 800x1 RenderBlock (positioned) {DIV} at (0,100) size 800x1 - RenderFrame {FRAME} at (800,0) size 200x600 - layer at (0,0) size 200x600 - RenderView at (0,0) size 200x600 - layer at (0,0) size 200x600 - RenderBlock {HTML} at (0,0) size 200x600 - RenderBody {BODY} at (8,8) size 184x584 + RenderFrame {FRAME} at (800,0) size 200x584 + layer at (0,0) size 200x584 + RenderView at (0,0) size 200x584 + layer at (0,0) size 200x584 + RenderBlock {HTML} at (0,0) size 200x584 + RenderBody {BODY} at (8,8) size 184x568 502888 4 pnormand 2011-11-15 07:12:05 -0800 Marked flaky in http://trac.webkit.org/changeset/100279 1402070 5 fred.wang 2018-02-26 09:17:21 -0800 (In reply to Philippe Normand from comment #3) > It's still flaky :( > > > --- > /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/ > frames/flattening/frameset-flattening-simple-expected.txt > +++ > /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/ > frames/flattening/frameset-flattening-simple-actual.txt > - RenderFrame {FRAME} at (0,0) size 800x600 > + RenderFrame {FRAME} at (0,0) size 800x584 It seems that the width is always 800px but the height changes, probably because of scrollbars on the main frame. I'm trying to rewrite the test in bug 183129, that would allow to get rid of these scrollbars. 1402087 6 mcatanzaro 2018-02-26 10:06:11 -0800 Does GTK support frame flattening...? 1402089 7 fred.wang 2018-02-26 10:11:32 -0800 (In reply to Michael Catanzaro from comment #6) > Does GTK support frame flattening...? Yes, it does. 1422679 8 fred.wang 2018-05-10 01:31:42 -0700 It seems frameset-flattening-simple is no longer flacky on GTK release but there are other similar tests (e.g. from bug 80129 marked as duplicate) that I did not rewrite and are still flacky. Also I wonder why frameset-flattening-simple is failing on debug build only: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&showFlaky=true&tests=frameset-flattening 2127164 9 ahmad.saleem792 2025-07-01 16:13:53 -0700 Test is gone - https://github.com/WebKit/WebKit/commit/37224f042c178a094cc2287dee595345bc89f687 113833 2011-11-07 01:27:20 -0800 2011-11-15 00:01:26 -0800 proposed patch proposed-patch.patch text/plain 1805 pnormand RnJvbSAyMzFiNGZmZGUwNTQzNGFiNzQyYzIxM2UwZmUwMDA4Yjc3MzBkMGE4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDcgTm92IDIwMTEgMTA6MjY6NTkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogLi4uL2ZsYXR0ZW5pbmcvZnJhbWVzZXQt ZmxhdHRlbmluZy1zaW1wbGUuaHRtbCAgICAgfCAgICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwg MTIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjM2MTk1NS4uNWY1NTc3 ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDExLTExLTA3ICBQaGlsaXBwZSBOb3JtYW5kICA8 cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBmYXN0L2ZyYW1lcy9mbGF0dGVu aW5nL2ZyYW1lc2V0LWZsYXR0ZW5pbmctc2ltcGxlLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNjU1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2ZyYW1lcy9mbGF0dGVu aW5nL2ZyYW1lc2V0LWZsYXR0ZW5pbmctc2ltcGxlLmh0bWw6IFRyaWdnZXIKKyAgICAgICAgdGhl IHRlc3Qgb25seSBhZnRlciB0aGUgZW1iZWRkZWQgZnJhbWUgaGFzIGJlZW4gbG9hZGVkLgorCisy MDExLTExLTA3ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwogICAg ICAgICBVbnJldmlld2VkLCB1bmtpcCBhIHdvcmtpbmcgdGVzdCBhbmQgcmVjbGFzc2lmeSB0aGUg d2hlZWxldmVudCBtaXNzaW5nIERSVCBmZWF0dXJlcy4KIAogICAgICAgICAqIHBsYXRmb3JtL2d0 ay9Ta2lwcGVkOgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvZmxhdHRlbmlu Zy9mcmFtZXNldC1mbGF0dGVuaW5nLXNpbXBsZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFt ZXMvZmxhdHRlbmluZy9mcmFtZXNldC1mbGF0dGVuaW5nLXNpbXBsZS5odG1sCmluZGV4IGYyMTg4 OTAuLjkzZWFhNWUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZnJhbWVzL2ZsYXR0ZW5p bmcvZnJhbWVzZXQtZmxhdHRlbmluZy1zaW1wbGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0 L2ZyYW1lcy9mbGF0dGVuaW5nL2ZyYW1lc2V0LWZsYXR0ZW5pbmctc2ltcGxlLmh0bWwKQEAgLTE1 LDggKzE1LDggQEAKICAgICAgICAgfQogICAgIDwvc2NyaXB0PgogPC9oZWFkPgotPGZyYW1lc2V0 IGJvcmRlcj0wIGNvbHM9IiosMjAwIiBvbmxvYWQ9InRlc3QoKSI+Ci0gICAgPGZyYW1lIHNyYz0i ZGF0YTp0ZXh0L2h0bWwsCis8ZnJhbWVzZXQgYm9yZGVyPTAgY29scz0iKiwyMDAiPgorICAgIDxm cmFtZSBvbmxvYWQ9InRlc3QoKSIgc3JjPSJkYXRhOnRleHQvaHRtbCwKICAgICAgICAgPHN0eWxl PmJvZHkgeyBiYWNrZ3JvdW5kLWNvbG9yOiBncmVlbjsgfTwvc3R5bGU+CiAgICAgICAgIDxwPgog ICAgICAgICAgICAgVGVzdCBmb3IgZnJhbWVzZXQgZmxhdHRlbmluZy4gVGhlIGZsYXR0ZW5pbmcg b25seSB3b3JrcyBpbnNpZGUgdGhlIERSVC4KLS0gCjEuNy43LjE=