<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>71651</bug_id>
          
          <creation_ts>2011-11-06 22:16:42 -0800</creation_ts>
          <short_desc>Refactor canvas encoding mimeType validation</short_desc>
          <delta_ts>2011-11-07 09:49:02 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Canvas</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="noel gordon">noel.gordon</reporter>
          <assigned_to name="noel gordon">noel.gordon</assigned_to>
          <cc>jamesr</cc>
    
    <cc>levin</cc>
    
    <cc>mdelaney7</cc>
    
    <cc>senorblanco</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>496972</commentid>
    <comment_count>0</comment_count>
    <who name="noel gordon">noel.gordon</who>
    <bug_when>2011-11-06 22:16:42 -0800</bug_when>
    <thetext>Refactor canvas encoding mimeType validation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>496974</commentid>
    <comment_count>1</comment_count>
      <attachid>113824</attachid>
    <who name="noel gordon">noel.gordon</who>
    <bug_when>2011-11-06 22:26:00 -0800</bug_when>
    <thetext>Created attachment 113824
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497197</commentid>
    <comment_count>2</comment_count>
      <attachid>113824</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2011-11-07 08:40:22 -0800</bug_when>
    <thetext>Comment on attachment 113824
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497255</commentid>
    <comment_count>3</comment_count>
      <attachid>113824</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-07 09:48:58 -0800</bug_when>
    <thetext>Comment on attachment 113824
Patch

Clearing flags on attachment: 113824

Committed r99434: &lt;http://trac.webkit.org/changeset/99434&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>497256</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-07 09:49:02 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>113824</attachid>
            <date>2011-11-06 22:26:00 -0800</date>
            <delta_ts>2011-11-07 09:48:57 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-71651-20111107172406.patch</filename>
            <type>text/plain</type>
            <size>3682</size>
            <attacher name="noel gordon">noel.gordon</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogOTkzODgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3N2QyNWE5MDBmMjVkZjQ4
MzMyZTQ0YTEyODk3NGQwNmI0OTBlODNiLi4zY2I0ZTFiYzlhMzg1ZGM0NTg2ZWZjMWYyNTQ1Njg3
MGFkZDIwNTZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTEtMDYgIE5vZWwg
R29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisgICAgICAgIFJlZmFjdG9yIGNhbnZh
cyBlbmNvZGluZyBtaW1lVHlwZSB2YWxpZGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTY1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmVmYWN0b3Jpbmcgb25seSwgY292
ZXJlZCBieSBleGlzdGluZyBjYW52YXMgdGVzdHMuCisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52
YXNFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50Ojp0b0Vu
Y29kaW5nTWltZVR5cGUpOiBtb3ZlIGVuY29kZXIgbWltZVR5cGUKKyAgICAgICAgdmFsaWRhdGlv
biBsb2dpYyBpbnRvIGEgaGVscGVyIHJvdXRpbmUuCisgICAgICAgIChXZWJDb3JlOjpIVE1MQ2Fu
dmFzRWxlbWVudDo6dG9EYXRhVVJMKToKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50
Lmg6CisKIDIwMTEtMTEtMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAg
ICAgICBEb24ndCBjcmFzaCB3aGVuIGEgY29udGV4dCBoYXNuJ3QgYmVlbiBjcmVhdGVkLiAgVGhp
cyBmaXhlZCBhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVt
ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCmluZGV4
IDg3Y2U5ZTljZjhmOGE4OWE2ZjkzOWY2ZjcwZjJhYjc2NDBkN2VlMTIuLjJmYzhjYTgzOTIzMDhk
YWZiOGFkMjc4YjM3ZmVjMTUyMTI0NTJjYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0
bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENh
bnZhc0VsZW1lbnQuY3BwCkBAIC0zMjgsNiArMzI4LDE3IEBAIHZvaWQgSFRNTENhbnZhc0VsZW1l
bnQ6OnNldFN1cmZhY2VTaXplKGNvbnN0IEludFNpemUmIHNpemUpCiAgICAgbV9jb3BpZWRJbWFn
ZS5jbGVhcigpOwogfQogCitTdHJpbmcgSFRNTENhbnZhc0VsZW1lbnQ6OnRvRW5jb2RpbmdNaW1l
VHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQoreworICAgIFN0cmluZyBsb3dlcmNhc2VNaW1l
VHlwZSA9IG1pbWVUeXBlLmxvd2VyKCk7CisKKyAgICAvLyBGSVhNRTogTWFrZSBpc1N1cHBvcnRl
ZEltYWdlTUlNRVR5cGVGb3JFbmNvZGluZyB0aHJlYWRzYWZlICh0byBhbGxvdyB0aGlzIG1ldGhv
ZCB0byBiZSB1c2VkIG9uIGEgd29ya2VyIHRocmVhZCkuCisgICAgaWYgKG1pbWVUeXBlLmlzTnVs
bCgpIHx8ICFNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1cHBvcnRlZEltYWdlTUlNRVR5cGVGb3JFbmNv
ZGluZyhsb3dlcmNhc2VNaW1lVHlwZSkpCisgICAgICAgIGxvd2VyY2FzZU1pbWVUeXBlID0gImlt
YWdlL3BuZyI7CisKKyAgICByZXR1cm4gbG93ZXJjYXNlTWltZVR5cGU7Cit9CisKIFN0cmluZyBI
VE1MQ2FudmFzRWxlbWVudDo6dG9EYXRhVVJMKGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIGNvbnN0
IGRvdWJsZSogcXVhbGl0eSwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAgICAgaWYgKCFtX29yaWdp
bkNsZWFuKSB7CkBAIC0zMzgsMjMgKzM0OSwxOSBAQCBTdHJpbmcgSFRNTENhbnZhc0VsZW1lbnQ6
OnRvRGF0YVVSTChjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBjb25zdCBkb3VibGUqIHF1YWxpdAog
ICAgIGlmIChtX3NpemUuaXNFbXB0eSgpIHx8ICFidWZmZXIoKSkKICAgICAgICAgcmV0dXJuIFN0
cmluZygiZGF0YTosIik7CiAKLSAgICBTdHJpbmcgbG93ZXJjYXNlTWltZVR5cGUgPSBtaW1lVHlw
ZS5sb3dlcigpOwotCi0gICAgLy8gRklYTUU6IE1ha2UgaXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBl
Rm9yRW5jb2RpbmcgdGhyZWFkc2FmZSAodG8gYWxsb3cgdGhpcyBtZXRob2QgdG8gYmUgdXNlZCBv
biBhIHdvcmtlciB0aHJlYWQpLgotICAgIGlmIChtaW1lVHlwZS5pc051bGwoKSB8fCAhTUlNRVR5
cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2RpbmcobG93ZXJjYXNl
TWltZVR5cGUpKQotICAgICAgICBsb3dlcmNhc2VNaW1lVHlwZSA9ICJpbWFnZS9wbmciOworICAg
IFN0cmluZyBlbmNvZGluZ01pbWVUeXBlID0gdG9FbmNvZGluZ01pbWVUeXBlKG1pbWVUeXBlKTsK
IAogI2lmIFVTRShDRykgfHwgVVNFKFNLSUEpCiAgICAgLy8gVHJ5IHRvIGdldCBJbWFnZURhdGEg
Zmlyc3QsIGFzIHRoYXQgbWF5IGF2b2lkIGxvc3N5IGNvbnZlcnNpb25zLgogICAgIFJlZlB0cjxJ
bWFnZURhdGE+IGltYWdlRGF0YSA9IGdldEltYWdlRGF0YSgpOwogCiAgICAgaWYgKGltYWdlRGF0
YSkKLSAgICAgICAgcmV0dXJuIEltYWdlRGF0YVRvRGF0YVVSTCgqaW1hZ2VEYXRhLCBsb3dlcmNh
c2VNaW1lVHlwZSwgcXVhbGl0eSk7CisgICAgICAgIHJldHVybiBJbWFnZURhdGFUb0RhdGFVUkwo
KmltYWdlRGF0YSwgZW5jb2RpbmdNaW1lVHlwZSwgcXVhbGl0eSk7CiAjZW5kaWYKIAogICAgIG1h
a2VSZW5kZXJpbmdSZXN1bHRzQXZhaWxhYmxlKCk7Ci0gICAgICAKLSAgICByZXR1cm4gYnVmZmVy
KCktPnRvRGF0YVVSTChsb3dlcmNhc2VNaW1lVHlwZSwgcXVhbGl0eSk7CisKKyAgICByZXR1cm4g
YnVmZmVyKCktPnRvRGF0YVVSTChlbmNvZGluZ01pbWVUeXBlLCBxdWFsaXR5KTsKIH0KIAogUGFz
c1JlZlB0cjxJbWFnZURhdGE+IEhUTUxDYW52YXNFbGVtZW50OjpnZXRJbWFnZURhdGEoKQpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oIGIvU291cmNl
L1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCmluZGV4IGVhYzU5YWJlZTI4OTM0Njli
MTlmNWIyNGE5OTk2NmJjZTBhMGEyMGMuLmVjNGM4MGU3MTdjMTdkODQ3ZTZhYzY4NmJiYzNhMmZm
OGRlOTQyZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1l
bnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmgKQEAgLTkx
LDYgKzkxLDcgQEAgcHVibGljOgogCiAgICAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dCogZ2V0Q29u
dGV4dChjb25zdCBTdHJpbmcmLCBDYW52YXNDb250ZXh0QXR0cmlidXRlcyogYXR0cmlidXRlcyA9
IDApOwogCisgICAgc3RhdGljIFN0cmluZyB0b0VuY29kaW5nTWltZVR5cGUoY29uc3QgU3RyaW5n
JiBtaW1lVHlwZSk7CiAgICAgU3RyaW5nIHRvRGF0YVVSTChjb25zdCBTdHJpbmcmIG1pbWVUeXBl
LCBjb25zdCBkb3VibGUqIHF1YWxpdHksIEV4Y2VwdGlvbkNvZGUmKTsKICAgICBTdHJpbmcgdG9E
YXRhVVJMKGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIEV4Y2VwdGlvbkNvZGUmIGVjKSB7IHJldHVy
biB0b0RhdGFVUkwobWltZVR5cGUsIDAsIGVjKTsgfQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>