71647 2011-11-06 19:43:47 -0800 DFG operationCreateThis slow path may get the wrong callee in case of inlining 2011-11-07 16:37:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 496952 0 fpizlo 2011-11-06 19:43:47 -0800 This bug is self-evident in the code, but it's really hard to reproduce - I only saw it when working on a changeset that had bugs in value profiling. Patch forthcoming. 496953 1 113820 fpizlo 2011-11-06 19:45:54 -0800 Created attachment 113820 the patch 496954 2 webkit.review.bot 2011-11-06 19:51:16 -0800 Attachment 113820 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGOperations.h:67: DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 496973 3 113820 oliver 2011-11-06 22:19:51 -0800 Comment on attachment 113820 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=113820&action=review >> Source/JavaScriptCore/dfg/DFGOperations.h:67 >> +typedef JSCell* DFG_OPERATION (*C_DFGOperation_ECC)(ExecState*, JSCell*, JSCell*); > > DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] We really should beat the stylebot into not producing these warnings 497313 4 oliver 2011-11-07 11:16:02 -0800 <rdar://problem/10406876> 497591 5 fpizlo 2011-11-07 16:37:56 -0800 Landed in http://trac.webkit.org/changeset/99502 113820 2011-11-06 19:45:54 -0800 2011-11-06 22:19:51 -0800 the patch fixconstruct_patch_1.diff text/plain 7040 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTkzOTQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTEtMTEtMDYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE Rkcgb3BlcmF0aW9uQ3JlYXRlVGhpcyBzbG93IHBhdGggbWF5IGdldCB0aGUgd3JvbmcgY2FsbGVl IGluIGNhc2Ugb2YgaW5saW5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTcxNjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisgICAgICAgIAorICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBJIG9ubHkgc2F3IHRoaXMg bWFuaWZlc3QgaXRzZWxmIHdoZW4gSSBoYWQgb3RoZXIgYnVncworICAgICAgICBsZWFkaW5nIHRv IHNwdXJpb3VzIHNsb3cgcGF0aCBleGVjdXRpb25zLgorCisgICAgICAgICogZGZnL0RGR0pJVENv ZGVHZW5lcmF0b3IuaDoKKyAgICAgICAgKEpTQzo6REZHOjpjYWxsT3BlcmF0aW9uKToKKyAgICAg ICAgKiBkZmcvREZHT3BlcmF0aW9ucy5jcHA6CisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMu aDoKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHA6CisgICAgICAgIChK U0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUpOgorICAgICAgICAqIGRmZy9ERkdTcGVj dWxhdGl2ZUpJVDY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29t cGlsZSk6CisKIDIwMTEtMTEtMDYgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OKHI5OTM3NCk6IEdUSysgYnVpbGQgb2YgdGhlIGpzYyBiaW5hcnkg ZG9lc24ndCBsaWtlIHRoZSBjYWxsCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0pJVENvZGVHZW5lcmF0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IuaAkocmV2aXNpb24gOTkzODgpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvZGVHZW5lcmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAt MTM5Niw2ICsxMzk2LDExIEBAIHByb3RlY3RlZDoKICAgICAgICAgc2V0dXBBcmd1bWVudHNXaXRo RXhlY1N0YXRlKGFyZzEpOwogICAgICAgICByZXR1cm4gYXBwZW5kQ2FsbFdpdGhFeGNlcHRpb25D aGVja1NldFJlc3VsdChvcGVyYXRpb24sIHJlc3VsdCk7CiAgICAgfQorICAgIEpJVENvbXBpbGVy OjpDYWxsIGNhbGxPcGVyYXRpb24oQ19ERkdPcGVyYXRpb25fRUNDIG9wZXJhdGlvbiwgR1BSUmVn IHJlc3VsdCwgR1BSUmVnIGFyZzEsIEpTQ2VsbCogY2VsbCkKKyAgICB7CisgICAgICAgIHNldHVw QXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShhcmcxLCBUcnVzdGVkSW1tUHRyKGNlbGwpKTsKKyAgICAg ICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2tTZXRSZXN1bHQob3BlcmF0aW9u LCByZXN1bHQpOworICAgIH0KICAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxsT3BlcmF0aW9uKFNf REZHT3BlcmF0aW9uX0VKIG9wZXJhdGlvbiwgR1BSUmVnIHJlc3VsdCwgR1BSUmVnIGFyZzEpCiAg ICAgewogICAgICAgICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSk7CkBAIC0xNTQ5 LDYgKzE1NTQsMTEgQEAgcHJvdGVjdGVkOgogICAgICAgICBzZXR1cEFyZ3VtZW50c1dpdGhFeGVj U3RhdGUoYXJnMSk7CiAgICAgICAgIHJldHVybiBhcHBlbmRDYWxsV2l0aEV4Y2VwdGlvbkNoZWNr U2V0UmVzdWx0KG9wZXJhdGlvbiwgcmVzdWx0KTsKICAgICB9CisgICAgSklUQ29tcGlsZXI6OkNh bGwgY2FsbE9wZXJhdGlvbihDX0RGR09wZXJhdGlvbl9FQ0Mgb3BlcmF0aW9uLCBHUFJSZWcgcmVz dWx0LCBHUFJSZWcgYXJnMSwgSlNDZWxsKiBjZWxsKQorICAgIHsKKyAgICAgICAgc2V0dXBBcmd1 bWVudHNXaXRoRXhlY1N0YXRlKGFyZzEsIFRydXN0ZWRJbW1QdHIoY2VsbCkpOworICAgICAgICBy ZXR1cm4gYXBwZW5kQ2FsbFdpdGhFeGNlcHRpb25DaGVja1NldFJlc3VsdChvcGVyYXRpb24sIHJl c3VsdCk7CisgICAgfQogICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oU19ERkdP cGVyYXRpb25fRUogb3BlcmF0aW9uLCBHUFJSZWcgcmVzdWx0LCBHUFJSZWcgYXJnMVRhZywgR1BS UmVnIGFyZzFQYXlsb2FkKQogICAgIHsKICAgICAgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0 YXRlKGFyZzFQYXlsb2FkLCBhcmcxVGFnKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHT3BlcmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdPcGVyYXRpb25zLmNwcAkocmV2aXNpb24gOTkzODgpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjMsMTAg KzE2Myw4IEBAIEVuY29kZWRKU1ZhbHVlIERGR19PUEVSQVRJT04gb3BlcmF0aW9uQ28KICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTVmFsdWU6OmRlY29kZShlbmNvZGVkT3ApLnRvVGhpc09i amVjdChleGVjKSk7CiB9CiAKLUpTQ2VsbCogREZHX09QRVJBVElPTiBvcGVyYXRpb25DcmVhdGVU aGlzKEV4ZWNTdGF0ZSogZXhlYywgSlNDZWxsKiBwcm90b3R5cGUpCitpbmxpbmUgSlNDZWxsKiBj cmVhdGVUaGlzKEV4ZWNTdGF0ZSogZXhlYywgSlNDZWxsKiBwcm90b3R5cGUsIEpTRnVuY3Rpb24q IGNvbnN0cnVjdG9yKQogewotICAgIEpTRnVuY3Rpb24qIGNvbnN0cnVjdG9yID0gYXNGdW5jdGlv bihleGVjLT5jYWxsZWUoKSk7Ci0gICAgCiAjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgIENvbnN0 cnVjdERhdGEgY29uc3RydWN0RGF0YTsKICAgICBBU1NFUlQoY29uc3RydWN0b3ItPm1ldGhvZFRh YmxlKCktPmdldENvbnN0cnVjdERhdGEoY29uc3RydWN0b3IsIGNvbnN0cnVjdERhdGEpID09IENv bnN0cnVjdFR5cGVKUyk7CkBAIC0xODMsNiArMTgxLDE2IEBAIEpTQ2VsbCogREZHX09QRVJBVElP TiBvcGVyYXRpb25DcmVhdGVUaGkKICAgICByZXR1cm4gY29uc3RydWN0RW1wdHlPYmplY3QoZXhl Yywgc3RydWN0dXJlKTsKIH0KIAorSlNDZWxsKiBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbkNyZWF0 ZVRoaXMoRXhlY1N0YXRlKiBleGVjLCBKU0NlbGwqIHByb3RvdHlwZSkKK3sKKyAgICByZXR1cm4g Y3JlYXRlVGhpcyhleGVjLCBwcm90b3R5cGUsIGFzRnVuY3Rpb24oZXhlYy0+Y2FsbGVlKCkpKTsK K30KKworSlNDZWxsKiBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbkNyZWF0ZVRoaXNJbmxpbmVkKEV4 ZWNTdGF0ZSogZXhlYywgSlNDZWxsKiBwcm90b3R5cGUsIEpTQ2VsbCogY29uc3RydWN0b3IpCit7 CisgICAgcmV0dXJuIGNyZWF0ZVRoaXMoZXhlYywgcHJvdG90eXBlLCBzdGF0aWNfY2FzdDxKU0Z1 bmN0aW9uKj4oY29uc3RydWN0b3IpKTsKK30KKwogSlNDZWxsKiBERkdfT1BFUkFUSU9OIG9wZXJh dGlvbk5ld09iamVjdChFeGVjU3RhdGUqIGV4ZWMpCiB7CiAgICAgcmV0dXJuIGNvbnN0cnVjdEVt cHR5T2JqZWN0KGV4ZWMpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVy YXRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVy YXRpb25zLmgJKHJldmlzaW9uIDk5Mzg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdPcGVyYXRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTY0LDYgKzY0LDcgQEAgZXh0ZXJuICJD IiB7CiB0eXBlZGVmIGludDMyX3QgREZHX09QRVJBVElPTiAoKlpfREZHT3BlcmF0aW9uX0QpKGRv dWJsZSk7CiB0eXBlZGVmIEpTQ2VsbCogREZHX09QRVJBVElPTiAoKkNfREZHT3BlcmF0aW9uX0Up KEV4ZWNTdGF0ZSopOwogdHlwZWRlZiBKU0NlbGwqIERGR19PUEVSQVRJT04gKCpDX0RGR09wZXJh dGlvbl9FQykoRXhlY1N0YXRlKiwgSlNDZWxsKik7Cit0eXBlZGVmIEpTQ2VsbCogREZHX09QRVJB VElPTiAoKkNfREZHT3BlcmF0aW9uX0VDQykoRXhlY1N0YXRlKiwgSlNDZWxsKiwgSlNDZWxsKik7 CiB0eXBlZGVmIEVuY29kZWRKU1ZhbHVlIERGR19PUEVSQVRJT04gKCpKX0RGR09wZXJhdGlvbl9F QSkoRXhlY1N0YXRlKiwgSlNBcnJheSopOwogdHlwZWRlZiBFbmNvZGVkSlNWYWx1ZSBERkdfT1BF UkFUSU9OICgqSl9ERkdPcGVyYXRpb25fRUpBKShFeGVjU3RhdGUqLCBFbmNvZGVkSlNWYWx1ZSwg SlNBcnJheSopOwogdHlwZWRlZiBFbmNvZGVkSlNWYWx1ZSBERkdfT1BFUkFUSU9OICgqSl9ERkdP cGVyYXRpb25fRUNKKShFeGVjU3RhdGUqLCBKU0NlbGwqLCBFbmNvZGVkSlNWYWx1ZSk7CkBAIC05 Miw2ICs5Myw3IEBAIHR5cGVkZWYgdm9pZCogREZHX09QRVJBVElPTiAoKlBfREZHT3BlcmEKIC8v IFRoZXNlIHJvdXRpbmVzIGFyZSBwcm92aWRlIGNhbGxiYWNrcyBvdXQgdG8gQysrIGltcGxlbWVu dGF0aW9ucyBvZiBvcGVyYXRpb25zIHRvbyBjb21wbGV4IHRvIEpJVC4KIEpTQ2VsbCogREZHX09Q RVJBVElPTiBvcGVyYXRpb25OZXdPYmplY3QoRXhlY1N0YXRlKik7CiBKU0NlbGwqIERGR19PUEVS QVRJT04gb3BlcmF0aW9uQ3JlYXRlVGhpcyhFeGVjU3RhdGUqLCBKU0NlbGwqIGVuY29kZWRPcDEp OworSlNDZWxsKiBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbkNyZWF0ZVRoaXNJbmxpbmVkKEV4ZWNT dGF0ZSosIEpTQ2VsbCogZW5jb2RlZE9wMSwgSlNDZWxsKiBjb25zdHJ1Y3Rvcik7CiBFbmNvZGVk SlNWYWx1ZSBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbkNvbnZlcnRUaGlzKEV4ZWNTdGF0ZSosIEVu Y29kZWRKU1ZhbHVlIGVuY29kZWRPcDEpOwogRW5jb2RlZEpTVmFsdWUgREZHX09QRVJBVElPTiBv cGVyYXRpb25WYWx1ZUFkZChFeGVjU3RhdGUqLCBFbmNvZGVkSlNWYWx1ZSBlbmNvZGVkT3AxLCBF bmNvZGVkSlNWYWx1ZSBlbmNvZGVkT3AyKTsKIEVuY29kZWRKU1ZhbHVlIERGR19PUEVSQVRJT04g b3BlcmF0aW9uVmFsdWVBZGROb3ROdW1iZXIoRXhlY1N0YXRlKiwgRW5jb2RlZEpTVmFsdWUgZW5j b2RlZE9wMSwgRW5jb2RlZEpTVmFsdWUgZW5jb2RlZE9wMik7CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUMzJfNjQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHJldmlz aW9uIDk5Mzg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJ VDMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk3NSw3ICsxOTc1LDEwIEBAIHZvaWQgU3Bl Y3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSYgbm9kZSkKICAgICAgICAgc2xvd1BhdGgubGluaygm bV9qaXQpOwogICAgICAgICAKICAgICAgICAgc2lsZW50U3BpbGxBbGxSZWdpc3RlcnMocmVzdWx0 R1BSKTsKLSAgICAgICAgY2FsbE9wZXJhdGlvbihvcGVyYXRpb25DcmVhdGVUaGlzLCByZXN1bHRH UFIsIHByb3RvR1BSKTsKKyAgICAgICAgaWYgKG5vZGUuY29kZU9yaWdpbi5pbmxpbmVDYWxsRnJh bWUpCisgICAgICAgICAgICBjYWxsT3BlcmF0aW9uKG9wZXJhdGlvbkNyZWF0ZVRoaXNJbmxpbmVk LCByZXN1bHRHUFIsIHByb3RvR1BSLCBub2RlLmNvZGVPcmlnaW4uaW5saW5lQ2FsbEZyYW1lLT5j YWxsZWUuZ2V0KCkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBjYWxsT3BlcmF0aW9uKG9w ZXJhdGlvbkNyZWF0ZVRoaXMsIHJlc3VsdEdQUiwgcHJvdG9HUFIpOwogICAgICAgICBzaWxlbnRG aWxsQWxsUmVnaXN0ZXJzKHJlc3VsdEdQUik7CiAgICAgICAgIAogICAgICAgICBkb25lLmxpbmso Jm1faml0KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVK SVQ2NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVj dWxhdGl2ZUpJVDY0LmNwcAkocmV2aXNpb24gOTkzODgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1NwZWN1bGF0aXZlSklUNjQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xOTg1LDcg KzE5ODUsMTAgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZShOb2RlJiBub2RlKQogICAg ICAgICBzbG93UGF0aC5saW5rKCZtX2ppdCk7CiAgICAgICAgIAogICAgICAgICBzaWxlbnRTcGls bEFsbFJlZ2lzdGVycyhyZXN1bHRHUFIpOwotICAgICAgICBjYWxsT3BlcmF0aW9uKG9wZXJhdGlv bkNyZWF0ZVRoaXMsIHJlc3VsdEdQUiwgcHJvdG9HUFIpOworICAgICAgICBpZiAobm9kZS5jb2Rl T3JpZ2luLmlubGluZUNhbGxGcmFtZSkKKyAgICAgICAgICAgIGNhbGxPcGVyYXRpb24ob3BlcmF0 aW9uQ3JlYXRlVGhpc0lubGluZWQsIHJlc3VsdEdQUiwgcHJvdG9HUFIsIG5vZGUuY29kZU9yaWdp bi5pbmxpbmVDYWxsRnJhbWUtPmNhbGxlZS5nZXQoKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAg ICAgIGNhbGxPcGVyYXRpb24ob3BlcmF0aW9uQ3JlYXRlVGhpcywgcmVzdWx0R1BSLCBwcm90b0dQ Uik7CiAgICAgICAgIHNpbGVudEZpbGxBbGxSZWdpc3RlcnMocmVzdWx0R1BSKTsKICAgICAgICAg CiAgICAgICAgIGRvbmUubGluaygmbV9qaXQpOwo=