71646 2011-11-06 19:09:28 -0800 Remove unnecessary use of function pointer in FrameSelection::modify() 2011-11-07 15:43:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboxhall aboxhall rniwa webkit.review.bot oldest_to_newest 496946 0 aboxhall 2011-11-06 19:09:28 -0800 Remove unnecessary use of function pointer in FrameSelection::modify() 496947 1 113818 aboxhall 2011-11-06 19:10:45 -0800 Created attachment 113818 Patch 496951 2 113818 rniwa 2011-11-06 19:41:33 -0800 Comment on attachment 113818 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113818&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Please remove this line before commit. 497471 3 113930 aboxhall 2011-11-07 14:24:30 -0800 Created attachment 113930 Patch 497474 4 113930 webkit.review.bot 2011-11-07 14:25:54 -0800 Comment on attachment 113930 Patch Rejecting attachment 113930 from review queue. aboxhall@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 497542 5 113930 webkit.review.bot 2011-11-07 15:43:37 -0800 Comment on attachment 113930 Patch Clearing flags on attachment: 113930 Committed r99492: <http://trac.webkit.org/changeset/99492> 497543 6 webkit.review.bot 2011-11-07 15:43:42 -0800 All reviewed patches have been landed. Closing bug. 113818 2011-11-06 19:10:45 -0800 2011-11-07 14:24:23 -0800 Patch bug-71646-20111107141043.patch text/plain 1569 aboxhall U3VidmVyc2lvbiBSZXZpc2lvbjogOTkzODYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3N2QyNWE5MDBmMjVkZjQ4 MzMyZTQ0YTEyODk3NGQwNmI0OTBlODNiLi4wMThkNmQ0ZDlmYjAzODgyYTVkYmU1OTQ4NTM0MTMy YTk1NzBlZTE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEtMDYgIEFsaWNl IEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVubmVj ZXNzYXJ5IHVzZSBvZiBmdW5jdGlvbiBwb2ludGVyIGluIEZyYW1lU2VsZWN0aW9uOjptb2RpZnko KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE2NDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg dGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RnJhbWVTZWxlY3Rpb246Om1vZGlmeSk6CisKIDIwMTEtMTEtMDYg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBEb24ndCBjcmFzaCB3 aGVuIGEgY29udGV4dCBoYXNuJ3QgYmVlbiBjcmVhdGVkLiAgVGhpcyBmaXhlZCBhCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCmluZGV4IGM3YmYzYWI3ZDMyYTZlZGQy Y2JkNTQ3OWRjZGJlNThkZWFjODRmODguLjU4MGU4ZmY2YzgzM2JhMGQ5YTc3NGMzMGYxM2QyZTAy OTAwYWIyM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rp b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCkBA IC0xMDI0LDcgKzEwMjQsMTEgQEAgYm9vbCBGcmFtZVNlbGVjdGlvbjo6bW9kaWZ5KEVBbHRlcmF0 aW9uIGFsdGVyLCB1bnNpZ25lZCB2ZXJ0aWNhbERpc3RhbmNlLCBWZXJ0aWMKICAgICBWaXNpYmxl UG9zaXRpb24gcmVzdWx0OwogICAgIFZpc2libGVQb3NpdGlvbiBuZXh0OwogICAgIGZvciAoVmlz aWJsZVBvc2l0aW9uIHAgPSBwb3M7IDsgcCA9IG5leHQpIHsKLSAgICAgICAgbmV4dCA9IChkaXJl Y3Rpb24gPT0gRGlyZWN0aW9uVXAgPyBwcmV2aW91c0xpbmVQb3NpdGlvbiA6IG5leHRMaW5lUG9z aXRpb24pKHAsIHhQb3MpOworICAgICAgICBpZiAoZGlyZWN0aW9uID09IERpcmVjdGlvblVwKQor ICAgICAgICAgICAgbmV4dCA9IHByZXZpb3VzTGluZVBvc2l0aW9uKHAsIHhQb3MpOworICAgICAg ICBlbHNlCisgICAgICAgICAgICBuZXh0ID0gbmV4dExpbmVQb3NpdGlvbihwLCB4UG9zKTsKKwog ICAgICAgICBpZiAobmV4dC5pc051bGwoKSB8fCBuZXh0ID09IHApCiAgICAgICAgICAgICBicmVh azsKICAgICAgICAgTGF5b3V0VW5pdCBuZXh0WTsK 113930 2011-11-07 14:24:30 -0800 2011-11-07 15:43:37 -0800 Patch bug-71646-20111108092427.patch text/plain 1536 aboxhall U3VidmVyc2lvbiBSZXZpc2lvbjogOTkzODYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3N2QyNWE5MDBmMjVkZjQ4 MzMyZTQ0YTEyODk3NGQwNmI0OTBlODNiLi5kMTBlMDZhYTUwMTZhNzNjNGZlNWQ4NmQzN2NmN2My NTljZjA4NWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEtMDYgIEFsaWNl IEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVubmVj ZXNzYXJ5IHVzZSBvZiBmdW5jdGlvbiBwb2ludGVyIGluIEZyYW1lU2VsZWN0aW9uOjptb2RpZnko KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE2NDYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVkaXRp bmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVTZWxlY3Rpb246 Om1vZGlmeSk6CisKIDIwMTEtMTEtMDYgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4K IAogICAgICAgICBEb24ndCBjcmFzaCB3aGVuIGEgY29udGV4dCBoYXNuJ3QgYmVlbiBjcmVhdGVk LiAgVGhpcyBmaXhlZCBhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1l U2VsZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3Bw CmluZGV4IGM3YmYzYWI3ZDMyYTZlZGQyY2JkNTQ3OWRjZGJlNThkZWFjODRmODguLjU4MGU4ZmY2 YzgzM2JhMGQ5YTc3NGMzMGYxM2QyZTAyOTAwYWIyM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvRnJhbWVTZWxlY3Rpb24uY3BwCkBAIC0xMDI0LDcgKzEwMjQsMTEgQEAgYm9vbCBGcmFtZVNl bGVjdGlvbjo6bW9kaWZ5KEVBbHRlcmF0aW9uIGFsdGVyLCB1bnNpZ25lZCB2ZXJ0aWNhbERpc3Rh bmNlLCBWZXJ0aWMKICAgICBWaXNpYmxlUG9zaXRpb24gcmVzdWx0OwogICAgIFZpc2libGVQb3Np dGlvbiBuZXh0OwogICAgIGZvciAoVmlzaWJsZVBvc2l0aW9uIHAgPSBwb3M7IDsgcCA9IG5leHQp IHsKLSAgICAgICAgbmV4dCA9IChkaXJlY3Rpb24gPT0gRGlyZWN0aW9uVXAgPyBwcmV2aW91c0xp bmVQb3NpdGlvbiA6IG5leHRMaW5lUG9zaXRpb24pKHAsIHhQb3MpOworICAgICAgICBpZiAoZGly ZWN0aW9uID09IERpcmVjdGlvblVwKQorICAgICAgICAgICAgbmV4dCA9IHByZXZpb3VzTGluZVBv c2l0aW9uKHAsIHhQb3MpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBuZXh0ID0gbmV4dExp bmVQb3NpdGlvbihwLCB4UG9zKTsKKwogICAgICAgICBpZiAobmV4dC5pc051bGwoKSB8fCBuZXh0 ID09IHApCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgTGF5b3V0VW5pdCBuZXh0WTsK