71640 2011-11-06 15:27:08 -0800 Remove ColorInputType::handleClickEvent 2011-11-06 18:35:01 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keishi keishi tkent webkit.review.bot oldest_to_newest 496900 0 keishi 2011-11-06 15:27:08 -0800 When you click the input color element, both ColorInputType::handleClickEvent and ColorInputType::handleDOMActivateEvent are called, causing Chrome::openColorChooser to be called too many times. 496904 1 113808 keishi 2011-11-06 15:30:41 -0800 Created attachment 113808 Patch 496922 2 113808 tkent 2011-11-06 17:15:58 -0800 Comment on attachment 113808 Patch ok 496941 3 113808 webkit.review.bot 2011-11-06 18:34:57 -0800 Comment on attachment 113808 Patch Clearing flags on attachment: 113808 Committed r99391: <http://trac.webkit.org/changeset/99391> 496942 4 webkit.review.bot 2011-11-06 18:35:01 -0800 All reviewed patches have been landed. Closing bug. 113808 2011-11-06 15:30:41 -0800 2011-11-06 18:34:57 -0800 Patch bug-71640-20111107083040.patch text/plain 2496 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogOTkyNzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZjI0NzczMTkzNDk2M2Vh ZGNkZTA2ZjMwMjMwMDlmOGE4NzQxYmJmLi44MmI4MmUwNWU4YWExNDhjNTlhN2RkZjFjYWYxMDY1 NmIwM2E1OWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMTEtMDYgIEtlaXNo aSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIENvbG9ySW5w dXRUeXBlOjpoYW5kbGVDbGlja0V2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03MTY0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4geW91IGNsaWNrIHRoZSBpbnB1dCBjb2xvciBlbGVtZW50LCBi b3RoIENvbG9ySW5wdXRUeXBlOjpoYW5kbGVDbGlja0V2ZW50IGFuZAorICAgICAgICBDb2xvcklu cHV0VHlwZTo6aGFuZGxlRE9NQWN0aXZhdGVFdmVudCBhcmUgY2FsbGVkLCBjYXVzaW5nIENocm9t ZTo6b3BlbkNvbG9yQ2hvb3NlcgorICAgICAgICB0byBiZSBjYWxsZWQgdG9vIG1hbnkgdGltZXMu CisKKyAgICAgICAgKiBodG1sL0NvbG9ySW5wdXRUeXBlLmNwcDogUmVtb3ZlZCBDb2xvcklucHV0 VHlwZTo6aGFuZGxlQ2xpY2tFdmVudAorICAgICAgICAqIGh0bWwvQ29sb3JJbnB1dFR5cGUuaDog UmVtb3ZlZCBDb2xvcklucHV0VHlwZTo6aGFuZGxlQ2xpY2tFdmVudAorCiAyMDExLTExLTA0ICBQ YXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgQ01ha2UgYnVpbGQgZml4IGZvciAhRU5BQkxFKFNRTF9EQVRBQkFTRSkuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCmluZGV4IGM4MmNiZjQ1OGMxMWY1YjI0ZDAxMDY4ZjYz ZTEzNmYzMTY4YzJmZWUuLmUwMTZhZWY2NzM2ZGYxMmRhZjUxM2I4NmU3MTFlNzNiNzM4NDU5ZmQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1dFR5cGUuY3BwCkBAIC0xMzIsMjEgKzEzMiw2 IEBAIHZvaWQgQ29sb3JJbnB1dFR5cGU6OnNldFZhbHVlKGNvbnN0IFN0cmluZyYgdmFsdWUsIGJv b2wgdmFsdWVDaGFuZ2VkLCBib29sIHNlbmRDCiAgICAgfQogfQogCi12b2lkIENvbG9ySW5wdXRU eXBlOjpoYW5kbGVDbGlja0V2ZW50KE1vdXNlRXZlbnQqIGV2ZW50KQotewotICAgIGlmIChldmVu dC0+aXNTaW11bGF0ZWQoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgaWYgKGVsZW1lbnQoKS0+ ZGlzYWJsZWQoKSB8fCBlbGVtZW50KCktPnJlYWRPbmx5KCkpCi0gICAgICAgIHJldHVybjsKLQot ICAgIGlmIChDaHJvbWUqIGNocm9tZSA9IHRoaXMtPmNocm9tZSgpKSB7Ci0gICAgICAgIENvbG9y Q2hvb3Nlcjo6Y2hvb3NlcigpLT5jb25uZWN0Q2xpZW50KHRoaXMpOwotICAgICAgICBjaHJvbWUt Pm9wZW5Db2xvckNob29zZXIoQ29sb3JDaG9vc2VyOjpjaG9vc2VyKCksIHZhbHVlQXNDb2xvcigp KTsKLSAgICB9Ci0gICAgZXZlbnQtPnNldERlZmF1bHRIYW5kbGVkKCk7Ci19Ci0KIHZvaWQgQ29s b3JJbnB1dFR5cGU6OmhhbmRsZURPTUFjdGl2YXRlRXZlbnQoRXZlbnQqIGV2ZW50KQogewogICAg IGlmIChlbGVtZW50KCktPmRpc2FibGVkKCkgfHwgZWxlbWVudCgpLT5yZWFkT25seSgpIHx8ICFl bGVtZW50KCktPnJlbmRlcmVyKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Nv bG9ySW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0NvbG9ySW5wdXRUeXBlLmgKaW5k ZXggMGU0YjBkNTM5MjMxZGI0NTRiZTA0YmQ2ZTFhZGU4M2JhYzQ4N2FmOC4uYTE1MjkzODdmMmI2 ZTEzMmYwOGQ0N2IzNjkzYzQ3YjEzN2JkNmM0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9Db2xvcklucHV0VHlwZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQ29sb3JJbnB1 dFR5cGUuaApAQCAtNTMsNyArNTMsNiBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgQ29sb3IgdmFs dWVBc0NvbG9yKCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIGNyZWF0ZVNoYWRvd1N1YnRyZWUo KTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0VmFsdWUoY29uc3QgU3RyaW5nJiwgYm9vbCB2YWx1ZUNo YW5nZWQsIGJvb2wgc2VuZENoYW5nZUV2ZW50KTsKLSAgICB2aXJ0dWFsIHZvaWQgaGFuZGxlQ2xp Y2tFdmVudChNb3VzZUV2ZW50Kik7CiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZURPTUFjdGl2YXRl RXZlbnQoRXZlbnQqKTsKICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCk7CiAK