71637 2011-11-06 14:52:16 -0800 [chromium] When GC3DPrivate::initializExtensions fails, dont keep retrying 2011-11-08 20:04:00 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca nduca kbr webkit.review.bot oldest_to_newest 496891 0 nduca 2011-11-06 14:52:16 -0800 [chromium] When GC3DPrivate::initializExtensions fails, dont keep retrying 496892 1 113804 nduca 2011-11-06 14:52:33 -0800 Created attachment 113804 Patch 496893 2 nduca 2011-11-06 14:53:52 -0800 While this should never happen, one side effect of the way the initializeExtensions routine is currently implemented is that when the init fails, it will keep hammering on makeCurrent every time it is called. This makes debugging failures that follow difficult. 498564 3 113804 kbr 2011-11-08 17:44:07 -0800 Comment on attachment 113804 Patch Looks good to me. 498618 4 113804 webkit.review.bot 2011-11-08 20:03:56 -0800 Comment on attachment 113804 Patch Clearing flags on attachment: 113804 Committed r99648: <http://trac.webkit.org/changeset/99648> 498619 5 webkit.review.bot 2011-11-08 20:04:00 -0800 All reviewed patches have been landed. Closing bug. 113804 2011-11-06 14:52:33 -0800 2011-11-08 20:03:55 -0800 Patch bug-71637-20111106145232.patch text/plain 2203 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogOTkyMzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MDFjNjM4OWU4NTg0NTE0NmQ1ZmZiOWRjZDk1MTJmODIwNjkyMjllMC4uMTFmMWIyZDA2NTcwOWNj YjJlMWIwOTA4MzllNjIxOGJjNDhlMDMxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0xMS0wNiAgTmF0IER1Y2EgIDxuZHVjYUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW2Nocm9taXVtXSBXaGVuIEdDM0RQcml2YXRlOjppbml0aWFsaXpFeHRlbnNp b25zIGZhaWxzLCBkb250IGtlZXAgcmV0cnlpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6OmluaXRpYWxpemVF eHRlbnNpb25zKToKKwogMjAxMS0xMS0wMyAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFJlZmFjdG9yIFdlYkZyYW1lSW1wbDo6Y3JlYXRl RnJhbWVWaWV3KCkgdG8gdXNlIEZyYW1lOmNyZWF0ZVZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4dDNEQ2hyb21pdW0uY3BwIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAKaW5kZXgg MDQxNGNjNjE4NGJlZDZhOTMyNDZmNTNmNGY3NGUzNTQ1M2RiMjVlNS4uYTUxZmFkMTk2Y2M4NDk3 ODQ2ZWM5ZTQzNjU2ZDU3Njk4MGZkMGY3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAKQEAgLTgyNiwxNyAr ODI2LDIwIEBAIFN0cmluZyBtYXBFeHRlbnNpb25OYW1lKGNvbnN0IFN0cmluZyYgbmFtZSkKIAog dm9pZCBHcmFwaGljc0NvbnRleHQzRFByaXZhdGU6OmluaXRpYWxpemVFeHRlbnNpb25zKCkKIHsK KyAgICBpZiAobV9pbml0aWFsaXplZEF2YWlsYWJsZUV4dGVuc2lvbnMpCisgICAgICAgIHJldHVy bjsKKworICAgIG1faW5pdGlhbGl6ZWRBdmFpbGFibGVFeHRlbnNpb25zID0gdHJ1ZTsKICAgICBi b29sIHN1Y2Nlc3MgPSBtYWtlQ29udGV4dEN1cnJlbnQoKTsKICAgICBBU1NFUlQoc3VjY2Vzcyk7 Ci0gICAgaWYgKHN1Y2Nlc3MgJiYgIW1faW5pdGlhbGl6ZWRBdmFpbGFibGVFeHRlbnNpb25zKSB7 Ci0gICAgICAgIFN0cmluZyBleHRlbnNpb25zU3RyaW5nID0gZ2V0U3RyaW5nKEdyYXBoaWNzQ29u dGV4dDNEOjpFWFRFTlNJT05TKTsKLSAgICAgICAgc3BsaXRTdHJpbmdIZWxwZXIoZXh0ZW5zaW9u c1N0cmluZywgbV9lbmFibGVkRXh0ZW5zaW9ucyk7CisgICAgaWYgKCFzdWNjZXNzKQorICAgICAg ICByZXR1cm47CiAKLSAgICAgICAgU3RyaW5nIHJlcXVlc3RhYmxlRXh0ZW5zaW9uc1N0cmluZyA9 IG1faW1wbC0+Z2V0UmVxdWVzdGFibGVFeHRlbnNpb25zQ0hST01JVU0oKTsKLSAgICAgICAgc3Bs aXRTdHJpbmdIZWxwZXIocmVxdWVzdGFibGVFeHRlbnNpb25zU3RyaW5nLCBtX3JlcXVlc3RhYmxl RXh0ZW5zaW9ucyk7CisgICAgU3RyaW5nIGV4dGVuc2lvbnNTdHJpbmcgPSBnZXRTdHJpbmcoR3Jh cGhpY3NDb250ZXh0M0Q6OkVYVEVOU0lPTlMpOworICAgIHNwbGl0U3RyaW5nSGVscGVyKGV4dGVu c2lvbnNTdHJpbmcsIG1fZW5hYmxlZEV4dGVuc2lvbnMpOwogCi0gICAgICAgIG1faW5pdGlhbGl6 ZWRBdmFpbGFibGVFeHRlbnNpb25zID0gdHJ1ZTsKLSAgICB9CisgICAgU3RyaW5nIHJlcXVlc3Rh YmxlRXh0ZW5zaW9uc1N0cmluZyA9IG1faW1wbC0+Z2V0UmVxdWVzdGFibGVFeHRlbnNpb25zQ0hS T01JVU0oKTsKKyAgICBzcGxpdFN0cmluZ0hlbHBlcihyZXF1ZXN0YWJsZUV4dGVuc2lvbnNTdHJp bmcsIG1fcmVxdWVzdGFibGVFeHRlbnNpb25zKTsKIH0KIAogCg==