71616 2011-11-05 18:00:46 -0700 Improve pending resource hash table code, including fixing a memory leak 2011-11-05 19:27:04 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin aroben mrowe webkit.review.bot zimmermann oldest_to_newest 496749 0 darin 2011-11-05 18:00:46 -0700 Improve pending resource hash table code, including fixing a memory leak 496754 1 113772 darin 2011-11-05 18:09:14 -0700 Created attachment 113772 Patch 496769 2 113772 webkit.review.bot 2011-11-05 19:27:00 -0700 Comment on attachment 113772 Patch Clearing flags on attachment: 113772 Committed r99367: <http://trac.webkit.org/changeset/99367> 496770 3 webkit.review.bot 2011-11-05 19:27:04 -0700 All reviewed patches have been landed. Closing bug. 113772 2011-11-05 18:09:14 -0700 2011-11-05 19:27:00 -0700 Patch bug-71616-20111105180913.patch text/plain 4444 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5MzY1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTEtMTEtMDUgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIEltcHJvdmUgcGVuZGluZyByZXNvdXJj ZSBoYXNoIHRhYmxlIGNvZGUsIGluY2x1ZGluZyBmaXhpbmcgYSBtZW1vcnkgbGVhaworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE2MTYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZW1vcnkgbGVhayBmaXgg YW5kIHJlZmFjdG9yaW5nIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBz dmcvU1ZHRG9jdW1lbnRFeHRlbnNpb25zLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0RvY3Vt ZW50RXh0ZW5zaW9uczo6YWRkUGVuZGluZ1Jlc291cmNlKTogUmVwbGFjZSB0aGUgY29tYmluYXRp b24KKyAgICAgICAgb2YgY29udGFpbnMsIGdldCwgYW5kIGFkZCB3aXRoIGp1c3QgYWRkLCByZW1v dmluZyBhbiBleHRyYSB1bm5lZWRlZCBoYXNoIHRhYmxlCisgICAgICAgIGxvb2t1cCBlYWNoIHRp bWUgdGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQuCisgICAgICAgIChXZWJDb3JlOjpTVkdEb2N1bWVu dEV4dGVuc2lvbnM6OmlzRWxlbWVudEluUGVuZGluZ1Jlc291cmNlcyk6IEFkZGVkIGEgY29tbWVu dAorICAgICAgICBhYm91dCB0aGUgcGVyZm9ybWFuY2Ugb2YgdGhpcyBmdW5jdGlvbi4gUmVtb3Zl ZCB1bm5lY2Vzc2FyeSBjaGVjayBmb3IgYW4gZW1wdHkKKyAgICAgICAgbWFwOyB0aGUgY29kZSBh bHJlYWR5IGVmZmljaWVudGx5IGV4aXRzIGRvaW5nIG5vdGhpbmcgd2l0aG91dCB0aGUgY2hlY2su CisgICAgICAgIChXZWJDb3JlOjpTVkdEb2N1bWVudEV4dGVuc2lvbnM6OnJlbW92ZUVsZW1lbnRG cm9tUGVuZGluZ1Jlc291cmNlcyk6IFJlbW92ZWQKKyAgICAgICAgdW5uZWNlc3NhcnkgY2hlY2sg Zm9yIGFuIGVtcHR5IG1hcDsgdGhlIGNvZGUgYWxyZWFkeSBlZmZpY2llbnRseSBkb2VzIG5vdGhp bmcKKyAgICAgICAgd2l0aG91dCB0aGUgY2hlY2suIFVzZSByZW1vdmVQZW5kaW5nUmVzb3VyY2Ug cmF0aGVyIHRoYW4gY2FsbGluZyByZW1vdmUgdG8KKyAgICAgICAgYXZvaWQgbGVha2luZyB0aGUg U1ZHUGVuZGluZ0VsZW1lbnRzIHNldC4KKyAgICAgICAgKFdlYkNvcmU6OlNWR0RvY3VtZW50RXh0 ZW5zaW9uczo6cmVtb3ZlUGVuZGluZ1Jlc291cmNlKTogUmVwbGFjZSB0aGUKKyAgICAgICAgY29t YmluYXRpb24gb2YgZ2V0IGFuZCByZW1vdmUgd2l0aCBhIGNhbGwgdG8gdGFrZSwgcmVtb3Zpbmcg YW4gZXh0cmEKKyAgICAgICAgdW5uZWVkZWQgaGFzaCB0YWJsZSBsb29rdXAgZWFjaCB0aW1lIHRo aXMgZnVuY3Rpb24gaXMgY2FsbGVkCisKIDIwMTEtMTEtMDUgIERhbiBXaW5zaGlwICA8ZGFud0Bn bm9tZS5vcmc+CiAKICAgICAgICAgW0dUS10gQWN0dWFsbHkgdXNlIHRoZSB1c2VyX2RhdGEgYXJn dW1lbnRzIHRvIGdpbyBhc3luYyBmdW5jdGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9T VkdEb2N1bWVudEV4dGVuc2lvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdEb2N1bWVudEV4dGVuc2lvbnMuY3BwCShyZXZpc2lvbiA5OTMwNykKKysrIFNvdXJjZS9X ZWJDb3JlL3N2Zy9TVkdEb2N1bWVudEV4dGVuc2lvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y MDUsMTQgKzIwNSwxNCBAQCB2b2lkIFNWR0RvY3VtZW50RXh0ZW5zaW9uczo6YWRkUGVuZGluZ1Jl CiAgICAgaWYgKGlkLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKG1fcGVu ZGluZ1Jlc291cmNlcy5jb250YWlucyhpZCkpCi0gICAgICAgIG1fcGVuZGluZ1Jlc291cmNlcy5n ZXQoaWQpLT5hZGQoZWxlbWVudCk7Ci0gICAgZWxzZSB7Ci0gICAgICAgIFNWR1BlbmRpbmdFbGVt ZW50cyogc2V0ID0gbmV3IFNWR1BlbmRpbmdFbGVtZW50czsKLSAgICAgICAgc2V0LT5hZGQoZWxl bWVudCk7Ci0KLSAgICAgICAgbV9wZW5kaW5nUmVzb3VyY2VzLmFkZChpZCwgc2V0KTsKLSAgICB9 CisgICAgLy8gVGhlIEhhc2hNYXAgYWRkIGZ1bmN0aW9uIGxlYXZlcyB0aGUgbWFwIGFsb25lIGFu ZCByZXR1cm5zIGEgcG9pbnRlciB0byB0aGUgZWxlbWVudCBpbiB0aGUKKyAgICAvLyBtYXAgaWYg dGhlIGVsZW1lbnQgYWxyZWFkeSBleGlzdHMuIFNvIHdlIGFkZCB3aXRoIGEgdmFsdWUgb2YgMCwg YW5kIGl0IGVpdGhlciBmaW5kcyB0aGUKKyAgICAvLyBleGlzdGluZyBlbGVtZW50IG9yIGFkZHMg YSBuZXcgb25lIGluIGEgc2luZ2xlIG9wZXJhdGlvbi4gVGhlICIuZmlyc3QtPnNlY29uZCIgaWRp b20gZ2V0cworICAgIC8vIHVzIHRvIHRoZSBpdGVyYXRvciBmcm9tIGFkZCdzIHJlc3VsdCwgYW5k IHRoZW4gdG8gdGhlIHZhbHVlIGluc2lkZSB0aGUgaGFzaCB0YWJsZS4KKyAgICBTVkdQZW5kaW5n RWxlbWVudHMqJiBzZXQgPSBtX3BlbmRpbmdSZXNvdXJjZXMuYWRkKGlkLCAwKS5maXJzdC0+c2Vj b25kOworICAgIGlmICghc2V0KQorICAgICAgICBzZXQgPSBuZXcgU1ZHUGVuZGluZ0VsZW1lbnRz OworICAgIHNldC0+YWRkKGVsZW1lbnQpOwogCiAgICAgZWxlbWVudC0+c2V0SGFzUGVuZGluZ1Jl c291cmNlcygpOwogfQpAQCAtMjI3LDEwICsyMjcsMTAgQEAgYm9vbCBTVkdEb2N1bWVudEV4dGVu c2lvbnM6Omhhc1BlbmRpbmdSZQogCiBib29sIFNWR0RvY3VtZW50RXh0ZW5zaW9uczo6aXNFbGVt ZW50SW5QZW5kaW5nUmVzb3VyY2VzKFNWR1N0eWxlZEVsZW1lbnQqIGVsZW1lbnQpIGNvbnN0CiB7 Ci0gICAgQVNTRVJUKGVsZW1lbnQpOworICAgIC8vIFRoaXMgYWxnb3JpdGhtIHRha2VzIHRpbWUg cHJvcG9ydGlvbmFsIHRvIHRoZSBudW1iZXIgb2YgcGVuZGluZyByZXNvdXJjZXMgYW5kIG5lZWQg bm90LgorICAgIC8vIElmIHBlcmZvcm1hbmNlIGJlY29tZXMgYW4gaXNzdWUgd2UgY2FuIGtlZXAg YSBjb3VudGVkIHNldCBvZiBlbGVtZW50cyBhbmQgYW5zd2VyIHRoZSBxdWVzdGlvbiBlZmZpY2ll bnRseS4KIAotICAgIGlmIChtX3BlbmRpbmdSZXNvdXJjZXMuaXNFbXB0eSgpKQotICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgQVNTRVJUKGVsZW1lbnQpOwogCiAgICAgSGFzaE1hcDxBdG9taWNT dHJpbmcsIFNWR1BlbmRpbmdFbGVtZW50cyo+Ojpjb25zdF9pdGVyYXRvciBlbmQgPSBtX3BlbmRp bmdSZXNvdXJjZXMuZW5kKCk7CiAgICAgZm9yIChIYXNoTWFwPEF0b21pY1N0cmluZywgU1ZHUGVu ZGluZ0VsZW1lbnRzKj46OmNvbnN0X2l0ZXJhdG9yIGl0ID0gbV9wZW5kaW5nUmVzb3VyY2VzLmJl Z2luKCk7IGl0ICE9IGVuZDsgKytpdCkgewpAQCAtMjY0LDIxICsyNjQsMTYgQEAgdm9pZCBTVkdE b2N1bWVudEV4dGVuc2lvbnM6OnJlbW92ZUVsZW1lbgogCiAgICAgZWxlbWVudC0+Y2xlYXJIYXNQ ZW5kaW5nUmVzb3VyY2VzSWZQb3NzaWJsZSgpOwogCi0gICAgaWYgKHRvQmVSZW1vdmVkLmlzRW1w dHkoKSkKLSAgICAgICAgcmV0dXJuOwotCisgICAgLy8gV2UgdXNlIHRoZSByZW1vdmVQZW5kaW5n UmVzb3VyY2UgZnVuY3Rpb24gaGVyZSBiZWNhdXNlIGl0IGRlYWxzIHdpdGggc2V0IGxpZmV0aW1l IGNvcnJlY3RseS4KICAgICBWZWN0b3I8QXRvbWljU3RyaW5nPjo6aXRlcmF0b3IgZW5kVmVjdG9y ID0gdG9CZVJlbW92ZWQuZW5kKCk7CiAgICAgZm9yIChWZWN0b3I8QXRvbWljU3RyaW5nPjo6aXRl cmF0b3IgaXQgPSB0b0JlUmVtb3ZlZC5iZWdpbigpOyBpdCAhPSBlbmRWZWN0b3I7ICsraXQpCi0g ICAgICAgIG1fcGVuZGluZ1Jlc291cmNlcy5yZW1vdmUoKml0KTsKKyAgICAgICAgcmVtb3ZlUGVu ZGluZ1Jlc291cmNlKCppdCk7CiB9CiAKIFBhc3NPd25QdHI8U1ZHRG9jdW1lbnRFeHRlbnNpb25z OjpTVkdQZW5kaW5nRWxlbWVudHM+IFNWR0RvY3VtZW50RXh0ZW5zaW9uczo6cmVtb3ZlUGVuZGlu Z1Jlc291cmNlKGNvbnN0IEF0b21pY1N0cmluZyYgaWQpCiB7CiAgICAgQVNTRVJUKG1fcGVuZGlu Z1Jlc291cmNlcy5jb250YWlucyhpZCkpOwotCi0gICAgT3duUHRyPFNWR1BlbmRpbmdFbGVtZW50 cz4gc2V0ID0gYWRvcHRQdHIobV9wZW5kaW5nUmVzb3VyY2VzLmdldChpZCkpOwotICAgIG1fcGVu ZGluZ1Jlc291cmNlcy5yZW1vdmUoaWQpOwotICAgIHJldHVybiBzZXQucmVsZWFzZSgpOworICAg IHJldHVybiBhZG9wdFB0cihtX3BlbmRpbmdSZXNvdXJjZXMudGFrZShpZCkpOwogfQogCiB9Cg==