71613 2011-11-05 16:22:46 -0700 [GTK] remove some dead code 2011-11-05 17:37:31 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danw webkit-unassigned webkit.review.bot oldest_to_newest 496719 0 danw 2011-11-05 16:22:46 -0700 There's some old charset conversion stuff in ResourceHandleSoup that hasn't been used for a year now. 496720 1 113766 danw 2011-11-05 16:23:45 -0700 Created attachment 113766 Remove a bit of dead code 496737 2 113766 webkit.review.bot 2011-11-05 17:37:27 -0700 Comment on attachment 113766 Remove a bit of dead code Clearing flags on attachment: 113766 Committed r99362: <http://trac.webkit.org/changeset/99362> 496738 3 webkit.review.bot 2011-11-05 17:37:31 -0700 All reviewed patches have been landed. Closing bug. 113766 2011-11-05 16:23:45 -0700 2011-11-05 17:37:27 -0700 Remove a bit of dead code 0001-GTK-Remove-a-bit-of-dead-code.patch text/plain 3497 danw RnJvbSA1MjFlZWFjZWIwOGFiMzljMDkzYjE1ZGJkYWYxYjMwYWMzZWYzMjUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW4gV2luc2hpcCA8ZGFud0Bnbm9tZS5vcmc+CkRhdGU6IFN1 biwgMjMgT2N0IDIwMTEgMjE6MTQ6MTkgLTA0MDAKU3ViamVjdDogW1BBVENIXSBbR1RLXSBSZW1v dmUgYSBiaXQgb2YgZGVhZCBjb2RlCgp0aGUgY2FsbGVyIHRoYXQgbmVlZGVkIHRoZSBjb252ZXJ0 VG9VVEYxNiBjb2RlIHdhcyByZW1vdmVkIGluIHI3NzQwOCwKYnV0IHRoZSBjb2RlIHdhcyBhY2Np ZGVudGFsbHkgbGVmdCBiZWhpbmQuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0v bmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgICB8ICAgMTMgKysrLS0tLS0tLS0t LQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggZDU1ODViZi4uMTM4MjUyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBA CiAyMDExLTExLTA1ICBEYW4gV2luc2hpcCAgPGRhbndAZ25vbWUub3JnPgogCisgICAgICAgIFtH VEtdIFJlbW92ZSBhIGJpdCBvZiBkZWFkIGNvZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNjEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzOyBiZWhhdmlvciBpcyB1bmNoYW5nZWQK KworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6cmVhZENhbGxiYWNrKTogdGhlIGNhbGxlciB0aGF0IG5lZWRl ZCB0aGUgY29udmVydFRvVVRGMTYKKyAgICAgICAgY29kZSB3YXMgcmVtb3ZlZCBpbiByNzc0MDgs IGJ1dCB0aGUgY29kZSB3YXMgYWNjaWRlbnRhbGx5IGxlZnQKKyAgICAgICAgYmVoaW5kLgorCisy MDExLTExLTA1ICBEYW4gV2luc2hpcCAgPGRhbndAZ25vbWUub3JnPgorCiAgICAgICAgIFtHVEtd IERvbid0IHVubmVjZXNzYXJpbHkgMC1pbml0aWFsaXplIHJlYWQgYnVmZmVycy4KICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNjEyCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNv dXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFu ZGxlU291cC5jcHAKaW5kZXggNGY0ZjMwZC4uYzg1Zjg0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j cHAKQEAgLTgyNiwxMyArODI2LDEyIEBAIHN0YXRpYyB2b2lkIGNsb3NlQ2FsbGJhY2soR09iamVj dCogc291cmNlLCBHQXN5bmNSZXN1bHQqIHJlcywgZ3BvaW50ZXIpCiAgICAgY2xlYW51cFNvdXBS ZXF1ZXN0T3BlcmF0aW9uKGhhbmRsZS5nZXQoKSk7CiB9CiAKLXN0YXRpYyB2b2lkIHJlYWRDYWxs YmFjayhHT2JqZWN0KiBzb3VyY2UsIEdBc3luY1Jlc3VsdCogYXN5bmNSZXN1bHQsIGdwb2ludGVy IGRhdGEpCitzdGF0aWMgdm9pZCByZWFkQ2FsbGJhY2soR09iamVjdCogc291cmNlLCBHQXN5bmNS ZXN1bHQqIGFzeW5jUmVzdWx0LCBncG9pbnRlcikKIHsKICAgICBSZWZQdHI8UmVzb3VyY2VIYW5k bGU+IGhhbmRsZSA9IHN0YXRpY19jYXN0PFJlc291cmNlSGFuZGxlKj4oZ19vYmplY3RfZ2V0X2Rh dGEoc291cmNlLCAid2Via2l0LXJlc291cmNlIikpOwogICAgIGlmICghaGFuZGxlKQogICAgICAg ICByZXR1cm47CiAKLSAgICBib29sIGNvbnZlcnRUb1VURjE2ID0gc3RhdGljX2Nhc3Q8Ym9vbD4o ZGF0YSk7CiAgICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCogZCA9IGhhbmRsZS0+Z2V0SW50ZXJu YWwoKTsKICAgICBSZXNvdXJjZUhhbmRsZUNsaWVudCogY2xpZW50ID0gaGFuZGxlLT5jbGllbnQo KTsKIApAQCAtODYwLDEzICs4NTksNyBAQCBzdGF0aWMgdm9pZCByZWFkQ2FsbGJhY2soR09iamVj dCogc291cmNlLCBHQXN5bmNSZXN1bHQqIGFzeW5jUmVzdWx0LCBncG9pbnRlciBkYQogICAgIC8v IEl0J3MgbWFuZGF0b3J5IHRvIGhhdmUgc2VudCBhIHJlc3BvbnNlIGJlZm9yZSBzZW5kaW5nIGRh dGEKICAgICBBU1NFUlQoIWQtPm1fcmVzcG9uc2UuaXNOdWxsKCkpOwogCi0gICAgaWYgKEdfTElL RUxZKCFjb252ZXJ0VG9VVEYxNikpCi0gICAgICAgIGNsaWVudC0+ZGlkUmVjZWl2ZURhdGEoaGFu ZGxlLmdldCgpLCBkLT5tX2J1ZmZlciwgYnl0ZXNSZWFkLCBieXRlc1JlYWQpOwotICAgIGVsc2Ug ewotICAgICAgICAvLyBXZSBoYXZlIHRvIGNvbnZlcnQgaXQgdG8gVVRGLTE2IGR1ZSB0byBsaW1p dGF0aW9ucyBpbiBLVVJMCi0gICAgICAgIFN0cmluZyBkYXRhID0gU3RyaW5nOjpmcm9tVVRGOChk LT5tX2J1ZmZlciwgYnl0ZXNSZWFkKTsKLSAgICAgICAgY2xpZW50LT5kaWRSZWNlaXZlRGF0YSho YW5kbGUuZ2V0KCksIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KGRhdGEuY2hhcmFjdGVy cygpKSwgZGF0YS5sZW5ndGgoKSAqIHNpemVvZihVQ2hhciksIGJ5dGVzUmVhZCk7Ci0gICAgfQor ICAgIGNsaWVudC0+ZGlkUmVjZWl2ZURhdGEoaGFuZGxlLmdldCgpLCBkLT5tX2J1ZmZlciwgYnl0 ZXNSZWFkLCBieXRlc1JlYWQpOwogCiAgICAgLy8gZGlkUmVjZWl2ZURhdGEgbWF5IGNhbmNlbCB0 aGUgbG9hZCwgd2hpY2ggbWF5IHJlbGVhc2UgdGhlIGxhc3QgcmVmZXJlbmNlLgogICAgIGlmIChk LT5tX2NhbmNlbGxlZCB8fCAhY2xpZW50KSB7CkBAIC04NzUsNyArODY4LDcgQEAgc3RhdGljIHZv aWQgcmVhZENhbGxiYWNrKEdPYmplY3QqIHNvdXJjZSwgR0FzeW5jUmVzdWx0KiBhc3luY1Jlc3Vs dCwgZ3BvaW50ZXIgZGEKICAgICB9CiAKICAgICBnX2lucHV0X3N0cmVhbV9yZWFkX2FzeW5jKGQt Pm1faW5wdXRTdHJlYW0uZ2V0KCksIGQtPm1fYnVmZmVyLCBSRUFEX0JVRkZFUl9TSVpFLCBHX1BS SU9SSVRZX0RFRkFVTFQsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkLT5tX2NhbmNl bGxhYmxlLmdldCgpLCByZWFkQ2FsbGJhY2ssIGRhdGEpOworICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZC0+bV9jYW5jZWxsYWJsZS5nZXQoKSwgcmVhZENhbGxiYWNrLCAwKTsKIH0KIAog c3RhdGljIGJvb2wgc3RhcnROb25IVFRQUmVxdWVzdChSZXNvdXJjZUhhbmRsZSogaGFuZGxlLCBL VVJMIHVybCkKLS0gCjEuNy43Cgo=