71603 2011-11-04 19:51:42 -0700 Refactor sandbox flag calculation to make implementing CSP sandbox directive easier 2011-11-05 14:56:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric japhet sam webkit.review.bot oldest_to_newest 496618 0 abarth 2011-11-04 19:51:42 -0700 Refactor sandbox flag calculation to make implementing CSP sandbox directive easier 496619 1 113747 abarth 2011-11-04 19:54:47 -0700 Created attachment 113747 Patch 496707 2 113747 webkit.review.bot 2011-11-05 14:56:16 -0700 Comment on attachment 113747 Patch Clearing flags on attachment: 113747 Committed r99359: <http://trac.webkit.org/changeset/99359> 496708 3 webkit.review.bot 2011-11-05 14:56:21 -0700 All reviewed patches have been landed. Closing bug. 113747 2011-11-04 19:54:47 -0700 2011-11-05 14:56:16 -0700 Patch bug-71603-20111104195446.patch text/plain 7069 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTkzNDcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxNTBjOTUzMWIyYmYwZGJj MWFlY2ZiMjUyZDI5ZmMxYTdjNDJjYWI0Li4zZmY1YjAxYjZkOGE0NjEwNTAzZTYyMDg4YzBmMzE5 OGQwMmU5NzcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzMgQEAKIDIwMTEtMTEtMDQgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZWZhY3RvciBzYW5kYm94IGZs YWcgY2FsY3VsYXRpb24gdG8gbWFrZSBpbXBsZW1lbnRpbmcgQ1NQIHNhbmRib3ggZGlyZWN0aXZl IGVhc2llcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzE2MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIGNoYW5nZXMgdGhlIHdheSB3ZSBjb21wdXRlIHNhbmRib3ggYml0cy4gIEluc3Rl YWQgb2YgY2FjaGluZworICAgICAgICB0aGUgcmVzdWx0IG9uIEZyYW1lLCB3ZSBhbHdheXMgY29t cHV0ZSB0aGUgc2FuZGJveCBiaXRzIGZvciBhIG5ldworICAgICAgICBkb2N1bWVudCBmcmVzaCBm cm9tIHRoZSBpbnB1dHMgdG8gdGhlIHByb2Nlc3MgKHRoZSBzYW5kYm94IGF0dHJpYnV0ZQorICAg ICAgICBhbmQgdGhlIGZvcmNlZCBzYW5kYm94IGZsYWdzKS4KKworICAgICAgICBUaGlzIHBhdGNo IGlzIGp1c3QgcmVmYWN0b3JpbmcuICBJdCBzaG91bGRuJ3QgaGF2ZSBhbiBvYnNlcnZhYmxlCisg ICAgICAgIGVmZmVjdHMuICBUaGlzIHBhdGNoIG1ha2VzIGl0IGVhc2llciB0byBpbXBsZW1lbnQg Q1NQJ3Mgc2FuZGJveAorICAgICAgICBkaXJlY3RpdmUgaW4gYSBzdWJzZXF1ZW50IHBhdGNoLgor CisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50 Ojppbml0U2VjdXJpdHlDb250ZXh0KToKKyAgICAgICAgKiBodG1sL0hUTUxGcmFtZU93bmVyRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRnJhbWVPd25lckVsZW1lbnQ6OnNldFNh bmRib3hGbGFncyk6CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpGcmFtZUxvYWRlcik6CisgICAgICAgIChXZWJDb3JlOjpG cmFtZUxvYWRlcjo6aW5pdCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6ZWZmZWN0 aXZlU2FuZGJveEZsYWdzKToKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZVdpbmRvdyk6CisgICAg ICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRl cjo6Zm9yY2VTYW5kYm94RmxhZ3MpOgorCisyMDExLTExLTA0ICBBZGFtIEJhcnRoICA8YWJhcnRo QHdlYmtpdC5vcmc+CisKICAgICAgICAgSmF2YVNjcmlwdCBVUkxzIGV4ZWN1dGUgaW4gc2FuZGJv eGVkIGlmcmFtZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcxNTk5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDk0ODE4N2Q3YjFmNmU3NTE1 MWE0MDUxYTdjMmFjYTcyMzIyNTc1MDUuLjUwYzJjMGM0OTgzZDg1NDdiOTExNDRiNzQ4NTA4NWQ1 NzRmNjU0ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNDQwMiw3ICs0NDAyLDcgQEAg dm9pZCBEb2N1bWVudDo6aW5pdFNlY3VyaXR5Q29udGV4dCgpCiAgICAgLy8gSW4gdGhlIGNvbW1v biBjYXNlLCBjcmVhdGUgdGhlIHNlY3VyaXR5IGNvbnRleHQgZnJvbSB0aGUgY3VycmVudGx5CiAg ICAgLy8gbG9hZGluZyBVUkwgd2l0aCBhIGZyZXNoIGNvbnRlbnQgc2VjdXJpdHkgcG9saWN5Lgog ICAgIG1fY29va2llVVJMID0gbV91cmw7Ci0gICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDo6ZW5m b3JjZVNhbmRib3hGbGFncyhtX2ZyYW1lLT5sb2FkZXIoKS0+c2FuZGJveEZsYWdzKCkpOworICAg IFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OmVuZm9yY2VTYW5kYm94RmxhZ3MobV9mcmFtZS0+bG9h ZGVyKCktPmVmZmVjdGl2ZVNhbmRib3hGbGFncygpKTsKICAgICBTY3JpcHRFeGVjdXRpb25Db250 ZXh0OjpzZXRTZWN1cml0eU9yaWdpbihTZWN1cml0eU9yaWdpbjo6Y3JlYXRlKG1fdXJsLCBpc1Nh bmRib3hlZChTYW5kYm94T3JpZ2luKSkpOwogICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ6OnNl dENvbnRlbnRTZWN1cml0eVBvbGljeShDb250ZW50U2VjdXJpdHlQb2xpY3k6OmNyZWF0ZSh0aGlz KSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lT3duZXJFbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lT3duZXJFbGVtZW50LmNwcApp bmRleCBhMjE3ODgxZjMyNTQ2YzVlNGQ0YmM0NTA3NjllODg4NjNlNGI0Mjk5Li5iODRjNDQ5YjUw OGM3MjNjNDJiMGQ5NzcyZjU2ZDY4YTQwZWI1MDgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxGcmFtZU93bmVyRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRnJhbWVPd25lckVsZW1lbnQuY3BwCkBAIC04MCwxMyArODAsNyBAQCBET01XaW5kb3cq IEhUTUxGcmFtZU93bmVyRWxlbWVudDo6Y29udGVudFdpbmRvdygpIGNvbnN0CiAKIHZvaWQgSFRN TEZyYW1lT3duZXJFbGVtZW50OjpzZXRTYW5kYm94RmxhZ3MoU2FuZGJveEZsYWdzIGZsYWdzKQog ewotICAgIGlmIChtX3NhbmRib3hGbGFncyA9PSBmbGFncykKLSAgICAgICAgcmV0dXJuOwotCiAg ICAgbV9zYW5kYm94RmxhZ3MgPSBmbGFnczsKLQotICAgIGlmIChGcmFtZSogZnJhbWUgPSBjb250 ZW50RnJhbWUoKSkKLSAgICAgICAgZnJhbWUtPmxvYWRlcigpLT5vd25lckVsZW1lbnRTYW5kYm94 RmxhZ3NDaGFuZ2VkKCk7CiB9CiAKIGJvb2wgSFRNTEZyYW1lT3duZXJFbGVtZW50Ojppc0tleWJv YXJkRm9jdXNhYmxlKEtleWJvYXJkRXZlbnQqIGV2ZW50KSBjb25zdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlci5jcHAKaW5kZXggMjhkNDY4MDQwMGIyOGMyNTcyZWY1Mzc3NjVhNzA3ODc5 ZTJmYzc5OS4uNmFhNDYwZDUzOWZhNjVhMjBjODYyMDcwZGE5YjhhY2E4ODAxZjBkMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0xOTUsNyArMTk1LDYgQEAgRnJhbWVM b2FkZXI6OkZyYW1lTG9hZGVyKEZyYW1lKiBmcmFtZSwgRnJhbWVMb2FkZXJDbGllbnQqIGNsaWVu dCkKICAgICAsIG1fZGlkUGVyZm9ybUZpcnN0TmF2aWdhdGlvbihmYWxzZSkKICAgICAsIG1fbG9h ZGluZ0Zyb21DYWNoZWRQYWdlKGZhbHNlKQogICAgICwgbV9zdXBwcmVzc09wZW5lckluTmV3RnJh bWUoZmFsc2UpCi0gICAgLCBtX3NhbmRib3hGbGFncyhTYW5kYm94QWxsKQogICAgICwgbV9mb3Jj ZWRTYW5kYm94RmxhZ3MoU2FuZGJveE5vbmUpCiB7CiB9CkBAIC0yMTYsMTAgKzIxNSw2IEBAIEZy YW1lTG9hZGVyOjp+RnJhbWVMb2FkZXIoKQogCiB2b2lkIEZyYW1lTG9hZGVyOjppbml0KCkKIHsK LSAgICAvLyBQcm9wYWdhdGUgc2FuZGJveCBhdHRyaWJ1dGVzIHRvIHRoaXMgRnJhbWVsb2FkZXIg YW5kIGl0cyBkZXNjZW5kYW50cy4KLSAgICAvLyBUaGlzIG5lZWRzIHRvIGJlIGRvbmUgZWFybHks IHNvIHRoYXQgYW4gaW5pdGlhbCBkb2N1bWVudCBnZXRzIGNvcnJlY3Qgc2FuZGJveCBmbGFncyBp biBpdHMgU2VjdXJpdHlPcmlnaW4uCi0gICAgdXBkYXRlU2FuZGJveEZsYWdzKCk7Ci0KICAgICAv LyBUaGlzIHNvbWV3aGF0IG9kZCBzZXQgb2Ygc3RlcHMgZ2l2ZXMgdGhlIGZyYW1lIGFuIGluaXRp YWwgZW1wdHkgZG9jdW1lbnQuCiAgICAgLy8gSXQgd291bGQgYmUgYmV0dGVyIGlmIHRoaXMgY291 bGQgYmUgZG9uZSB3aXRoIGV2ZW4gZmV3ZXIgc3RlcHMuCiAgICAgbV9zdGF0ZU1hY2hpbmUuYWR2 YW5jZVRvKEZyYW1lTG9hZGVyU3RhdGVNYWNoaW5lOjpDcmVhdGluZ0luaXRpYWxFbXB0eURvY3Vt ZW50KTsKQEAgLTMxNjksMjEgKzMxNjQsMTQgQEAgdm9pZCBGcmFtZUxvYWRlcjo6ZGlzcGF0Y2hE aWRDbGVhcldpbmRvd09iamVjdEluV29ybGQoRE9NV3JhcHBlcldvcmxkKiB3b3JsZCkKICAgICBJ bnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZENsZWFyV2luZG93T2JqZWN0SW5Xb3JsZChtX2Zy YW1lLCB3b3JsZCk7CiB9CiAKLXZvaWQgRnJhbWVMb2FkZXI6OnVwZGF0ZVNhbmRib3hGbGFncygp CitTYW5kYm94RmxhZ3MgRnJhbWVMb2FkZXI6OmVmZmVjdGl2ZVNhbmRib3hGbGFncygpIGNvbnN0 CiB7CiAgICAgU2FuZGJveEZsYWdzIGZsYWdzID0gbV9mb3JjZWRTYW5kYm94RmxhZ3M7CiAgICAg aWYgKEZyYW1lKiBwYXJlbnRGcmFtZSA9IG1fZnJhbWUtPnRyZWUoKS0+cGFyZW50KCkpCi0gICAg ICAgIGZsYWdzIHw9IHBhcmVudEZyYW1lLT5sb2FkZXIoKS0+c2FuZGJveEZsYWdzKCk7CisgICAg ICAgIGZsYWdzIHw9IHBhcmVudEZyYW1lLT5kb2N1bWVudCgpLT5zYW5kYm94RmxhZ3MoKTsKICAg ICBpZiAoSFRNTEZyYW1lT3duZXJFbGVtZW50KiBvd25lckVsZW1lbnQgPSBtX2ZyYW1lLT5vd25l ckVsZW1lbnQoKSkKICAgICAgICAgZmxhZ3MgfD0gb3duZXJFbGVtZW50LT5zYW5kYm94RmxhZ3Mo KTsKLQotICAgIGlmIChtX3NhbmRib3hGbGFncyA9PSBmbGFncykKLSAgICAgICAgcmV0dXJuOwot Ci0gICAgbV9zYW5kYm94RmxhZ3MgPSBmbGFnczsKLQotICAgIGZvciAoRnJhbWUqIGNoaWxkID0g bV9mcmFtZS0+dHJlZSgpLT5maXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT50cmVl KCktPm5leHRTaWJsaW5nKCkpCi0gICAgICAgIGNoaWxkLT5sb2FkZXIoKS0+dXBkYXRlU2FuZGJv eEZsYWdzKCk7CisgICAgcmV0dXJuIGZsYWdzOwogfQogCiB2b2lkIEZyYW1lTG9hZGVyOjpkaWRD aGFuZ2VUaXRsZShEb2N1bWVudExvYWRlciogbG9hZGVyKQpAQCAtMzI4Niw3ICszMjc0LDcgQEAg RnJhbWUqIGNyZWF0ZVdpbmRvdyhGcmFtZSogb3BlbmVyRnJhbWUsIEZyYW1lKiBsb29rdXBGcmFt ZSwgY29uc3QgRnJhbWVMb2FkUmVxdWUKIAogICAgIEZyYW1lKiBmcmFtZSA9IHBhZ2UtPm1haW5G cmFtZSgpOwogCi0gICAgZnJhbWUtPmxvYWRlcigpLT5mb3JjZVNhbmRib3hGbGFncyhvcGVuZXJG cmFtZS0+bG9hZGVyKCktPnNhbmRib3hGbGFncygpKTsKKyAgICBmcmFtZS0+bG9hZGVyKCktPmZv cmNlU2FuZGJveEZsYWdzKG9wZW5lckZyYW1lLT5kb2N1bWVudCgpLT5zYW5kYm94RmxhZ3MoKSk7 CiAKICAgICBpZiAocmVxdWVzdC5mcmFtZU5hbWUoKSAhPSAiX2JsYW5rIikKICAgICAgICAgZnJh bWUtPnRyZWUoKS0+c2V0TmFtZShyZXF1ZXN0LmZyYW1lTmFtZSgpKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmgKaW5kZXggM2U3NGFjYjQ0NzViMzY3YjAzYzYyNDFjM2IxZGZiYTI2MTkx NTg0YS4uOGYxZDhlMDFlZDk5ZDdmNGQyNjIwN2E2OWI1Nzk2MmZlN2NkYTdlMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKQEAgLTIwOSwxMiArMjA5LDEwIEBAIHB1YmxpYzoKICAg ICB2b2lkIGRpc3BhdGNoRGlkQ2xlYXJXaW5kb3dPYmplY3RzSW5BbGxXb3JsZHMoKTsKICAgICB2 b2lkIGRpc3BhdGNoRG9jdW1lbnRFbGVtZW50QXZhaWxhYmxlKCk7CiAKLSAgICB2b2lkIG93bmVy RWxlbWVudFNhbmRib3hGbGFnc0NoYW5nZWQoKSB7IHVwZGF0ZVNhbmRib3hGbGFncygpOyB9Ci0K LSAgICBTYW5kYm94RmxhZ3Mgc2FuZGJveEZsYWdzKCkgY29uc3QgeyByZXR1cm4gbV9zYW5kYm94 RmxhZ3M7IH0KICAgICAvLyBUaGUgZm9sbG93aW5nIHNhbmRib3ggZmxhZ3Mgd2lsbCBiZSBmb3Jj ZWQsIHJlZ2FyZGxlc3Mgb2YgY2hhbmdlcyB0bwogICAgIC8vIHRoZSBzYW5kYm94IGF0dHJpYnV0 ZSBvZiBhbnkgcGFyZW50IGZyYW1lcy4KLSAgICB2b2lkIGZvcmNlU2FuZGJveEZsYWdzKFNhbmRi b3hGbGFncyBmbGFncykgeyBtX2ZvcmNlZFNhbmRib3hGbGFncyB8PSBmbGFnczsgbV9zYW5kYm94 RmxhZ3MgfD0gZmxhZ3M7IH0KKyAgICB2b2lkIGZvcmNlU2FuZGJveEZsYWdzKFNhbmRib3hGbGFn cyBmbGFncykgeyBtX2ZvcmNlZFNhbmRib3hGbGFncyB8PSBmbGFnczsgfQorICAgIFNhbmRib3hG bGFncyBlZmZlY3RpdmVTYW5kYm94RmxhZ3MoKSBjb25zdDsKIAogICAgIC8vIE1peGVkIGNvbnRl bnQgcmVsYXRlZCBmdW5jdGlvbnMuCiAgICAgc3RhdGljIGJvb2wgaXNNaXhlZENvbnRlbnQoU2Vj dXJpdHlPcmlnaW4qIGNvbnRleHQsIGNvbnN0IEtVUkwmKTsKQEAgLTM2Nyw4ICszNjUsNiBAQCBw cml2YXRlOgogCiAgICAgYm9vbCBzaG91bGRUcmVhdFVSTEFzU2FtZUFzQ3VycmVudChjb25zdCBL VVJMJikgY29uc3Q7CiAKLSAgICB2b2lkIHVwZGF0ZVNhbmRib3hGbGFncygpOwotCiAgICAgRnJh bWUqIG1fZnJhbWU7CiAgICAgRnJhbWVMb2FkZXJDbGllbnQqIG1fY2xpZW50OwogCkBAIC00MjUs NyArNDIxLDYgQEAgcHJpdmF0ZToKICAgICBib29sIG1fbG9hZGluZ0Zyb21DYWNoZWRQYWdlOwog ICAgIGJvb2wgbV9zdXBwcmVzc09wZW5lckluTmV3RnJhbWU7CiAKLSAgICBTYW5kYm94RmxhZ3Mg bV9zYW5kYm94RmxhZ3M7CiAgICAgU2FuZGJveEZsYWdzIG1fZm9yY2VkU2FuZGJveEZsYWdzOwog CiAgICAgUmVmUHRyPEZyYW1lTmV0d29ya2luZ0NvbnRleHQ+IG1fbmV0d29ya2luZ0NvbnRleHQ7 Cg==