71600 2011-11-04 17:26:39 -0700 --webkit-visual-word crash when create legacy position for shadowRoot 2011-11-10 11:52:18 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 25298 1 xji webkit-unassigned amir.aharoni rniwa oldest_to_newest 496580 0 xji 2011-11-04 17:26:39 -0700 crash in previousRootInlineBox due to pass in shadowRoot node to create legacy position. 496590 1 113740 xji 2011-11-04 17:40:09 -0700 Created attachment 113740 patch w/ layout test 500047 2 113740 rniwa 2011-11-10 10:45:25 -0800 Comment on attachment 113740 patch w/ layout test View in context: https://bugs.webkit.org/attachment.cgi?id=113740&action=review > LayoutTests/editing/selection/move-by-word-visually-crash-test-textarea.html:4 > + try { Why do we need try? > LayoutTests/editing/selection/move-by-word-visually-crash-test-textarea.html:16 > + sel = window.getSelection(); > + sel.modify("move", "left", "-webkit-visual-word"); > + sel.modify("move", "left", "-webkit-visual-word"); This can be written as: getSelection().modify("move", "left", "-webkit-visual-word"); getSelection().modify("move", "left", "-webkit-visual-word"); 500082 3 xji 2011-11-10 11:52:18 -0800 Committed r99886: <http://trac.webkit.org/changeset/99886> 113740 2011-11-04 17:40:09 -0700 2011-11-10 10:45:25 -0800 patch w/ layout test 71600.diff text/plain 4471 xji SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5MzM2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMTEtMDQgIFhpYW9tZWkg SmkgIDx4amlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIC0td2Via2l0LXZpc3VhbC13b3JkIGNy YXNoIHdoZW4gY3JlYXRlIGxlZ2FjeSBwb3NpdGlvbiBmb3Igc2hhZG93Um9vdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE2MDAKKyAgICAKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zaWRlIHRleHRhcmVh LCB0aGUgc2hhZG93ZWQgdGV4dCBub2RlJ3MgcHJldmlvdXMgbGVhZiBub2RlIGNvdWxkIGJlIHRo ZQorICAgICAgICBzaGFkb3dSb290IG5vZGUsIHdoaWNoIGNhdXNlIGFzc2VydCBleGNlcHRpb24g aW4gY3JlYXRpbmcgbGVnYWN5IHBvc2l0aW9uIGJhc2VkCisgICAgICAgIG9uIHN1Y2ggbm9kZS4g RXhpdCBwcmV2aW91c1Jvb3RJbmxpbmVCb3goKSB3aGVuIHJlYWNoIHNoYWRvd1Jvb3Qgbm9kZS4K KworICAgICAgICBJdCBkb2VzIG5vdCBjYXVzZSBwcm9ibGVtIHdoZW4gbG9va2luZyBmb3IgdGV4 dCBub2RlJ3MgbmV4dCBsZWFmIG5vZGUuIEFkZGluZworICAgICAgICB0aGUgc2FtZSBjaGVja2lu ZyBpbiBuZXh0Um9vdElubGluZUJveCBqdXN0IHRvIGJlIHNhZmUuCisKKyAgICAgICAgVGVzdDog ZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS13b3JkLXZpc3VhbGx5LWNyYXNoLXRlc3QtdGV4dGFy ZWEuaHRtbAorCisgICAgICAgICogZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OnByZXZpb3VzUm9vdElubGluZUJveCk6CisgICAgICAgIChXZWJDb3JlOjpuZXh0 Um9vdElubGluZUJveCk6CisKIDIwMTEtMTEtMDQgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFp bkBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10gUmVzb3VyY2VSZXF1ZXN0J3MgbnNVUkxSZXF1 ZXN0KCkgZG9lcyBub3QgZGlmZmVyZW50aWF0ZSBudWxsIGFuZCBlbXB0eSBVUkxzIHdpdGggQ0ZO ZXR3b3JrCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAJKHJl dmlzaW9uIDk5MjU0KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy92aXNpYmxlX3VuaXRzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTQzNCw3ICsxNDM0LDcgQEAgc3RhdGljIGNvbnN0IFJvb3RJ bmxpbmVCb3gqIHByZXZpb3VzUm9vdAogICAgIHdoaWxlIChwcmV2aW91c05vZGUgJiYgZW5jbG9z aW5nQmxvY2tOb2RlID09IGVuY2xvc2luZ05vZGVXaXRoTm9uSW5saW5lUmVuZGVyZXIocHJldmlv dXNOb2RlKSkKICAgICAgICAgcHJldmlvdXNOb2RlID0gcHJldmlvdXNOb2RlLT5wcmV2aW91c0xl YWZOb2RlKCk7CiAgIAotICAgIHdoaWxlIChwcmV2aW91c05vZGUpIHsKKyAgICB3aGlsZSAocHJl dmlvdXNOb2RlICYmICFwcmV2aW91c05vZGUtPmlzU2hhZG93Um9vdCgpKSB7CiAgICAgICAgIFBv c2l0aW9uIHBvcyA9IGNyZWF0ZUxlZ2FjeUVkaXRpbmdQb3NpdGlvbihwcmV2aW91c05vZGUsIGNh cmV0TWF4T2Zmc2V0KHByZXZpb3VzTm9kZSkpOwogICAgICAgICAKICAgICAgICAgaWYgKHBvcy5p c0NhbmRpZGF0ZSgpKSB7CkBAIC0xNDU3LDcgKzE0NTcsNyBAQCBzdGF0aWMgY29uc3QgUm9vdElu bGluZUJveCogbmV4dFJvb3RJbmxpCiAgICAgd2hpbGUgKG5leHROb2RlICYmIGVuY2xvc2luZ0Js b2NrTm9kZSA9PSBlbmNsb3NpbmdOb2RlV2l0aE5vbklubGluZVJlbmRlcmVyKG5leHROb2RlKSkK ICAgICAgICAgbmV4dE5vZGUgPSBuZXh0Tm9kZS0+bmV4dExlYWZOb2RlKCk7CiAgIAotICAgIHdo aWxlIChuZXh0Tm9kZSkgeworICAgIHdoaWxlIChuZXh0Tm9kZSAmJiAhbmV4dE5vZGUtPmlzU2hh ZG93Um9vdCgpKSB7CiAgICAgICAgIFBvc2l0aW9uIHBvczsKICAgICAgICAgcG9zID0gY3JlYXRl TGVnYWN5RWRpdGluZ1Bvc2l0aW9uKG5leHROb2RlLCBjYXJldE1pbk9mZnNldChuZXh0Tm9kZSkp OwogICAgICAgICAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5MzM2KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTEtMDQgIFhpYW9t ZWkgSmkgIDx4amlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIC0td2Via2l0LXZpc3VhbC13b3Jk IGNyYXNoIHdoZW4gY3JlYXRlIGxlZ2FjeSBwb3NpdGlvbiBmb3Igc2hhZG93Um9vdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE2MDAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0 aW9uL21vdmUtYnktd29yZC12aXN1YWxseS1jcmFzaC10ZXN0LXRleHRhcmVhLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS13b3JkLXZpc3Vh bGx5LWNyYXNoLXRlc3QtdGV4dGFyZWEuaHRtbDogQWRkZWQuCisKIDIwMTEtMTEtMDQgIEJlbiBX ZWxscyAgPGJlbndlbGxzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBCYXNlbGluZXMgZm9yIG5l dyB0ZXN0IGludHJvZHVjZWQgaW4gcjk5MDQzCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3Nl bGVjdGlvbi9tb3ZlLWJ5LXdvcmQtdmlzdWFsbHktY3Jhc2gtdGVzdC10ZXh0YXJlYS1leHBlY3Rl ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1i eS13b3JkLXZpc3VhbGx5LWNyYXNoLXRlc3QtdGV4dGFyZWEtZXhwZWN0ZWQudHh0CShyZXZpc2lv biAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS13b3JkLXZpc3Vh bGx5LWNyYXNoLXRlc3QtdGV4dGFyZWEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCww ICsxIEBACitDcmFzaCB0ZXN0IHBhc3NlZApJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxl Y3Rpb24vbW92ZS1ieS13b3JkLXZpc3VhbGx5LWNyYXNoLXRlc3QtdGV4dGFyZWEuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLWJ5LXdvcmQtdmlz dWFsbHktY3Jhc2gtdGVzdC10ZXh0YXJlYS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS13b3JkLXZpc3VhbGx5LWNyYXNoLXRlc3QtdGV4 dGFyZWEuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyNiBAQAorPHNjcmlwdD4KKworb25s b2FkID0gZnVuY3Rpb24oKSB7CisgICAgdHJ5IHsKKyAgICAgICAgdmFyIHNlbCA9IHdpbmRvdy5n ZXRTZWxlY3Rpb24oKTsKKyAgICAgICAgc2VsLmVtcHR5KCk7CisKKyAgICAgICAgdmFyIHRlc3Qg PSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdF9tb3ZlX2J5X3dvcmQiKTsKKyAgICAgICAg dGVzdC5mb2N1cygpOworICAgICAgICB0ZXN0LnNlbGVjdGlvbkRpcmVjdGlvbiA9ICdub25lJzsK KyAgICAgICAgdGVzdC5zZWxlY3Rpb25TdGFydCA9IDE7CisgICAgICAgIHRlc3Quc2VsZWN0aW9u RW5kID0gMTsKKworICAgICAgICBzZWwgPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CisgICAgICAg IHNlbC5tb2RpZnkoIm1vdmUiLCAibGVmdCIsICItd2Via2l0LXZpc3VhbC13b3JkIik7CisgICAg ICAgIHNlbC5tb2RpZnkoIm1vdmUiLCAibGVmdCIsICItd2Via2l0LXZpc3VhbC13b3JkIik7Cisg ICAgICAgIGRvY3VtZW50LmJvZHkuaW5uZXJIVE1MID0gIkNyYXNoIHRlc3QgcGFzc2VkIjsKKyAg ICB9IGZpbmFsbHkgeworICAgIH0KK307CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworPC9zY3JpcHQ+CisK Kzx0ZXh0YXJlYSBkaXI9bHRyIHRpdGxlPSIwfDAiIGlkPSJ0ZXN0X21vdmVfYnlfd29yZCI+QXQg d2hlcmUgYXJlIHlvdTwvdGV4dGFyZWE+Cg==