71597 2011-11-04 17:08:07 -0700 Reduce the number of putWithAttributes 2011-11-06 13:09:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam rniwa webkit.review.bot oldest_to_newest 496568 0 sam 2011-11-04 17:08:07 -0700 Reduce the number of putWithAttributes 496569 1 113736 sam 2011-11-04 17:13:41 -0700 Created attachment 113736 Patch 496571 2 webkit.review.bot 2011-11-04 17:15:10 -0700 Attachment 113736 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/JSObject.h:110: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 496574 3 113736 aroben 2011-11-04 17:16:46 -0700 Comment on attachment 113736 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113736&action=review Wait for the EWS bots so you don't break everyone else. > Source/JavaScriptCore/ChangeLog:19 > + Remove four unused JSObject::putWithAttributes overloads and remove make > + one of the remain two overloads not virtual, since no one overloads it. Typo: "remove make one of the remain two" Typo: overloads should be overrides 496697 4 sam 2011-11-05 13:29:07 -0700 Committed r99357: <http://trac.webkit.org/changeset/99357> 496849 5 rniwa 2011-11-06 12:48:29 -0800 It appears that this patch caused one jsc regression? http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34474 496860 6 sam 2011-11-06 13:06:54 -0800 (In reply to comment #5) > It appears that this patch caused one jsc regression? > http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34474 I don't think so. Those test fail from occasionally based no the current time. 496862 7 rniwa 2011-11-06 13:09:33 -0800 (In reply to comment #6) > (In reply to comment #5) > > It appears that this patch caused one jsc regression? > > http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34474 > > I don't think so. Those test fail from occasionally based no the current time. I see. Thanks for the clarification. 113736 2011-11-04 17:13:41 -0700 2011-11-04 17:16:45 -0700 Patch bug-71597-20111104171340.patch text/plain 7018 sam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTkzMzQpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAK KzIwMTEtMTEtMDQgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZWR1 Y2UgdGhlIG51bWJlciBvZiBwdXRXaXRoQXR0cmlidXRlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE1OTcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEphdmFTY3JpcHRDb3JlLmV4cDoKKyAgICAgICAg UmVtb3ZlIGV4cG9ydHMgb2YgcmVtb3ZlZCBmdW5jdGlvbnMuCisKKyAgICAgICAgKiBydW50aW1l L0pTQWN0aXZhdGlvbi5jcHA6CisgICAgICAgIChKU0M6OkpTQWN0aXZhdGlvbjo6cHV0V2l0aEF0 dHJpYnV0ZXMpOgorICAgICAgICBDYWxsaW5nIHRoZSBvdmVybG9hZCB3aXRob3V0IHRoZSBleHRy YSBwYXJhbWV0ZXJzIGRvZXMgdGhlIHNhbWUgdGhpbmcuCisKKyAgICAgICAgKiBydW50aW1lL0pT T2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OnB1dFdpdGhBdHRyaWJ1dGVzKToK KyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0Lmg6CisgICAgICAgIFJlbW92ZSBmb3VyIHVudXNl ZCBKU09iamVjdDo6cHV0V2l0aEF0dHJpYnV0ZXMgb3ZlcmxvYWRzIGFuZCByZW1vdmUgbWFrZQor ICAgICAgICBvbmUgb2YgdGhlIHJlbWFpbiB0d28gb3ZlcmxvYWRzIG5vdCB2aXJ0dWFsLCBzaW5j ZSBubyBvbmUgb3ZlcmxvYWRzIGl0LgorCiAyMDExLTExLTA0ICBQcmF0aWsgU29sYW5raSAgPHBz b2xhbmtpQGFwcGxlLmNvbT4KIAogICAgICAgICBzcXJ0RG91YmxlIGFuZCBhbmRub3REb3VibGUg c2hvdWxkIGJlIGRlY2xhcmVkIG5vcmV0dXJuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv SmF2YVNjcmlwdENvcmUuZXhwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9K YXZhU2NyaXB0Q29yZS5leHAJKHJldmlzaW9uIDk5MzI0KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLmV4cAkod29ya2luZyBjb3B5KQpAQCAtMzE2LDExICszMTYsNyBA QCBfX1pOM0pTQzhKU09iamVjdDE2Z2V0UHJvcGVydHlOYW1lc0VQUzBfCiBfX1pOM0pTQzhKU09i amVjdDE3ZGVmaW5lT3duUHJvcGVydHlFUE5TXzlFeGVjU3RhdGVFUktOU18xMElkZW50aWZpZXJF Uk5TXzE4UHJvcGVydHlEZXNjcmlwdG9yRWIKIF9fWk4zSlNDOEpTT2JqZWN0MTdwcmV2ZW50RXh0 ZW5zaW9uc0VSTlNfMTJKU0dsb2JhbERhdGFFCiBfX1pOM0pTQzhKU09iamVjdDE3cHV0V2l0aEF0 dHJpYnV0ZXNFUE5TXzEySlNHbG9iYWxEYXRhRVJLTlNfMTBJZGVudGlmaWVyRU5TXzdKU1ZhbHVl RWoKLV9fWk4zSlNDOEpTT2JqZWN0MTdwdXRXaXRoQXR0cmlidXRlc0VQTlNfMTJKU0dsb2JhbERh dGFFUktOU18xMElkZW50aWZpZXJFTlNfN0pTVmFsdWVFamJSTlNfMTVQdXRQcm9wZXJ0eVNsb3RF Ci1fX1pOM0pTQzhKU09iamVjdDE3cHV0V2l0aEF0dHJpYnV0ZXNFUE5TXzEySlNHbG9iYWxEYXRh RWpOU183SlNWYWx1ZUVqCiBfX1pOM0pTQzhKU09iamVjdDE3cHV0V2l0aEF0dHJpYnV0ZXNFUE5T XzlFeGVjU3RhdGVFUktOU18xMElkZW50aWZpZXJFTlNfN0pTVmFsdWVFagotX19aTjNKU0M4SlNP YmplY3QxN3B1dFdpdGhBdHRyaWJ1dGVzRVBOU185RXhlY1N0YXRlRVJLTlNfMTBJZGVudGlmaWVy RU5TXzdKU1ZhbHVlRWpiUk5TXzE1UHV0UHJvcGVydHlTbG90RQotX19aTjNKU0M4SlNPYmplY3Qx N3B1dFdpdGhBdHRyaWJ1dGVzRVBOU185RXhlY1N0YXRlRWpOU183SlNWYWx1ZUVqCiBfX1pOM0pT QzhKU09iamVjdDE5Z2V0T3duUHJvcGVydHlOYW1lc0VQUzBfUE5TXzlFeGVjU3RhdGVFUk5TXzE3 UHJvcGVydHlOYW1lQXJyYXlFTlNfMTVFbnVtZXJhdGlvbk1vZGVFCiBfX1pOM0pTQzhKU09iamVj dDIxZGVsZXRlUHJvcGVydHlCeUluZGV4RVBOU182SlNDZWxsRVBOU185RXhlY1N0YXRlRWoKIF9f Wk4zSlNDOEpTT2JqZWN0MjFnZXRQcm9wZXJ0eURlc2NyaXB0b3JFUE5TXzlFeGVjU3RhdGVFUktO U18xMElkZW50aWZpZXJFUk5TXzE4UHJvcGVydHlEZXNjcmlwdG9yRQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBY3RpdmF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FjdGl2YXRpb24uY3BwCShyZXZpc2lvbiA5OTMy NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQWN0aXZhdGlvbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE5Miw4ICsxOTIsNyBAQCB2b2lkIEpTQWN0aXZhdGlvbjo6cHV0V2l0 aEF0dHJpYnV0ZXMoRXhlCiAgICAgLy8gcHJvcGVydGllcyBhcmUgbm9uLXN0YW5kYXJkIGV4dGVu c2lvbnMgdGhhdCBvdGhlciBpbXBsZW1lbnRhdGlvbnMgZG8gbm90CiAgICAgLy8gZXhwb3NlIGlu IHRoZSBhY3RpdmF0aW9uIG9iamVjdC4KICAgICBBU1NFUlQoIWhhc0dldHRlclNldHRlclByb3Bl cnRpZXMoKSk7Ci0gICAgUHV0UHJvcGVydHlTbG90IHNsb3Q7Ci0gICAgSlNPYmplY3Q6OnB1dFdp dGhBdHRyaWJ1dGVzKGV4ZWMsIHByb3BlcnR5TmFtZSwgdmFsdWUsIGF0dHJpYnV0ZXMsIHRydWUs IHNsb3QpOworICAgIEpTT2JqZWN0OjpwdXRXaXRoQXR0cmlidXRlcyhleGVjLCBwcm9wZXJ0eU5h bWUsIHZhbHVlLCBhdHRyaWJ1dGVzKTsKIH0KIAogYm9vbCBKU0FjdGl2YXRpb246OmRlbGV0ZVBy b3BlcnR5KEpTQ2VsbCogY2VsbCwgRXhlY1N0YXRlKiBleGVjLCBjb25zdCBJZGVudGlmaWVyJiBw cm9wZXJ0eU5hbWUpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVj dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmpl Y3QuY3BwCShyZXZpc2lvbiA5OTMyNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAwLDkgKzIwMCwxMCBAQCB2b2lkIEpT T2JqZWN0OjpwdXRCeUluZGV4KEpTQ2VsbCogY2VsbCwgCiAgICAgdGhpc09iamVjdC0+bWV0aG9k VGFibGUoKS0+cHV0KHRoaXNPYmplY3QsIGV4ZWMsIElkZW50aWZpZXI6OmZyb20oZXhlYywgcHJv cGVydHlOYW1lKSwgdmFsdWUsIHNsb3QpOwogfQogCi12b2lkIEpTT2JqZWN0OjpwdXRXaXRoQXR0 cmlidXRlcyhKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEsIGNvbnN0IElkZW50aWZpZXImIHByb3Bl cnR5TmFtZSwgSlNWYWx1ZSB2YWx1ZSwgdW5zaWduZWQgYXR0cmlidXRlcywgYm9vbCBjaGVja1Jl YWRPbmx5LCBQdXRQcm9wZXJ0eVNsb3QmIHNsb3QpCit2b2lkIEpTT2JqZWN0OjpwdXRXaXRoQXR0 cmlidXRlcyhFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwg SlNWYWx1ZSB2YWx1ZSwgdW5zaWduZWQgYXR0cmlidXRlcykKIHsKLSAgICBwdXREaXJlY3RJbnRl cm5hbCgqZ2xvYmFsRGF0YSwgcHJvcGVydHlOYW1lLCB2YWx1ZSwgYXR0cmlidXRlcywgY2hlY2tS ZWFkT25seSwgc2xvdCwgZ2V0SlNGdW5jdGlvbih2YWx1ZSkpOworICAgIFB1dFByb3BlcnR5U2xv dCBzbG90OworICAgIHB1dERpcmVjdEludGVybmFsKGV4ZWMtPmdsb2JhbERhdGEoKSwgcHJvcGVy dHlOYW1lLCB2YWx1ZSwgYXR0cmlidXRlcywgdHJ1ZSwgc2xvdCwgZ2V0SlNGdW5jdGlvbih2YWx1 ZSkpOwogfQogCiB2b2lkIEpTT2JqZWN0OjpwdXRXaXRoQXR0cmlidXRlcyhKU0dsb2JhbERhdGEq IGdsb2JhbERhdGEsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNWYWx1ZSB2YWx1 ZSwgdW5zaWduZWQgYXR0cmlidXRlcykKQEAgLTIxMSwyOSArMjEyLDYgQEAgdm9pZCBKU09iamVj dDo6cHV0V2l0aEF0dHJpYnV0ZXMoSlNHbG9iYQogICAgIHB1dERpcmVjdEludGVybmFsKCpnbG9i YWxEYXRhLCBwcm9wZXJ0eU5hbWUsIHZhbHVlLCBhdHRyaWJ1dGVzLCB0cnVlLCBzbG90LCBnZXRK U0Z1bmN0aW9uKHZhbHVlKSk7CiB9CiAKLXZvaWQgSlNPYmplY3Q6OnB1dFdpdGhBdHRyaWJ1dGVz KEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSwgdW5zaWduZWQgcHJvcGVydHlOYW1lLCBKU1ZhbHVl IHZhbHVlLCB1bnNpZ25lZCBhdHRyaWJ1dGVzKQotewotICAgIHB1dFdpdGhBdHRyaWJ1dGVzKGds b2JhbERhdGEsIElkZW50aWZpZXI6OmZyb20oZ2xvYmFsRGF0YSwgcHJvcGVydHlOYW1lKSwgdmFs dWUsIGF0dHJpYnV0ZXMpOwotfQotCi12b2lkIEpTT2JqZWN0OjpwdXRXaXRoQXR0cmlidXRlcyhF eGVjU3RhdGUqIGV4ZWMsIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNWYWx1ZSB2 YWx1ZSwgdW5zaWduZWQgYXR0cmlidXRlcywgYm9vbCBjaGVja1JlYWRPbmx5LCBQdXRQcm9wZXJ0 eVNsb3QmIHNsb3QpCi17Ci0gICAgSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhID0gZXhlYy0+Z2xv YmFsRGF0YSgpOwotICAgIHB1dERpcmVjdEludGVybmFsKGdsb2JhbERhdGEsIHByb3BlcnR5TmFt ZSwgdmFsdWUsIGF0dHJpYnV0ZXMsIGNoZWNrUmVhZE9ubHksIHNsb3QsIGdldEpTRnVuY3Rpb24o dmFsdWUpKTsKLX0KLQotdm9pZCBKU09iamVjdDo6cHV0V2l0aEF0dHJpYnV0ZXMoRXhlY1N0YXRl KiBleGVjLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUgdmFsdWUsIHVu c2lnbmVkIGF0dHJpYnV0ZXMpCi17Ci0gICAgUHV0UHJvcGVydHlTbG90IHNsb3Q7Ci0gICAgSlNH bG9iYWxEYXRhJiBnbG9iYWxEYXRhID0gZXhlYy0+Z2xvYmFsRGF0YSgpOwotICAgIHB1dERpcmVj dEludGVybmFsKGdsb2JhbERhdGEsIHByb3BlcnR5TmFtZSwgdmFsdWUsIGF0dHJpYnV0ZXMsIHRy dWUsIHNsb3QsIGdldEpTRnVuY3Rpb24odmFsdWUpKTsKLX0KLQotdm9pZCBKU09iamVjdDo6cHV0 V2l0aEF0dHJpYnV0ZXMoRXhlY1N0YXRlKiBleGVjLCB1bnNpZ25lZCBwcm9wZXJ0eU5hbWUsIEpT VmFsdWUgdmFsdWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMpCi17Ci0gICAgcHV0V2l0aEF0dHJpYnV0 ZXMoZXhlYywgSWRlbnRpZmllcjo6ZnJvbShleGVjLCBwcm9wZXJ0eU5hbWUpLCB2YWx1ZSwgYXR0 cmlidXRlcyk7Ci19Ci0KIGJvb2wgSlNPYmplY3Q6Omhhc1Byb3BlcnR5KEV4ZWNTdGF0ZSogZXhl YywgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lKSBjb25zdAogewogICAgIFByb3BlcnR5 U2xvdCBzbG90OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3Qu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5o CShyZXZpc2lvbiA5OTMyNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2Jq ZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNiwxMiArMTA2LDggQEAgbmFtZXNwYWNlIEpTQyB7 CiAgICAgICAgIHN0YXRpYyB2b2lkIHB1dChKU0NlbGwqLCBFeGVjU3RhdGUqLCBjb25zdCBJZGVu dGlmaWVyJiBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUsIFB1dFByb3BlcnR5U2xvdCYpOwogICAgICAg ICBzdGF0aWMgdm9pZCBwdXRCeUluZGV4KEpTQ2VsbCosIEV4ZWNTdGF0ZSosIHVuc2lnbmVkIHBy b3BlcnR5TmFtZSwgSlNWYWx1ZSk7CiAKLSAgICAgICAgdmlydHVhbCB2b2lkIHB1dFdpdGhBdHRy aWJ1dGVzKEpTR2xvYmFsRGF0YSosIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNW YWx1ZSB2YWx1ZSwgdW5zaWduZWQgYXR0cmlidXRlcywgYm9vbCBjaGVja1JlYWRPbmx5LCBQdXRQ cm9wZXJ0eVNsb3QmIHNsb3QpOwotICAgICAgICB2aXJ0dWFsIHZvaWQgcHV0V2l0aEF0dHJpYnV0 ZXMoSlNHbG9iYWxEYXRhKiwgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lLCBKU1ZhbHVl IHZhbHVlLCB1bnNpZ25lZCBhdHRyaWJ1dGVzKTsKLSAgICAgICAgdmlydHVhbCB2b2lkIHB1dFdp dGhBdHRyaWJ1dGVzKEpTR2xvYmFsRGF0YSosIHVuc2lnbmVkIHByb3BlcnR5TmFtZSwgSlNWYWx1 ZSB2YWx1ZSwgdW5zaWduZWQgYXR0cmlidXRlcyk7Ci0gICAgICAgIHZpcnR1YWwgdm9pZCBwdXRX aXRoQXR0cmlidXRlcyhFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUs IEpTVmFsdWUgdmFsdWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMsIGJvb2wgY2hlY2tSZWFkT25seSwg UHV0UHJvcGVydHlTbG90JiBzbG90KTsKICAgICAgICAgdmlydHVhbCB2b2lkIHB1dFdpdGhBdHRy aWJ1dGVzKEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNWYWx1 ZSB2YWx1ZSwgdW5zaWduZWQgYXR0cmlidXRlcyk7Ci0gICAgICAgIHZpcnR1YWwgdm9pZCBwdXRX aXRoQXR0cmlidXRlcyhFeGVjU3RhdGUqLCB1bnNpZ25lZCBwcm9wZXJ0eU5hbWUsIEpTVmFsdWUg dmFsdWUsIHVuc2lnbmVkIGF0dHJpYnV0ZXMpOworICAgICAgICB2b2lkIHB1dFdpdGhBdHRyaWJ1 dGVzKEpTR2xvYmFsRGF0YSosIGNvbnN0IElkZW50aWZpZXImIHByb3BlcnR5TmFtZSwgSlNWYWx1 ZSB2YWx1ZSwgdW5zaWduZWQgYXR0cmlidXRlcyk7CiAKICAgICAgICAgYm9vbCBwcm9wZXJ0eUlz RW51bWVyYWJsZShFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUpIGNv bnN0OwogCg==