71592 2011-11-04 16:11:32 -0700 sqrtDouble and andnotDouble should be declared noreturn 2011-11-04 16:51:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 psolanki psolanki psolanki webkit.review.bot oldest_to_newest 496531 0 psolanki 2011-11-04 16:11:32 -0700 sqrtDouble and andnotDouble should be declared noreturn in debug builds since they just have ASSERT_NOT_REACHED() in them. 496532 1 113726 psolanki 2011-11-04 16:12:45 -0700 Created attachment 113726 Patch 496559 2 113726 webkit.review.bot 2011-11-04 16:51:41 -0700 Comment on attachment 113726 Patch Clearing flags on attachment: 113726 Committed r99333: <http://trac.webkit.org/changeset/99333> 496560 3 webkit.review.bot 2011-11-04 16:51:44 -0700 All reviewed patches have been landed. Closing bug. 113726 2011-11-04 16:12:45 -0700 2011-11-04 16:51:40 -0700 Patch bug-71592-20111104161244.patch text/plain 1419 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogOTkzMzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGVj ZjdmM2QyODkyZWYwZDg3N2I1YzNlMTdhM2I4OGIwNjhkMTUxZGIuLmYwOGFlZmRjYjczZTk1NmIx M2VjYjkyYzNiNTBhYmQ0YmViOGU3ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDExLTExLTA0ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNv bT4KKworICAgICAgICBzcXJ0RG91YmxlIGFuZCBhbmRub3REb3VibGUgc2hvdWxkIGJlIGRlY2xh cmVkIG5vcmV0dXJuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MTU5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuaDoKKwogMjAxMS0xMS0wNCAgTWFy ayBIYWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIERlLXZpcnR1 YWxpemUgSlNPYmplY3Q6Omhhc0luc3RhbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oCmluZGV4IDFlNzA1ZjgwZWM4OGEw Mjg2NjhhNjg3NDRhNjU3MmZhNzIwYzc5MjIuLmExYjNlYjhlZTlmZTI2NDY3ZWE1NTM3YzZjY2M4 ZDMzODVhYzA3MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk12Ny5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oCkBAIC02NTgsMTIgKzY1OCwxMiBAQCBwdWJsaWM6CiAg ICAgICAgIG11bERvdWJsZShmcFRlbXBSZWdpc3RlciwgZGVzdCk7CiAgICAgfQogCi0gICAgdm9p ZCBzcXJ0RG91YmxlKEZQUmVnaXN0ZXJJRCwgRlBSZWdpc3RlcklEKQorICAgIHZvaWQgc3FydERv dWJsZShGUFJlZ2lzdGVySUQsIEZQUmVnaXN0ZXJJRCkgTk9fUkVUVVJOX0RVRV9UT19BU1NFUlQK ICAgICB7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KICAgICAKLSAgICB2 b2lkIGFuZG5vdERvdWJsZShGUFJlZ2lzdGVySUQsIEZQUmVnaXN0ZXJJRCkKKyAgICB2b2lkIGFu ZG5vdERvdWJsZShGUFJlZ2lzdGVySUQsIEZQUmVnaXN0ZXJJRCkgTk9fUkVUVVJOX0RVRV9UT19B U1NFUlQKICAgICB7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0K