71540 2011-11-03 22:47:26 -0700 More code clean-up in DFG 32_64 2011-11-04 00:45:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 496058 0 yuqiang.xian 2011-11-03 22:47:26 -0700 Remove unnecessary code duplications, and fix compilation warnings. 496061 1 113624 yuqiang.xian 2011-11-03 22:53:51 -0700 Created attachment 113624 the patch 496092 2 113624 webkit.review.bot 2011-11-04 00:45:52 -0700 Comment on attachment 113624 the patch Clearing flags on attachment: 113624 Committed r99265: <http://trac.webkit.org/changeset/99265> 496093 3 webkit.review.bot 2011-11-04 00:45:56 -0700 All reviewed patches have been landed. Closing bug. 113624 2011-11-03 22:53:51 -0700 2011-11-04 00:45:52 -0700 the patch 71540.patch text/plain 5869 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTkyNjMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMTEtMDMgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgTW9yZSBjb2RlIGNsZWFuLXVwIGluIERGRyAzMl82NAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE1NDAKKworICAgICAgICBSZW1vdmUgdW5u ZWNlc3NhcnkgY29kZSBkdXBsaWNhdGlvbnMsIGFuZCBmaXggY29tcGlsYXRpb24gd2FybmluZ3Mu CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcv REZHSklUQ29tcGlsZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvbXBpbGVyOjplbWl0 Q291bnQpOgorICAgICAgICAoSlNDOjpERkc6OkpJVENvbXBpbGVyOjpzZXRTYW1wbGluZ0ZsYWcp OgorICAgICAgICAoSlNDOjpERkc6OkpJVENvbXBpbGVyOjpjbGVhclNhbXBsaW5nRmxhZyk6Cisg ICAgICAgIChKU0M6OkRGRzo6SklUQ29tcGlsZXI6OmppdEFzc2VydElzQ2VsbCk6CisgICAgICAg ICogZGZnL0RGR0pJVENvbXBpbGVyMzJfNjQuY3BwOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxh dGl2ZUpJVDMyXzY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29t cGlsZSk6CisKIDIwMTEtMTEtMDMgIE1hcmsgSGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxl LmNvbT4KIAogICAgICAgICBEZS12aXJ0dWFsaXplIEpTT2JqZWN0OjpnZXRQcm9wZXJ0eU5hbWVz CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyMzJfNjQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIz Ml82NC5jcHAJKHJldmlzaW9uIDk5MjYzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdKSVRDb21waWxlcjMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTk1LDMxICs1OTUsNiBA QCB2b2lkIEpJVENvbXBpbGVyOjpqaXRBc3NlcnRJc0NlbGwoR1BSUmVnCiB9CiAjZW5kaWYKIAot I2lmIEVOQUJMRShTQU1QTElOR19DT1VOVEVSUykgJiYgQ1BVKFg4NikgLy8gT3IgYW55IG90aGVy IGxpdHRsZS1lbmRpYW4gMzItYml0IHBsYXRmb3JtIQotdm9pZCBKSVRDb21waWxlcjo6ZW1pdENv dW50KE1hY3JvQXNlbWJsZXImIGppdCwgQWJzdHJhY3RTYW1wbGluZ0NvdW50ZXImIGNvdW50ZXIs IHVpbnQzMl90IGluY3JlbWVudCkKLXsKLSAgICBpbnRwdHJfdCBoaVdvcmQgPSByZWludGVycHJl dF9jYXN0PGludHB0cl90Pihjb3VudGVyLmFkZHJlc3NPZkNvdW50ZXIoKSkgKyBzaXplb2YoaW50 MzJfdCk7Ci0gICAgaml0LmFkZDMyKFRydXN0ZWRJbW0zMihpbmNyZW1lbnQpLCBBYnNvbHV0ZUFk ZHJlc3MoY291bnRlci5hZGRyZXNzT2ZDb3VudGVyKCkpKTsKLSAgICBqaXQuYWRkV2l0aENhcnJ5 MzIoVHJ1c3RlZEltbTMyKDApLCBBYnNvbHV0ZUFkZHJlc3MocmVpbnRlcnByZXRfY2FzdDx2b2lk Kj4oaGlXb3JkKSkpOwotfQotI2VuZGlmCi0KLSNpZiBFTkFCTEUoU0FNUExJTkdfRkxBR1MpCi12 b2lkIEpJVENvbXBpbGVyOjpzZXRTYW1wbGluZ0ZsYWcoaW50MzJfdCBmbGFnKQotewotICAgIEFT U0VSVChmbGFnID49IDEpOwotICAgIEFTU0VSVChmbGFnIDw9IDMyKTsKLSAgICBvcjMyKFRydXN0 ZWRJbW0zMigxdSA8PCAoZmxhZyAtIDEpKSwgQWJzb2x1dGVBZGRyZXNzKFNhbXBsaW5nRmxhZ3M6 OmFkZHJlc3NPZkZsYWdzKCkpKTsKLX0KLQotdm9pZCBKSVRDb21waWxlcjo6Y2xlYXJTYW1wbGlu Z0ZsYWcoaW50MzJfdCBmbGFnKQotewotICAgIEFTU0VSVChmbGFnID49IDEpOwotICAgIEFTU0VS VChmbGFnIDw9IDMyKTsKLSAgICBhbmQzMihUcnVzdGVkSW1tMzIofigxdSA8PCAoZmxhZyAtIDEp KSksIEFic29sdXRlQWRkcmVzcyhTYW1wbGluZ0ZsYWdzOjphZGRyZXNzT2ZGbGFncygpKSk7Ci19 Ci0jZW5kaWYKLQogfSB9IC8vIG5hbWVzcGFjZSBKU0M6OkRGRwogCiAjZW5kaWYKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCShyZXZpc2lvbiA5 OTI2MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yODksNiArMjg5LDM4IEBAIHZvaWQgSklUQ29tcGlsZXI6OmNvbXBp bGVGdW5jdGlvbihKSVRDb2QKICAgICBlbnRyeSA9IEpJVENvZGUobGlua0J1ZmZlci5maW5hbGl6 ZUNvZGUoKSwgSklUQ29kZTo6REZHSklUKTsKIH0KIAorI2lmIEVOQUJMRShTQU1QTElOR19DT1VO VEVSUykgJiYgQ1BVKFg4Nl82NCkgLy8gT3IgYW55IG90aGVyIDY0LWJpdCBwbGF0Zm9ybSEKK3Zv aWQgSklUQ29tcGlsZXI6OmVtaXRDb3VudChNYWNyb0Fzc2VtYmxlciYgaml0LCBBYnN0cmFjdFNh bXBsaW5nQ291bnRlciYgY291bnRlciwgdWludDMyX3QgaW5jcmVtZW50KQoreworICAgIGppdC5h ZGRQdHIoVHJ1c3RlZEltbTMyKGluY3JlbWVudCksIEFic29sdXRlQWRkcmVzcyhjb3VudGVyLmFk ZHJlc3NPZkNvdW50ZXIoKSkpOworfQorI2VuZGlmCisKKyNpZiBFTkFCTEUoU0FNUExJTkdfQ09V TlRFUlMpICYmIENQVShYODYpIC8vIE9yIGFueSBvdGhlciBsaXR0bGUtZW5kaWFuIDMyLWJpdCBw bGF0Zm9ybSEKK3ZvaWQgSklUQ29tcGlsZXI6OmVtaXRDb3VudChNYWNyb0FzZW1ibGVyJiBqaXQs IEFic3RyYWN0U2FtcGxpbmdDb3VudGVyJiBjb3VudGVyLCB1aW50MzJfdCBpbmNyZW1lbnQpCit7 CisgICAgaW50cHRyX3QgaGlXb3JkID0gcmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oY291bnRl ci5hZGRyZXNzT2ZDb3VudGVyKCkpICsgc2l6ZW9mKGludDMyX3QpOworICAgIGppdC5hZGQzMihU cnVzdGVkSW1tMzIoaW5jcmVtZW50KSwgQWJzb2x1dGVBZGRyZXNzKGNvdW50ZXIuYWRkcmVzc09m Q291bnRlcigpKSk7CisgICAgaml0LmFkZFdpdGhDYXJyeTMyKFRydXN0ZWRJbW0zMigwKSwgQWJz b2x1dGVBZGRyZXNzKHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KGhpV29yZCkpKTsKK30KKyNlbmRp ZgorCisjaWYgRU5BQkxFKFNBTVBMSU5HX0ZMQUdTKQordm9pZCBKSVRDb21waWxlcjo6c2V0U2Ft cGxpbmdGbGFnKGludDMyX3QgZmxhZykKK3sKKyAgICBBU1NFUlQoZmxhZyA+PSAxKTsKKyAgICBB U1NFUlQoZmxhZyA8PSAzMik7CisgICAgb3IzMihUcnVzdGVkSW1tMzIoMXUgPDwgKGZsYWcgLSAx KSksIEFic29sdXRlQWRkcmVzcyhTYW1wbGluZ0ZsYWdzOjphZGRyZXNzT2ZGbGFncygpKSk7Cit9 CisKK3ZvaWQgSklUQ29tcGlsZXI6OmNsZWFyU2FtcGxpbmdGbGFnKGludDMyX3QgZmxhZykKK3sK KyAgICBBU1NFUlQoZmxhZyA+PSAxKTsKKyAgICBBU1NFUlQoZmxhZyA8PSAzMik7CisgICAgYW5k MzIoVHJ1c3RlZEltbTMyKH4oMXUgPDwgKGZsYWcgLSAxKSkpLCBBYnNvbHV0ZUFkZHJlc3MoU2Ft cGxpbmdGbGFnczo6YWRkcmVzc09mRmxhZ3MoKSkpOworfQorI2VuZGlmCisKICNpZiBVU0UoSlNW QUxVRTY0KQogCiB2b2lkIEpJVENvbXBpbGVyOjpleGl0U3BlY3VsYXRpdmVXaXRoT1NSKGNvbnN0 IE9TUkV4aXQmIGV4aXQsIFNwZWN1bGF0aW9uUmVjb3ZlcnkqIHJlY292ZXJ5KQpAQCAtODU1LDM4 ICs4ODcsNiBAQCB2b2lkIEpJVENvbXBpbGVyOjpqaXRBc3NlcnRJc0NlbGwoR1BSUmVnCiB9CiAj ZW5kaWYKIAotI2lmIEVOQUJMRShTQU1QTElOR19DT1VOVEVSUykgJiYgQ1BVKFg4Nl82NCkgLy8g T3IgYW55IG90aGVyIDY0LWJpdCBwbGF0Zm9ybSEKLXZvaWQgSklUQ29tcGlsZXI6OmVtaXRDb3Vu dChNYWNyb0Fzc2VtYmxlciYgaml0LCBBYnN0cmFjdFNhbXBsaW5nQ291bnRlciYgY291bnRlciwg dWludDMyX3QgaW5jcmVtZW50KQotewotICAgIGppdC5hZGRQdHIoVHJ1c3RlZEltbTMyKGluY3Jl bWVudCksIEFic29sdXRlQWRkcmVzcyhjb3VudGVyLmFkZHJlc3NPZkNvdW50ZXIoKSkpOwotfQot I2VuZGlmCi0KLSNpZiBFTkFCTEUoU0FNUExJTkdfQ09VTlRFUlMpICYmIENQVShYODYpIC8vIE9y IGFueSBvdGhlciBsaXR0bGUtZW5kaWFuIDMyLWJpdCBwbGF0Zm9ybSEKLXZvaWQgSklUQ29tcGls ZXI6OmVtaXRDb3VudChNYWNyb0FzZW1ibGVyJiBqaXQsIEFic3RyYWN0U2FtcGxpbmdDb3VudGVy JiBjb3VudGVyLCB1aW50MzJfdCBpbmNyZW1lbnQpCi17Ci0gICAgaW50cHRyX3QgaGlXb3JkID0g cmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oY291bnRlci5hZGRyZXNzT2ZDb3VudGVyKCkpICsg c2l6ZW9mKGludDMyX3QpOwotICAgIGppdC5hZGQzMihUcnVzdGVkSW1tMzIoaW5jcmVtZW50KSwg QWJzb2x1dGVBZGRyZXNzKGNvdW50ZXIuYWRkcmVzc09mQ291bnRlcigpKSk7Ci0gICAgaml0LmFk ZFdpdGhDYXJyeTMyKFRydXN0ZWRJbW0zMigwKSwgQWJzb2x1dGVBZGRyZXNzKHJlaW50ZXJwcmV0 X2Nhc3Q8dm9pZCo+KGhpV29yZCkpKTsKLX0KLSNlbmRpZgotCi0jaWYgRU5BQkxFKFNBTVBMSU5H X0ZMQUdTKQotdm9pZCBKSVRDb21waWxlcjo6c2V0U2FtcGxpbmdGbGFnKGludDMyX3QgZmxhZykK LXsKLSAgICBBU1NFUlQoZmxhZyA+PSAxKTsKLSAgICBBU1NFUlQoZmxhZyA8PSAzMik7Ci0gICAg b3IzMihUcnVzdGVkSW1tMzIoMXUgPDwgKGZsYWcgLSAxKSksIEFic29sdXRlQWRkcmVzcyhTYW1w bGluZ0ZsYWdzOjphZGRyZXNzT2ZGbGFncygpKSk7Ci19Ci0KLXZvaWQgSklUQ29tcGlsZXI6OmNs ZWFyU2FtcGxpbmdGbGFnKGludDMyX3QgZmxhZykKLXsKLSAgICBBU1NFUlQoZmxhZyA+PSAxKTsK LSAgICBBU1NFUlQoZmxhZyA8PSAzMik7Ci0gICAgYW5kMzIoVHJ1c3RlZEltbTMyKH4oMXUgPDwg KGZsYWcgLSAxKSkpLCBBYnNvbHV0ZUFkZHJlc3MoU2FtcGxpbmdGbGFnczo6YWRkcmVzc09mRmxh Z3MoKSkpOwotfQotI2VuZGlmCi0KICNlbmRpZiAvLyBVU0UoSlNWQUxVRTY0KQogCiB9IH0gLy8g bmFtZXNwYWNlIEpTQzo6REZHCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklUMzJfNjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQzMl82NC5jcHAJKHJldmlzaW9uIDk5MjYzKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMjUwOCw2ICsyNTA4LDEwIEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBp bGUoTm9kZSYgbm9kZSkKICAgICAgICAgLy8gVGhpcyBpcyBhIG5vLW9wLgogICAgICAgICBub1Jl c3VsdChtX2NvbXBpbGVJbmRleCk7CiAgICAgICAgIGJyZWFrOworCisgICAgY2FzZSBJbmxpbmVT dGFydDoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGJyZWFrOwogICAg IH0KIAogICAgIGlmIChub2RlLmhhc1Jlc3VsdCgpICYmIG5vZGUubXVzdEdlbmVyYXRlKCkpCg==