<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>71516</bug_id>
          
          <creation_ts>2011-11-03 16:02:56 -0700</creation_ts>
          <short_desc>CMake: Only generate from WebGL IDLs when building with WebGL</short_desc>
          <delta_ts>2011-11-03 16:36:04 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>leandro</cc>
    
    <cc>paroga</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>495839</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-11-03 16:02:56 -0700</bug_when>
    <thetext>Following the convention used for other feature defines, such as Blob and FileAPI, we should only generate from the WebGL IDLs when building with WebGL enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495841</commentid>
    <comment_count>1</comment_count>
      <attachid>113568</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-11-03 16:05:56 -0700</bug_when>
    <thetext>Created attachment 113568
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495871</commentid>
    <comment_count>2</comment_count>
      <attachid>113568</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-11-03 16:30:39 -0700</bug_when>
    <thetext>Comment on attachment 113568
Patch

Looks reasonable to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>495876</commentid>
    <comment_count>3</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-11-03 16:36:04 -0700</bug_when>
    <thetext>Committed r99245: &lt;http://trac.webkit.org/changeset/99245&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>113568</attachid>
            <date>2011-11-03 16:05:56 -0700</date>
            <delta_ts>2011-11-03 16:30:39 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-71516-20111103160255.patch</filename>
            <type>text/plain</type>
            <size>2696</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5MjM4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTEtMDMgIERhbmllbCBC
YXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIENNYWtlOiBPbmx5IGdlbmVyYXRlIGZy
b20gV2ViR0wgSURMcyB3aGVuIGJ1aWxkaW5nIHdpdGggV2ViR0wKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNTE2CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxMS0x
MS0wMyAgRGFuaWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hy
b21pdW1dIFJlbW92ZSB1bnVzZWQgY2xpcGJvYXJkIG1ldGhvZHMKSW5kZXg6IFNvdXJjZS9XZWJD
b3JlL0NNYWtlTGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlz
dHMudHh0CShyZXZpc2lvbiA5OTIzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0
CSh3b3JraW5nIGNvcHkpCkBAIC0yOTcsMjYgKzI5Nyw5IEBAIFNFVChXZWJDb3JlX0lETF9GSUxF
UwogICAgIGh0bWwvY2FudmFzL0ludDE2QXJyYXkuaWRsCiAgICAgaHRtbC9jYW52YXMvSW50MzJB
cnJheS5pZGwKICAgICBodG1sL2NhbnZhcy9JbnQ4QXJyYXkuaWRsCi0gICAgaHRtbC9jYW52YXMv
T0VTU3RhbmRhcmREZXJpdmF0aXZlcy5pZGwKLSAgICBodG1sL2NhbnZhcy9PRVNUZXh0dXJlRmxv
YXQuaWRsCi0gICAgaHRtbC9jYW52YXMvT0VTVmVydGV4QXJyYXlPYmplY3QuaWRsCiAgICAgaHRt
bC9jYW52YXMvVWludDE2QXJyYXkuaWRsCiAgICAgaHRtbC9jYW52YXMvVWludDMyQXJyYXkuaWRs
CiAgICAgaHRtbC9jYW52YXMvVWludDhBcnJheS5pZGwKLSAgICBodG1sL2NhbnZhcy9XZWJHTEFj
dGl2ZUluZm8uaWRsCi0gICAgaHRtbC9jYW52YXMvV2ViR0xCdWZmZXIuaWRsCi0gICAgaHRtbC9j
YW52YXMvV2ViR0xDb250ZXh0QXR0cmlidXRlcy5pZGwKLSAgICBodG1sL2NhbnZhcy9XZWJHTERl
YnVnUmVuZGVyZXJJbmZvLmlkbAotICAgIGh0bWwvY2FudmFzL1dlYkdMRGVidWdTaGFkZXJzLmlk
bAotICAgIGh0bWwvY2FudmFzL1dlYkdMRnJhbWVidWZmZXIuaWRsCi0gICAgaHRtbC9jYW52YXMv
V2ViR0xQcm9ncmFtLmlkbAotICAgIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyYnVmZmVyLmlkbAot
ICAgIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGwKLSAgICBodG1sL2NhbnZh
cy9XZWJHTFNoYWRlci5pZGwKLSAgICBodG1sL2NhbnZhcy9XZWJHTFRleHR1cmUuaWRsCi0gICAg
aHRtbC9jYW52YXMvV2ViR0xVbmlmb3JtTG9jYXRpb24uaWRsCi0gICAgaHRtbC9jYW52YXMvV2Vi
R0xWZXJ0ZXhBcnJheU9iamVjdE9FUy5pZGwKLSAgICBodG1sL2NhbnZhcy9XZWJLaXRMb3NlQ29u
dGV4dC5pZGwKIAogICAgIGluc3BlY3Rvci9JbmplY3RlZFNjcmlwdEhvc3QuaWRsCiAgICAgaW5z
cGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwKQEAgLTIxNjIsNiArMjE0NSwyNSBAQCBJ
RiAoRU5BQkxFX1dFQkdMKQogICAgICAgICAKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1
L0RyYXdpbmdCdWZmZXIuY3BwCiAgICAgKQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfSURMX0ZJ
TEVTCisgICAgICAgIGh0bWwvY2FudmFzL09FU1N0YW5kYXJkRGVyaXZhdGl2ZXMuaWRsCisgICAg
ICAgIGh0bWwvY2FudmFzL09FU1RleHR1cmVGbG9hdC5pZGwKKyAgICAgICAgaHRtbC9jYW52YXMv
T0VTVmVydGV4QXJyYXlPYmplY3QuaWRsCisgICAgICAgIGh0bWwvY2FudmFzL1dlYkdMQWN0aXZl
SW5mby5pZGwKKyAgICAgICAgaHRtbC9jYW52YXMvV2ViR0xCdWZmZXIuaWRsCisgICAgICAgIGh0
bWwvY2FudmFzL1dlYkdMQ29udGV4dEF0dHJpYnV0ZXMuaWRsCisgICAgICAgIGh0bWwvY2FudmFz
L1dlYkdMRGVidWdSZW5kZXJlckluZm8uaWRsCisgICAgICAgIGh0bWwvY2FudmFzL1dlYkdMRGVi
dWdTaGFkZXJzLmlkbAorICAgICAgICBodG1sL2NhbnZhcy9XZWJHTEZyYW1lYnVmZmVyLmlkbAor
ICAgICAgICBodG1sL2NhbnZhcy9XZWJHTFByb2dyYW0uaWRsCisgICAgICAgIGh0bWwvY2FudmFz
L1dlYkdMUmVuZGVyYnVmZmVyLmlkbAorICAgICAgICBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmlu
Z0NvbnRleHQuaWRsCisgICAgICAgIGh0bWwvY2FudmFzL1dlYkdMU2hhZGVyLmlkbAorICAgICAg
ICBodG1sL2NhbnZhcy9XZWJHTFRleHR1cmUuaWRsCisgICAgICAgIGh0bWwvY2FudmFzL1dlYkdM
VW5pZm9ybUxvY2F0aW9uLmlkbAorICAgICAgICBodG1sL2NhbnZhcy9XZWJHTFZlcnRleEFycmF5
T2JqZWN0T0VTLmlkbAorICAgICAgICBodG1sL2NhbnZhcy9XZWJLaXRMb3NlQ29udGV4dC5pZGwK
KyAgICApCiBFTkRJRiAoKQogCiAjIE1vZHVsZXMgdGhhdCB0aGUgYmluZGluZ3MgZ2VuZXJhdG9y
IHNjcmlwdHMgbWF5IHVzZQo=
</data>
<flag name="review"
          id="111981"
          type_id="1"
          status="+"
          setter="mrobinson"
    />
          </attachment>
      

    </bug>

</bugzilla>