<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>71505</bug_id>
          
          <creation_ts>2011-11-03 13:51:58 -0700</creation_ts>
          <short_desc>Showing the data overlay in OpenStreetMap doesn&apos;t work, zooming partially broken</short_desc>
          <delta_ts>2011-11-22 15:59:55 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac (Intel)</rep_platform>
          <op_sys>OS X 10.6</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.openstreetmap.org/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>lars.sonchocky-helldorf</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>fpizlo</cc>
    
    <cc>oliver</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>495777</commentid>
    <comment_count>0</comment_count>
    <who name="">lars.sonchocky-helldorf</who>
    <bug_when>2011-11-03 13:51:58 -0700</bug_when>
    <thetext>For Version 5.1.1 (6534.51.22, r98912) OpenStreetMap is somewhat broken:

1. showing the data overlay doesn&apos;t work:
  - on the right side of http://www.openstreetmap.org/ there is a small (+) sign. 
  - When you click on this a drawer with options opens. 
  - now click onto the &quot;data&quot; overlay checkbox.
  -&gt; nothing happens.
  -&gt; check the normal release of Safari (or any other browser) to see the expected behaviour.

2. zooming into OpenStreetMap by double clicking into the map works unreliable
  - after a while the map display is either empty or no longer updated
  - reloading brings back a lower zoom level
  -&gt; check the normal release of Safari (or any other browser) to see the expected behaviour.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506280</commentid>
    <comment_count>1</comment_count>
    <who name="">lars.sonchocky-helldorf</who>
    <bug_when>2011-11-18 18:37:21 -0800</bug_when>
    <thetext>r97664 is the last version to work without flaws, the next available version r98824 has the issues (up until today r100547)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506624</commentid>
    <comment_count>2</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-11-20 17:11:02 -0800</bug_when>
    <thetext>Seems like in debug builds of ToT (r100874) we hit the following assertion:


ASSERTION FAILED: dst != func
/Volumes/Data/pizlo/tertiary/OpenSource/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp(1840) : JSC::RegisterID *JSC::BytecodeGenerator::emitCallVarargs(JSC::RegisterID *, JSC::RegisterID *, JSC::RegisterID *, JSC::RegisterID *, JSC::RegisterID *, unsigned int, unsigned int, unsigned int)
1   0x10d947c01 JSC::BytecodeGenerator::emitCallVarargs(JSC::RegisterID*, JSC::RegisterID*, JSC::RegisterID*, JSC::RegisterID*, JSC::RegisterID*, unsigned int, unsigned int, unsigned int)
2   0x10db1b6a5 JSC::ApplyFunctionCallDotNode::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
3   0x10d94f278 JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::Node*)
4   0x10db1fd13 JSC::ConditionalNode::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
5   0x10d94f278 JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::Node*)
6   0x10db20b95 JSC::AssignResolveNode::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
7   0x10d94f278 JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::Node*)
8   0x10db226cd JSC::ExprStatementNode::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
9   0x10d94f278 JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::Node*)
10  0x10db28324 JSC::SourceElements::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
11  0x10db2251f JSC::BlockNode::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
12  0x10d94f278 JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::Node*)
13  0x10db22a21 JSC::IfNode::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
14  0x10d94f278 JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::Node*)
15  0x10db28324 JSC::SourceElements::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
16  0x10db2251f JSC::BlockNode::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
17  0x10d94f278 JSC::BytecodeGenerator::emitNode(JSC::RegisterID*, JSC::Node*)
18  0x10db28324 JSC::SourceElements::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
19  0x10db28945 JSC::ScopeNode::emitStatementsBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
20  0x10db2728c JSC::FunctionBodyNode::emitBytecode(JSC::BytecodeGenerator&amp;, JSC::RegisterID*)
21  0x10d93daad JSC::BytecodeGenerator::generate()
22  0x10da106cd JSC::FunctionExecutable::produceCodeBlockFor(JSC::ScopeChainNode*, JSC::CompilationKind, JSC::CodeSpecializationKind, JSC::JSObject*&amp;)
23  0x10da0f0f6 JSC::FunctionExecutable::compileForCallInternal(JSC::ExecState*, JSC::ScopeChainNode*, JSC::JITCode::JITType)
24  0x10d92e633 JSC::FunctionExecutable::compileForCall(JSC::ExecState*, JSC::ScopeChainNode*)
25  0x10da2e2d8 JSC::Interpreter::prepareForRepeatCall(JSC::FunctionExecutable*, JSC::ExecState*, JSC::JSFunction*, int, JSC::ScopeChainNode*)
26  0x10d92caea JSC::CachedCall::CachedCall(JSC::ExecState*, JSC::JSFunction*, int)
27  0x10d92bb8b JSC::CachedCall::CachedCall(JSC::ExecState*, JSC::JSFunction*, int)
28  0x10dbbbc00 _ZN3JSCL22stringProtoFuncReplaceEPNS_9ExecStateE
29  0x21511e601218
30  0x10da30679 JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*)
31  0x10da2d0f6 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506643</commentid>
    <comment_count>3</comment_count>
      <attachid>116018</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-11-20 18:15:42 -0800</bug_when>
    <thetext>Created attachment 116018
the patch

I believe this fixes it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506670</commentid>
    <comment_count>4</comment_count>
      <attachid>116018</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-20 20:35:55 -0800</bug_when>
    <thetext>Comment on attachment 116018
the patch

Clearing flags on attachment: 116018

Committed r100879: &lt;http://trac.webkit.org/changeset/100879&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506671</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-11-20 20:36:00 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>506679</commentid>
    <comment_count>6</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-11-20 20:51:31 -0800</bug_when>
    <thetext>&lt;rdar://problem/10476342&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507272</commentid>
    <comment_count>7</comment_count>
    <who name="">lars.sonchocky-helldorf</who>
    <bug_when>2011-11-21 15:23:16 -0800</bug_when>
    <thetext>Sorry to rain on your parade, the bug is not fixed. Try zooming into the map at http://www.openstreetmap.org/ by double clicking the map several times in a row.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507287</commentid>
    <comment_count>8</comment_count>
    <who name="">lars.sonchocky-helldorf</who>
    <bug_when>2011-11-21 15:55:03 -0800</bug_when>
    <thetext>Version r100927 is still affected I wanted to say.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507290</commentid>
    <comment_count>9</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2011-11-21 15:56:13 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; Sorry to rain on your parade, the bug is not fixed. Try zooming into the map at http://www.openstreetmap.org/ by double clicking the map several times in a row.

Try to be polite and respectful in bug comments, being snarky isn&apos;t helpful</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507294</commentid>
    <comment_count>10</comment_count>
    <who name="">lars.sonchocky-helldorf</who>
    <bug_when>2011-11-21 16:01:47 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; (In reply to comment #7)
&gt; &gt; Sorry to rain on your parade, the bug is not fixed. Try zooming into the map at http://www.openstreetmap.org/ by double clicking the map several times in a row.
&gt; 
&gt; Try to be polite and respectful in bug comments, being snarky isn&apos;t helpful

Sorry for that. I did not want to be snarky, I am not a native speaker, I wasn&apos;t aware that the idiom I used is considered snarky. I just used http://dict.leo.org/ to translate a colloquial german saying. Please excuse me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507297</commentid>
    <comment_count>11</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-11-21 16:06:49 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; Version r100927 is still affected I wanted to say.

It appears so.  I&apos;m looking into it now, but I wanted to see if you can confirm what I&apos;m seeing:

1) Zooming and panning often results in the map getting totally corrupted, and eventually stops responding.  Expected behavior is that this does not happen.

2) Changing the following line in Source/JavaScriptCore/runtime/Heuristics.cpp

    SET(maximumInliningDepth, 5);

to:

    SET(maximumInliningDepth, 1);

appears to &quot;fix&quot; the problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507305</commentid>
    <comment_count>12</comment_count>
    <who name="">lars.sonchocky-helldorf</who>
    <bug_when>2011-11-21 16:13:02 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #8)
&gt; &gt; Version r100927 is still affected I wanted to say.
&gt; 
&gt; It appears so.  I&apos;m looking into it now, but I wanted to see if you can confirm what I&apos;m seeing:
&gt; 
&gt; 1) Zooming and panning often results in the map getting totally corrupted, and eventually stops responding.  Expected behavior is that this does not happen.

This is what I experienced to. The map gets corrupted and stops to respond to any action until you reload it. For the expected behaviour please try r97664 which doesn&apos;t fail even if the double clicks are done in a rapid manner.

&gt; 
&gt; 2) Changing the following line in Source/JavaScriptCore/runtime/Heuristics.cpp
&gt; 
&gt;     SET(maximumInliningDepth, 5);
&gt; 
&gt; to:
&gt; 
&gt;     SET(maximumInliningDepth, 1);
&gt; 
&gt; appears to &quot;fix&quot; the problem.

I can&apos;t comment on that one as I have no idea what it does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507334</commentid>
    <comment_count>13</comment_count>
      <attachid>116157</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-11-21 17:48:48 -0800</bug_when>
    <thetext>Created attachment 116157
the patch

Sadly, I couldn&apos;t get this to repro in any simplified test case. :-(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507337</commentid>
    <comment_count>14</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-11-21 17:53:47 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; Version r100927 is still affected I wanted to say.

I think my new patch fixes it.  But please do let us know if you still find problems!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507345</commentid>
    <comment_count>15</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-11-21 18:16:16 -0800</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/100972</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>507854</commentid>
    <comment_count>16</comment_count>
    <who name="">lars.sonchocky-helldorf</who>
    <bug_when>2011-11-22 15:59:55 -0800</bug_when>
    <thetext>The issue seems to be solved. Thanks one more time!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>116018</attachid>
            <date>2011-11-20 18:15:42 -0800</date>
            <delta_ts>2011-11-20 20:35:55 -0800</delta_ts>
            <desc>the patch</desc>
            <filename>fixdotapply_patch_1.diff</filename>
            <type>text/plain</type>
            <size>8539</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAwODc2KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA
CisyMDExLTExLTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
U2hvd2luZyB0aGUgZGF0YSBvdmVybGF5IGluIE9wZW5TdHJlZXRNYXAgZG9lc24ndCB3b3JrLCB6
b29taW5nIHBhcnRpYWxseSBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTcxNTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisgICAgICAgIAorICAgICAgICBUaGUgYnl0ZWNvZGUgZ2VuZXJhdG9yIHdhcyBhc3N1bWlu
ZyB0aGF0IGNhbGxfdmFyYXJncyBuZXZlciByZXVzZXMgdGhlIGJhc2UgcmVnaXN0ZXIKKyAgICAg
ICAgKGkuZS4gdGhlIGZ1bmN0aW9uIGJlaW5nIGNhbGxlZCkgZm9yIHRoZSByZXN1bHQuIFRoaXMg
aXMgbm8gbG9uZ2VyIHRydWUuCisKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5l
cmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdENhbGxWYXJh
cmdzKToKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuaDoKKyAgICAg
ICAgKiBieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcDoKKyAgICAgICAgKEpTQzo6QXBwbHlG
dW5jdGlvbkNhbGxEb3ROb2RlOjplbWl0Qnl0ZWNvZGUpOgorCiAyMDExLTExLTIwICBOb2VsIEdv
cmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIFJlbW92
ZSBERkc6OkpJVENvZGVHZW5lcmF0b3IgZnJvbSB0aGUgZ3lwIHByb2plY3RzCkluZGV4OiBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2Vu
ZXJhdG9yLmNwcAkocmV2aXNpb24gMTAwODc0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5
dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4MzUs
MTIgKzE4MzUsMTIgQEAgUmVnaXN0ZXJJRCogQnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRDYWxsKAog
ICAgIHJldHVybiBkc3Q7CiB9CiAKLVJlZ2lzdGVySUQqIEJ5dGVjb2RlR2VuZXJhdG9yOjplbWl0
Q2FsbFZhcmFyZ3MoUmVnaXN0ZXJJRCogZHN0LCBSZWdpc3RlcklEKiBmdW5jLCBSZWdpc3RlcklE
KiB0aGlzUmVnaXN0ZXIsIFJlZ2lzdGVySUQqIGFyZ3VtZW50cywgUmVnaXN0ZXJJRCogZmlyc3RG
cmVlUmVnaXN0ZXIsIHVuc2lnbmVkIGRpdm90LCB1bnNpZ25lZCBzdGFydE9mZnNldCwgdW5zaWdu
ZWQgZW5kT2Zmc2V0KQorUmVnaXN0ZXJJRCogQnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRDYWxsVmFy
YXJncyhSZWdpc3RlcklEKiBkc3QsIFJlZ2lzdGVySUQqIGZ1bmMsIFJlZ2lzdGVySUQqIHRoaXNS
ZWdpc3RlciwgUmVnaXN0ZXJJRCogYXJndW1lbnRzLCBSZWdpc3RlcklEKiBmaXJzdEZyZWVSZWdp
c3RlciwgUmVnaXN0ZXJJRCogcHJvZmlsZUhvb2tSZWdpc3RlciwgdW5zaWduZWQgZGl2b3QsIHVu
c2lnbmVkIHN0YXJ0T2Zmc2V0LCB1bnNpZ25lZCBlbmRPZmZzZXQpCiB7Ci0gICAgQVNTRVJUKGRz
dCAhPSBmdW5jKTsKICAgICBpZiAobV9zaG91bGRFbWl0UHJvZmlsZUhvb2tzKSB7CisgICAgICAg
IGVtaXRNb3ZlKHByb2ZpbGVIb29rUmVnaXN0ZXIsIGZ1bmMpOwogICAgICAgICBlbWl0T3Bjb2Rl
KG9wX3Byb2ZpbGVfd2lsbF9jYWxsKTsKLSAgICAgICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5kKGZ1
bmMtPmluZGV4KCkpOworICAgICAgICBpbnN0cnVjdGlvbnMoKS5hcHBlbmQocHJvZmlsZUhvb2tS
ZWdpc3Rlci0+aW5kZXgoKSk7CiAgICAgfQogICAgIAogICAgIGVtaXRFeHByZXNzaW9uSW5mbyhk
aXZvdCwgc3RhcnRPZmZzZXQsIGVuZE9mZnNldCk7CkBAIC0xODU3LDcgKzE4NTcsNyBAQCBSZWdp
c3RlcklEKiBCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdENhbGxWCiAgICAgfQogICAgIGlmIChtX3No
b3VsZEVtaXRQcm9maWxlSG9va3MpIHsKICAgICAgICAgZW1pdE9wY29kZShvcF9wcm9maWxlX2Rp
ZF9jYWxsKTsKLSAgICAgICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5kKGZ1bmMtPmluZGV4KCkpOwor
ICAgICAgICBpbnN0cnVjdGlvbnMoKS5hcHBlbmQocHJvZmlsZUhvb2tSZWdpc3Rlci0+aW5kZXgo
KSk7CiAgICAgfQogICAgIHJldHVybiBkc3Q7CiB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oCShyZXZpc2lv
biAxMDA4NzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2Rl
R2VuZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTMzNSw3ICszMzUsNyBAQCBuYW1lc3BhY2Ug
SlNDIHsKIAogICAgICAgICBSZWdpc3RlcklEKiBlbWl0Q2FsbChSZWdpc3RlcklEKiBkc3QsIFJl
Z2lzdGVySUQqIGZ1bmMsIENhbGxBcmd1bWVudHMmLCB1bnNpZ25lZCBkaXZvdCwgdW5zaWduZWQg
c3RhcnRPZmZzZXQsIHVuc2lnbmVkIGVuZE9mZnNldCk7CiAgICAgICAgIFJlZ2lzdGVySUQqIGVt
aXRDYWxsRXZhbChSZWdpc3RlcklEKiBkc3QsIFJlZ2lzdGVySUQqIGZ1bmMsIENhbGxBcmd1bWVu
dHMmLCB1bnNpZ25lZCBkaXZvdCwgdW5zaWduZWQgc3RhcnRPZmZzZXQsIHVuc2lnbmVkIGVuZE9m
ZnNldCk7Ci0gICAgICAgIFJlZ2lzdGVySUQqIGVtaXRDYWxsVmFyYXJncyhSZWdpc3RlcklEKiBk
c3QsIFJlZ2lzdGVySUQqIGZ1bmMsIFJlZ2lzdGVySUQqIHRoaXNSZWdpc3RlciwgUmVnaXN0ZXJJ
RCogYXJndW1lbnRzLCBSZWdpc3RlcklEKiBmaXJzdEZyZWVSZWdpc3RlciwgdW5zaWduZWQgZGl2
b3QsIHVuc2lnbmVkIHN0YXJ0T2Zmc2V0LCB1bnNpZ25lZCBlbmRPZmZzZXQpOworICAgICAgICBS
ZWdpc3RlcklEKiBlbWl0Q2FsbFZhcmFyZ3MoUmVnaXN0ZXJJRCogZHN0LCBSZWdpc3RlcklEKiBm
dW5jLCBSZWdpc3RlcklEKiB0aGlzUmVnaXN0ZXIsIFJlZ2lzdGVySUQqIGFyZ3VtZW50cywgUmVn
aXN0ZXJJRCogZmlyc3RGcmVlUmVnaXN0ZXIsIFJlZ2lzdGVySUQqIHByb2ZpbGVIb29rUmVnaXN0
ZXIsIHVuc2lnbmVkIGRpdm90LCB1bnNpZ25lZCBzdGFydE9mZnNldCwgdW5zaWduZWQgZW5kT2Zm
c2V0KTsKICAgICAgICAgUmVnaXN0ZXJJRCogZW1pdExvYWRWYXJhcmdzKFJlZ2lzdGVySUQqIGFy
Z0NvdW50RHN0LCBSZWdpc3RlcklEKiB0aGlzUmVnaXN0ZXIsIFJlZ2lzdGVySUQqIGFyZ3MpOwog
CiAgICAgICAgIFJlZ2lzdGVySUQqIGVtaXRSZXR1cm4oUmVnaXN0ZXJJRCogc3JjKTsKSW5kZXg6
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdl
bi5jcHAJKHJldmlzaW9uIDEwMDg3NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29t
cGlsZXIvTm9kZXNDb2RlZ2VuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDk2LDYgKzQ5Niw5IEBA
IFJlZ2lzdGVySUQqIEFwcGx5RnVuY3Rpb25DYWxsRG90Tm9kZTo6ZW0KICAgICAgICAgICAgIH0K
ICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIEFTU0VSVChtX2FyZ3MtPm1fbGlzdE5vZGUg
JiYgbV9hcmdzLT5tX2xpc3ROb2RlLT5tX25leHQpOworICAgICAgICAgICAgUmVmUHRyPFJlZ2lz
dGVySUQ+IHByb2ZpbGVIb29rUmVnaXN0ZXI7CisgICAgICAgICAgICBpZiAoZ2VuZXJhdG9yLnNo
b3VsZEVtaXRQcm9maWxlSG9va3MoKSkKKyAgICAgICAgICAgICAgICBwcm9maWxlSG9va1JlZ2lz
dGVyID0gZ2VuZXJhdG9yLm5ld1RlbXBvcmFyeSgpOwogICAgICAgICAgICAgUmVmUHRyPFJlZ2lz
dGVySUQ+IHRoaXNSZWdpc3RlciA9IGdlbmVyYXRvci5lbWl0Tm9kZShtX2FyZ3MtPm1fbGlzdE5v
ZGUtPm1fZXhwcik7CiAgICAgICAgICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gYXJnc1JlZ2lzdGVy
OwogICAgICAgICAgICAgQXJndW1lbnRMaXN0Tm9kZSogYXJncyA9IG1fYXJncy0+bV9saXN0Tm9k
ZS0+bV9uZXh0OwpAQCAtNTA5LDcgKzUxMiw3IEBAIFJlZ2lzdGVySUQqIEFwcGx5RnVuY3Rpb25D
YWxsRG90Tm9kZTo6ZW0KICAgICAgICAgICAgIHdoaWxlICgoYXJncyA9IGFyZ3MtPm1fbmV4dCkp
CiAgICAgICAgICAgICAgICAgZ2VuZXJhdG9yLmVtaXROb2RlKGFyZ3MtPm1fZXhwcik7CiAKLSAg
ICAgICAgICAgIGdlbmVyYXRvci5lbWl0Q2FsbFZhcmFyZ3MoZmluYWxEZXN0aW5hdGlvbk9ySWdu
b3JlZC5nZXQoKSwgYmFzZS5nZXQoKSwgdGhpc1JlZ2lzdGVyLmdldCgpLCBhcmdzUmVnaXN0ZXIu
Z2V0KCksIGdlbmVyYXRvci5uZXdUZW1wb3JhcnkoKSwgZGl2b3QoKSwgc3RhcnRPZmZzZXQoKSwg
ZW5kT2Zmc2V0KCkpOworICAgICAgICAgICAgZ2VuZXJhdG9yLmVtaXRDYWxsVmFyYXJncyhmaW5h
bERlc3RpbmF0aW9uT3JJZ25vcmVkLmdldCgpLCBiYXNlLmdldCgpLCB0aGlzUmVnaXN0ZXIuZ2V0
KCksIGFyZ3NSZWdpc3Rlci5nZXQoKSwgZ2VuZXJhdG9yLm5ld1RlbXBvcmFyeSgpLCBwcm9maWxl
SG9va1JlZ2lzdGVyLmdldCgpLCBkaXZvdCgpLCBzdGFydE9mZnNldCgpLCBlbmRPZmZzZXQoKSk7
CiAgICAgICAgIH0KICAgICAgICAgZ2VuZXJhdG9yLmVtaXRKdW1wKGVuZC5nZXQoKSk7CiAgICAg
fQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz
L0NoYW5nZUxvZwkocmV2aXNpb24gMTAwODc2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3
b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMTEtMjAgIEZpbGlwIFBpemxvICA8
ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBTaG93aW5nIHRoZSBkYXRhIG92ZXJsYXkgaW4g
T3BlblN0cmVldE1hcCBkb2Vzbid0IHdvcmssIHpvb21pbmcgcGFydGlhbGx5IGJyb2tlbgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE1MDUKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvanMvZnVu
Y3Rpb24tZG90LWFwcGx5LXJlcGxhY2UtYmFzZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg
ICAqIGZhc3QvanMvZnVuY3Rpb24tZG90LWFwcGx5LXJlcGxhY2UtYmFzZS5odG1sOiBBZGRlZC4K
KyAgICAgICAgKiBmYXN0L2pzL3NjcmlwdC10ZXN0cy9jcm9zcy1nbG9iYWwtb2JqZWN0LWlubGlu
ZS1nbG9iYWwtdmFyLmpzOgorICAgICAgICAoZG9uZSk6CisgICAgICAgICogZmFzdC9qcy9zY3Jp
cHQtdGVzdHMvZnVuY3Rpb24tZG90LWFwcGx5LXJlcGxhY2UtYmFzZS5qczogQWRkZWQuCisgICAg
ICAgIChmb28pOgorICAgICAgICAoYmFyKToKKwogMjAxMS0xMS0xOSAgSmFtZXMgUm9iaW5zb24g
IDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gVXBkYXRlIHZhcmlv
dXMgY29tcG9zaXRpbmcgYmFzZWxpbmVzIGFuZCBleHBlY3RhdGlvbnMuCkluZGV4OiBMYXlvdXRU
ZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLWRvdC1hcHBseS1yZXBsYWNlLWJhc2UtZXhwZWN0ZWQudHh0
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvZnVuY3Rpb24tZG90LWFwcGx5LXJl
cGxhY2UtYmFzZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0
L2pzL2Z1bmN0aW9uLWRvdC1hcHBseS1yZXBsYWNlLWJhc2UtZXhwZWN0ZWQudHh0CShyZXZpc2lv
biAwKQpAQCAtMCwwICsxLDEwIEBACitUaGlzIHRlc3RzIHRoYXQgZXhwcmVzc2lvbnMgb2YgdGhl
IGZvcm0geCA9IHguYXBwbHkoLi4uKSBkb24ndCBicmVhayBieXRlY29kZSBnZW5lcmF0aW9uLgor
CitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBm
b2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBiYXIoKSBpcyAzCitQQVNTIHN1
Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0
VGVzdHMvZmFzdC9qcy9mdW5jdGlvbi1kb3QtYXBwbHktcmVwbGFjZS1iYXNlLmh0bWwKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9mdW5jdGlvbi1kb3QtYXBwbHktcmVwbGFjZS1i
YXNlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLWRv
dC1hcHBseS1yZXBsYWNlLWJhc2UuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMCBAQAor
PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8
aGVhZD4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor
PC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL2Z1bmN0aW9uLWRvdC1h
cHBseS1yZXBsYWNlLWJhc2UuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9q
cy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0
VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvY3Jvc3MtZ2xvYmFsLW9iamVjdC1pbmxpbmUtZ2xv
YmFsLXZhci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0
cy9jcm9zcy1nbG9iYWwtb2JqZWN0LWlubGluZS1nbG9iYWwtdmFyLmpzCShyZXZpc2lvbiAxMDA4
NzQpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2pzL3NjcmlwdC10ZXN0cy9jcm9zcy1nbG9iYWwtb2Jq
ZWN0LWlubGluZS1nbG9iYWwtdmFyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xOSw4ICsxOSw3IEBA
IGZ1bmN0aW9uIGRvbmUodmFsdWUpIHsKICAgICAgICAgdGVzdFBhc3NlZCgiZG9uZSgpIGNhbGxl
ZCB3aXRoICIgKyBleHBlY3RlZCk7CiAgICAgZWxzZQogICAgICAgICB0ZXN0RmFpbGVkKCJkb25l
KCkgaXMgIiArIHZhbHVlICsgIiBhbmQgc2hvdWxkIGJlICIgKyBleHBlY3RlZCArICIuIik7Ci0g
ICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICAgICAgbGF5b3V0VGVzdENv
bnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURv
bmUoKTsKIH0KIAogZnVuY3Rpb24gZG9pdCgpIHsKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvanMv
c2NyaXB0LXRlc3RzL2Z1bmN0aW9uLWRvdC1hcHBseS1yZXBsYWNlLWJhc2UuanMKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9zY3JpcHQtdGVzdHMvZnVuY3Rpb24tZG90LWFwcGx5
LXJlcGxhY2UtYmFzZS5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvc2Ny
aXB0LXRlc3RzL2Z1bmN0aW9uLWRvdC1hcHBseS1yZXBsYWNlLWJhc2UuanMJKHJldmlzaW9uIDAp
CkBAIC0wLDAgKzEsMjYgQEAKK2Rlc2NyaXB0aW9uKAorIlRoaXMgdGVzdHMgdGhhdCBleHByZXNz
aW9ucyBvZiB0aGUgZm9ybSB4ID0geC5hcHBseSguLi4pIGRvbid0IGJyZWFrIGJ5dGVjb2RlIGdl
bmVyYXRpb24uIgorKTsKKworZnVuY3Rpb24gZm9vKGEsYikgeworICAgIHJldHVybiBhK2I7Cit9
CisKK2Z1bmN0aW9uIGJhcigpIHsKKyAgICB2YXIgeDsKKyAgICAKKyAgICB4ID0gZm9vOworICAg
IAorICAgIHZhciBhcnJheSA9IFtdOworICAgIGFycmF5LnB1c2goMSk7CisgICAgYXJyYXkucHVz
aCgyKTsKKyAgICAKKyAgICB4ID0geC5hcHBseSh2b2lkKDApLCBhcnJheSk7CisgICAgCisgICAg
cmV0dXJuIHg7Cit9CisKK3Nob3VsZEJlKCJiYXIoKSIsICIzIik7CisKKworCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>116157</attachid>
            <date>2011-11-21 17:48:48 -0800</date>
            <delta_ts>2011-11-21 18:15:59 -0800</delta_ts>
            <desc>the patch</desc>
            <filename>fixstreetmap_patch_1.diff</filename>
            <type>text/plain</type>
            <size>1688</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAwOTcxKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA
CisyMDExLTExLTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
U2hvd2luZyB0aGUgZGF0YSBvdmVybGF5IGluIE9wZW5TdHJlZXRNYXAgZG9lc24ndCB3b3JrLCB6
b29taW5nIHBhcnRpYWxseSBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTcxNTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisgICAgICAgIAorICAgICAgICBJdCB0dXJucyBvdXQgdGhhdCB3ZSB3ZXJlIGNvcnJ1cHRp
bmcgcGhpIG5vZGVzIGluIGNhc2Ugb2Ygb3ZlcmZsb3cuIFRoZSBidWcgaXMKKyAgICAgICAgcmVh
bGx5IG9idmlvdXMsIGJ1dCBwcm9kdWNpbmcgYSB0ZXN0IGNhc2UgdGhhdCBjYXVzZXMgdGhlIGJh
ZG5lc3MgaXMgaGFyZC4gRXZlbgorICAgICAgICB3aGVuIHRoZSBwaGkgbm9kZXMgZG8gZ2V0IGNv
cnJ1cHQsIHRoZXJlJ3MgbW9yZSB0aGF0IGhhcyB0byBoYXBwZW4gYmVmb3JlIGl0CisgICAgICAg
IGNhdXNlcyBpbmNvcnJlY3QgZXhlY3V0aW9uIC0gYW5kIEkgd2Fzbid0IGFibGUgdG8gcmVwcm9k
dWNlIGluIGFueSBraW5kIG9mCisgICAgICAgIHNlbnNpYmxlIHJlZHVjZWQgY2FzZS4KKworICAg
ICAgICAqIGRmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0
ZUNvZGVQYXJzZXI6OnByb2Nlc3NQaGlTdGFjayk6CisKIDIwMTEtMTEtMjEgIFNpbW9uIEhhdXNt
YW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gU3BlZWQgdXAg
ZGVidWcgYnVpbGRzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29k
ZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdC
eXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9uIDEwMDk3MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjIyLDcg
KzIyMjIsNyBAQCB2b2lkIEJ5dGVDb2RlUGFyc2VyOjpwcm9jZXNzUGhpU3RhY2soKQogICAgICAg
ICAgICAgbmV3UGhpTm9kZS5jaGlsZHJlbi5maXhlZC5jaGlsZDMgPSBwaGlOb2RlLT5jaGlsZDMo
KTsKIAogICAgICAgICAgICAgcGhpTm9kZS0+Y2hpbGRyZW4uZml4ZWQuY2hpbGQxID0gbmV3UGhp
OwotICAgICAgICAgICAgcGhpTm9kZS0+Y2hpbGRyZW4uZml4ZWQuY2hpbGQxID0gdmFsdWVJblBy
ZWRlY2Vzc29yOworICAgICAgICAgICAgcGhpTm9kZS0+Y2hpbGRyZW4uZml4ZWQuY2hpbGQyID0g
dmFsdWVJblByZWRlY2Vzc29yOwogICAgICAgICAgICAgcGhpTm9kZS0+Y2hpbGRyZW4uZml4ZWQu
Y2hpbGQzID0gTm9Ob2RlOwogICAgICAgICB9CiAgICAgfQo=
</data>
<flag name="review"
          id="115264"
          type_id="1"
          status="+"
          setter="barraclough"
    />
          </attachment>
      

    </bug>

</bugzilla>