71498 2011-11-03 13:04:53 -0700 JIT-specific code should be able to refer to register types even on JIT-disabled builds 2011-11-03 13:23:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned paroga oldest_to_newest 495735 0 fpizlo 2011-11-03 13:04:53 -0700 Increasingly, code in CodeBlock and elsewhere outside of the JIT refers to JIT features. This is part of the evolution of the system to rely more on high-performance JIT optimizations. But we still want to support no-JIT builds. Doing this often means that we must insert #if's in a bunch of places if no JIT support is present. A particularly egregious case is the current build bug introduced by http://trac.webkit.org/changeset/99148. That changeset makes use of MacroAssembler::RegisterID in structs and classes that are placed in CodeBlock. In the case that the JIT is turned off, no instances of those classes are ever instantiated. But we've taken the approach of letting them be declared without #if guards to minimize noise. But this breaks because the latest addition to these classes is ValueRecovery (referenced from InlineCallFrame, which is referenced from CodeBlock's RareData), which uses MacroAssembler::RegisterID. We can either fix this by adding #if's around all references from CodeBlock to ValueRecovery (transitively, of course), or we can localize the noise by making MacroAssembler.h define a dummy MacroAssembler, with a dummy RegisterID, even if the assembler (and the JIT) is disabled. This will have no run-time overhead, since this would just be an empty class with some typedef's, and ValueRecovery is never instantiated in non-JIT builds anyway. 495738 1 113545 fpizlo 2011-11-03 13:08:25 -0700 Created attachment 113545 the patch 495740 2 113545 barraclough 2011-11-03 13:17:37 -0700 Comment on attachment 113545 the patch Ick, a bit ugly, but I guess the alternative involves a bunch of ifdefing code / data structures holding these as fields? Probably for the best. 495745 3 fpizlo 2011-11-03 13:23:45 -0700 Landed in http://trac.webkit.org/changeset/99232 113545 2011-11-03 13:08:25 -0700 2011-11-03 13:17:37 -0700 the patch fixasm_patch_1.diff text/plain 1583 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTkyMjkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMTEtMDMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBK SVQtc3BlY2lmaWMgY29kZSBzaG91bGQgYmUgYWJsZSB0byByZWZlciB0byByZWdpc3RlciB0eXBl cyBldmVuIG9uIEpJVC1kaXNhYmxlZCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNDk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXIuaDoKKyAgICAg ICAgKE1hY3JvQXNzZW1ibGVyOjpNYWNyb0Fzc2VtYmxlcik6CisKIDIwMTEtMTEtMDMgIE1hcmsg SGFobmVuYmVyZyAgPG1oYWhuZW5iZXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBEZS12aXJ0dWFs aXplIEpTT2JqZWN0OjpjbGFzc05hbWUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmgJKHJldmlzaW9uIDk5MjI5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCSh3b3JraW5nIGNvcHkp CkBAIC0zODUsMTIgKzM4NSwyNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICByZXR1cm4gTWFj cm9Bc3NlbWJsZXJCYXNlOjpicmFuY2hUZXN0OChjb25kLCBBZGRyZXNzKGFkZHJlc3MuYmFzZSwg YWRkcmVzcy5vZmZzZXQpLCBtYXNrKTsKICAgICB9Ci0jZW5kaWYKKyNlbmRpZiAvLyAhQ1BVKFg4 Nl82NCkKIAogfTsKIAogfSAvLyBuYW1lc3BhY2UgSlNDCiAKKyNlbHNlIC8vIEVOQUJMRShBU1NF TUJMRVIpCisKKy8vIElmIHRoZXJlIGlzIG5vIGFzc2VtYmxlciBmb3IgdGhpcyBwbGF0Zm9ybSwg YXQgbGVhc3QgYWxsb3cgY29kZSB0byBtYWtlIHJlZmVyZW5jZXMgdG8KKy8vIHNvbWUgb2YgdGhl IHRoaW5ncyBpdCB3b3VsZCBvdGhlcndpc2UgZGVmaW5lLCBhbGJlaXQgd2l0aG91dCBnaXZpbmcg dGhhdCBjb2RlIGFueSB3YXkKKy8vIG9mIGRvaW5nIGFueXRoaW5nIHVzZWZ1bC4KK2NsYXNzIE1h Y3JvQXNzZW1ibGVyIHsKK3ByaXZhdGU6CisgICAgTWFjcm9Bc3NlbWJsZXIoKSB7IH0KKyAgICAK K3B1YmxpYzoKKyAgICAKKyAgICBlbnVtIFJlZ2lzdGVySUQgeyBOb1JlZ2lzdGVyIH07CisgICAg ZW51bSBGUFJlZ2lzdGVySUQgeyBOb0ZQUmVnaXN0ZXIgfTsKK307CisKICNlbmRpZiAvLyBFTkFC TEUoQVNTRU1CTEVSKQogCiAjZW5kaWYgLy8gTWFjcm9Bc3NlbWJsZXJfaAo=