71468 2011-11-03 06:39:09 -0700 CSSOM: Inline some trivial methods. 2011-11-03 07:02:31 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling dglazkov koivisto macpherson webkit.review.bot oldest_to_newest 495414 0 kling 2011-11-03 06:39:09 -0700 SSIA 495416 1 113477 kling 2011-11-03 06:39:51 -0700 Created attachment 113477 Patch 495424 2 113477 webkit.review.bot 2011-11-03 06:54:46 -0700 Comment on attachment 113477 Patch Attachment 113477 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10175600 495432 3 113477 gyuyoung.kim 2011-11-03 06:58:19 -0700 Comment on attachment 113477 Patch Attachment 113477 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10258581 495434 4 kling 2011-11-03 07:02:31 -0700 Committed r99185: <http://trac.webkit.org/changeset/99185> 113477 2011-11-03 06:39:51 -0700 2011-11-03 06:58:19 -0700 Patch bug-71468.diff text/plain 7410 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjZmEwZmIxLi5hZGIyN2Q1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjkg QEAKIDIwMTEtMTEtMDMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIENTU09NOiBJbmxpbmUgc29tZSB0cml2aWFsIG1ldGhvZHMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTQ2OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogY3NzL0NTU0ZvbnRGYWNlUnVsZS5jcHA6 CisgICAgICAgICogY3NzL0NTU0ZvbnRGYWNlUnVsZS5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NT Rm9udEZhY2VSdWxlOjpzZXREZWNsYXJhdGlvbik6CisgICAgICAgICogY3NzL0NTU1N0eWxlUnVs ZS5jcHA6CisgICAgICAgICogY3NzL0NTU1N0eWxlUnVsZS5oOgorICAgICAgICAoV2ViQ29yZTo6 Q1NTU3R5bGVSdWxlOjpzZXREZWNsYXJhdGlvbik6CisgICAgICAgICogY3NzL0NTU1N0eWxlU2hl ZXQuY3BwOgorICAgICAgICAqIGNzcy9DU1NTdHlsZVNoZWV0Lmg6CisgICAgICAgIChXZWJDb3Jl OjpDU1NTdHlsZVNoZWV0Ojpvd25lclJ1bGUpOgorICAgICAgICAqIGNzcy9TdHlsZVNoZWV0LmNw cDoKKyAgICAgICAgKiBjc3MvU3R5bGVTaGVldC5oOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVT aGVldDo6cGFyZW50U3R5bGVTaGVldCk6CisgICAgICAgICogY3NzL1dlYktpdENTU0tleWZyYW1l c1J1bGUuY3BwOgorICAgICAgICAqIGNzcy9XZWJLaXRDU1NLZXlmcmFtZXNSdWxlLmg6CisgICAg ICAgIChXZWJDb3JlOjpXZWJLaXRDU1NLZXlmcmFtZXNSdWxlOjpuYW1lKToKKyAgICAgICAgKFdl YkNvcmU6OldlYktpdENTU0tleWZyYW1lc1J1bGU6Omxlbmd0aCk6CisKKzIwMTEtMTEtMDMgIEFu ZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCiAgICAgICAgIERldmlydHVhbGl6ZSBN ZWRpYUxpc3QuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD03MTQ2NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2VSdWxl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVJ1bGUuY3BwCmluZGV4IDFmMTdm MmQuLjEwMDcwNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVJ1 bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVJ1bGUuY3BwCkBAIC0z NSwxMSArMzUsNiBAQCBDU1NGb250RmFjZVJ1bGU6On5DU1NGb250RmFjZVJ1bGUoKQogewogfQog Ci12b2lkIENTU0ZvbnRGYWNlUnVsZTo6c2V0RGVjbGFyYXRpb24oUGFzc1JlZlB0cjxDU1NNdXRh YmxlU3R5bGVEZWNsYXJhdGlvbj4gc3R5bGUpCi17Ci0gICAgbV9zdHlsZSA9IHN0eWxlOwotfQot CiBTdHJpbmcgQ1NTRm9udEZhY2VSdWxlOjpjc3NUZXh0KCkgY29uc3QKIHsKICAgICBTdHJpbmcg cmVzdWx0KCJAZm9udC1mYWNlIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT Rm9udEZhY2VSdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTRm9udEZhY2VSdWxlLmgKaW5k ZXggYWQwNzZhMi4uYTQwMDZmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Zv bnRGYWNlUnVsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NGb250RmFjZVJ1bGUuaApA QCAtNDcsNyArNDcsNyBAQCBwdWJsaWM6CiAKICAgICBTdHJpbmcgY3NzVGV4dCgpIGNvbnN0Owog Ci0gICAgdm9pZCBzZXREZWNsYXJhdGlvbihQYXNzUmVmUHRyPENTU011dGFibGVTdHlsZURlY2xh cmF0aW9uPik7CisgICAgdm9pZCBzZXREZWNsYXJhdGlvbihQYXNzUmVmUHRyPENTU011dGFibGVT dHlsZURlY2xhcmF0aW9uPiBzdHlsZSkgeyBtX3N0eWxlID0gc3R5bGU7IH0KIAogICAgIHZvaWQg YWRkU3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8S1VSTD4mIHVybHMpOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVJ1bGUuY3BwCmluZGV4IDZiMmFjZjguLjdkZDMxN2EgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVJ1bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVJ1bGUuY3BwCkBAIC05NiwxMSArOTYsNiBAQCBTdHJpbmcgQ1NTU3R5 bGVSdWxlOjpjc3NUZXh0KCkgY29uc3QKICAgICByZXR1cm4gcmVzdWx0OwogfQogCi12b2lkIENT U1N0eWxlUnVsZTo6c2V0RGVjbGFyYXRpb24oUGFzc1JlZlB0cjxDU1NNdXRhYmxlU3R5bGVEZWNs YXJhdGlvbj4gc3R5bGUpCi17Ci0gICAgbV9zdHlsZSA9IHN0eWxlOwotfQotCiB2b2lkIENTU1N0 eWxlUnVsZTo6YWRkU3VicmVzb3VyY2VTdHlsZVVSTHMoTGlzdEhhc2hTZXQ8S1VSTD4mIHVybHMp CiB7CiAgICAgaWYgKG1fc3R5bGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT U3R5bGVSdWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVSdWxlLmgKaW5kZXggNWE3 ZmI1OC4uZGM1MDBmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlUnVs ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVJ1bGUuaApAQCAtNDgsNyArNDgs NyBAQCBwdWJsaWM6CiAgICAgU3RyaW5nIGNzc1RleHQoKSBjb25zdDsKIAogICAgIHZvaWQgYWRv cHRTZWxlY3RvclZlY3RvcihWZWN0b3I8T3duUHRyPENTU1BhcnNlclNlbGVjdG9yPiA+JiBzZWxl Y3RvcnMpIHsgbV9zZWxlY3Rvckxpc3QuYWRvcHRTZWxlY3RvclZlY3RvcihzZWxlY3RvcnMpOyB9 Ci0gICAgdm9pZCBzZXREZWNsYXJhdGlvbihQYXNzUmVmUHRyPENTU011dGFibGVTdHlsZURlY2xh cmF0aW9uPik7CisgICAgdm9pZCBzZXREZWNsYXJhdGlvbihQYXNzUmVmUHRyPENTU011dGFibGVT dHlsZURlY2xhcmF0aW9uPiBzdHlsZSkgeyBtX3N0eWxlID0gc3R5bGU7IH0KIAogICAgIGNvbnN0 IENTU1NlbGVjdG9yTGlzdCYgc2VsZWN0b3JMaXN0KCkgY29uc3QgeyByZXR1cm4gbV9zZWxlY3Rv ckxpc3Q7IH0KICAgICBDU1NNdXRhYmxlU3R5bGVEZWNsYXJhdGlvbiogZGVjbGFyYXRpb24oKSB7 IHJldHVybiBtX3N0eWxlLmdldCgpOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTU3R5bGVTaGVldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTaGVldC5jcHAK aW5kZXggZDhjM2M2Zi4uYjZlNjEwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U1N0eWxlU2hlZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmNw cApAQCAtOTksMTEgKzk5LDYgQEAgdm9pZCBDU1NTdHlsZVNoZWV0OjpyZW1vdmUodW5zaWduZWQg aW5kZXgpCiAgICAgbV9jaGlsZHJlbi5yZW1vdmUoaW5kZXgpOwogfQogCi1DU1NSdWxlICpDU1NT dHlsZVNoZWV0Ojpvd25lclJ1bGUoKSBjb25zdAotewotICAgIHJldHVybiBwYXJlbnRSdWxlKCk7 Ci19Ci0KIHVuc2lnbmVkIENTU1N0eWxlU2hlZXQ6Omluc2VydFJ1bGUoY29uc3QgU3RyaW5nJiBy dWxlLCB1bnNpZ25lZCBpbmRleCwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAgICAgZWMgPSAwOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuaCBiL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmgKaW5kZXggYWE4NmNjOS4uYTU3N2JkMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlU2hlZXQuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTU3R5bGVTaGVldC5oCkBAIC03MCw3ICs3MCw3IEBAIHB1YmxpYzoKICAgICAg ICAgcmV0dXJuIHN0YXRpY19jYXN0PENTU1N0eWxlU2hlZXQqPihwYXJlbnRTaGVldCk7CiAgICAg fQogCi0gICAgQ1NTUnVsZSogb3duZXJSdWxlKCkgY29uc3Q7CisgICAgQ1NTUnVsZSogb3duZXJS dWxlKCkgY29uc3QgeyByZXR1cm4gcGFyZW50UnVsZSgpOyB9CiAgICAgUGFzc1JlZlB0cjxDU1NS dWxlTGlzdD4gY3NzUnVsZXMoYm9vbCBvbWl0Q2hhcnNldFJ1bGVzID0gZmFsc2UpOwogICAgIHVu c2lnbmVkIGluc2VydFJ1bGUoY29uc3QgU3RyaW5nJiBydWxlLCB1bnNpZ25lZCBpbmRleCwgRXhj ZXB0aW9uQ29kZSYpOwogICAgIHZvaWQgZGVsZXRlUnVsZSh1bnNpZ25lZCBpbmRleCwgRXhjZXB0 aW9uQ29kZSYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlU2hlZXQuY3Bw IGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlU2hlZXQuY3BwCmluZGV4IDY0Y2ExZjYuLjU3MDE2 YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVNoZWV0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVTaGVldC5jcHAKQEAgLTUyLDEyICs1Miw2IEBAIFN0eWxl U2hlZXQ6On5TdHlsZVNoZWV0KCkKICAgICAgICAgbV9tZWRpYS0+c2V0UGFyZW50U3R5bGVTaGVl dCgwKTsKIH0KIAotU3R5bGVTaGVldCogU3R5bGVTaGVldDo6cGFyZW50U3R5bGVTaGVldCgpIGNv bnN0Ci17Ci0gICAgQVNTRVJUKGlzQ1NTU3R5bGVTaGVldCgpKTsKLSAgICByZXR1cm4gbV9wYXJl bnRSdWxlID8gbV9wYXJlbnRSdWxlLT5wYXJlbnRTdHlsZVNoZWV0KCkgOiAwOwotfQotCiB2b2lk IFN0eWxlU2hlZXQ6OnNldE1lZGlhKFBhc3NSZWZQdHI8TWVkaWFMaXN0PiBtZWRpYSkKIHsKICAg ICBBU1NFUlQoaXNDU1NTdHlsZVNoZWV0KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Y3NzL1N0eWxlU2hlZXQuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVNoZWV0LmgKaW5kZXgg Y2ZlMjdmZC4uOTMxNThlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlU2hl ZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVTaGVldC5oCkBAIC00Myw3ICs0Mywx MSBAQCBwdWJsaWM6CiAgICAgTm9kZSogb3duZXJOb2RlKCkgY29uc3QgeyByZXR1cm4gbV9wYXJl bnROb2RlOyB9CiAgICAgdm9pZCBjbGVhck93bmVyTm9kZSgpIHsgbV9wYXJlbnROb2RlID0gMDsg fQogCi0gICAgU3R5bGVTaGVldCogcGFyZW50U3R5bGVTaGVldCgpIGNvbnN0OworICAgIFN0eWxl U2hlZXQqIHBhcmVudFN0eWxlU2hlZXQoKSBjb25zdAorICAgIHsKKyAgICAgICAgQVNTRVJUKGlz Q1NTU3R5bGVTaGVldCgpKTsKKyAgICAgICAgcmV0dXJuIG1fcGFyZW50UnVsZSA/IG1fcGFyZW50 UnVsZS0+cGFyZW50U3R5bGVTaGVldCgpIDogMDsKKyAgICB9CiAKICAgICBDU1NSdWxlKiBwYXJl bnRSdWxlKCkgY29uc3QgeyByZXR1cm4gbV9wYXJlbnRSdWxlOyB9CiAgICAgdm9pZCBzZXRQYXJl bnRSdWxlKENTU1J1bGUqIHJ1bGUpIHsgbV9wYXJlbnRSdWxlID0gcnVsZTsgfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU0tleWZyYW1lc1J1bGUuY3BwIGIvU291cmNl L1dlYkNvcmUvY3NzL1dlYktpdENTU0tleWZyYW1lc1J1bGUuY3BwCmluZGV4IDRlYzBjNWIuLjM3 Mzc1NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NLZXlmcmFtZXNS dWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5j cHAKQEAgLTUwLDExICs1MCw2IEBAIFdlYktpdENTU0tleWZyYW1lc1J1bGU6On5XZWJLaXRDU1NL ZXlmcmFtZXNSdWxlKCkKICAgICB9CiB9CiAKLVN0cmluZyBXZWJLaXRDU1NLZXlmcmFtZXNSdWxl OjpuYW1lKCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9uYW1lOwotfQotCiB2b2lkIFdlYktpdENT U0tleWZyYW1lc1J1bGU6OnNldE5hbWUoY29uc3QgU3RyaW5nJiBuYW1lKQogewogICAgIG1fbmFt ZSA9IG5hbWU7CkBAIC02NSwxMSArNjAsNiBAQCB2b2lkIFdlYktpdENTU0tleWZyYW1lc1J1bGU6 OnNldE5hbWUoY29uc3QgU3RyaW5nJiBuYW1lKQogICAgICAgICBzdHlsZVNoZWV0LT5zdHlsZVNo ZWV0Q2hhbmdlZCgpOwogfQogCi11bnNpZ25lZCBXZWJLaXRDU1NLZXlmcmFtZXNSdWxlOjpsZW5n dGgoKSBjb25zdAotewotICAgIHJldHVybiBtX2xzdENTU1J1bGVzLT5sZW5ndGgoKTsKLX0KLQog V2ViS2l0Q1NTS2V5ZnJhbWVSdWxlKiBXZWJLaXRDU1NLZXlmcmFtZXNSdWxlOjppdGVtKHVuc2ln bmVkIGluZGV4KQogewogICAgIENTU1J1bGUqIHJ1bGUgPSBtX2xzdENTU1J1bGVzLT5pdGVtKGlu ZGV4KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NLZXlmcmFtZXNS dWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTS2V5ZnJhbWVzUnVsZS5oCmluZGV4 IGYwZDdhZWIuLmIxYTFiOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRD U1NLZXlmcmFtZXNSdWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU0tleWZy YW1lc1J1bGUuaApAQCAtNTEsNyArNTEsNyBAQCBwdWJsaWM6CiAKICAgICB+V2ViS2l0Q1NTS2V5 ZnJhbWVzUnVsZSgpOwogCi0gICAgU3RyaW5nIG5hbWUoKSBjb25zdDsKKyAgICBTdHJpbmcgbmFt ZSgpIGNvbnN0IHsgcmV0dXJuIG1fbmFtZTsgfQogICAgIHZvaWQgc2V0TmFtZShjb25zdCBTdHJp bmcmKTsKIAogICAgIC8vIFRoaXMgdmVyc2lvbiBvZiBzZXROYW1lIGRvZXMgbm90IGNhbGwgc3R5 bGVTaGVldENoYW5nZWQgdG8gYXZvaWQKQEAgLTcwLDExICs3MCwxMSBAQCBwdWJsaWM6CiAKICAg ICBTdHJpbmcgY3NzVGV4dCgpIGNvbnN0OwogCi0gICAgLyogbm90IHBhcnQgb2YgdGhlIERPTSAq LwotICAgIHVuc2lnbmVkIGxlbmd0aCgpIGNvbnN0OwotICAgIFdlYktpdENTU0tleWZyYW1lUnVs ZSogICAgICAgIGl0ZW0odW5zaWduZWQgaW5kZXgpOwotICAgIGNvbnN0IFdlYktpdENTU0tleWZy YW1lUnVsZSogIGl0ZW0odW5zaWduZWQgaW5kZXgpIGNvbnN0OwotICAgIHZvaWQgYXBwZW5kKFdl YktpdENTU0tleWZyYW1lUnVsZSogcnVsZSk7CisgICAgLy8gTm90IHBhcnQgb2YgdGhlIENTU09N LgorICAgIHVuc2lnbmVkIGxlbmd0aCgpIGNvbnN0IHsgcmV0dXJuIG1fbHN0Q1NTUnVsZXMtPmxl bmd0aCgpOyB9CisgICAgV2ViS2l0Q1NTS2V5ZnJhbWVSdWxlKiBpdGVtKHVuc2lnbmVkIGluZGV4 KTsKKyAgICBjb25zdCBXZWJLaXRDU1NLZXlmcmFtZVJ1bGUqIGl0ZW0odW5zaWduZWQgaW5kZXgp IGNvbnN0OworICAgIHZvaWQgYXBwZW5kKFdlYktpdENTU0tleWZyYW1lUnVsZSopOwogCiBwcml2 YXRlOgogICAgIFdlYktpdENTU0tleWZyYW1lc1J1bGUoQ1NTU3R5bGVTaGVldCogcGFyZW50KTsK