71467 2011-11-03 06:38:56 -0700 [WK2] State variable name refactor in WebPageProxy.cpp 2011-11-03 07:32:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jesus jesus webkit.review.bot oldest_to_newest 495413 0 jesus 2011-11-03 06:38:56 -0700 Just a tiny refactor after https://bugs.webkit.org/show_bug.cgi?id=55827. The state variable m_inDecidePolicyForMIMEType was kept with the original function name, but since decidePolicyForMIMEType was renamed to decidePolicyForResponse this state variable should follow the same rule to make code reading easier. Patch coming. 495421 1 113478 jesus 2011-11-03 06:49:08 -0700 Created attachment 113478 Patch 495422 2 113478 kling 2011-11-03 06:51:37 -0700 Comment on attachment 113478 Patch D'oh! r=me 495448 3 113478 webkit.review.bot 2011-11-03 07:32:32 -0700 Comment on attachment 113478 Patch Clearing flags on attachment: 113478 Committed r99188: <http://trac.webkit.org/changeset/99188> 495449 4 webkit.review.bot 2011-11-03 07:32:35 -0700 All reviewed patches have been landed. Closing bug. 113478 2011-11-03 06:49:08 -0700 2011-11-03 07:32:31 -0700 Patch bug-71467-20111103154835.patch text/plain 3913 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogOTkxNzQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAwZThkMTQyZjRkYTA1MWQ5 NzM1OWVjMDA5MmZiOGFmNjI2NjRhMWNlLi5iYzU5NTFkMDU0NTc5MjIzNDY4NTZhZDNlNzk4MWQ0 Y2I3ZWRjZmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTEtMDMgIEplc3Vz IFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgorCisgICAg ICAgIFtXSzJdIFN0YXRlIHZhcmlhYmxlIG5hbWUgcmVmYWN0b3IgaW4gV2ViUGFnZVByb3h5LmNw cAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE0NjcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5hbWlu ZyBtX2luRGVjaWRlUG9saWN5Rm9yTUlNRVR5cGUgdG8gbV9pbkRlY2lkZVBvbGljeUZvclJlc3Bv bnNlIGFmdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NTgyNyAuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpXZWJQYWdlUHJveHkpOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlUHJveHk6OnJlY2VpdmVkUG9saWN5RGVjaXNpb24pOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlUHJveHk6OmRlY2lkZVBvbGljeUZvclJlc3BvbnNlKToKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisKIDIwMTEtMTEtMDMgIFNpbW9uIEhhdXNtYW5uICA8c2lt b24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF1bV0syXSBGYWlsaW5nIGFzc2Vy dGlvbiB3aXRoIGRlc2t0b3Agd2VidmlldyB3aGVuIHRvdWNoIG1vY2tpbmcgaW4gTWluQnJvd3Nl cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCBlZTQzYjI4 ZjBhYzVkOWJkMzA4NzRhOWI4ZDJkZTFhM2IzOWI2ZDc1Li5lMWE1ZGRhZjU0ZGVkOGE4YmQ4NTJi YzQyNGUwYjRmMmNmNGJhOGU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcApAQCAtMTYzLDcgKzE2Myw3IEBAIFdlYlBhZ2VQcm94eTo6V2ViUGFnZVByb3h5KFBh Z2VDbGllbnQqIHBhZ2VDbGllbnQsIFBhc3NSZWZQdHI8V2ViUHJvY2Vzc1Byb3h5PiBwCiAgICAg LCBtX2lzQ2xvc2VkKGZhbHNlKQogICAgICwgbV9pc0luUHJpbnRpbmdNb2RlKGZhbHNlKQogICAg ICwgbV9pc1BlcmZvcm1pbmdET01QcmludE9wZXJhdGlvbihmYWxzZSkKLSAgICAsIG1faW5EZWNp ZGVQb2xpY3lGb3JNSU1FVHlwZShmYWxzZSkKKyAgICAsIG1faW5EZWNpZGVQb2xpY3lGb3JSZXNw b25zZShmYWxzZSkKICAgICAsIG1fc3luY01pbWVUeXBlUG9saWN5QWN0aW9uSXNWYWxpZChmYWxz ZSkKICAgICAsIG1fc3luY01pbWVUeXBlUG9saWN5QWN0aW9uKFBvbGljeVVzZSkKICAgICAsIG1f c3luY01pbWVUeXBlUG9saWN5RG93bmxvYWRJRCgwKQpAQCAtMTAxOSw5ICsxMDE5LDkgQEAgdm9p ZCBXZWJQYWdlUHJveHk6OnJlY2VpdmVkUG9saWN5RGVjaXNpb24oUG9saWN5QWN0aW9uIGFjdGlv biwgV2ViRnJhbWVQcm94eSogZnIKICAgICAgICAgZG93bmxvYWRJRCA9IG1fcHJvY2Vzcy0+Y29u dGV4dCgpLT5jcmVhdGVEb3dubG9hZFByb3h5KCktPmRvd25sb2FkSUQoKTsKICAgICB9CiAKLSAg ICAvLyBJZiB3ZSByZWNlaXZlZCBhIHBvbGljeSBkZWNpc2lvbiB3aGlsZSBpbiBkZWNpZGVQb2xp Y3lGb3JNSU1FVHlwZSB0aGUgZGVjaXNpb24gd2lsbCAKLSAgICAvLyBiZSBzZW50IGJhY2sgdG8g dGhlIHdlYiBwcm9jZXNzIGJ5IGRlY2lkZVBvbGljeUZvck1JTUVUeXBlLiAKLSAgICBpZiAobV9p bkRlY2lkZVBvbGljeUZvck1JTUVUeXBlKSB7CisgICAgLy8gSWYgd2UgcmVjZWl2ZWQgYSBwb2xp Y3kgZGVjaXNpb24gd2hpbGUgaW4gZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UgdGhlIGRlY2lzaW9u IHdpbGwKKyAgICAvLyBiZSBzZW50IGJhY2sgdG8gdGhlIHdlYiBwcm9jZXNzIGJ5IGRlY2lkZVBv bGljeUZvclJlc3BvbnNlLgorICAgIGlmIChtX2luRGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UpIHsK ICAgICAgICAgbV9zeW5jTWltZVR5cGVQb2xpY3lBY3Rpb25Jc1ZhbGlkID0gdHJ1ZTsKICAgICAg ICAgbV9zeW5jTWltZVR5cGVQb2xpY3lBY3Rpb24gPSBhY3Rpb247CiAgICAgICAgIG1fc3luY01p bWVUeXBlUG9saWN5RG93bmxvYWRJRCA9IGRvd25sb2FkSUQ7CkBAIC0xOTM3LDE1ICsxOTM3LDE1 IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkZWNpZGVQb2xpY3lGb3JSZXNwb25zZSh1aW50NjRfdCBm cmFtZUlELCBjb25zdCBSZXNvdXJjZVJlc3BvCiAgICAgCiAgICAgUmVmUHRyPFdlYkZyYW1lUG9s aWN5TGlzdGVuZXJQcm94eT4gbGlzdGVuZXIgPSBmcmFtZS0+c2V0VXBQb2xpY3lMaXN0ZW5lclBy b3h5KGxpc3RlbmVySUQpOwogCi0gICAgQVNTRVJUKCFtX2luRGVjaWRlUG9saWN5Rm9yTUlNRVR5 cGUpOworICAgIEFTU0VSVCghbV9pbkRlY2lkZVBvbGljeUZvclJlc3BvbnNlKTsKIAotICAgIG1f aW5EZWNpZGVQb2xpY3lGb3JNSU1FVHlwZSA9IHRydWU7CisgICAgbV9pbkRlY2lkZVBvbGljeUZv clJlc3BvbnNlID0gdHJ1ZTsKICAgICBtX3N5bmNNaW1lVHlwZVBvbGljeUFjdGlvbklzVmFsaWQg PSBmYWxzZTsKIAogICAgIGlmICghbV9wb2xpY3lDbGllbnQuZGVjaWRlUG9saWN5Rm9yUmVzcG9u c2UodGhpcywgZnJhbWUsIHJlc3BvbnNlLCByZXF1ZXN0LCBsaXN0ZW5lci5nZXQoKSwgdXNlckRh dGEuZ2V0KCkpKQogICAgICAgICBsaXN0ZW5lci0+dXNlKCk7CiAKLSAgICBtX2luRGVjaWRlUG9s aWN5Rm9yTUlNRVR5cGUgPSBmYWxzZTsKKyAgICBtX2luRGVjaWRlUG9saWN5Rm9yUmVzcG9uc2Ug PSBmYWxzZTsKIAogICAgIC8vIENoZWNrIGlmIHdlIHJlY2VpdmVkIGEgcG9saWN5IGRlY2lzaW9u IGFscmVhZHkuIElmIHdlIGRpZCwgd2UgY2FuIGp1c3QgcGFzcyBpdCBiYWNrLgogICAgIHJlY2Vp dmVkUG9saWN5QWN0aW9uID0gbV9zeW5jTWltZVR5cGVQb2xpY3lBY3Rpb25Jc1ZhbGlkOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCmluZGV4IGI5NWFhNWY3MDI5ODU0Mzlj YTkxNzQxNTA3ZmJjY2YzZDViYTBjODQuLjE2ZWNkYzljYWJkZmYzNjEzODNkMGUwZjhkYjcxYWEx MWE5NzY4NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKQEAgLTg5 Miw3ICs4OTIsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgbV9pc0luUHJpbnRpbmdNb2RlOwogICAg IGJvb2wgbV9pc1BlcmZvcm1pbmdET01QcmludE9wZXJhdGlvbjsKIAotICAgIGJvb2wgbV9pbkRl Y2lkZVBvbGljeUZvck1JTUVUeXBlOworICAgIGJvb2wgbV9pbkRlY2lkZVBvbGljeUZvclJlc3Bv bnNlOwogICAgIGJvb2wgbV9zeW5jTWltZVR5cGVQb2xpY3lBY3Rpb25Jc1ZhbGlkOwogICAgIFdl YkNvcmU6OlBvbGljeUFjdGlvbiBtX3N5bmNNaW1lVHlwZVBvbGljeUFjdGlvbjsKICAgICB1aW50 NjRfdCBtX3N5bmNNaW1lVHlwZVBvbGljeURvd25sb2FkSUQ7Cg==