71461 2011-11-03 05:22:38 -0700 [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API 2011-11-03 09:14:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 71459 71447 71466 1 cgarcia webkit-unassigned pnormand xan.lopez oldest_to_newest 495372 0 cgarcia 2011-11-03 05:22:38 -0700 We could use the GtkEntry progress API for that 495375 1 113466 cgarcia 2011-11-03 05:25:59 -0700 Created attachment 113466 Patch 495512 2 113466 mrobinson 2011-11-03 09:08:05 -0700 Comment on attachment 113466 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113466&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:86 > + g_timeout_add(500, (GSourceFunc)resetEntryProgress, window->uriEntry); This seems a bit long, but we can always adjust it later. 495515 3 cgarcia 2011-11-03 09:14:08 -0700 Committed r99201: <http://trac.webkit.org/changeset/99201> 113466 2011-11-03 05:25:59 -0700 2011-11-03 09:08:05 -0700 Patch wk2-mb-load-progress.diff text/plain 2383 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxZjAz ZTM5Li43ODNiYzYyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTEtMTEtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIFNob3cgbG9hZCBwcm9ncmVz cyBpbmZvcm1hdGlvbiBpbiBNaW5pQnJvd3NlciB1c2luZyBXZWJLaXQyIEdUSysgQVBJCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTQ2MQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIv Z3RrL0Jyb3dzZXJXaW5kb3cuYzoKKyAgICAgICAgKHJlc2V0RW50cnlQcm9ncmVzcyk6IFJlc2V0 IHRoZSBlbnRyeSBwcm9ncmVzcyBhZnRlciBhIHdoaWxlIHdoZW4KKyAgICAgICAgbG9hZCBoYXMg YmVlbiBjb21wbGV0ZWQuCisgICAgICAgICh3ZWJWaWV3TG9hZFByb2dyZXNzQ2hhbmdlZCk6IFVw ZGF0ZSBsb2NhdGlvbiBlbnRyeSBwcm9ncmVzcy4KKyAgICAgICAgKGJyb3dzZXJXaW5kb3dDb25z dHJ1Y3RlZCk6IENvbm5lY3QgdG8gV2ViVmlldworICAgICAgICBub3RpZnk6OmVzdGltYXRlZC1s b2FkLXByb2dyZXNzIHNpZ25hbC4KKworMjAxMS0xMS0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gUmVtb3ZlIEd0a0xhdW5jaGVy MgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE0NDkK IApkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYyBiL1Rv b2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKaW5kZXggY2IzZDZhYi4uYTk4ODkz NCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYworKysg Yi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCkBAIC03Miw2ICs3MiwyMCBA QCBzdGF0aWMgdm9pZCB3ZWJWaWV3VVJJQ2hhbmdlZChXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3LCAg R1BhcmFtU3BlYyAqcHNwZWMsIEJyb3dzZQogICAgIGd0a19lbnRyeV9zZXRfdGV4dChHVEtfRU5U Ulkod2luZG93LT51cmlFbnRyeSksIHdlYmtpdF93ZWJfdmlld19nZXRfdXJpKHdlYlZpZXcpKTsK IH0KIAorc3RhdGljIGdib29sZWFuIHJlc2V0RW50cnlQcm9ncmVzcyhHdGtFbnRyeSAqZW50cnkp Cit7CisgICAgZ3RrX2VudHJ5X3NldF9wcm9ncmVzc19mcmFjdGlvbihlbnRyeSwgMCk7CisgICAg cmV0dXJuIEZBTFNFOworfQorCitzdGF0aWMgdm9pZCB3ZWJWaWV3TG9hZFByb2dyZXNzQ2hhbmdl ZChXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3LCBHUGFyYW1TcGVjICpwc3BlYywgQnJvd3NlcldpbmRv dyAqd2luZG93KQoreworICAgIGdkb3VibGUgcHJvZ3Jlc3MgPSB3ZWJraXRfd2ViX3ZpZXdfZ2V0 X2VzdGltYXRlZF9sb2FkX3Byb2dyZXNzKHdlYlZpZXcpOworICAgIGd0a19lbnRyeV9zZXRfcHJv Z3Jlc3NfZnJhY3Rpb24oR1RLX0VOVFJZKHdpbmRvdy0+dXJpRW50cnkpLCBwcm9ncmVzcyk7Cisg ICAgaWYgKHByb2dyZXNzID09IDEuMCkKKyAgICAgICAgZ190aW1lb3V0X2FkZCg1MDAsIChHU291 cmNlRnVuYylyZXNldEVudHJ5UHJvZ3Jlc3MsIHdpbmRvdy0+dXJpRW50cnkpOworfQorCiBzdGF0 aWMgdm9pZCBicm93c2VyV2luZG93RmluYWxpemUoR09iamVjdCAqZ09iamVjdCkKIHsKICAgICBH X09CSkVDVF9DTEFTUyhicm93c2VyX3dpbmRvd19wYXJlbnRfY2xhc3MpLT5maW5hbGl6ZShnT2Jq ZWN0KTsKQEAgLTE1OSw2ICsxNzMsNyBAQCBzdGF0aWMgdm9pZCBicm93c2VyV2luZG93Q29uc3Ry dWN0ZWQoR09iamVjdCAqZ09iamVjdCkKICAgICBCcm93c2VyV2luZG93ICp3aW5kb3cgPSBCUk9X U0VSX1dJTkRPVyhnT2JqZWN0KTsKIAogICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2luZG93LT53ZWJW aWV3LCAibm90aWZ5Ojp1cmkiLCBHX0NBTExCQUNLKHdlYlZpZXdVUklDaGFuZ2VkKSwgd2luZG93 KTsKKyAgICBnX3NpZ25hbF9jb25uZWN0KHdpbmRvdy0+d2ViVmlldywgIm5vdGlmeTo6ZXN0aW1h dGVkLWxvYWQtcHJvZ3Jlc3MiLCBHX0NBTExCQUNLKHdlYlZpZXdMb2FkUHJvZ3Jlc3NDaGFuZ2Vk KSwgd2luZG93KTsKIAogICAgIGd0a19ib3hfcGFja19zdGFydChHVEtfQk9YKHdpbmRvdy0+bWFp bkJveCksIEdUS19XSURHRVQod2luZG93LT53ZWJWaWV3KSwgVFJVRSwgVFJVRSwgMCk7CiAgICAg Z3RrX3dpZGdldF9zaG93KEdUS19XSURHRVQod2luZG93LT53ZWJWaWV3KSk7Cg==