71440 2011-11-03 00:17:31 -0700 [GTK] Fix build-break on r99143 2011-11-03 01:55:01 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 kevin.cs.oh webkit-unassigned cgarcia pnormand webkit.review.bot oldest_to_newest 495231 0 kevin.cs.oh 2011-11-03 00:17:31 -0700 Two variables should be relocated, and a method should be replaced. 495237 1 113440 kevin.cs.oh 2011-11-03 00:36:06 -0700 Created attachment 113440 Proposed patch Proposed patch. Mimic changes to fix build break. 495240 2 webkit.review.bot 2011-11-03 00:37:19 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 495247 3 113441 kevin.cs.oh 2011-11-03 01:06:43 -0700 Created attachment 113441 Updated patch 495271 4 113441 pnormand 2011-11-03 01:54:45 -0700 Comment on attachment 113441 Updated patch Clearing flags on attachment: 113441 Committed r99149: <http://trac.webkit.org/changeset/99149> 495272 5 pnormand 2011-11-03 01:55:01 -0700 All reviewed patches have been landed. Closing bug. 113440 2011-11-03 00:36:06 -0700 2011-11-03 01:06:43 -0700 Proposed patch P71440.patch text/plain 4122 kevin.cs.oh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5MTQ0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMTEtMDMgIENoYW5nU2Vv ayBPaCAgPHNoaXZhbWlkb3dAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBidWlsZC1i cmVhayBvbiByOTkxNDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTcxNDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgbV9jb250ZW50c1NjYWxlRmFjdG9yIHNob3VsZCBiZSBwbGFjZWQgb3V0IG9mIFBMQVRG T1JNKE1BQykuCisgICAgICAgIGRyYWdPcGVyYXRpb24oKSBzaG91bGQgYmUgcmVwbGFjZWQgd2l0 aCBkcmFnU2Vzc2lvbigpLm9wZXJhdGlvbiBzaW5jZSBpdCB3YXMgcmVtb3ZlZC4KKyAgICAgICAg ZGlkRGV0ZWN0WFNTRm9yRnJhbWUgb2YgV0tQYWdlTG9hZGVyQ2xpZW50IHNob3VsZCBiZSByZWxv Y2F0ZWQuIAorCisgICAgICAgICogUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHku aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJMb2FkZXJDbGllbnQuY3Bw OgorICAgICAgICAod2Via2l0V2ViTG9hZGVyQ2xpZW50QXR0YWNoTG9hZGVyQ2xpZW50VG9QYWdl KToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6Cisg ICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZURyYWdEYXRhUmVjZWl2ZWQpOgorICAgICAgICAod2Vi a2l0V2ViVmlld0Jhc2VEcmFnTW90aW9uKToKKwogMjAxMS0xMS0wMiAgVmlhdGNoZXNsYXYgT3N0 YXBlbmtvICA8b3N0YXBlbmtvLnZpYXRjaGVzbGF2QG5va2lhLmNvbT4KIAogICAgICAgICBbUXRd IFtXS10gRGVidWcgYnVpbGQgYnJva2VuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9j ZXNzL1BsdWdpbkNvbnRyb2xsZXJQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1BsdWdpblByb2Nlc3MvUGx1Z2luQ29udHJvbGxlclByb3h5LmgJKHJldmlzaW9uIDk5MTQzKQor KysgU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Db250cm9sbGVyUHJveHkuaAko d29ya2luZyBjb3B5KQpAQCAtMTkwLDEzICsxOTAsMTIgQEAgcHJpdmF0ZToKICAgICAvLyBXaGV0 aGVyIHRoZSBwbHVnLWluIGhhcyBjYW5jZWxlZCB0aGUgbWFudWFsIHN0cmVhbSBsb2FkLgogICAg IGJvb2wgbV9wbHVnaW5DYW5jZWxlZE1hbnVhbFN0cmVhbUxvYWQ7CiAKKyAgICAvLyBUaGUgY29u dGVudHMgc2NhbGUgZmFjdG9yIG9mIHRoaXMgcGx1Zy1pbi4KKyAgICBmbG9hdCBtX2NvbnRlbnRz U2NhbGVGYWN0b3I7CiAjaWYgUExBVEZPUk0oTUFDKQogICAgIC8vIFdoZXRoZXIgY29tcGxleCB0 ZXh0IGlucHV0IGlzIGVuYWJsZWQgZm9yIHRoaXMgcGx1Zy1pbi4KICAgICBib29sIG1faXNDb21w bGV4VGV4dElucHV0RW5hYmxlZDsKIAotICAgIC8vIFRoZSBjb250ZW50cyBzY2FsZSBmYWN0b3Ig b2YgdGhpcyBwbHVnLWluLgotICAgIGZsb2F0IG1fY29udGVudHNTY2FsZUZhY3RvcjsKLQogICAg IC8vIEZvciBDQSBwbHVnLWlucywgdGhpcyBob2xkcyB0aGUgaW5mb3JtYXRpb24gbmVlZGVkIHRv IGV4cG9ydCB0aGUgbGF5ZXIgaGllcmFyY2h5IHRvIHRoZSBVSSBwcm9jZXNzLgogICAgIFJldGFp blB0cjxXS0NBUmVtb3RlTGF5ZXJDbGllbnRSZWY+IG1fcmVtb3RlTGF5ZXJDbGllbnQ7CiAjZW5k aWYKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkxvYWRl ckNsaWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViTG9hZGVyQ2xpZW50LmNwcAkocmV2aXNpb24gOTkxNDMpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJMb2FkZXJDbGllbnQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjIsNyArMTYyLDYgQEAgdm9pZCB3ZWJraXRXZWJMb2FkZXJDbGllbnRB dHRhY2hMb2FkZXJDbAogICAgICAgICAwLCAvLyBkaWRSZW1vdmVGcmFtZUZyb21IaWVyYXJjaHkK ICAgICAgICAgMCwgLy8gZGlkRGlzcGxheUluc2VjdXJlQ29udGVudEZvckZyYW1lCiAgICAgICAg IDAsIC8vIGRpZFJ1bkluc2VjdXJlQ29udGVudEZvckZyYW1lCi0gICAgICAgIDAsIC8vIGRpZERl dGVjdFhTU0ZvckZyYW1lCiAgICAgICAgIDAsIC8vIGNhbkF1dGhlbnRpY2F0ZUFnYWluc3RQcm90 ZWN0aW9uU3BhY2VJbkZyYW1lCiAgICAgICAgIDAsIC8vIGRpZFJlY2VpdmVBdXRoZW50aWNhdGlv bkNoYWxsZW5nZUluRnJhbWUKICAgICAgICAgZGlkQ2hhbmdlUHJvZ3Jlc3MsIC8vIGRpZFN0YXJ0 UHJvZ3Jlc3MKQEAgLTE3Myw3ICsxNzIsOCBAQCB2b2lkIHdlYmtpdFdlYkxvYWRlckNsaWVudEF0 dGFjaExvYWRlckNsCiAgICAgICAgIDAsIC8vIHByb2Nlc3NEaWRDcmFzaAogICAgICAgICBkaWRD aGFuZ2VCYWNrRm9yd2FyZExpc3QsCiAgICAgICAgIDAsIC8vIHNob3VsZEdvVG9CYWNrRm9yd2Fy ZExpc3RJdGVtCi0gICAgICAgIDAgLy8gZGlkRmFpbFRvSW5pdGlhbGl6ZVBsdWdpbgorICAgICAg ICAwLCAvLyBkaWRGYWlsVG9Jbml0aWFsaXplUGx1Z2luCisgICAgICAgIDAgLy8gZGlkRGV0ZWN0 WFNTRm9yRnJhbWUKICAgICB9OwogICAgIFdLUGFnZVNldFBhZ2VMb2FkZXJDbGllbnQod2tQYWdl LCAmd2tMb2FkZXJDbGllbnQpOwogfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAkocmV2aXNpb24gOTkxNDMp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTM0MCw3ICszNDAsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRX ZWJWaWV3QmFzZURyYWdEYXRhUmVjCiAKICAgICB3ZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5 LT5yZXNldERyYWdPcGVyYXRpb24oKTsKICAgICB3ZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5 LT5kcmFnRW50ZXJlZChkcmFnRGF0YS5nZXQoKSk7Ci0gICAgRHJhZ09wZXJhdGlvbiBvcGVyYXRp b24gPSB3ZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5LT5kcmFnT3BlcmF0aW9uKCk7CisgICAg RHJhZ09wZXJhdGlvbiBvcGVyYXRpb24gPSB3ZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5LT5k cmFnU2Vzc2lvbigpLm9wZXJhdGlvbjsKICAgICBnZGtfZHJhZ19zdGF0dXMoY29udGV4dCwgZHJh Z09wZXJhdGlvblRvU2luZ2xlR2RrRHJhZ0FjdGlvbihvcGVyYXRpb24pLCB0aW1lKTsKIH0KIApA QCAtMzUyLDcgKzM1Miw3IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFzZURyYWdN b3QKICAgICAgICAgcmV0dXJuIFRSVUU7CiAKICAgICB3ZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVBy b3h5LT5kcmFnVXBkYXRlZChkcmFnRGF0YS5nZXQoKSk7Ci0gICAgRHJhZ09wZXJhdGlvbiBvcGVy YXRpb24gPSB3ZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5LT5kcmFnT3BlcmF0aW9uKCk7Cisg ICAgRHJhZ09wZXJhdGlvbiBvcGVyYXRpb24gPSB3ZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVByb3h5 LT5kcmFnU2Vzc2lvbigpLm9wZXJhdGlvbjsKICAgICBnZGtfZHJhZ19zdGF0dXMoY29udGV4dCwg ZHJhZ09wZXJhdGlvblRvU2luZ2xlR2RrRHJhZ0FjdGlvbihvcGVyYXRpb24pLCB0aW1lKTsKICAg ICByZXR1cm4gVFJVRTsKIH0K 113441 2011-11-03 01:06:43 -0700 2011-11-03 01:54:45 -0700 Updated patch P71440.patch text/plain 3130 kevin.cs.oh SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5MTQ3KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTEtMDMgIENoYW5nU2Vv ayBPaCAgPHNoaXZhbWlkb3dAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBidWlsZC1i cmVhayBvbiByOTkxNDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTcxNDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgZHJhZ09wZXJhdGlvbigpIHNob3VsZCBiZSByZXBsYWNlZCB3aXRoIGRyYWdTZXNzaW9u KCkub3BlcmF0aW9uIHNpbmNlIGl0IHdhcyByZW1vdmVkLgorICAgICAgICBBbmQgZGlkRGV0ZWN0 WFNTRm9yRnJhbWUgb2YgV0tQYWdlTG9hZGVyQ2xpZW50IHNob3VsZCBiZSByZWxvY2F0ZWQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJMb2FkZXJDbGllbnQuY3BwOgor ICAgICAgICAod2Via2l0V2ViTG9hZGVyQ2xpZW50QXR0YWNoTG9hZGVyQ2xpZW50VG9QYWdlKToK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAg ICAgICh3ZWJraXRXZWJWaWV3QmFzZURyYWdEYXRhUmVjZWl2ZWQpOgorICAgICAgICAod2Via2l0 V2ViVmlld0Jhc2VEcmFnTW90aW9uKToKKwogMjAxMS0xMS0wMyAgTWFoZXNoIEt1bGthcm5pICA8 bWFoZXNoLmt1bGthcm5pQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZsYWdnaW5nIHVzYWdl IG9mIFgxMSBoZWFkZXJzIHVuZGVyIFBMQVRfQVJDSChYMTEpCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJMb2FkZXJDbGllbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkxvYWRlckNsaWVu dC5jcHAJKHJldmlzaW9uIDk5MTQ3KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViTG9hZGVyQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYyLDcgKzE2 Miw2IEBAIHZvaWQgd2Via2l0V2ViTG9hZGVyQ2xpZW50QXR0YWNoTG9hZGVyQ2wKICAgICAgICAg MCwgLy8gZGlkUmVtb3ZlRnJhbWVGcm9tSGllcmFyY2h5CiAgICAgICAgIDAsIC8vIGRpZERpc3Bs YXlJbnNlY3VyZUNvbnRlbnRGb3JGcmFtZQogICAgICAgICAwLCAvLyBkaWRSdW5JbnNlY3VyZUNv bnRlbnRGb3JGcmFtZQotICAgICAgICAwLCAvLyBkaWREZXRlY3RYU1NGb3JGcmFtZQogICAgICAg ICAwLCAvLyBjYW5BdXRoZW50aWNhdGVBZ2FpbnN0UHJvdGVjdGlvblNwYWNlSW5GcmFtZQogICAg ICAgICAwLCAvLyBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2VJbkZyYW1lCiAgICAg ICAgIGRpZENoYW5nZVByb2dyZXNzLCAvLyBkaWRTdGFydFByb2dyZXNzCkBAIC0xNzMsNyArMTcy LDggQEAgdm9pZCB3ZWJraXRXZWJMb2FkZXJDbGllbnRBdHRhY2hMb2FkZXJDbAogICAgICAgICAw LCAvLyBwcm9jZXNzRGlkQ3Jhc2gKICAgICAgICAgZGlkQ2hhbmdlQmFja0ZvcndhcmRMaXN0LAog ICAgICAgICAwLCAvLyBzaG91bGRHb1RvQmFja0ZvcndhcmRMaXN0SXRlbQotICAgICAgICAwIC8v IGRpZEZhaWxUb0luaXRpYWxpemVQbHVnaW4KKyAgICAgICAgMCwgLy8gZGlkRmFpbFRvSW5pdGlh bGl6ZVBsdWdpbgorICAgICAgICAwIC8vIGRpZERldGVjdFhTU0ZvckZyYW1lCiAgICAgfTsKICAg ICBXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KHdrUGFnZSwgJndrTG9hZGVyQ2xpZW50KTsKIH0K SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRXZWJWaWV3QmFzZS5jcHAJKHJldmlzaW9uIDk5MTQ3KQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z NDAsNyArMzQwLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VEcmFnRGF0YVJlYwog CiAgICAgd2ViVmlld0Jhc2UtPnByaXYtPnBhZ2VQcm94eS0+cmVzZXREcmFnT3BlcmF0aW9uKCk7 CiAgICAgd2ViVmlld0Jhc2UtPnByaXYtPnBhZ2VQcm94eS0+ZHJhZ0VudGVyZWQoZHJhZ0RhdGEu Z2V0KCkpOwotICAgIERyYWdPcGVyYXRpb24gb3BlcmF0aW9uID0gd2ViVmlld0Jhc2UtPnByaXYt PnBhZ2VQcm94eS0+ZHJhZ09wZXJhdGlvbigpOworICAgIERyYWdPcGVyYXRpb24gb3BlcmF0aW9u ID0gd2ViVmlld0Jhc2UtPnByaXYtPnBhZ2VQcm94eS0+ZHJhZ1Nlc3Npb24oKS5vcGVyYXRpb247 CiAgICAgZ2RrX2RyYWdfc3RhdHVzKGNvbnRleHQsIGRyYWdPcGVyYXRpb25Ub1NpbmdsZUdka0Ry YWdBY3Rpb24ob3BlcmF0aW9uKSwgdGltZSk7CiB9CiAKQEAgLTM1Miw3ICszNTIsNyBAQCBzdGF0 aWMgZ2Jvb2xlYW4gd2Via2l0V2ViVmlld0Jhc2VEcmFnTW90CiAgICAgICAgIHJldHVybiBUUlVF OwogCiAgICAgd2ViVmlld0Jhc2UtPnByaXYtPnBhZ2VQcm94eS0+ZHJhZ1VwZGF0ZWQoZHJhZ0Rh dGEuZ2V0KCkpOwotICAgIERyYWdPcGVyYXRpb24gb3BlcmF0aW9uID0gd2ViVmlld0Jhc2UtPnBy aXYtPnBhZ2VQcm94eS0+ZHJhZ09wZXJhdGlvbigpOworICAgIERyYWdPcGVyYXRpb24gb3BlcmF0 aW9uID0gd2ViVmlld0Jhc2UtPnByaXYtPnBhZ2VQcm94eS0+ZHJhZ1Nlc3Npb24oKS5vcGVyYXRp b247CiAgICAgZ2RrX2RyYWdfc3RhdHVzKGNvbnRleHQsIGRyYWdPcGVyYXRpb25Ub1NpbmdsZUdk a0RyYWdBY3Rpb24ob3BlcmF0aW9uKSwgdGltZSk7CiAgICAgcmV0dXJuIFRSVUU7CiB9Cg==