71434 2011-11-02 19:05:17 -0700 FunctionPtr should accept FASTCALL functions on X86 2011-11-02 20:13:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 yuqiang.xian webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 495149 0 yuqiang.xian 2011-11-02 19:05:17 -0700 On X86 we sometimes use FASTCALL convention functions, for example the cti functions, and we may need the pointers to such functions, e.g., in current DFG register file check and arity check, though long term we may avoid such usage of cti calls in DFG. 495153 1 113420 yuqiang.xian 2011-11-02 19:09:23 -0700 Created attachment 113420 proposed patch 495169 2 113420 webkit.review.bot 2011-11-02 20:13:43 -0700 Comment on attachment 113420 proposed patch Clearing flags on attachment: 113420 Committed r99133: <http://trac.webkit.org/changeset/99133> 495170 3 webkit.review.bot 2011-11-02 20:13:47 -0700 All reviewed patches have been landed. Closing bug. 113420 2011-11-02 19:09:23 -0700 2011-11-02 20:13:43 -0700 proposed patch 71434.patch text/plain 2972 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTkxMzApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK KzIwMTEtMTEtMDIgIFl1cWlhbmcgWGlhbiAgPHl1cWlhbmcueGlhbkBpbnRlbC5jb20+CisKKyAg ICAgICAgRnVuY3Rpb25QdHIgc2hvdWxkIGFjY2VwdCBGQVNUQ0FMTCBmdW5jdGlvbnMgb24gWDg2 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTQzNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIFg4NiB3 ZSBzb21ldGltZXMgdXNlIEZBU1RDQUxMIGNvbnZlbnRpb24gZnVuY3Rpb25zLCBmb3IgZXhhbXBs ZSB0aGUKKyAgICAgICAgY3RpIGZ1bmN0aW9ucywgYW5kIHdlIG1heSBuZWVkIHRoZSBwb2ludGVy cyB0byBzdWNoIGZ1bmN0aW9ucywgZS5nLiwKKyAgICAgICAgaW4gY3VycmVudCBERkcgcmVnaXN0 ZXIgZmlsZSBjaGVjayBhbmQgYXJpdHkgY2hlY2ssIHRob3VnaCBsb25nIHRlcm0KKyAgICAgICAg d2UgbWF5IGF2b2lkIHN1Y2ggdXNhZ2Ugb2YgY3RpIGNhbGxzIGluIERGRy4KKworICAgICAgICAq IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckNvZGVSZWYuaDoKKyAgICAgICAgKEpTQzo6RnVuY3Rp b25QdHI6OkZ1bmN0aW9uUHRyKToKKwogMjAxMS0xMS0wMiAgWXVxaWFuZyBYaWFuICA8eXVxaWFu Zy54aWFuQGludGVsLmNvbT4KIAogICAgICAgICBSZW1vdmUgc29tZSB1bm5lY2Vzc2FyeSBsb2Fk cy9zdG9yZXMgaW4gREZHIEpJVCAzMl82NApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NYWNyb0Fzc2VtYmxlckNvZGVSZWYuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oCShyZXZpc2lvbiA5 OTEzMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJD b2RlUmVmLmgJKHdvcmtpbmcgY29weSkKQEAgLTY1LDYgKzY1LDE5IEBACiAjZGVmaW5lIENBTExJ TkdfQ09OVkVOVElPTl9JU19TVERDQUxMIDAKICNlbmRpZgogCisjaWYgQ1BVKFg4NikKKyNkZWZp bmUgSEFTX0ZBU1RDQUxMX0NBTExJTkdfQ09OVkVOVElPTiAxCisjaWZuZGVmIEZBU1RDQUxMCisj aWYgQ09NUElMRVIoTVNWQykKKyNkZWZpbmUgRkFTVENBTEwgX19mYXN0Y2FsbAorI2Vsc2UKKyNk ZWZpbmUgRkFTVENBTEwgIF9fYXR0cmlidXRlX18gKChmYXN0Y2FsbCkpCisjZW5kaWYgLy8gQ09N UElMRVIoTVNWQykKKyNlbmRpZiAvLyBGQVNUQ0FMTAorI2Vsc2UKKyNkZWZpbmUgSEFTX0ZBU1RD QUxMX0NBTExJTkdfQ09OVkVOVElPTiAwCisjZW5kaWYgLy8gQ1BVKFg4NikKKwogbmFtZXNwYWNl IEpTQyB7CiAKIC8vIEZ1bmN0aW9uUHRyOgpAQCAtMTQ4LDYgKzE2MSw0NCBAQCBwdWJsaWM6CiAg ICAgICAgIDogbV92YWx1ZSgodm9pZCopdmFsdWUpCiAgICAgewogICAgICAgICBBU1NFUlRfVkFM SURfQ09ERV9QT0lOVEVSKG1fdmFsdWUpOworICAgIH0KKyNlbmRpZgorCisjaWYgSEFTX0ZBU1RD QUxMX0NBTExJTkdfQ09OVkVOVElPTgorCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgcmV0dXJuVHlw ZT4KKyAgICBGdW5jdGlvblB0cihyZXR1cm5UeXBlIChGQVNUQ0FMTCAqdmFsdWUpKCkpCisgICAg ICAgIDogbV92YWx1ZSgodm9pZCopdmFsdWUpCisgICAgeworICAgICAgICBBU1NFUlRfVkFMSURf Q09ERV9QT0lOVEVSKG1fdmFsdWUpOworICAgIH0KKworICAgIHRlbXBsYXRlPHR5cGVuYW1lIHJl dHVyblR5cGUsIHR5cGVuYW1lIGFyZ1R5cGUxPgorICAgIEZ1bmN0aW9uUHRyKHJldHVyblR5cGUg KEZBU1RDQUxMICp2YWx1ZSkoYXJnVHlwZTEpKQorICAgICAgICA6IG1fdmFsdWUoKHZvaWQqKXZh bHVlKQorICAgIHsKKyAgICAgICAgQVNTRVJUX1ZBTElEX0NPREVfUE9JTlRFUihtX3ZhbHVlKTsK KyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSByZXR1cm5UeXBlLCB0eXBlbmFtZSBhcmdU eXBlMSwgdHlwZW5hbWUgYXJnVHlwZTI+CisgICAgRnVuY3Rpb25QdHIocmV0dXJuVHlwZSAoRkFT VENBTEwgKnZhbHVlKShhcmdUeXBlMSwgYXJnVHlwZTIpKQorICAgICAgICA6IG1fdmFsdWUoKHZv aWQqKXZhbHVlKQorICAgIHsKKyAgICAgICAgQVNTRVJUX1ZBTElEX0NPREVfUE9JTlRFUihtX3Zh bHVlKTsKKyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSByZXR1cm5UeXBlLCB0eXBlbmFt ZSBhcmdUeXBlMSwgdHlwZW5hbWUgYXJnVHlwZTIsIHR5cGVuYW1lIGFyZ1R5cGUzPgorICAgIEZ1 bmN0aW9uUHRyKHJldHVyblR5cGUgKEZBU1RDQUxMICp2YWx1ZSkoYXJnVHlwZTEsIGFyZ1R5cGUy LCBhcmdUeXBlMykpCisgICAgICAgIDogbV92YWx1ZSgodm9pZCopdmFsdWUpCisgICAgeworICAg ICAgICBBU1NFUlRfVkFMSURfQ09ERV9QT0lOVEVSKG1fdmFsdWUpOworICAgIH0KKworICAgIHRl bXBsYXRlPHR5cGVuYW1lIHJldHVyblR5cGUsIHR5cGVuYW1lIGFyZ1R5cGUxLCB0eXBlbmFtZSBh cmdUeXBlMiwgdHlwZW5hbWUgYXJnVHlwZTMsIHR5cGVuYW1lIGFyZ1R5cGU0PgorICAgIEZ1bmN0 aW9uUHRyKHJldHVyblR5cGUgKEZBU1RDQUxMICp2YWx1ZSkoYXJnVHlwZTEsIGFyZ1R5cGUyLCBh cmdUeXBlMywgYXJnVHlwZTQpKQorICAgICAgICA6IG1fdmFsdWUoKHZvaWQqKXZhbHVlKQorICAg IHsKKyAgICAgICAgQVNTRVJUX1ZBTElEX0NPREVfUE9JTlRFUihtX3ZhbHVlKTsKICAgICB9CiAj ZW5kaWYKIAo=