7143 2006-02-08 11:53:51 -0800 REGRESSION: onclick handler cannot call a function named OnClick 2006-03-22 12:13:58 -0800 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction, InRadar, Regression P1 Normal --- 1 ap darin alice.barraclough darin oldest_to_newest 31853 0 ap 2006-02-08 11:53:51 -0800 Steps to reproduce: open the attached test case, click on the text. Expected results: an alert appears. Actual results: nothing happens. 31854 1 6345 ap 2006-02-08 11:54:41 -0800 Created attachment 6345 test case Error message: Value OnClick(); (result of expression OnClick) is not object. 31906 2 darin 2006-02-08 21:03:49 -0800 For some reason, we have an onclick property on DOM nodes that allows you to set and get the onclick handle for a DOM node. I can't find any other web browser that has this property. Because of this property, when you try to call a function on the window object named onclick, you find the property on the DOM node first. The fix is presumably just to remove the property, but I would like to know why the property is there, and how many of the other "onxxx" properties need to be removed. 31908 3 darin 2006-02-08 21:08:22 -0800 Removing the properties from kjs_dom.cpp is going to be easy. The only hard thing here is testing with other browsers to see whether they have properties like ours. 32294 4 darin 2006-02-12 21:55:43 -0800 Maciej thinks my analysis is wrong and this is really about case sensitivity. I think he's right and my tests of other browsers were confused. I'll look into a fix given that insight. 33377 5 darin 2006-02-19 09:32:17 -0800 I now believe that fixing this is as simple as changing the getAttribute calls in KJS::DOMElement::getOwnPropertySlot and KJS::DOMElement::attributeGetter in kjs_dom.cpp. Either we remove them entirely or we change them to construct a QualifiedName directly to avoid the lower-casing that's done in WebCore::ElementImpl::getAttributeNS. The argument for removing them entirely is that they implement a feature that is not present in Gecko/Firefox. The argument for keeping them is that they implement a feature that is similar to something present in Internet Explorer. 37002 6 alice.barraclough 2006-03-20 07:10:26 -0800 <rdar://problem/4483856> 6345 2006-02-08 11:54:41 -0800 2006-02-08 11:54:41 -0800 test case onclick.html text/html 167 ap PGh0bWw+DQo8aGVhZD4NCjxzY3JpcHQ+DQpmdW5jdGlvbiBPbkNsaWNrKCkNCnsNCiAgYWxlcnQo MCk7DQp9DQo8L3NjcmlwdD4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBvbmNsaWNrPSJPbkNsaWNr KCk7Ij5DbGljayB0byB0ZXN0IG9uY2xpY2suPC9kaXY+DQo8L2JvZHk+DQo8L2h0bWw+DQo=