71423 2011-11-02 17:13:43 -0700 Remove all releaseRef implementations except for RetainPtr 2011-11-11 14:52:19 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 41374 1 darin darin jchaffraix webkit.review.bot oldest_to_newest 495077 0 darin 2011-11-02 17:13:43 -0700 Last step in renaming releaseRef to leakRef. 499932 1 114508 darin 2011-11-10 08:26:52 -0800 Created attachment 114508 Patch 500097 2 114508 jchaffraix 2011-11-10 12:05:56 -0800 Comment on attachment 114508 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114508&action=review > Source/JavaScriptCore/API/JSRetainPtr.h:-75 > - T releaseRef() { return leakRef(); } I guess you have discussed this API breakage. 500099 3 darin 2011-11-10 12:07:50 -0800 (In reply to comment #2) > I guess you have discussed this API breakage. Is JSRetainPtr API? On what platforms? 500105 4 jchaffraix 2011-11-10 12:13:13 -0800 (In reply to comment #3) > (In reply to comment #2) > > I guess you have discussed this API breakage. > > Is JSRetainPtr API? On what platforms? I thought it was exposed to the JSC API but it is actually not exposed. 501124 5 114508 webkit.review.bot 2011-11-11 14:52:15 -0800 Comment on attachment 114508 Patch Clearing flags on attachment: 114508 Committed r100030: <http://trac.webkit.org/changeset/100030> 501125 6 webkit.review.bot 2011-11-11 14:52:19 -0800 All reviewed patches have been landed. Closing bug. 114508 2011-11-10 08:26:52 -0800 2011-11-11 14:52:14 -0800 Patch bug-71423-20111110082651.patch text/plain 4520 darin SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTk4NTkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMTEtMTAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJl bW92ZSBhbGwgcmVsZWFzZVJlZiBpbXBsZW1lbnRhdGlvbnMgZXhjZXB0IGZvciBSZXRhaW5QdHIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNDIzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBUEkvSlNS ZXRhaW5QdHIuaDogUmVtb3ZlZCByZWxlYXNlUmVmLgorICAgICAgICAqIHd0Zi9QYXNzUmVmUHRy Lmg6IFJlbW92ZWQgcmVsZWFzZVJlZi4KKwogMjAxMS0xMS0xMCAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4IG1ha2Ug ZGlzdGNoZWNrIGJ1aWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1JldGFp blB0ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNSZXRhaW5Q dHIuaAkocmV2aXNpb24gOTk4NTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTUmV0 YWluUHRyLmgJKHdvcmtpbmcgY29weSkKQEAgLTcxLDkgKzcxLDYgQEAgcHVibGljOgogICAgIAog ICAgIHZvaWQgc3dhcChKU1JldGFpblB0ciYpOwogCi0gICAgLy8gRklYTUU6IFJlbW92ZSByZWxl YXNlUmVmIG9uY2Ugd2UgY2hhbmdlIGFsbCBjYWxsZXJzIHRvIGNhbGwgbGVha1JlZiBpbnN0ZWFk LgotICAgIFQgcmVsZWFzZVJlZigpIHsgcmV0dXJuIGxlYWtSZWYoKTsgfQotCiBwcml2YXRlOgog ICAgIFQgbV9wdHI7CiB9OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzUmVm UHRyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzUmVmUHRy LmgJKHJldmlzaW9uIDk5ODU4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXNzUmVm UHRyLmgJKHdvcmtpbmcgY29weSkKQEAgLTkyLDkgKzkyLDYgQEAgbmFtZXNwYWNlIFdURiB7CiAK ICAgICAgICAgZnJpZW5kIFBhc3NSZWZQdHIgYWRvcHRSZWY8VD4oVCopOwogCi0gICAgICAgIC8v IEZJWE1FOiBSZW1vdmUgcmVsZWFzZVJlZiBvbmNlIHdlIGNoYW5nZSBhbGwgY2FsbGVycyB0byBj YWxsIGxlYWtSZWYgaW5zdGVhZC4KLSAgICAgICAgVCogcmVsZWFzZVJlZigpIGNvbnN0IFdBUk5f VU5VU0VEX1JFVFVSTiB7IHJldHVybiBsZWFrUmVmKCk7IH0KLQogICAgIHByaXZhdGU6CiAgICAg ICAgIC8vIGFkb3B0aW5nIGNvbnN0cnVjdG9yCiAgICAgICAgIFBhc3NSZWZQdHIoVCogcHRyLCBi b29sKSA6IG1fcHRyKHB0cikgeyB9CkBAIC0xNTUsOSArMTUyLDYgQEAgbmFtZXNwYWNlIFdURiB7 CiAKICAgICAgICAgTm9uTnVsbFBhc3NSZWZQdHImIG9wZXJhdG9yPShjb25zdCBOb25OdWxsUGFz c1JlZlB0ciYpIHsgQ09NUElMRV9BU1NFUlQoIXNpemVvZihUKiksIE5vbk51bGxQYXNzUmVmUHRy X3Nob3VsZF9uZXZlcl9iZV9hc3NpZ25lZF90byk7IHJldHVybiAqdGhpczsgfQogCi0gICAgICAg IC8vIEZJWE1FOiBSZW1vdmUgcmVsZWFzZVJlZiBvbmNlIHdlIGNoYW5nZSBhbGwgY2FsbGVycyB0 byBjYWxsIGxlYWtSZWYgaW5zdGVhZC4KLSAgICAgICAgVCogcmVsZWFzZVJlZigpIGNvbnN0IFdB Uk5fVU5VU0VEX1JFVFVSTiB7IHJldHVybiBsZWFrUmVmKCk7IH0KLQogICAgIHByaXZhdGU6CiAg ICAgICAgIG11dGFibGUgVCogbV9wdHI7CiAgICAgfTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9u IDk5ODU5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTEtMTEtMTAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgor CisgICAgICAgIFJlbW92ZSBhbGwgcmVsZWFzZVJlZiBpbXBsZW1lbnRhdGlvbnMgZXhjZXB0IGZv ciBSZXRhaW5QdHIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcxNDIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS93aW4vQ09NUHRyLmg6IFJlbW92ZWQgcmVsZWFzZVJlZi4KKwogMjAxMS0x MS0xMCAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1lcm1hbm5AcmltLmNvbT4KIAogICAgICAg ICBbR1RLXSBzdmcvYXMtaW1hZ2Uvc3ZnLWltYWdlLWNoYW5nZS1jb250ZW50LXNpemUueGh0bWwg Y3Jhc2hlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vd2luL0NPTVB0ci5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9DT01QdHIuaAkocmV2aXNpb24g OTk4NTgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vQ09NUHRyLmgJKHdvcmtpbmcg Y29weSkKQEAgLTkzLDkgKzkzLDYgQEAgcHVibGljOgogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+ IEhSRVNVTFQgY29weVJlZlRvKFUqKik7CiAgICAgdm9pZCBhZG9wdFJlZihUKik7CiAKLSAgICAv LyBGSVhNRTogUmVtb3ZlIHJlbGVhc2VSZWYgb25jZSB3ZSBjaGFuZ2UgYWxsIGNhbGxlcnMgdG8g Y2FsbCBsZWFrUmVmIGluc3RlYWQuCi0gICAgVCogcmVsZWFzZVJlZigpIHsgcmV0dXJuIGxlYWtS ZWYoKTsgfQotCiBwcml2YXRlOgogICAgIHN0YXRpYyBUKiBjb3B5UXVlcnlJbnRlcmZhY2VSZWYo SVVua25vd24qKTsKICAgICBzdGF0aWMgVCogY3JlYXRlSW5zdGFuY2UoY29uc3QgSUlEJiBjbHNp ZCk7CkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9n CShyZXZpc2lvbiA5OTg1OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDEzIEBACisyMDExLTExLTEwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4K KworICAgICAgICBSZW1vdmUgYWxsIHJlbGVhc2VSZWYgaW1wbGVtZW50YXRpb25zIGV4Y2VwdCBm b3IgUmV0YWluUHRyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MTQyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvY2YvV2ViQXJjaGl2ZUR1bXBTdXBwb3J0LmNwcDoKKyAgICAg ICAgKGNyZWF0ZVhNTFN0cmluZ0Zyb21XZWJBcmNoaXZlRGF0YSk6IFVzZSBsZWFrUmVmIGluc3Rl YWQgb2YgcmVsZWFzZVJlZi4KKwogMjAxMS0xMS0xMCAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5o YXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBGaXgga2V5Ym9hcmQgcmVsYXRlZCBs YXlvdXQgdGVzdHMgYWZ0ZXIgQVBJIHJlZmFjdG9yaW5nCkluZGV4OiBUb29scy9EdW1wUmVuZGVy VHJlZS9jZi9XZWJBcmNoaXZlRHVtcFN1cHBvcnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2NmL1dlYkFyY2hpdmVEdW1wU3VwcG9ydC5jcHAJKHJldmlzaW9uIDk5ODU4 KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvY2YvV2ViQXJjaGl2ZUR1bXBTdXBwb3J0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjI2LDUgKzIyNiw1IEBAIENGU3RyaW5nUmVmIGNyZWF0ZVhNTFN0 cmluZ0Zyb21XZWJBcmNoaXYKICAgICAvLyBSZXBsYWNlICJBcHBsZSBDb21wdXRlciIgd2l0aCAi QXBwbGUiIGluIHRoZSBEVEQgZGVjbGFyYXRpb24uCiAgICAgQ0ZTdHJpbmdGaW5kQW5kUmVwbGFj ZShzdHJpbmcuZ2V0KCksIENGU1RSKCItLy9BcHBsZSBDb21wdXRlci8vIiksIENGU1RSKCItLy9B cHBsZS8vIiksIENGUmFuZ2VNYWtlKDAsIENGU3RyaW5nR2V0TGVuZ3RoKHN0cmluZy5nZXQoKSkp LCAwKTsKIAotICAgIHJldHVybiBzdHJpbmcucmVsZWFzZVJlZigpOworICAgIHJldHVybiBzdHJp bmcubGVha1JlZigpOwogfQo=