71421 2011-11-02 17:08:13 -0700 REGRESSION(r99025-r99037): platform/mac/accessibility/select-element-selection-with-optgroups.html is asserting 2011-11-07 18:26:14 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r99103%20(2810)/results.html MakingBotsRed P2 Normal --- 1 simon.fraser jonlee cfleizach darin rniwa tkent oldest_to_newest 495073 0 simon.fraser 2011-11-02 17:08:13 -0700 ASSERTION FAILED: !(flags & DispatchChangeEvent) /Volumes/Big/slave/snowleopard-intel-debug/build/Source/WebCore/html/HTMLSelectElement.cpp(792) : void WebCore::HTMLSelectElement::selectOption(int, unsigned int) 1 0x101887a53 WebCore::HTMLSelectElement::selectOption(int, unsigned int) 2 0x101887c0e WebCore::HTMLSelectElement::accessKeySetSelectedIndex(int) 3 0x1012315ed WebCore::AccessibilityListBoxOption::setSelected(bool) 4 0x101221578 WebCore::AccessibilityListBox::setSelectedChildren(WTF::Vector<WTF::RefPtr<WebCore::AccessibilityObject>, 0ul>&) 5 0x10125f242 -[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:] 6 0x10000614f AccessibilityUIElement::setSelectedChild(AccessibilityUIElement*) const 7 0x100004629 setSelectedChildCallback(OpaqueJSContext const*, OpaqueJSValue*, OpaqueJSValue*, unsigned long, OpaqueJSValue const* const*, OpaqueJSValue const**) 8 0x1002d1537 JSC::JSCallbackFunction::call(JSC::ExecState*) 9 0x1002b9ec8 cti_op_call_NotJSFunction 10 0x1002b25e5 jscGeneratedNativeCode 11 0x100290b48 JSC::JITCode::execute(JSC::RegisterFile*, JSC::ExecState*, JSC::JSGlobalData*) 12 0x10028c4c3 JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*, JSC::ScopeChainNode*, JSC::JSObject*) 13 0x1002253e9 JSC::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 14 0x1022a4504 WebCore::JSMainThreadExecState::evaluate(JSC::ExecState*, JSC::ScopeChainNode*, JSC::SourceCode const&, JSC::JSValue, JSC::JSValue*) 15 0x1020908dc WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld*) 16 0x102090b37 WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&) 17 0x10209f954 WebCore::ScriptElement::executeScript(WebCore::ScriptSourceCode const&) 18 0x1020a04b8 WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) 19 0x101884470 WebCore::HTMLScriptRunner::runScript(WebCore::Element*, WTF::TextPosition const&) 20 0x101884f97 WebCore::HTMLScriptRunner::execute(WTF::PassRefPtr<WebCore::Element>, WTF::TextPosition const&) 21 0x101829ce8 WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() 22 0x101829d96 WebCore::HTMLDocumentParser::canTakeNextToken(WebCore::HTMLDocumentParser::SynchronousMode, WebCore::PumpSession&) 23 0x10182ac61 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) 24 0x10182af4d WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) 25 0x10182b4ab WebCore::HTMLDocumentParser::append(WebCore::SegmentedString const&) 26 0x1015656d4 WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter*, char const*, unsigned long) 27 0x1015d12a2 WebCore::DocumentWriter::addData(char const*, unsigned long) 28 0x1015ba8a7 WebCore::DocumentLoader::commitData(char const*, unsigned long) 29 0x100cacddd -[WebFrame(WebInternal) _commitData:] 30 0x100cd7548 -[WebHTMLRepresentation receivedData:withDataSource:] 31 0x100c9382c -[WebDataSource(WebInternal) _receivedData:] 496853 1 rniwa 2011-11-06 12:54:34 -0800 Maybe caused by http://trac.webkit.org/changeset/99035/ ? 496856 2 rniwa 2011-11-06 13:01:25 -0800 Added a crash expectation in http://trac.webkit.org/changeset/99380 (debug only) for now. 496977 3 cfleizach 2011-11-06 22:43:12 -0800 (In reply to comment #1) > Maybe caused by http://trac.webkit.org/changeset/99035/ ? This assert was added in this patch as far as I can tell if (!usesMenuList()) 792 ASSERT(!(flags & DispatchChangeEvent)); Darin, can you take a look at this? It's likely this is the code path that VoiceOver will use whenever selecting elements within a <select> 497324 4 darin 2011-11-07 11:24:30 -0800 The code previously had a comment saying this would never happen. I changed that to an assertion. We can just remove the assertion to restore the old behavior. 497325 5 darin 2011-11-07 11:25:26 -0800 I have no time for this right now; worth investigating further later. But for now, just turning off the ASSERT is smart. 497501 6 cfleizach 2011-11-07 15:01:44 -0800 will upload a patch 497650 7 113970 cfleizach 2011-11-07 18:11:39 -0800 Created attachment 113970 patch 497658 8 cfleizach 2011-11-07 18:26:14 -0800 http://trac.webkit.org/changeset/99514 113970 2011-11-07 18:11:39 -0800 2011-11-07 18:12:39 -0800 patch patch.txt text/plain 2636 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk5NTEwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTEtMDcgIENocmlzIEZs ZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHI5OTAy NS1yOTkwMzcpOiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zZWxlY3QtZWxlbWVudC1zZWxl Y3Rpb24td2l0aC1vcHRncm91cHMuaHRtbCBpcyBhc3NlcnRpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTcxNDIxCisKKyAgICAgICAgUmVtb3ZlIGFu IGFzc2VydCB0aGF0IHdhcyBhZGRlZCBieSByOTkwMzUuIEl0IHdhcyBhZGRlZCBiYXNlZCBvbiBh IGNvbW1lbnQgaW4gdGhlIGNvZGUsIGJ1dCBub3QgdGVzdGVkLiAgIAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MU2VsZWN0RWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2VsZWN0RWxlbWVudDo6c2VsZWN0T3B0aW9u KToKKwogMjAxMS0xMS0wNyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgRml4ZWQgd3JvbmcgdGVzdCByZXN1bHRzIG9mIGZhc3QvanMvY3VzdG9tLWNvbnN0 cnVjdG9ycy5odG1sCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50 LmNwcAkocmV2aXNpb24gOTk0OTgpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RF bGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzg4LDkgKzc4OCw3IEBACiAKICAgICBzY3Jv bGxUb1NlbGVjdGlvbigpOwogCi0gICAgaWYgKCF1c2VzTWVudUxpc3QoKSkKLSAgICAgICAgQVNT RVJUKCEoZmxhZ3MgJiBEaXNwYXRjaENoYW5nZUV2ZW50KSk7Ci0gICAgZWxzZSB7CisgICAgaWYg KHVzZXNNZW51TGlzdCgpKSB7CiAgICAgICAgIG1faXNQcm9jZXNzaW5nVXNlckRyaXZlbkNoYW5n ZSA9IGZsYWdzICYgVXNlckRyaXZlbjsKICAgICAgICAgaWYgKGZsYWdzICYgRGlzcGF0Y2hDaGFu Z2VFdmVudCkKICAgICAgICAgICAgIGRpc3BhdGNoQ2hhbmdlRXZlbnRGb3JNZW51TGlzdCgpOwpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gOTk1MTApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0xMS0wNyAgQ2hyaXMgRmxlaXphY2ggIDxj ZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjk5MDI1LXI5OTAzNyk6 IHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlbGVjdC1lbGVtZW50LXNlbGVjdGlvbi13aXRo LW9wdGdyb3Vwcy5odG1sIGlzIGFzc2VydGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE0MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZS1lbmFibGUgdGVzdCBhZnRlciByZW1vdmluZyBhbiBlcnJv bmVvdXMgYXNzZXJ0LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL3Rlc3RfZXhwZWN0YXRpb25z LnR4dDoKKwogMjAxMS0xMS0wNyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgRml4ZWQgd3JvbmcgdGVzdCByZXN1bHRzIG9mIGZhc3QvanMvY3VzdG9tLWNv bnN0cnVjdG9ycy5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvdGVzdF9leHBl Y3RhdGlvbnMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy90ZXN0 X2V4cGVjdGF0aW9ucy50eHQJKHJldmlzaW9uIDk5NDk4KQorKysgTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMzEsNSArMzEs MyBAQAogQlVHV0s2NzAwNyBERUJVRyA6IGZhc3QvcnVieS9nZW5lcmF0ZWQtYmVmb3JlLWFuZC1h ZnRlci1jb3VudGVyLWRvZXNudC1jcmFzaC5odG1sID0gQ1JBU0gKIAogQlVHV0s2OTk5OSBSRUxF QVNFIDogaHR0cC90ZXN0cy9zZWN1cml0eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvbWVkaWEtc3Jj LWFsbG93ZWQuaHRtbCA9IFRFWFQgUEFTUwotCi1CVUdXSzcxNDIxIERFQlVHIDogcGxhdGZvcm0v bWFjL2FjY2Vzc2liaWxpdHkvc2VsZWN0LWVsZW1lbnQtc2VsZWN0aW9uLXdpdGgtb3B0Z3JvdXBz Lmh0bWwgPSBDUkFTSAo=