71417 2011-11-02 16:25:00 -0700 [Qt] [WK] Debug build broken 2011-11-02 23:33:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 1 ostap73 webkit-unassigned webkit.review.bot zoltan oldest_to_newest 495019 0 ostap73 2011-11-02 16:25:00 -0700 BundlePage.o ../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp ../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp: In constructor ‘WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage(WebKit::QtBuiltinBundle*, WKBundlePageRef)’: ../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp:70:5: error: missing initializer for member ‘WKBundlePageLoaderClient::didDetectXSSForFrame’ [-Werror=missing-field-initializers] ../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp: In member function ‘void WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled(WKTypeRef)’: ../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:134:5: error: ‘WKGetTypeId’ was not declared in this scope ../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:139:5: error: ‘WKBooleanGetTypeID’ was not declared in this scope 495028 1 113394 ostap73 2011-11-02 16:31:07 -0700 Created attachment 113394 Another debug build fix. 495032 2 webkit.review.bot 2011-11-02 16:34:01 -0700 Attachment 113394 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 495094 3 113394 noam 2011-11-02 17:28:32 -0700 Comment on attachment 113394 Another debug build fix. Please fix style in changelog before committing. 495166 4 113424 ostap73 2011-11-02 20:03:39 -0700 Created attachment 113424 Removed stupid tab from Changelog 495214 5 113424 webkit.review.bot 2011-11-02 23:33:15 -0700 Comment on attachment 113424 Removed stupid tab from Changelog Clearing flags on attachment: 113424 Committed r99141: <http://trac.webkit.org/changeset/99141> 495215 6 webkit.review.bot 2011-11-02 23:33:20 -0700 All reviewed patches have been landed. Closing bug. 113394 2011-11-02 16:31:07 -0700 2011-11-02 20:03:39 -0700 Another debug build fix. QtBuiltinBundle_build_fix.diff text/plain 2373 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ZDJjZDkxLi5iMGE3MWE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMTEtMDIgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0tdIERlYnVnIGJ1aWxkIGJyb2tlbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE0MTcKKwor ICAgICAgICBBZGQgV0tOdW1iZXIuaCBmb3IgV0tCb29sZWFuR2V0VHlwZUlECisgICAgICAgIFJl cGxhY2UgV0tHZXRUeXBlSWQgd2l0aCBXS0dldFR5cGVJRAorICAgICAgICBBZGQgaW5pdGlhbGl6 YXRpb24gZm9yIGRpZERldGVjdFhTU0ZvckZyYW1lIG1lbWJlciBpbiBXS0J1bmRsZVBhZ2VMb2Fk ZXJDbGllbnQgCQorICAgICAgICBpbnN0YW5jZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvcXQvUXRCdWlsdGluQnVuZGxlLmNw cDoKKyAgICAgICAgKFdlYktpdDo6UXRCdWlsdGluQnVuZGxlOjpoYW5kbGVTZXROYXZpZ2F0b3JR dE9iamVjdEVuYWJsZWQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvcXQvUXRCdWlsdGluQnVuZGxl UGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0QnVpbHRpbkJ1bmRsZVBhZ2U6OlF0QnVpbHRp bkJ1bmRsZVBhZ2UpOgorCiAyMDExLTExLTAyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBh cHBsZS5jb20+CiAKICAgICAgICAgRml4IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9xdC9RdEJ1aWx0aW5CdW5kbGUuY3BwIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9xdC9RdEJ1aWx0aW5CdW5kbGUuY3BwCmluZGV4IGFlYTQ1NTIuLmYwYzI4Y2YgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvUXRCdWlsdGluQnVuZGxlLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0QnVpbHRpbkJ1bmRsZS5jcHAK QEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJRdEJ1aWx0aW5CdW5kbGVQYWdlLmgiCiAjaW5j bHVkZSAiV0tBcnJheS5oIgogI2luY2x1ZGUgIldLQnVuZGxlUGFnZS5oIgorI2luY2x1ZGUgIldL TnVtYmVyLmgiCiAjaW5jbHVkZSAiV0tSZXRhaW5QdHIuaCIKICNpbmNsdWRlICJXS1N0cmluZy5o IgogI2luY2x1ZGUgIldLU3RyaW5nUXQuaCIKQEAgLTEzMSw3ICsxMzIsNyBAQCB2b2lkIFF0QnVp bHRpbkJ1bmRsZTo6aGFuZGxlTWVzc2FnZVRvTmF2aWdhdG9yUXRPYmplY3QoV0tUeXBlUmVmIG1l c3NhZ2VCb2R5KQogdm9pZCBRdEJ1aWx0aW5CdW5kbGU6OmhhbmRsZVNldE5hdmlnYXRvclF0T2Jq ZWN0RW5hYmxlZChXS1R5cGVSZWYgbWVzc2FnZUJvZHkpCiB7CiAgICAgQVNTRVJUKG1lc3NhZ2VC b2R5KTsKLSAgICBBU1NFUlQoV0tHZXRUeXBlSWQobWVzc2FnZUJvZHkpID09IFdLQXJyYXlHZXRU eXBlSUQoKSk7CisgICAgQVNTRVJUKFdLR2V0VHlwZUlEKG1lc3NhZ2VCb2R5KSA9PSBXS0FycmF5 R2V0VHlwZUlEKCkpOwogCiAgICAgV0tBcnJheVJlZiBib2R5ID0gc3RhdGljX2Nhc3Q8V0tBcnJh eVJlZj4obWVzc2FnZUJvZHkpOwogICAgIEFTU0VSVChXS0FycmF5R2V0U2l6ZShib2R5KSA9PSAy KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvUXRCdWlsdGluQnVu ZGxlUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0QnVpbHRpbkJ1bmRs ZVBhZ2UuY3BwCmluZGV4IDQyYjE5YzEuLjJjODk1NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvcXQvUXRCdWlsdGluQnVuZGxlUGFnZS5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9xdC9RdEJ1aWx0aW5CdW5kbGVQYWdlLmNwcApAQCAtNjcsNiArNjcs NyBAQCBRdEJ1aWx0aW5CdW5kbGVQYWdlOjpRdEJ1aWx0aW5CdW5kbGVQYWdlKFF0QnVpbHRpbkJ1 bmRsZSogYnVuZGxlLCBXS0J1bmRsZVBhZ2VSZQogICAgICAgICAwLCAvLyB3aWxsUGVyZm9ybUNs aWVudFJlZGlyZWN0Rm9yRnJhbWUKICAgICAgICAgMCwgLy8gZGlkSGFuZGxlT25sb2FkRXZlbnRz Rm9yRnJhbWUKICAgICAgICAgMCwgLy8gZGlkTGF5b3V0Rm9yRnJhbWUKKyAgICAgICAgMCwgLy8g ZGlkRGV0ZWN0WFNTRm9yRnJhbWUKICAgICB9OwogICAgIFdLQnVuZGxlUGFnZVNldFBhZ2VMb2Fk ZXJDbGllbnQobV9wYWdlLCAmbG9hZGVyQ2xpZW50KTsKIH0K 113424 2011-11-02 20:03:39 -0700 2011-11-02 23:33:15 -0700 Removed stupid tab from Changelog QtBuiltinBundle_build_fix.diff text/plain 2371 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ZDJjZDkxLi5hZTBiOWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTEtMTEtMDIgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0tdIERlYnVnIGJ1aWxkIGJyb2tlbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzE0MTcKKwor ICAgICAgICBBZGQgV0tOdW1iZXIuaCBmb3IgV0tCb29sZWFuR2V0VHlwZUlECisgICAgICAgIFJl cGxhY2UgV0tHZXRUeXBlSWQgd2l0aCBXS0dldFR5cGVJRAorICAgICAgICBBZGQgaW5pdGlhbGl6 YXRpb24gZm9yIGRpZERldGVjdFhTU0ZvckZyYW1lIG1lbWJlciBpbiBXS0J1bmRsZVBhZ2VMb2Fk ZXJDbGllbnQKKyAgICAgICAgaW5zdGFuY2UuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTm9hbSBS b3NlbnRoYWwuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL3F0L1F0QnVpbHRpbkJ1bmRsZS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OlF0QnVpbHRpbkJ1bmRsZTo6aGFuZGxlU2V0TmF2aWdhdG9yUXRP YmplY3RFbmFibGVkKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL3F0L1F0QnVpbHRpbkJ1bmRsZVBh Z2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpRdEJ1aWx0aW5CdW5kbGVQYWdlOjpRdEJ1aWx0aW5C dW5kbGVQYWdlKToKKwogMjAxMS0xMS0wMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIEZpeCBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvcXQvUXRCdWlsdGluQnVuZGxlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvcXQvUXRCdWlsdGluQnVuZGxlLmNwcAppbmRleCBhZWE0NTUyLi5mMGMyOGNmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0QnVpbHRpbkJ1bmRsZS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9RdEJ1aWx0aW5CdW5kbGUuY3BwCkBA IC0zMCw2ICszMCw3IEBACiAjaW5jbHVkZSAiUXRCdWlsdGluQnVuZGxlUGFnZS5oIgogI2luY2x1 ZGUgIldLQXJyYXkuaCIKICNpbmNsdWRlICJXS0J1bmRsZVBhZ2UuaCIKKyNpbmNsdWRlICJXS051 bWJlci5oIgogI2luY2x1ZGUgIldLUmV0YWluUHRyLmgiCiAjaW5jbHVkZSAiV0tTdHJpbmcuaCIK ICNpbmNsdWRlICJXS1N0cmluZ1F0LmgiCkBAIC0xMzEsNyArMTMyLDcgQEAgdm9pZCBRdEJ1aWx0 aW5CdW5kbGU6OmhhbmRsZU1lc3NhZ2VUb05hdmlnYXRvclF0T2JqZWN0KFdLVHlwZVJlZiBtZXNz YWdlQm9keSkKIHZvaWQgUXRCdWlsdGluQnVuZGxlOjpoYW5kbGVTZXROYXZpZ2F0b3JRdE9iamVj dEVuYWJsZWQoV0tUeXBlUmVmIG1lc3NhZ2VCb2R5KQogewogICAgIEFTU0VSVChtZXNzYWdlQm9k eSk7Ci0gICAgQVNTRVJUKFdLR2V0VHlwZUlkKG1lc3NhZ2VCb2R5KSA9PSBXS0FycmF5R2V0VHlw ZUlEKCkpOworICAgIEFTU0VSVChXS0dldFR5cGVJRChtZXNzYWdlQm9keSkgPT0gV0tBcnJheUdl dFR5cGVJRCgpKTsKIAogICAgIFdLQXJyYXlSZWYgYm9keSA9IHN0YXRpY19jYXN0PFdLQXJyYXlS ZWY+KG1lc3NhZ2VCb2R5KTsKICAgICBBU1NFUlQoV0tBcnJheUdldFNpemUoYm9keSkgPT0gMik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1F0QnVpbHRpbkJ1bmRs ZVBhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9RdEJ1aWx0aW5CdW5kbGVQ YWdlLmNwcAppbmRleCA0MmIxOWMxLi4yYzg5NTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL3F0L1F0QnVpbHRpbkJ1bmRsZVBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvcXQvUXRCdWlsdGluQnVuZGxlUGFnZS5jcHAKQEAgLTY3LDYgKzY3LDcg QEAgUXRCdWlsdGluQnVuZGxlUGFnZTo6UXRCdWlsdGluQnVuZGxlUGFnZShRdEJ1aWx0aW5CdW5k bGUqIGJ1bmRsZSwgV0tCdW5kbGVQYWdlUmUKICAgICAgICAgMCwgLy8gd2lsbFBlcmZvcm1DbGll bnRSZWRpcmVjdEZvckZyYW1lCiAgICAgICAgIDAsIC8vIGRpZEhhbmRsZU9ubG9hZEV2ZW50c0Zv ckZyYW1lCiAgICAgICAgIDAsIC8vIGRpZExheW91dEZvckZyYW1lCisgICAgICAgIDAsIC8vIGRp ZERldGVjdFhTU0ZvckZyYW1lCiAgICAgfTsKICAgICBXS0J1bmRsZVBhZ2VTZXRQYWdlTG9hZGVy Q2xpZW50KG1fcGFnZSwgJmxvYWRlckNsaWVudCk7CiB9Cg==