71409 2011-11-02 15:04:07 -0700 [Qt] Flagging usage of X11 headers under PLAT_ARCH(X11) 2011-11-03 00:36:48 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 maheshk maheshk webkit.review.bot oldest_to_newest 494950 0 maheshk 2011-11-02 15:04:07 -0700 Latest qt5 has removed X11 header and webkit does not build because of it. Putting under X11 PLATFORM_ARCH flag along with GTK's x11 header file as it is anyway right thing to do 494958 1 113383 maheshk 2011-11-02 15:11:35 -0700 Created attachment 113383 patch 495234 2 113383 hausmann 2011-11-03 00:22:28 -0700 Comment on attachment 113383 patch I guess that'll do as a build fix as it's consistent with the usage the same guards around QX11Info later in the file. But I think the correct fix is to include QX11Info for Qt 4.x and use the QPlatformNativeInterface in Qt 5 to retrieve the display. I admit that requires more than just a build fix, so r=me for this one :) 495238 3 113383 webkit.review.bot 2011-11-03 00:36:44 -0700 Comment on attachment 113383 patch Clearing flags on attachment: 113383 Committed r99146: <http://trac.webkit.org/changeset/99146> 495239 4 webkit.review.bot 2011-11-03 00:36:48 -0700 All reviewed patches have been landed. Closing bug. 113383 2011-11-02 15:11:35 -0700 2011-11-03 00:36:44 -0700 patch build_webkit.patch text/plain 1287 maheshk ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4NmM0ZTQxLi5iOTFhYzEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTEtMDIgIE1haGVzaCBLdWxrYXJuaSAgPG1haGVzaC5rdWxrYXJuaUBub2tpYS5j b20+CisKKyAgICAgICAgW1F0XSBGbGFnZ2luZyB1c2FnZSBvZiBYMTEgaGVhZGVycyB1bmRlciBQ TEFUX0FSQ0goWDExKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzE0MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBCdWlsZCBmaXggZm9yIGJ1aWxkaW5nIHF0d2Via2l0IHdpdGggbGF0ZXN0IHF0NSB3aGlj aCBoYXMgcmVtb3ZlZCBRdCBYMTEgaGVhZGVycy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1 Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHA6CisKIDIwMTEtMTEtMDIgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgbV9wbHVn aW5TaXplIGluc3RlYWQgb2YgbV9mcmFtZVJlY3RJbldpbmRvd0Nvb3JkaW5hdGVzLnNpemUoKSBp biBOZXRzY2FwZVBsdWdpbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVCcm93c2VyRnVuY3MuY3BwCmlu ZGV4IGU0NDUwY2QuLjFlYzQzMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZUJyb3dzZXJGdW5jcy5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlQnJvd3NlckZ1bmNz LmNwcApAQCAtMzYsMTEgKzM2LDEzIEBACiAjaW5jbHVkZSA8V2ViQ29yZS9TaGFyZWRCdWZmZXIu aD4KICNpbmNsdWRlIDx1dGlsaXR5PgogCisjaWYgUExVR0lOX0FSQ0hJVEVDVFVSRShYMTEpCiAj aWYgUExBVEZPUk0oUVQpCiAjaW5jbHVkZSA8UVgxMUluZm8+CiAjZWxpZiBQTEFURk9STShHVEsp CiAjaW5jbHVkZSA8Z2RrL2dka3guaD4KICNlbmRpZgorI2VuZGlmCiAKIHVzaW5nIG5hbWVzcGFj ZSBXZWJDb3JlOwogdXNpbmcgbmFtZXNwYWNlIHN0ZDsK