71397 2011-11-02 13:48:09 -0700 [Qt] [WK] Debug build broken after r99065 2011-11-02 16:03:10 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P3 Normal --- 1 ostap73 webkit-unassigned hausmann kenneth webkit.review.bot zoltan oldest_to_newest 494875 0 ostap73 2011-11-02 13:48:09 -0700 ../../../Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:296:5: error: ‘panGestureActive’ was not declared in this scope 494881 1 113373 ostap73 2011-11-02 13:55:14 -0700 Created attachment 113373 Remove reference to panGestureActive. 494930 2 113373 hausmann 2011-11-02 14:46:24 -0700 Comment on attachment 113373 Remove reference to panGestureActive. View in context: https://bugs.webkit.org/attachment.cgi?id=113373&action=review r=me for buildfix > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:-296 > - Q_ASSERT(!panGestureActive); I suppose Kenneth intended to write !panAnimationActive() perhaps? 495003 3 113373 webkit.review.bot 2011-11-02 16:03:05 -0700 Comment on attachment 113373 Remove reference to panGestureActive. Clearing flags on attachment: 113373 Committed r99116: <http://trac.webkit.org/changeset/99116> 495004 4 webkit.review.bot 2011-11-02 16:03:10 -0700 All reviewed patches have been landed. Closing bug. 113373 2011-11-02 13:55:14 -0700 2011-11-02 16:03:05 -0700 Remove reference to panGestureActive. panGestureActive_remove.diff text/plain 1452 ostap73 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyMjljZGU0Li4yZGEyYmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMTEtMDIgIFZpYXRjaGVzbGF2IE9zdGFwZW5rbyAgPG9zdGFwZW5rby52aWF0Y2hl c2xhdkBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBbV0tdIERlYnVnIGJ1aWxkIGJyb2tlbiBh ZnRlciByOTkwNjUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTcxMzk3CisKKyAgICAgICAgUmVtb3ZlIHJlZmVyZW5jZSB0byBwYW5HZXN0dXJlQWN0aXZl IGJlY3Vhc2UgaXQgaXMgbm90IGRlZmluZWQgYW55d2hlcmUuCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvcXQvUXRWaWV3cG9ydElu dGVyYWN0aW9uRW5naW5lLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UXRWaWV3cG9ydEludGVyYWN0 aW9uRW5naW5lOjpwYW5HZXN0dXJlU3RhcnRlZCk6CisKIDIwMTEtMTEtMDIgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggbm9uLU1hYyBidWlsZHMu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRWaWV3cG9ydEludGVy YWN0aW9uRW5naW5lLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0 SW50ZXJhY3Rpb25FbmdpbmUuY3BwCmluZGV4IGJkZGU3ZTguLjAxNzkwNDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rpb25FbmdpbmUu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFZpZXdwb3J0SW50ZXJhY3Rp b25FbmdpbmUuY3BwCkBAIC0yOTMsOCArMjkzLDYgQEAgYm9vbCBRdFZpZXdwb3J0SW50ZXJhY3Rp b25FbmdpbmU6OnBhbkFuaW1hdGlvbkFjdGl2ZSgpIGNvbnN0CiAKIHZvaWQgUXRWaWV3cG9ydElu dGVyYWN0aW9uRW5naW5lOjpwYW5HZXN0dXJlU3RhcnRlZChjb25zdCBRUG9pbnRGJiB0b3VjaFBv aW50LCBxaW50NjQgZXZlbnRUaW1lc3RhbXBNaWxsaXMpCiB7Ci0gICAgUV9BU1NFUlQoIXBhbkdl c3R1cmVBY3RpdmUpOwotCiAgICAgLy8gRklYTUU6IHN1c3BlbmQgdGhlIFdlYiBlbmdpbmUgKHN0 b3AgYW5pbWF0ZWQgR0lGLCBldGMpLgogICAgIG1fdXNlckludGVyYWN0aW9uRmxhZ3MgfD0gVXNl ckhhc01vdmVkQ29udGVudDsKICAgICBzY3JvbGxlcigpLT5oYW5kbGVJbnB1dChRU2Nyb2xsZXI6 OklucHV0UHJlc3MsIG1fdmlld3BvcnQtPm1hcEZyb21JdGVtKG1fY29udGVudCwgdG91Y2hQb2lu dCksIGV2ZW50VGltZXN0YW1wTWlsbGlzKTsK