71390 2011-11-02 13:10:17 -0700 Use m_pluginSize instead of m_frameRectInWindowCoordinates.size() in NetscapePlugin 2011-11-02 13:29:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 494841 0 andersca 2011-11-02 13:10:17 -0700 Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in NetscapePlugin 494842 1 113356 andersca 2011-11-02 13:10:35 -0700 Created attachment 113356 Patch 494851 2 113356 aroben 2011-11-02 13:21:19 -0700 Comment on attachment 113356 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113356&action=review > Source/WebKit2/ChangeLog:4 > + Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in NetscapePlugin > + https://bugs.webkit.org/show_bug.cgi?id=71390 You also aren't using m_frameRectInWindowCoordinates.height anymore. I assume m_pluginSize is always equal to m_frameRectInWindowCoordinates.size() in normal cases. It might be worth mentioning that, and whether there are cases where they are not equal. 494856 3 andersca 2011-11-02 13:29:05 -0700 Committed r99092: <http://trac.webkit.org/changeset/99092> 113356 2011-11-02 13:10:35 -0700 2011-11-02 13:21:19 -0700 Patch bug-71390-20111102131047.patch text/plain 2259 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogOTkwOTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBmNTk2OTVmNWZlNDYyODAx ZmQxYTIyNjgzYjc4ZTA4MWM0N2E4NjIyLi41MDczM2JlOTE5OTRiMmE4Y2M1MDQ4ODI1YWUxMjc4 MDE1MjIwMGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTEtMTEtMDIgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBVc2UgbV9wbHVnaW5T aXplIGluc3RlYWQgb2YgbV9mcmFtZVJlY3RJbldpbmRvd0Nvb3JkaW5hdGVzLndpZHRoIGluIE5l dHNjYXBlUGx1Z2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD03MTM5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6TmV0c2NhcGVQbHVnaW46OmludmFsaWRhdGUpOgorICAgICAgICAoV2Vi S2l0OjpOZXRzY2FwZVBsdWdpbjo6c25hcHNob3QpOgorCisyMDExLTExLTAyICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUGx1Zy1pbiBzbmFwc2hvdHMg YXJlIGJsdXJyeSBpbiBIaURQSQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzEzODcKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEwMzg1MzkzPgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNj YXBlUGx1Z2luLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2Fw ZS9OZXRzY2FwZVBsdWdpbi5jcHAKaW5kZXggZTliYjlhMjhkNzNmZTUxOTQ1NmY2YzQ0YWM0ZGUy ZDBhN2JhNzhmNS4uMjNmNDI1ODVmNjM3YTFkMTRjY2ExODM3MGNhYjdkN2IyYmEwYmFhYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNj YXBlUGx1Z2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0 c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwCkBAIC0xMTgsMTAgKzExOCw5IEBAIHZvaWQgTmV0c2Nh cGVQbHVnaW46OmludmFsaWRhdGUoY29uc3QgTlBSZWN0KiBpbnZhbGlkUmVjdCkKICAgICBJbnRS ZWN0IHJlY3Q7CiAgICAgCiAgICAgaWYgKCFpbnZhbGlkUmVjdCkKLSAgICAgICAgcmVjdCA9IElu dFJlY3QoMCwgMCwgbV9mcmFtZVJlY3RJbldpbmRvd0Nvb3JkaW5hdGVzLndpZHRoKCksIG1fZnJh bWVSZWN0SW5XaW5kb3dDb29yZGluYXRlcy5oZWlnaHQoKSk7CisgICAgICAgIHJlY3QgPSBJbnRS ZWN0KDAsIDAsIG1fcGx1Z2luU2l6ZS53aWR0aCgpLCBtX3BsdWdpblNpemUuaGVpZ2h0KCkpOwog ICAgIGVsc2UKLSAgICAgICAgcmVjdCA9IEludFJlY3QoaW52YWxpZFJlY3QtPmxlZnQsIGludmFs aWRSZWN0LT50b3AsCi0gICAgICAgICAgICAgICAgICAgICAgIGludmFsaWRSZWN0LT5yaWdodCAt IGludmFsaWRSZWN0LT5sZWZ0LCBpbnZhbGlkUmVjdC0+Ym90dG9tIC0gaW52YWxpZFJlY3QtPnRv cCk7CisgICAgICAgIHJlY3QgPSBJbnRSZWN0KGludmFsaWRSZWN0LT5sZWZ0LCBpbnZhbGlkUmVj dC0+dG9wLCBpbnZhbGlkUmVjdC0+cmlnaHQgLSBpbnZhbGlkUmVjdC0+bGVmdCwgaW52YWxpZFJl Y3QtPmJvdHRvbSAtIGludmFsaWRSZWN0LT50b3ApOwogICAgIAogICAgIGlmIChwbGF0Zm9ybUlu dmFsaWRhdGUocmVjdCkpCiAgICAgICAgIHJldHVybjsKQEAgLTY0MCw3ICs2MzksNyBAQCB2b2lk IE5ldHNjYXBlUGx1Z2luOjpwYWludChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IElu dFJlY3QmIGRpcnR5UmVjdCkKIAogUGFzc1JlZlB0cjxTaGFyZWFibGVCaXRtYXA+IE5ldHNjYXBl UGx1Z2luOjpzbmFwc2hvdCgpCiB7Ci0gICAgaWYgKCFzdXBwb3J0c1NuYXBzaG90dGluZygpIHx8 IG1fZnJhbWVSZWN0SW5XaW5kb3dDb29yZGluYXRlcy5pc0VtcHR5KCkpCisgICAgaWYgKCFzdXBw b3J0c1NuYXBzaG90dGluZygpIHx8IG1fcGx1Z2luU2l6ZS5pc0VtcHR5KCkpCiAgICAgICAgIHJl dHVybiAwOwogCiAgICAgQVNTRVJUKG1faXNTdGFydGVkKTsK