71387 2011-11-02 12:56:19 -0700 Plug-in snapshots are blurry in HiDPI 2011-11-03 02:13:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andersca andersca abecsi gustavo hausmann kbalazs kling mrobinson ossy webkit-bug-importer xan.lopez zoltan oldest_to_newest 494825 0 andersca 2011-11-02 12:56:19 -0700 Plug-in snapshots are blurry in HiDPI 494827 1 webkit-bug-importer 2011-11-02 12:59:25 -0700 <rdar://problem/10385393> 494830 2 113355 andersca 2011-11-02 13:00:45 -0700 Created attachment 113355 Patch 494832 3 113355 aroben 2011-11-02 13:02:52 -0700 Comment on attachment 113355 Patch Can you create a test for this with TestWebKitAPI? You could check the snapshot's dimensions, at a minimum. 494836 4 andersca 2011-11-02 13:04:44 -0700 (In reply to comment #3) > (From update of attachment 113355 [details]) > Can you create a test for this with TestWebKitAPI? You could check the snapshot's dimensions, at a minimum. Hmm, since the plug-in snapshot is just painted into the regular snapshot it's not really possible to check the dimensions. 494838 5 andersca 2011-11-02 13:06:12 -0700 Committed r99090: <http://trac.webkit.org/changeset/99090> 495244 6 ossy 2011-11-03 00:45:25 -0700 (In reply to comment #5) > Committed r99090: <http://trac.webkit.org/changeset/99090> It broke the GTK build. 495245 7 ossy 2011-11-03 00:50:08 -0700 (In reply to comment #5) > Committed r99090: <http://trac.webkit.org/changeset/99090> And the Qt-WK2 build too. (but it isn't a core builder, so you can't notice it) 495278 8 hausmann 2011-11-03 02:12:00 -0700 (In reply to comment #7) > (In reply to comment #5) > > Committed r99090: <http://trac.webkit.org/changeset/99090> > > And the Qt-WK2 build too. (but it isn't a core builder, so you can't notice it) Qt builds are fixed in http://trac.webkit.org/changeset/99151. The remaining Gtk build breakage is due to the dragSession changes. Closing this bug again, it's definitely fixed :) 495279 9 hausmann 2011-11-03 02:13:09 -0700 And http://trac.webkit.org/changeset/99149 fixed the remaining Gtk issues :) 113355 2011-11-02 13:00:45 -0700 2011-11-03 00:46:08 -0700 Patch bug-71387-20111102130058.patch text/plain 3253 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogOTkwODEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCA4OGViYzZmODcwNDg3ODI5 YTk3MjY5MmRiYzI0NTVmY2U2MDgwMWZjLi4zNTYzODVhNTgzN2NiY2QyYTY0NzEyODVhZGJlMDk1 ZGI3OWU1ZDFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMTEtMDIgIEFuZGVy cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBQbHVnLWluIHNuYXBz aG90cyBhcmUgYmx1cnJ5IGluIEhpRFBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03MTM4NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTAzODUzOTM+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwOgorICAgICAgICAoV2Vi S2l0OjpOZXRzY2FwZVBsdWdpbjo6c25hcHNob3QpOgorICAgICAgICBDcmVhdGUgdGhlIGJhY2tp bmcgc3RvcmUgaW4gdGhlIHJpZ2h0IHNpemUgYW5kIGFwcGx5IHRoZSBjb250ZW50cyBzY2FsZSBm YWN0b3IKKyAgICAgICAgdG8gdGhlIG5ld2x5IGNyZWF0ZWQgZ3JhcGhpY3MgY29udGV4dC4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAgICAgKFdl YktpdDo6UGx1Z2luVmlldzo6cGFpbnQpOgorICAgICAgICBQYXNzIHRoZSBzY2FsZSBmYWN0b3Ig dG8gU2hhcmVhYmxlQml0bWFwOjpwYWludC4KKwogMjAxMS0xMS0wMiAgQ2FpbyBNYXJjZWxvIGRl IE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAg IFtRdF0gSW1wbGVtZW50IG1lc3NhZ2UgZXhjaGFuZ2UgYmV0d2VlbiBXZWJWaWV3IGFuZCB0aGUg d2ViIHBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9O ZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwCmluZGV4IDdiMWM3ZmIxNTQ2YWFiZWQ3 NTdiNDQ1MzY1MzA0YTViYmVkMDBkZWEuLmU5YmI5YTI4ZDczZmU1MTk0NTZmNmM0NGFjNGRlMmQw YTdiYTc4ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9O ZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcApAQCAtNjQ0LDEyICs2NDQsMjAg QEAgUGFzc1JlZlB0cjxTaGFyZWFibGVCaXRtYXA+IE5ldHNjYXBlUGx1Z2luOjpzbmFwc2hvdCgp CiAgICAgICAgIHJldHVybiAwOwogCiAgICAgQVNTRVJUKG1faXNTdGFydGVkKTsKLSAgICAKLSAg ICBSZWZQdHI8U2hhcmVhYmxlQml0bWFwPiBiaXRtYXAgPSBTaGFyZWFibGVCaXRtYXA6OmNyZWF0 ZVNoYXJlYWJsZShtX2ZyYW1lUmVjdEluV2luZG93Q29vcmRpbmF0ZXMuc2l6ZSgpLCBTaGFyZWFi bGVCaXRtYXA6OlN1cHBvcnRzQWxwaGEpOworCisgICAgSW50U2l6ZSBiYWNraW5nU3RvcmVTaXpl ID0gbV9wbHVnaW5TaXplOworICAgIGJhY2tpbmdTdG9yZVNpemUuc2NhbGUoY29udGVudHNTY2Fs ZUZhY3RvcigpKTsKKworICAgIFJlZlB0cjxTaGFyZWFibGVCaXRtYXA+IGJpdG1hcCA9IFNoYXJl YWJsZUJpdG1hcDo6Y3JlYXRlU2hhcmVhYmxlKGJhY2tpbmdTdG9yZVNpemUsIFNoYXJlYWJsZUJp dG1hcDo6U3VwcG9ydHNBbHBoYSk7CiAgICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dD4gY29udGV4 dCA9IGJpdG1hcC0+Y3JlYXRlR3JhcGhpY3NDb250ZXh0KCk7CiAKLSAgICBjb250ZXh0LT50cmFu c2xhdGUoLW1fZnJhbWVSZWN0SW5XaW5kb3dDb29yZGluYXRlcy54KCksIC1tX2ZyYW1lUmVjdElu V2luZG93Q29vcmRpbmF0ZXMueSgpKTsKKyNpZiBQTEFURk9STShNQUMpCisgICAgLy8gRklYTUU6 IFdlIHNob3VsZCByZWFsbHkgY2FsbCBhcHBseURldmljZVNjYWxlRmFjdG9yIGluc3RlYWQgb2Yg c2NhbGUsIGJ1dCB0aGF0IGVuZHMgdXAgY2FsbGluZyBpbnRvIFdLU0kKKyAgICAvLyB3aGljaCB3 ZSBjdXJyZW50bHkgZG9uJ3QgaGF2ZSBpbml0aWF0ZWQgaW4gdGhlIHBsdWctaW4gcHJvY2Vzcy4K KyAgICBjb250ZXh0LT5zY2FsZShGbG9hdFNpemUoY29udGVudHNTY2FsZUZhY3RvcigpLCBjb250 ZW50c1NjYWxlRmFjdG9yKCkpKTsKKyNlbmRpZgogCisgICAgY29udGV4dC0+dHJhbnNsYXRlKC1t X2ZyYW1lUmVjdEluV2luZG93Q29vcmRpbmF0ZXMueCgpLCAtbV9mcmFtZVJlY3RJbldpbmRvd0Nv b3JkaW5hdGVzLnkoKSk7CiAgICAgcGxhdGZvcm1QYWludChjb250ZXh0LmdldCgpLCBtX2ZyYW1l UmVjdEluV2luZG93Q29vcmRpbmF0ZXMsIHRydWUpOwogICAgIAogICAgIHJldHVybiBiaXRtYXAu cmVsZWFzZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdp blZpZXcuY3BwCmluZGV4IDE5YWIxYmMxMjNjZmIyMzVlMjg0ZGIwMDRlMWQ3ZGZhNjYwYjk3MTUu Ljk3NjFiYmIyODYzOTUwMjYwYTQxYTZlZTk0ZTg4ODg3MTM1ZWU3Y2MgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTU4OSw3ICs1 ODksNyBAQCB2b2lkIFBsdWdpblZpZXc6OnBhaW50KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwg Y29uc3QgSW50UmVjdCYgZGlydHlSZWN0KQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAobV9z bmFwc2hvdCkgewotICAgICAgICBtX3NuYXBzaG90LT5wYWludCgqY29udGV4dCwgZnJhbWVSZWN0 KCkubG9jYXRpb24oKSwgbV9zbmFwc2hvdC0+Ym91bmRzKCkpOworICAgICAgICBtX3NuYXBzaG90 LT5wYWludCgqY29udGV4dCwgY29udGVudHNTY2FsZUZhY3RvcigpLCBmcmFtZVJlY3QoKS5sb2Nh dGlvbigpLCBtX3NuYXBzaG90LT5ib3VuZHMoKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAg ICAgCg==