71342 2011-11-01 17:29:09 -0700 [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame 2011-11-01 19:08:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin darin joepeck webkit.review.bot oldest_to_newest 494344 0 benjamin 2011-11-01 17:29:09 -0700 The test webarchive/loading/test-loading-archive-subresource-null-mimetype.html introduce the first case where a subresource is loaded from outside the test directory. The file in question file:///test.png causes the method to raise a NSRangeException. This is hidden by the fact that OS X WebKit catch any exceptions when calling the delegate. 494357 1 113266 benjamin 2011-11-01 17:41:17 -0700 Created attachment 113266 Patch 494362 2 113266 darin 2011-11-01 17:48:30 -0700 Comment on attachment 113266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113266&action=review > LayoutTests/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:12 > +file:///test.png - didReceiveResponse <NSURLResponse file:///Users/pecoraro/Desktop/test.png, http status code 0> That's not good. It has the patch of a user’s home directory! 494363 3 113266 darin 2011-11-01 17:50:07 -0700 Comment on attachment 113266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113266&action=review >> LayoutTests/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:12 >> +file:///test.png - didReceiveResponse <NSURLResponse file:///Users/pecoraro/Desktop/test.png, http status code 0> > > That's not good. It has the patch of a user’s home directory! The path of a specific users’s home directory. We can}t have that in expected test results. 494371 4 benjamin 2011-11-01 17:58:04 -0700 My user directly is definitely not /Users/pecoraro/ :) This the path of the source as encoded in the webarchive. 494372 5 benjamin 2011-11-01 17:58:37 -0700 s/user directly/user directory 494389 6 darin 2011-11-01 18:24:08 -0700 (In reply to comment #4) > This the path of the source as encoded in the webarchive. OK, makes sense. I looked in the web archive and couldn’t find that, but it was because it was in the Base64-encoded WebResourceResponse data. 494390 7 113266 darin 2011-11-01 18:26:53 -0700 Comment on attachment 113266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113266&action=review > Tools/DumpRenderTree/mac/ResourceLoadDelegate.mm:89 > + if ([[self path] hasPrefix:basePath]) { > + ASSERT([[self path] length] >= ([basePath length] + 1)); > + return [[self path] substringFromIndex:[basePath length] + 1]; > + } We could also write this code so that it appends a "/" to basePath first, then we would not need the assertion or the "+ 1". 494392 8 joepeck 2011-11-01 18:33:05 -0700 (In reply to comment #4) > My user directly is definitely not /Users/pecoraro/ :) > > This the path of the source as encoded in the webarchive. Feel free to update the webarchive. I didn't know this data was inside it, otherwise I wouldn't have included it originally =(. 494400 9 113266 webkit.review.bot 2011-11-01 19:08:33 -0700 Comment on attachment 113266 Patch Clearing flags on attachment: 113266 Committed r99031: <http://trac.webkit.org/changeset/99031> 494401 10 webkit.review.bot 2011-11-01 19:08:38 -0700 All reviewed patches have been landed. Closing bug. 113266 2011-11-01 17:41:17 -0700 2011-11-01 19:08:33 -0700 Patch bug-71342-20111101174116.patch text/plain 4325 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogOTg5OTgKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZjQzMGU0MDMzNzI0ZGRlMDI1YTM0NzJkYWVkMjk4OGVi ZWI3OThkLi45NjdhYTRhYWMxOWMxYTIxYzZlZDkxMmM1ZWNlYjQ1YzA4ZGMyNzUxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMTEtMDEgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisK KyAgICAgICAgW01hY10gX2RydF9kZXNjcmlwdGlvblN1aXRhYmxlRm9yVGVzdFJlc3VsdCBnZW5l cmF0ZSBhbiBleGNlcHRpb24gZm9yIGFic29sdXRlIHBhdGhzIGFib3ZlIHRoZSBtYWluIGZyYW1l CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTM0Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtOU1VSTCBf ZHJ0X2Rlc2NyaXB0aW9uU3VpdGFibGVGb3JUZXN0UmVzdWx0XSB3YXMgZ2VuZXJhdGluZyBhIE5T UmFuZ2VFeGNlcHRpb24gZHVlIHRvIHRoZSBjYWxsIHRvCisgICAgICAgIFtOU1N0cmluZyBzdWJz dHJpbmdGcm9tSW5kZXg6XSB3aXRoIGFuIGluZGV4IG91dCBvZiB0aGUgc3RyaW5nIHJhbmdlLgor CisgICAgICAgIFRoZSBzb3VyY2Ugb2YgdGhpcyBwYXRoIGlzIHRoZSB0ZXN0LWxvYWRpbmctYXJj aGl2ZS1zdWJyZXNvdXJjZS1udWxsLW1pbWV0eXBlLmh0bWwgd2hpY2ggbG9hZCBhIHN1YnJlc291 cmNlCisgICAgICAgIGZyb20gdGhlIHJvb3Qgb2YgdGhlIGRpc2suCisgICAgICAgIFRoZSBwcm9i bGVtIHdhcyBoaWRkZW4gYmVjYXVzZSB0aGUgZXhjZXB0aW9uIGFyZSBjYXRjaGVkIHdoZW4gY2Fs bGluZyB0aGUgZGVsZWdhdGUuCisKKyAgICAgICAgVGhpcyBwYXRjaCBjaGFuZ2VzIF9kcnRfZGVz Y3JpcHRpb25TdWl0YWJsZUZvclRlc3RSZXN1bHQgdG8gcmV0dXJuIGFic29sdXRlIHN0cmluZyBp ZiB0aGUgcmVzb3VyY2UgaXMgbm90CisgICAgICAgIGluIGEgc3ViZGlyZWN0b3J5IG9mIHRoZSBt YWluIGZyYW1lLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL1Jlc291cmNlTG9hZERl bGVnYXRlLm1tOgorICAgICAgICAoLVtOU1VSTCBfZHJ0X2Rlc2NyaXB0aW9uU3VpdGFibGVGb3JU ZXN0UmVzdWx0XSk6CisKIDIwMTEtMTEtMDEgIEVsbGlvdCBQb2dlciAgPGVwb2dlckBnb29nbGUu Y29tPgogCiAgICAgICAgIGNocm9taXVtLWdwdSBwb3J0IHNob3VsZCBkZWZhdWx0IHRvIGNocm9t aXVtLWdwdS1tYWMsIG5vdCBjaHJvbWl1bS1ncHUtY2ctbWFjCmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9tYWMvUmVzb3VyY2VMb2FkRGVsZWdhdGUubW0gYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvUmVzb3VyY2VMb2FkRGVsZWdhdGUubW0KaW5kZXggM2Q4NzMzMTI4NWUzMjZl YTNkZjI0N2VlOTBiZGRkMDEzZWY3NDJhNy4uNDY4YThjZWFiZTY3MGVmMTM4ZmFhODJlNDFkZGQ3 MGUwYjc1MTRlNyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL1Jlc291cmNl TG9hZERlbGVnYXRlLm1tCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9SZXNvdXJjZUxv YWREZWxlZ2F0ZS5tbQpAQCAtODMsNyArODMsMTEgQEAgdXNpbmcgbmFtZXNwYWNlIHN0ZDsKIAog ICAgIE5TU3RyaW5nICpiYXNlUGF0aCA9IFtbW1tkYXRhU291cmNlIHJlcXVlc3RdIFVSTF0gcGF0 aF0gc3RyaW5nQnlEZWxldGluZ0xhc3RQYXRoQ29tcG9uZW50XTsKIAotICAgIHJldHVybiBbW3Nl bGYgcGF0aF0gc3Vic3RyaW5nRnJvbUluZGV4OltiYXNlUGF0aCBsZW5ndGhdICsgMV07CisgICAg aWYgKFtbc2VsZiBwYXRoXSBoYXNQcmVmaXg6YmFzZVBhdGhdKSB7CisgICAgICAgIEFTU0VSVChb W3NlbGYgcGF0aF0gbGVuZ3RoXSA+PSAoW2Jhc2VQYXRoIGxlbmd0aF0gKyAxKSk7CisgICAgICAg IHJldHVybiBbW3NlbGYgcGF0aF0gc3Vic3RyaW5nRnJvbUluZGV4OltiYXNlUGF0aCBsZW5ndGhd ICsgMV07CisgICAgfQorICAgIHJldHVybiBbc2VsZiBhYnNvbHV0ZVN0cmluZ107CiB9CiAKIEBl bmQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA5YmMxZmZiOTkwOWVmZjYxMWYyNjE2MzMzMzFmNjQ2MDBhZjk2NmRhLi5jZTNj ODg3NjQ5YzNjYmM1YjNjNTZhNmVlYThjNzhmNzQ0NjQzMzdkIDEwMDc1NQotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTEtMDEgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisK KyAgICAgICAgW01hY10gX2RydF9kZXNjcmlwdGlvblN1aXRhYmxlRm9yVGVzdFJlc3VsdCBnZW5l cmF0ZSBhbiBleGNlcHRpb24gZm9yIGFic29sdXRlIHBhdGhzIGFib3ZlIHRoZSBtYWluIGZyYW1l CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTM0Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0 aGUgdGVzdCByZXN1bHRzIGZvbGxvd2luZyB0aGUgZml4IG9mIF9kcnRfZGVzY3JpcHRpb25TdWl0 YWJsZUZvclRlc3RSZXN1bHQuCisKKyAgICAgICAgKiB3ZWJhcmNoaXZlL2xvYWRpbmcvdGVzdC1s b2FkaW5nLWFyY2hpdmUtc3VicmVzb3VyY2UtbnVsbC1taW1ldHlwZS1leHBlY3RlZC50eHQ6CisK IDIwMTEtMTEtMDEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBFeHBh bmQgcHJvdG90eXBlIHNldHRpbmcgdGVzdCB0byB0ZXN0IE9iamVjdC5kZWZpbmVQcm9wZXJ0eQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvd2ViYXJjaGl2ZS9sb2FkaW5nL3Rlc3QtbG9hZGluZy1h cmNoaXZlLXN1YnJlc291cmNlLW51bGwtbWltZXR5cGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvd2ViYXJjaGl2ZS9sb2FkaW5nL3Rlc3QtbG9hZGluZy1hcmNoaXZlLXN1YnJlc291cmNlLW51 bGwtbWltZXR5cGUtZXhwZWN0ZWQudHh0CmluZGV4IDY0ZGY0ZTM0OWY4OWViNmFhZjJjNTEwMWYy MWE4ZGZmODc5ZjFiYzIuLjFmMTE2NThlMTE1NmYwYzEyYzQxODYxOGFhOWQ0YWRmMTU1OTY2ODAg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmFyY2hpdmUvbG9hZGluZy90ZXN0LWxvYWRpbmct YXJjaGl2ZS1zdWJyZXNvdXJjZS1udWxsLW1pbWV0eXBlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlv dXRUZXN0cy93ZWJhcmNoaXZlL2xvYWRpbmcvdGVzdC1sb2FkaW5nLWFyY2hpdmUtc3VicmVzb3Vy Y2UtbnVsbC1taW1ldHlwZS1leHBlY3RlZC50eHQKQEAgLTYsNyArNiwxMCBAQCBtYWluIGZyYW1l IC0gZGlkRmluaXNoRG9jdW1lbnRMb2FkRm9yRnJhbWUKIDx1bmtub3duPiAtIGRpZEZpbmlzaExv YWRpbmcKIHJlc291cmNlcy9zdWJyZXNvdXJjZS1udWxsLW1pbWV0eXBlLndlYmFyY2hpdmUgLSBk aWRSZWNlaXZlUmVzcG9uc2UgPE5TVVJMUmVzcG9uc2UgcmVzb3VyY2VzL3N1YnJlc291cmNlLW51 bGwtbWltZXR5cGUud2ViYXJjaGl2ZSwgaHR0cCBzdGF0dXMgY29kZSAwPgogZnJhbWUgIjwhLS1m cmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+IiAtIGRpZENvbW1pdExvYWRGb3JGcmFtZQorZmls ZTovLy90ZXN0LnBuZyAtIHdpbGxTZW5kUmVxdWVzdCA8TlNVUkxSZXF1ZXN0IFVSTCBmaWxlOi8v L3Rlc3QucG5nLCBtYWluIGRvY3VtZW50IFVSTCB0ZXN0LWxvYWRpbmctYXJjaGl2ZS1zdWJyZXNv dXJjZS1udWxsLW1pbWV0eXBlLmh0bWwsIGh0dHAgbWV0aG9kIEdFVD4gcmVkaXJlY3RSZXNwb25z ZSAobnVsbCkKIGZyYW1lICI8IS0tZnJhbWVQYXRoIC8vPCEtLWZyYW1lMC0tPi0tPiIgLSBkaWRG aW5pc2hEb2N1bWVudExvYWRGb3JGcmFtZQorcmVzb3VyY2VzL3N1YnJlc291cmNlLW51bGwtbWlt ZXR5cGUud2ViYXJjaGl2ZSAtIGRpZEZpbmlzaExvYWRpbmcKK2ZpbGU6Ly8vdGVzdC5wbmcgLSBk aWRSZWNlaXZlUmVzcG9uc2UgPE5TVVJMUmVzcG9uc2UgZmlsZTovLy9Vc2Vycy9wZWNvcmFyby9E ZXNrdG9wL3Rlc3QucG5nLCBodHRwIHN0YXR1cyBjb2RlIDA+CiBmcmFtZSAiPCEtLWZyYW1lUGF0 aCAvLzwhLS1mcmFtZTAtLT4tLT4iIC0gZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9yRnJhbWUKIG1h aW4gZnJhbWUgLSBkaWRIYW5kbGVPbmxvYWRFdmVudHNGb3JGcmFtZQogZnJhbWUgIjwhLS1mcmFt ZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+IiAtIGRpZEZpbmlzaExvYWRGb3JGcmFtZQo=